Commit Graph

8630 Commits (9a4ea04a7564a3e2ed36e8c09b618cd2fe586521)

Author SHA1 Message Date
Misty (Bot) b7db0f200e Latest translations and fallbacks
Julian Lam f743f92088
refactor: socket posts delete/restore/purge so tid is not necessary ()
* refactor: socket posts delete/restore/purge so tid is not necessary

* refactor: stop trying to be fancy

* fix: tests to not pass in tid into posts.deletePosts

* fix: some more unnecessary tid passing
Barış Soner Uşaklı 09de364e93 feat: add client side action:flag.create
Misty (Bot) 2a4f4f5aec Latest translations and fallbacks
Misty (Bot) b201bb2111 Latest translations and fallbacks
Julian Lam 0c20351702 feat: additional sorting options for flags
+ upvotes, +downvotes, +replies
Misty (Bot) 02a5fe9c68 Latest translations and fallbacks
Julian Lam 694f4b2bcf fix: accept/reject in post-queue instead of accept/delete
Julian Lam b587127560 fix: new openapi def for replies addition
Julian Lam e0c7d65a92 Revert "feat: add reply count to getPostSummaryByPids"
This reverts commit de0f4aadb8.
Julian Lam de0f4aadb8 feat: add reply count to getPostSummaryByPids
Misty (Bot) c25af08da0 Latest translations and fallbacks
Barış Soner Uşaklı 9f9164a9be fix:
Julian Lam fb3b4a0293 fix: debug logging 🐶
Julian Lam 56101ae5ae fix: ip-blacklist not working after
Julian Lam c681b4b2e0 fix: ip-blacklist not working after
Julian Lam dc5bd7601f fix: post-queue not working after
Julian Lam a93e19559d fix: missing language sources for ip-blacklist/post-queue
Julian Lam 4dc6e64a94 refactor: ip-blacklist and post-queue language files
closes 
Kyle Farris 2b785628e7
fix: removed invalid options for the sendmail transport ()
* Removed invalid options for the sendmail transport that were causing Nodemailer to return the SMTPTransport instead.

* Removed options for rate limiting in admin email interface. Added new option for toggling whether to use pooled connections.
Julian Lam b6b94a56dc refactor: moved ip-blacklist and post-queue styles/tpls to themes
This is a breaking change!, re: 
Misty (Bot) 073c4d7886 Latest translations and fallbacks
Julian Lam abb5e81d0d feat: allow undo of topic move
Julian Lam cd8e7963de feat: added alert.timeoutfn
Also, various alert methods now pass two arguments,
alert and params
Julian Lam bacee6b467 fix: missing localisation for topic move error
Julian Lam 5d60dce379 fix: select all checkbox does not re-enable bulk actions button
Misty (Bot) 5f15afff39 Latest translations and fallbacks
Barış Soner Uşaklı 4f7cfd5372 fix: openapi spec
Barış Soner Uşaklı c4ad14cb68 fix: api spec
Misty (Bot) 074d7dfd86 Latest translations and fallbacks
Julian Lam 9cbe9389f5 fix: use promises in privilege save
... instead of jQuery Deferreds
Julian Lam 7a5daff4c9 fix: overzealous click handler on flag list row
Misty (Bot) f425cecded Latest translations and fallbacks
Julian Lam 9608b44f21 fix: +comment, -debug log
Julian Lam a3a2279358 feat: logic for bulk actions in flags list,
Julian Lam 589216e720 fix: multiple alerts in the same millisecond overwrite each other
Julian Lam 2a948d32a4 Revert "test(openapi): missing commonprops addition"
This reverts commit 0dc55bbc80.
Julian Lam 0dc55bbc80 test(openapi): missing commonprops addition
Julian Lam b2271eb64f fix: client-side error in flags/detail
... as the filter form is no longer present in the details page
Misty (Bot) bb7bd1b421 Latest translations and fallbacks
Misty (Bot) 07ebc81a2f Latest translations and fallbacks
Julian Lam d935f03636 fix(openapi): tests
Julian Lam 334be11382 fix: no-widgets messaging in ACP + copy
Julian Lam 346db0d84d feat: flags list sorting, closes
Misty (Bot) 1101fa3394 Latest translations and fallbacks
Misty (Bot) 6bb60b0965 Latest translations and fallbacks
Barış Soner Uşaklı 35a538ec2a feat: allow adding multiple users to group
Misty (Bot) 7f57d39cd5 Latest translations and fallbacks
Misty (Bot) 2b930c894a Latest translations and fallbacks
Misty (Bot) ea53c95d67 Latest translations and fallbacks
Misty (Bot) 2aa36b649a Latest translations and fallbacks
Barış Soner Uşaklı 3f01f4a2b8 Revert "feat: load timeago strings client-side"
This reverts commit 558a2d739c.
Julian Lam 558a2d739c feat: load timeago strings client-side
9adaccd036 introduced the ability to
configure an assetBaseUrl, but the timeago strings were still
calling a hardcoded value as it was handled server-side. There's
no need for the strings to be loaded until timeago is initialised.
Barış Soner Uşaklı 79e847d424 fix: , only navigate if user is in same topic
Julian Lam 8ff09630b6 fix(openapi): new api definition
Julian Lam 9adaccd036 feat: +assetBaseUrl, -l10BaseUrl, -requireBaseUrl
Additional base URLs were necessary for benchpress and translator,
and in order to not clutter the API response with needless one-
time use base URLs, I decided to use a single base that is used
by all of the services, assetBaseUrl.
Misty (Bot) 75ef4bbe34 Latest translations and fallbacks
Julian Lam d6297b28e9 fix: tests
Misty (Bot) 8a6bc10eb1 Latest translations and fallbacks
Julian Lam def16f9e97 feat: introduce overridable l10nBaseUrl config value
Misty (Bot) 9846498df7 Latest translations and fallbacks
Barış Soner Uşaklı dfabd0a3fe feat: remove administrator property from public routes
Barış Soner Uşaklı 4216c277d5 feat: focus username when modal is shown
Misty (Bot) 3463fc51c6 Latest translations and fallbacks
Julian Lam 2ee6248316 refactor: for codeclimate
Julian Lam a7071bb808 fix: map instead of forEach in privileges save
Julian Lam a716a5529c
feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals ()
* feat: privileges save button, , WIP

* fix: disable firefox autocomplete on privilege form fields

* feat: closes  privilege changes commit on save

- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs

* fix(tests): remove duplicate template helper test

* fix(tests): broken template helper test

* feat: confirm dialogs for all privilege copy actions

Also, ability to add user to a privilege table without needing
to refresh the privilege table.

* feat: group row addition w/o table refresh

breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges
no longer make socket calls to the following hooks:

- filter:privileges.list, filter:privileges.admin.list,
  filter:privileges.global.list, filter:privileges.groups.list,
  filter:privileges.admin.groups.list,
  filter:privileges.gloval.groups.list

The filters are still called, but done before the helper method
is called, and the results are passed in instead. This change
should only affect you if you directly call the helper methods,
otherwise the change is transparent.

* fix: stale ajaxify data on privilege category switch

* fix: implicit privileges not showing for user privs

* fix: groups, not group, also fix tests

* fix(tests): again

* fix: wrong tpl rendered when adding group to global priv table
Misty (Bot) 8da742e065 Latest translations and fallbacks
Misty (Bot) 903c407171 Latest translations and fallbacks
Barış Soner Uşaklı e7a502e0aa feat: add ability to search groups in group details page
Barış Soner Uşaklı 519e665939 fix: , go to first unread instead of last read
Misty (Bot) 029f477434 Latest translations and fallbacks
Barış Soner Uşaklı 9e80a9efdd fix: , dont show modal on search
Barış Soner Uşaklı fb7bb8d400 feat: use category selector in category page
fix privilege shortcuts in group page after search
Barış Soner Uşaklı 560f3eb173 feat: css fixes
Barış Soner Uşaklı 91411cc47c feat: add privileges shortcut to groups list
fix issues with escape group names
Misty (Bot) caa78cc1f6 Latest translations and fallbacks
Julian Lam c705e08a76 feat: allow direct link to flag from post tools,
Barış Soner Uşaklı 8415d2f014 fix: api test
Barış Soner Uşaklı c4829fd8c2 feat: allow changing requirejs base url
Barış Soner Uşaklı bbc7737e14 feat: ability to clear cache from acp
Barış Soner Uşaklı 69fb15276c fix: tests
Barış Soner Uşaklı 8d8117ffa1 feat: reduce amount of data loaded on acp admin page
get rid of socket call and use ajaxify.data.categories
Misty (Bot) d580cf01c3 Latest translations and fallbacks
Barış Soner Uşaklı f48d155670 fix: tests
Barış Soner Uşaklı fd4c3cda42 fix: , remove new notif alert
Julian Lam 8473e165a6 fix: too small sortable handle for ACP>Manage>Categories
The handle was initially just the icon, but now it is the icon
and the category label itself.
Misty (Bot) 93d1ceccdd Latest translations and fallbacks
Misty (Bot) 43e9c25d26 Latest translations and fallbacks
Barış Soner Uşaklı db07dd8565 fix: less fixes for category dropdown
Barış Soner Uşaklı 24535a62e7 feat: make category tools in acp a dropdown
add view category, view privileges into dropdown
Barış Soner Uşaklı 609e37a67b feat: remove deprecated utils.walk
Julian Lam 55b0e902fb feat: consolidation of flags to reduce flagspam,
Squashed commit of the following:

commit c6d09396208a10c244d7b3d22ffd2d7dd1274d3a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 13:41:32 2020 -0400

    fix: more tests

commit 32f9af2a87a81fa62ecca01e71d6f0d5b9d37ba1
Merge: e50907535 4eae927d1
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:53:04 2020 -0400

    Merge remote-tracking branch 'origin/master' into singleton-flags

commit e50907535109dbdbe8f15c3e2fcdf22d90b1332a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:52:46 2020 -0400

    fix: controllers-admin test

commit fd5af99e303de48a80b0ccc166eee19175cf232b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:26:55 2020 -0400

    fix(tests): dummy commit to trigger travisCI

commit c452a6ffcfaef91403de084c4ae16795cb23c60e
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:05:09 2020 -0400

    fix(openapi): openapi spec changes

commit 8089a74e89128141ab1e6f8ff83447114b3b846b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:48:00 2020 -0400

    fix: reversing the order of reports for display purposes

commit a099892b377333561c72f1ad5b6b20ddb4ce8a96
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:45:44 2020 -0400

    refactor: run all flag creation calls in a single batch

commit b24999682f9d5a33a08a049749c1f0eb4f00facc
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:08:23 2020 -0400

    feat: handling multiple reporters per flag, 

commit 08c75c020021ada754bf0e39eae77d631b01dee5
Author: Julian Lam <julian@nodebb.org>
Date:   Thu Jul 16 20:53:18 2020 -0400

    feat: upgrade script for 
psychobunny 4c90fac412 fix: cursor for category select
psychobunny bc26883aed refactor: setting codeclimate to A
psychobunny 8769e28b28 fix: api docs for admin/manage/groups/x
psychobunny a6ae69737b Merge branch 'master' of https://github.com/NodeBB/NodeBB
psychobunny 10e4ae629c feat: highlight privs row if group is added / navigating from group page
psychobunny 53f6139b8c feat: prevent navigation away from groups page if changes are unsaved
psychobunny 2c83278f97 feat: quick access dropdown on groups page to access privileges page
Barış Soner Uşaklı 42af4b572b fix: api tests
Barış Soner Uşaklı 844f2b4ed0 feat: , allow editing category of queued topic
Barış Soner Uşaklı ec05783507 feat: remove js-enabled.css
Barış Soner Uşaklı a46adb3fd5 fix: more tests
Barış Soner Uşaklı 67ca5e3256 fix: tests
Barış Soner Uşaklı 23a9a334cd feat: short more info
Barış Soner Uşaklı 2485a55092 feat: , allow editing title before posting from queue
Barış Soner Uşaklı 8ddc8dd10f refactor: make msg pretty
Barış Soner Uşaklı 764969ab29 feat: show language when key isn't found
Barış Soner Uşaklı 1e7397b1b8 feat: allow searching categories in ACP
Barış Soner Uşaklı 320008cd49 feat: , don't scroll chat to bottom if user scrolled up
psychobunny 06143ca7d7 feat: added quick link to edit privileges on the category edit page
Julian Lam 1e14af4503 fix: composer textarea placeholder l10n /cc @pitaj
Julian Lam 9fb9185fa7 feat: hide some filters behind 'more filters' button
Julian Lam d52d7bdb10 feat: collapsible daily flags graph
Julian Lam e3e55f25d0 refactor: flag sanity checks, +feat: flag limits
- Added new config flag:limitPerTarget, to disallow flags after an item has
  already been flagged x times (default 0, or infinite)
- New zset flags:byTarget, score is the number of times a flag has been made
  against that item
- "already-flagged" translation key removed, now "post-already-flagged" or
  "user-already-flagged" -- this fixed bug where flagging a user you've already
  flagged would tell you you've already flagged this post already.
- Refactored Flags.canFlag to throw errors only, instead of returning boolean
- Updated ACP form inputs for reputation settings page to be more bootstrappy
- +1 upgrade script
Julian Lam 1441720962 feat: logic for flag note editing,
Julian Lam f85a45c722 feat: logic for flag note deletion,
Barış Soner Uşaklı 5e984d10f0 fix:
Julian Lam 2286ee2a61 fix: invalid session error modal during logout
A brief flash can be seen, but this is exacerbated by slow
connections and/or slow server response.
Julian Lam 3379d65f36 feat: fire action:flag.showModal on flag modal appearance
Barış Soner Uşaklı 00d39fb32c feat: , export groups members as csv
Barış Soner Uşaklı 3dcf538773 feat: , allow wildcard search for uid/email
Barış Soner Uşaklı 46a6686300 fix: category search in selector
Barış Soner Uşaklı c513b88dff feat: , daily downvote limits
Barış Soner Uşaklı 4adbf87c6c feat: warn user if whitelisted tags are less than minTags
Barış Soner Uşaklı 658dd03b03
feat: add tools to recent/unread ()
* feat: add tools to recent/unread

* fix: open api spec

* fix: more api spec
Julian Lam 4f51838df8 feat: fire new hooks on chat message editing
Barış Soner Uşaklı 9eb748b985 fix: , fix url to merged topic in subfolder installs
Barış Soner Uşaklı 5f1865c0b7 fix: openapi
Barış Soner Uşaklı 65c0adc720 fix: openapi
Barış Soner Uşaklı ac6b571ed5 fix: dont allow searching by email/ip if not privileged
Julian Lam c468942f14 fix(openapi): tests
Julian Lam f3441fce4f fix: admin privileges client-side regression
Julian Lam da29b947bf feat: add js-enabled.css to list of preloaded css files
Barış Soner Uşaklı bd228d5ee7 feat: fix blocksCount not being returned on user profile
add hook action:user.blocks.toggle
Misty (Bot) fe908cc022 Latest translations and fallbacks
Julian Lam 6cb31791ff feat: polish for user blocks UX
Misty (Bot) a1a5424047 Latest translations and fallbacks
Julian Lam 6931f29d53 feat: allow flagging of user acounts from post tools menu
Misty (Bot) 1b1e9b6725 Latest translations and fallbacks
Misty (Bot) e66b526ca0 Latest translations and fallbacks
Barış Soner Uşaklı e09ab3dc19 feat: closes , allow configuring max topic count
Barış Soner Uşaklı 2355d9d5dd fix: escape navigation item fields, theme:id, category fields
Misty (Bot) c0857f6390 Latest translations and fallbacks
Misty (Bot) 9b20d0ce20 Latest translations and fallbacks
Barış Soner Uşaklı e53a18f219 fix: ,
Barış Soner Uşaklı bffb830d87 feat: add missing translation key
Barış Soner Uşaklı c718b7293e feat: , min/max tags per category
Barış Soner Uşaklı ed4b5caf2c fix: copy settings showing empty category selection
Barış Soner Uşaklı 0482fb2998 feat: use tags partial instead of post_bar
Barış Soner Uşaklı 8482a54a68 fix: don't init autocomplete if user doesn't have privs
Barış Soner Uşaklı 4f6b6c5631 feat: hide elements if search element is a direct child of dropdown
this fixes themes if they put the search input inside the dropdown
Misty (Bot) d50f7c7dfa Latest translations and fallbacks
Barış Soner Uşaklı f03ca0867b fix: tests
Barış Soner Uşaklı 8383992dcc feat: move export functions into child processes
Barış Soner Uşaklı 48b41debe6
fix: vulnerability in cover and admin uploads ()
* fix: vulnerability in cover and admin uploads

* fix: remove old test

* fix: update tests
Misty (Bot) 76c577fa3c Latest translations and fallbacks
Misty (Bot) 55f8f99bcd Latest translations and fallbacks
Julian Lam 040e6a9a4c fix: reverse tabnabbing exploit in post images
Misty (Bot) 757cfe80be Latest translations and fallbacks
Misty (Bot) f5b3713313 Latest translations and fallbacks
Barış Soner Uşaklı bfd7eafe5b fix: ban
Barış Soner Uşaklı b459592a4e Merge branch 'master' of https://github.com/NodeBB/NodeBB
Barış Soner Uşaklı f70d1648c6 feat: show more relevant snippets
Julian Lam 4cae893f49 fix(openapi): tests for
Julian Lam 35a06a8419 feat: breadcrumbs for ip-blacklist/post queue/flags
Misty (Bot) 7fe9c1a26d Latest translations and fallbacks
Julian Lam 5a367ecbb4 fix: remove use of 'hidden' class in navbar toggling
Julian Lam f909ed2541 feat: show editor in post diffs if available
Julian Lam 2515aa77ba fix: bug where category privs page thought it was on admin
Julian Lam b3115ea813 fix:
Misty (Bot) cdf81159df Latest translations and fallbacks
Julian Lam d5af976915 feat: flags' quick assignment
Barış Soner Uşaklı 42466d3c6e fix: add missing translations
Julian Lam 58b3d608fc feat: allow post diffs to be restored,
Misty (Bot) 8f81651e2f Latest translations and fallbacks
Barış Soner Uşaklı 3a80a1651a feat: add missing translation
Barış Soner Uşaklı 6349fa03e1 feat: more search changes
Barış Soner Uşaklı 4b38533b15 feat: more merge/search fixes
Barış Soner Uşaklı bb3aa54006 feat: merge changes
allow selecting main topic to merge into
allow specifying a new title for merge topic
upon merge go to correct topic
new tests for merging with options
Barış Soner Uşaklı 8591f5d2cc fix: return false
Barış Soner Uşaklı 5fd05dc942 feat: more search & merge fixes
Barış Soner Uşaklı c4bdeae06e feat: merge improvements wip
Barış Soner Uşaklı a255c8f6fd fix: language
Julian Lam 6a96944247 fix(openapi): api change for
Misty (Bot) 2287963388 chore: latest translations and fallbacks
Barış Soner Uşaklı d92032dad1 fix: prevent logout form from submitting
Julian Lam 4d60eac60f feat: options to delete account, content, or both
Julian Lam 67aca822e6 feat: account content deletion, closes
Julian Lam 656b391fc5 feat: add missing language files for
Misty (Bot) 8019d316e2 Latest translations and fallbacks
Barış Soner Uşaklı 50703db879 fix: , dont break history
Barış Soner Uşaklı 0c265a41d4 fix: , go to hash when entering topic
Julian Lam a82e9bd7f6
feat: privileges for Admin Control Panel ()
* feat: acp privileges (WIP)

* fix: restore global privilege hooks

* refactor: using cid 0 in admin privs

* fix: no need for zebrastripe-reset

* feat: manage:categories privilege WIP

* feat: renamed prefix to admin:, settigns and dashboard privs

* fix: nofocus on acp privs group find modal

* refactor: privileges.x.get() to not used hardcoded privs

* fix: crash if unable to get latest version

* feat: setting acp priv

* Revert "fix: crash if unable to get latest version"

This reverts commit afdb235f48eb0072d88de45f3a1e0151281095b3.

* feat: user/privilege acp privs

* fix: category selector in manage/privileges

* fix: guests potentially becoming admins

* fix: bug in setting admin privs

* fix: some last minute things + api docs

* fix: some more last minute fixes
Barış Soner Uşaklı 30cc83c033 fix: , revert event delete
Julian Lam 09184f4027 fix: new language tag for select_tags
Julian Lam 260a482caa fix: remove duplicate link to manage/tags in settings/tags
Misty (Bot) 73055bfccc Latest translations and fallbacks
Barış Soner Uşaklı 1b5d5425b4 fix: handle search tag permission as well
Barış Soner Uşaklı 2100a03c1a refactor: change name to privileges to match other apis
cryptoethic f6b92d241a
fix: checking correct permissions for user search ()
* fix: checking correct permissions for user search

* fix: missing permissions porperty in openapi /api/search
Barış Soner Uşaklı c1d8b9bb5a Merge branch 'master' of https://github.com/NodeBB/NodeBB
Barış Soner Uşaklı 7786187e84 fix: change event name so it doesnt trigger complete event
add data to complete event
Misty (Bot) 5dc8982da3 Latest translations and fallbacks
Julian Lam 8ea1634824 feat: flag quick actions for delete/restore/purge
Julian Lam 922d49be0b fix(style): switch..case
Peter Jaszkowiak de7ec47f13
fix: , remove webfonts ()
Misty (Bot) b31482092d Latest translations and fallbacks
Julian Lam 98dffa3af8 fix: tests due to 0633ad327
Misty (Bot) bad23159d2 Latest translations and fallbacks
Misty (Bot) d7b2f163f2 Latest translations and fallbacks
Julian Lam 0633ad3277 fix: acp menu items
- Shuffled items in settings
- Moved post-queue and ip-blacklist to front-end
- Removed Settings > Sockets, merged with Settings > Advanced
Julian Lam a83f4259e8 fix: re-jigged tags acp pages
Julian Lam a51fff8bd1
refactor: remove general menu from ACP ()
* refactor: remove general menu from ACP

* fix: incorrect translation keys, fixed tests
Misty (Bot) 3338c3112e Latest translations and fallbacks
Barış Soner Uşaklı 9ffcb6f7ba feat: add results into results container
Barış Soner Uşaklı f12d448ef5 feat: quick search changes
Barış Soner Uşaklı bb1a56f0fe feat: move quick search into search module
so it can be used directly
Barış Soner Uşaklı 47d73a2ab4 fix: move checks into timeout
Barış Soner Uşaklı a9315aee7d fix: , add missing translation
Barış Soner Uşaklı 84c20f919b fix: don't explode if server sends `checkSession`
Barış Soner Uşaklı 5781a2dc65
feat: fix session mismatch errors by clearing cookie on logout ()
* feat: fix session mismatch errors by clearing cookie on logout

* feat: remove app.upateHeader

ported from 2.0

* feat: handle if user doesn't click button and just refreshes page
Misty (Bot) 938c232377 Latest translations and fallbacks
Julian Lam f0e59c149d fix: eliminate unnecessary try..catch
Julian Lam a0e243eea1 fix(openapi): schema for new flags api
Julian Lam 8d995d1eb6 refactor: flags detail page
- Show account moderation history
- Ban and delete quick actions

Squashed commit of the following:

commit 0e782e65f4d48ae814708e510ec9d01bcdd914e0
Author: Julian Lam <julian@nodebb.org>
Date:   Tue May 26 20:24:53 2020 -0400

    fix(deps): use persona 10.1.41/vanilla 11.1.17

commit 369e073d3c3189d8ce181eb3d573489cbe54d4fc
Author: Julian Lam <julian@nodebb.org>
Date:   Tue May 26 20:23:24 2020 -0400

    fix: allow ban and delete exported methods to have cbs

commit b83a086ea31a77ec82d161306c0b9bc115cb2a3a
Merge: 525aae1ea 256ee45d3
Author: Julian Lam <julian@nodebb.org>
Date:   Tue May 26 08:54:25 2020 -0400

    Merge remote-tracking branch 'origin/master' into flags-improvements

commit 525aae1ea2e5d0103028a0f0c8dde05f172d088e
Author: Julian Lam <julian@nodebb.org>
Date:   Tue May 26 08:53:39 2020 -0400

    feat: integrate ban history and username changes to flag history list

commit 3e68ad28ba266f4c8620a676aa7f463f0a9d1df7
Author: Julian Lam <julian@nodebb.org>
Date:   Mon May 25 18:22:53 2020 -0400

    feat: allow ban and deletion from flag details page

commit a559ea1d8e8883385c2876868d855a0b93516c54
Author: Julian Lam <julian@nodebb.org>
Date:   Mon May 25 18:22:00 2020 -0400

    feat: export banAccount and deleteAccount methods from accounts module
Ali Cihan 256ee45d37
typo ()
Misty (Bot) d2edf0c371 Latest translations and fallbacks
Misty (Bot) 31edcdee7d Latest translations and fallbacks
Misty (Bot) 8eb89156fb Latest translations and fallbacks
Barış Soner Uşaklı d6c2764fe7 fix: don't trigger quick search if val doesn't change
Barış Soner Uşaklı 6f78113ee3 fix: prevent duplicate search triggers
if app.handleSearch is called from a plugin in action:ajaxify.end events are fired multiple time
Misty (Bot) 478c8dd72b Latest translations and fallbacks
Julian Lam 6f504c4142
Remove allowFileUploads ACP option ()
* feat: allow awaitable upgrade scripts

* feat: allowFileUploads removal upgrade script

* refactor: remove unnecessary ACP option `allowFileUploads`

* fix: updated upgrade script template to not use callback arg

* fix: upgrade script as per @baris

* fix: add missing await

* fix: add missing await
Barış Soner Uşaklı ada45a34d5 fix: search post snipets incase content is plain text
Barış Soner Uşaklı cb662e15ce feat: improve grunt restart/rebuild speed
Barış Soner Uşaklı 2a00b0e973 fix: utils.params({url: ''})
Misty (Bot) 2203398efc Latest translations and fallbacks
Misty (Bot) 981db6429a Latest translations and fallbacks
Barış Soner Uşaklı f0323b6cfa feat: closes , add more data to export profile
Misty (Bot) 5e3760d276 Latest translations and fallbacks
Barış Soner Uşaklı 40b5cbab2c refactor: remove console.log
Barış Soner Uşaklı 765b8156d5 feat: parse quick search tpl even if no results
allows showing "no results found" in theme
Misty (Bot) 83b5a20c7c Latest translations and fallbacks
Julian Lam 45dfeeb033 fix(openapi): broken tests
Barış Soner Uşaklı 1f992cf371 fix: if category in selector has url use it
Julian Lam aa4ae78b63 fix(docs): added titles to all routes
Julian Lam 9fd5c439b2 feat: write-api update, WIP
Barış Soner Uşaklı 4e14cb5767 fix: add missing schema item
Misty (Bot) 928a94426b Latest translations and fallbacks
Barış Soner Uşaklı a73c755b05 feat: closes , edit post notif for watched topic posts
Misty (Bot) b4494cb876 Latest translations and fallbacks
Misty (Bot) 64c3310aa4 Latest translations and fallbacks
Julian Lam 6765de3db3 fix: sortable topics even if only 1 pinned topic
Julian Lam dd2bc18927 fix: , use class name added by jQueryUI instead
This reverts commit 2e57d8ac31.
Julian Lam 2e57d8ac31 fix: discoverability of topic reordering, re:
Julian Lam f2c725c658 fix: topic search shortcut for macs
Misty (Bot) 6567e47494 Latest translations and fallbacks
Julian Lam fcb81cb8ca fix: guest handles shown in category.tpl
Barış Soner Uşaklı be305410fb fix: , don't show error if there are no self messages
Barış Soner Uşaklı 84383d3995 fix: spec
Barış Soner Uşaklı 9839346ec3 fix: , if there are no filters go to ?reset=1
dont count ?page=1 as a filter
Misty (Bot) 2cf0a9b62d Latest translations and fallbacks
Barış Soner Uşaklı 2d07634494
fix: , update gdpr link again
Misty (Bot) c0e441d3b2 Latest translations and fallbacks
Barış Soner Uşaklı 3fcbd69149 feat: reduce infinite scroll area
Barış Soner Uşaklı 17d664e098 fix: , point to official site
psychobunny 275e837bcf fix: jquery xhtml violations
Opliko 4855f1deca
fix:#8274 Don't escape HTML in manage users ()
Perhaps the HTML for managing groups should ba actually rendered as HTML to serve its function. fixes 
Misty (Bot) 75aaba3f4e Latest translations and fallbacks
Julian Lam 23a0b8c54c fix(openapi): v14 test fix
Barış Soner Uşaklı 9ffdab02d0 fix: tag of /api/unread/total
Julian Lam ccc6118d30
Testing suite integration for openapi spec ()
* feat: testing suite integration for openapi spec

The testing suite now takes the openapi spec into account. It will
check each route defined, make a call to it, and compare the
response with the defined schema. Any mismatches will cause the
test to fail.

* fix(openapi): removed debug stuff from tests

* fix(openapi): fixed some tests

* fix(openapi): added additional check to tests, test fixes

* fix(openapi): better tests, fixed spec errors

* fix(openapi): bad conditional in test

* fix: oops

* fix(openapi): more tests fixing

* fix(openapi): more tests

* fix(openapi): fix some more tests

* fix: verbose'd an info log

* fix: topic pagination route returns schema-optimized pagination block

* fix(openapi): more test/spec fixes

* fix(openapi): accidentally sending in authenticated jar for anon routes

* fix(openapi): more test/spec fixes

* fix(openapi): more spec fixes

* fix: timestampReadable Invalid Date

* fix(openapi): more tests... almost there

* fix(openapi): more tests fixing

* fix(openapi): finally all tests passing

* fix(openapi): added reverse test to compare response to spec

... and fixed all the tests that broke

* fix: remove tests related to group covers, as route is gone

* fix(openapi): broken test on travis

* fix(openapi): broken test on travis

* fix(openapi): broken test on travis

* fix(openapi): object cache is not present for psql

* fix: tests

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
Misty (Bot) 267567a086 Latest translations and fallbacks
Misty (Bot) c1429fbbf1 Latest translations and fallbacks
Opliko 47e7e9572c Add loading=lazy tag to avatars
There is no reason why avatars should be a blocking reasorce, and browsers are now adding support for lazy loading of images (and iframes). According to [caniuse.com](https://caniuse.com/#feat=loading-lazy-attr) 62% of users use a browser that supports this attribute.

So there doesn't seem to be any downside to just adding this attribute here. It won't affect browsers that don't support it and might speed up page loads on browsers that do.
Opliko 6e5ebb6184
feat: manifest.json improvements from ()
* feat: manifest.json improvements from 

* Fix short title placeholder

* use lowercase letters for hex colors
Julian Lam d342a28c16 fix(openapi): remove account and group upload routes
re: 
Julian Lam 058a15dbb2 fix(openapi): more fleshing out
Julian Lam bae88e089a fix(openapi): fleshed out admin routes
Julian Lam 8387178b25 feat(openapi): merging openapi-test branch into master
Barış Soner Uşaklı ba6d3fd372 fix: only trigger infinitescroll on scroll end
Julian Lam ab4bd7e146 fix(openapi): added some descriptions
Misty (Bot) d678793cd4 Latest translations and fallbacks
Julian Lam 2395d2be2e fix(openapi): added PostsObject component
Julian Lam 1b425ef108 fix: no focus on find user modal
Julian Lam bcbf98aa4c fix: accidental fp precision on flag and acp dash graphs
Misty (Bot) d387cc231e Latest translations and fallbacks
Julian Lam 23dd2727f2 fix(openapi): finished moving all category objects out
Julian Lam c939f8c66d fix(openapi): changed some descriptions
Julian Lam 55d0a9ffea fix(openapi): added CategoryObject component
Julian Lam 646fac1e53 fix(openapi): removed repeated breadcrumb blocks in favour of $ref
Julian Lam ac579f9dc2 fix(openapi): remove all repeated pagination blocks in favour of
Julian Lam 1cf62095dc fix(openapi): removed warning for category mods route
Julian Lam 3a5c6e07f9 fix(openapi): normalising the file for programmatic updates
Misty (Bot) 0252e149d9 Latest translations and fallbacks
Julian Lam 65c78de6fe feat(openapi): move all commonprops out for commonprops component
psychobunny cd5065572c feat: moved component specs into separate files
Julian Lam 2425f4533f feat(openapi): added template to commonprops
Julian Lam 64d79fe5f6 feat: added UserObject, UserObjectFull, Breadcrumb, Pagination component
psychobunny ae3e90d693 feat: added some summary and descriptions
Misty (Bot) 390dbb1bf3 Latest translations and fallbacks
Barış Soner Uşaklı 442c018ec0 feat: add some descriptions
Barış Soner Uşaklı eade13f928 feat: common schema
Julian Lam 32985eb12e Merge remote-tracking branch 'refs/remotes/origin/master'
Julian Lam 7b31fb34a7 fix: missing descriptions for common properties
Barış Soner Uşaklı 9987813f30 feat: add page query param to docs
Barış Soner Uşaklı bbddaadf51 feat: tag route doc
Julian Lam 03739b6f83 fix: some definitions in read API spec
Julian Lam 455d42bcfa fix: tagged all routes in read api spec
Julian Lam 1136a369f3 feat: local redoc view on development mode only
Julian Lam 7b155dab74 feat: added auto-generated, slimmed-down openapi 3.0 file for read api
Misty (Bot) bb565b0a81 Latest translations and fallbacks
Misty (Bot) aabddea2b7 Latest translations and fallbacks
Misty (Bot) 5e849c6b52 Latest translations and fallbacks
Barış Soner Uşaklı 080317300a fix: , fix parent selection
Misty (Bot) 68afd01f67 Latest translations and fallbacks
Barış Soner Uşaklı 0b5fac75b0 fix: , add missing lang key
Misty (Bot) fc06f90346 Latest translations and fallbacks
Julian Lam 5aa76cdf2f feat: pass in target element in action:topic.tools.load
Barış Soner Uşaklı 2f9c7c626f fix: , fix user invites refreshing page
Misty (Bot) af5c6b8824 Latest translations and fallbacks
Misty (Bot) d0075ed9a3 Latest translations and fallbacks
psychobunny b67af70da4 fix: hsts max-age missing translation
Misty (Bot) 41572be879 Latest translations and fallbacks
Misty (Bot) 22ee2b8d06 Latest translations and fallbacks
Barış Soner Uşaklı 5e91a67e78 feat: add user ip to admin/dev/info
Misty (Bot) 07e7872622 Latest translations and fallbacks
Barış Soner Uşaklı 4083a6e39b feat: add awaitable socket.emit
Barış Soner Uşaklı 6e5de39ba0 fix: also fix updating bookmark if sorting is newest_to_oldest
Barış Soner Uşaklı 32ada7c4e7 fix: , fix bookmark if sorting is newest_to_oldest
Misty (Bot) 53720354de Latest translations and fallbacks
Misty (Bot) 7eb0053bd4 Latest translations and fallbacks
Misty (Bot) c71e4de8a8 Latest translations and fallbacks
Misty (Bot) 307c72a58b Latest translations and fallbacks
Misty (Bot) 8f2029faed Latest translations and fallbacks
Barış Soner Uşaklı 326367556f fix: tag key
Barış Soner Uşaklı bc93b5676c fix:
Andrew Rodrigues 3c9689a5ac
feat: settings sorted list ()
* feat: settings sorted list

see https://github.com/NodeBB/nodebb-plugin-quickstart/pull/9/files for sample
Misty (Bot) 307f8716b7 Latest translations and fallbacks
Misty (Bot) 316913b9bb Latest translations and fallbacks
Misty (Bot) f1d58989d8 Latest translations and fallbacks
Barış Soner Uşaklı 067034082f fix: , update deleted/restored messages
Misty (Bot) 20fbab9723 Latest translations and fallbacks
Misty (Bot) 99a3ca7582 Latest translations and fallbacks
Baris Usakli 2e79480179 fix: , don't crash if taskbar doesn't have element
Julian Lam 14655f8745 fix: no decimal places for category analytics
Julian Lam d6e3f3f058
fix: , broken site if no server-side session ()
* fix: , broken site if no server-side session

During the `addHeader` middleware, a check is now done to see if
`req.session.meta` is present. This value is only present if the user
has a valid server-side session.  If it is missing, then it is probably
safe to assume that the server-side session was deleted (either
intentionally or accidentally). In that scenario, the client-side cookie
should be cleared.

Also, there was an issue where the sessionRefresh flag was never cleared
after a successful login, so that was fixed too.

* feat: exported method to get cookie config

* fix: don't clear cookie if cookie is being set

* fix: socket.io tests

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
Misty (Bot) 5ed7fc0ffa Latest translations and fallbacks
Barış Soner Uşaklı 3077eb9428 fix: remove unused conditional, dont add dupe messages
Julian Lam 594cd7e176 fix: user join system message duplicated
- Now showing user-join message for chat owner in addition to the newly
  added user
- If a modal already exists for a room when createModal is called, don't
  return null, return the modal
Julian Lam 106c141ff5 fix: background-size in taskbar images
Barış Soner Uşaklı bfaba89557 Merge branch 'master' of https://github.com/NodeBB/NodeBB
Misty (Bot) ddce77b343 Latest translations and fallbacks
Barış Soner Uşaklı c8fb7f9246 fix: escape register query param
Misty (Bot) 1656738359 Latest translations and fallbacks
yossizahn 09d55581d8 Fix: ACP > manage > group: save disableLeave ()
* Fix: ACP > manage > group: save disableLeave

* Fix eslint comma-dangle
Opliko 879acc85ae Add disable/enable category to category edit page ()
Barış Soner Uşaklı e06c1bfcd2 fix: escape config.userLang/acpLang, don't allow invalid language codes
Barış Soner Uşaklı 5a8217de01 fix: , fix export json on page load
Misty (Bot) ac567bc10a Latest translations and fallbacks
Misty (Bot) 5410b5d6da Latest translations and fallbacks
Misty (Bot) 223225378e Latest translations and fallbacks
Misty (Bot) 0aae421417 Latest translations and fallbacks
Misty (Bot) fd056b58fb Latest translations and fallbacks
Misty (Bot) bb1515ce56 Latest translations and fallbacks
Barış Soner Uşaklı c1b1ee61f3 fix: create user modal instantly closing
Misty (Bot) b9679df784 Latest translations and fallbacks
Misty (Bot) 9a4a48bc45 Latest translations and fallbacks
Misty (Bot) 94e2c7e4bb Latest translations and fallbacks
Aziz Khoury acca0b956e more secure isRelativeUrl ()
Misty (Bot) 505409b9f3 Latest translations and fallbacks
Misty (Bot) 9c48a4c021 Latest translations and fallbacks
Misty (Bot) 581211e12f Latest translations and fallbacks
Misty (Bot) 9197a0db1e Latest translations and fallbacks
Barış Soner Uşaklı 05c9fe2735 feat: , allow changing user groups from manage users page
Misty (Bot) ff8dfa049d Latest translations and fallbacks
Baris Usakli 4d66978338 fix: , configurable necroThreshold
Baris Usakli 160e0ab1f5 Merge branch 'master' of https://github.com/NodeBB/NodeBB
Misty (Bot) 6ada231bc8 Latest translations and fallbacks
Baris Usakli c2cd7de891 fix: , dont show hidden groups in search
Misty (Bot) ce449e918d Latest translations and fallbacks
Misty (Bot) d8a48cf0a7 Latest translations and fallbacks
Misty (Bot) 802f566b17 Latest translations and fallbacks
Barış Soner Uşaklı 1bda92e3fc fix: , break-word on post-queue
Barış Soner Uşaklı 7ed002a138 fix:
Misty (Bot) c8db839e63 Latest translations and fallbacks
Misty (Bot) 86cc80348d Latest translations and fallbacks
Misty (Bot) 4fea12c83e Latest translations and fallbacks
Barış Soner Uşaklı 3811e0a3df fix: , dont show errors after clearing form
Misty (Bot) 10a6ca6173 Latest translations and fallbacks
Misty (Bot) beebe53a71 Latest translations and fallbacks
Misty (Bot) 0002c3f499 Latest translations and fallbacks
Misty (Bot) 2eb8c05e4b Latest translations and fallbacks
Baris Usakli 6c404b81fb fix: use the correct attribute name for widgets
Misty (Bot) 83ba2e234b Latest translations and fallbacks
Misty (Bot) b47f1769e4 Latest translations and fallbacks
Misty (Bot) 5e88c585cb Latest translations and fallbacks
Misty (Bot) 7721c58dd3 Latest translations and fallbacks
Misty (Bot) 8d41cdefa9 Latest translations and fallbacks
Julian Lam df139928b6
feat: displaying one-click unsubscribe link in email footer ()
closes 
Misty (Bot) 9c3fa7758a Latest translations and fallbacks
Misty (Bot) d75d9fdd33 Latest translations and fallbacks
Misty (Bot) d9b8e929e6 Latest translations and fallbacks
Misty (Bot) 23d66ae86c Latest translations and fallbacks
Julian Lam 645d647248
feat: wip, better digest handling (+ eventual digest resend logic) ()
* feat: wip, better digest handling (+ eventual digest resend logic)

- await emailer.send call in digest.send method
- save send success to a new sorted set digest:{interval}:byUid

* feat: continuing work on digest tools

- Added ACP page to view digest settings and delivery times per user

* feat: added paginator and stub buttons for resending digest

* feat: wrapping up digest revamp

- New language strings in ACP digest page
- Client-side ACP script for digest ACP page
- Websocket call for ACP page to execute digests
- Broke out logic to retrieve user digest settings to getUsersInterval

* fix: minor cleanup

* fix:  and some style suggestions from baris

* fix: resolve confusing comment
Misty (Bot) 0283ffd04d Latest translations and fallbacks
Misty (Bot) 72fd9f6546 Latest translations and fallbacks
Misty (Bot) f69b1cebb1 Latest translations and fallbacks
Barış Soner Uşaklı 1cedc4a0d6 feat: , allow post queue based on group
allow multiple select in ACP pages
Misty (Bot) 188bb6b3eb Latest translations and fallbacks
Misty (Bot) c4190dde0f Latest translations and fallbacks
Julian Lam 3952849f30
fix: , tweak wording; password reset success
Barış Soner Uşaklı 4b8897d9bc fix: lint
Aziz Khoury beea56b3c6 ie11 doesnt support Object.values ()
Misty (Bot) 500ca6658e Latest translations and fallbacks
Misty (Bot) 57dce269c3 Latest translations and fallbacks
Misty (Bot) 37642f4313 Latest translations and fallbacks
Barış Soner Uşaklı 441dd86d29 fix: convert param to string in slugify
fixes adding users to privilege table
Barış Soner Uşaklı 95a372df85
fix: , fix undefined url ()
Barış Soner Uşaklı ca3be1f336
fix: ()
Misty (Bot) 4093c98794 Latest translations and fallbacks
Misty (Bot) 132e32eb5c Latest translations and fallbacks
Misty (Bot) 632daa0e94 Latest translations and fallbacks
Baris Usakli 485fbd2f14 feat: , change all categories at once
allow passing cids to setCategoryWatchState and category.exists
Baris Usakli 990508a533 feat: closes , translate widget-settings
Baris Usakli 554e67116f feat: remove ability to delete events from acp
Baris Usakli 5b458fc7ca fix: , allow icon only group badges
Misty (Bot) b232b95f76 Latest translations and fallbacks
Barış Soner Uşaklı c5f7b66c3a fix: new nav items will show group select
Barış Soner Uşaklı f402d7271a fix: move post and change owner
Barış Soner Uşaklı b19f0a686c fix: 404 on new groups with spaces
Misty (Bot) aafb7739a9 Latest translations and fallbacks
Misty (Bot) a578f92bcc Latest translations and fallbacks
Misty (Bot) b484f309e2 Latest translations and fallbacks
Misty (Bot) 2477849bb5 Latest translations and fallbacks
Julian Lam 54c9f877a6 fix: , ACP digest wording
Barış Soner Uşaklı 2444ed5c88 feat: , redirect to group details after creation
add private/hidden on group creation modal
Baris Usakli 95ab071254 fix: remove jquery
Misty (Bot) 4d912ca300 Latest translations and fallbacks
Barış Soner Uşaklı 9a7560049a feat: bypass cropper for gifs
Misty (Bot) 2801ffa622 Latest translations and fallbacks
Barış Soner Uşaklı ed1223645e feat: send notification to group owners when someone leaves
Andrew Rodrigues 40f131a6bb
fix: potential for XSS here
Misty (Bot) 969c5d4a2b Latest translations and fallbacks
Misty (Bot) bd3d3f2e39 Latest translations and fallbacks
Barış Soner Uşaklı babb9d7c55 fix: , dont allow urls in fullname/location, validate birthday
Misty (Bot) f0ae2887b8 Latest translations and fallbacks
Misty (Bot) bb8a9b2563 Latest translations and fallbacks