1e7397b1b8
feat: allow searching categories in ACP
5 years ago
06143ca7d7
feat: added quick link to edit privileges on the category edit page
5 years ago
3653151143
fix : #8508 , dont allow moving topics if not moderator of target category
5 years ago
e3e55f25d0
refactor: flag sanity checks, +feat: flag limits
...
- Added new config flag:limitPerTarget, to disallow flags after an item has
already been flagged x times (default 0, or infinite)
- New zset flags:byTarget, score is the number of times a flag has been made
against that item
- "already-flagged" translation key removed, now "post-already-flagged" or
"user-already-flagged" -- this fixed bug where flagging a user you've already
flagged would tell you you've already flagged this post already.
- Refactored Flags.canFlag to throw errors only, instead of returning boolean
- Updated ACP form inputs for reputation settings page to be more bootstrappy
- +1 upgrade script
5 years ago
1441720962
feat: logic for flag note editing, #8499
5 years ago
f85a45c722
feat: logic for flag note deletion, #8499
5 years ago
00d39fb32c
feat: #8460 , export groups members as csv
5 years ago
b3a88331bf
fix : #8488
5 years ago
393f19b461
feat: pass connection options to socket.io-adapter-mongo
5 years ago
3dcf538773
feat: #8023 , allow wildcard search for uid/email
5 years ago
46a6686300
fix: category search in selector
5 years ago
73ddf1cb98
fix: groups.updateCover
5 years ago
c513b88dff
feat: #8427 , daily downvote limits
5 years ago
658dd03b03
feat: add tools to recent/unread ( #8477 )
...
* feat: add tools to recent/unread
* fix: open api spec
* fix: more api spec
5 years ago
c2ca02dfc7
fix : #8474
...
make isPrimary and isCluster always booleans
they were strings when using ./nodebb start and boolean if they were in config.json and started with node app.js
5 years ago
4f51838df8
feat: fire new hooks on chat message editing
5 years ago
7b04d8970d
fix: show stack properly
5 years ago
9a6b87d261
fix: editing chat messages does not go through content sanity checks
5 years ago
d6c619cf1a
fix: don't show blocked users under nested replies
5 years ago
b60e1cbf50
fix : #8469 , action:topic.changeOwner, action:post.changeOwner
5 years ago
87dd6c83eb
fix: tests
5 years ago
746222d6c6
fix: handle scan/zscan returning duplicate elements on redis
...
increase count on redis zscan
5 years ago
ac6b571ed5
fix: dont allow searching by email/ip if not privileged
5 years ago
fef04fcf6b
fix: missing backgroundImage #8386
5 years ago
02ac44cc5a
fix: dont allow searching by ip/banned/flagged for regular users
5 years ago
057b783df7
feat: use covered query
5 years ago
da29b947bf
feat: add js-enabled.css to list of preloaded css files
5 years ago
e95cd28f6f
Zscan ( #8458 )
...
* feat: zscan
* fix: mongodb tests
* feat: scan, ip search starts with
5 years ago
723fe8e8e0
feat: zscan ( #8457 )
...
* feat: zscan
* fix: mongodb tests
5 years ago
59a2ace6f7
fix: only add blocksCount for self and admins
5 years ago
fd20e5c62c
fix: tests
5 years ago
bd228d5ee7
feat: fix blocksCount not being returned on user profile
...
add hook action:user.blocks.toggle
5 years ago
eb9704f85e
feat: #8450 , next/prev link tags on /unread /recent
5 years ago
fd400a008d
fix: don't show in unreplied if score is null
5 years ago
e09ab3dc19
feat: closes #8440 , allow configuring max topic count
5 years ago
0d0b951380
fix: lint
5 years ago
37b6b8fd48
fix: upgrade script to unescape navigation titles
5 years ago
2355d9d5dd
fix: escape navigation item fields, theme:id, category fields
5 years ago
023de94ef8
fix: show controls @julianlam
5 years ago
e53a18f219
fix : #8437 , #8433
5 years ago
bffb830d87
feat: add missing translation key
5 years ago
0d112b3605
refactor: make code climate happier?
5 years ago
c718b7293e
feat: #3783 , min/max tags per category
5 years ago
00d8ce2663
fix: only allow valid uids
5 years ago
8383992dcc
feat: move export functions into child processes
5 years ago
48b41debe6
fix: vulnerability in cover and admin uploads ( #8419 )
...
* fix: vulnerability in cover and admin uploads
* fix: remove old test
* fix: update tests
5 years ago
e80379dc0e
feat: display stack trace on winston.error
5 years ago
af790e3f5e
refactor: shorter code
5 years ago
e8f0da6e42
refactor: shorter code
5 years ago
79a7f89235
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
2bcf7f72d2
fix: follower count going out of sync with real follower count
5 years ago
bef37e27cb
fix: test lock for user create ( #8415 )
...
* fix: test lock for user create
* fix: redis hdel with undefined
* feat: add test for undefined key in deleteObjectFields
5 years ago
f0526bff9f
fix: add mising timestamp
5 years ago
a680a95e73
feat: add filter:user.getFields to match topic/posts
5 years ago
056f85f864
Topic hooks extension ( #8413 )
...
* Update data.js with new hook
Implemented new 'filter:topic.getFields' hook as in posts
* Update data.js
* Update data.js
5 years ago
35a06a8419
feat: #8412 breadcrumbs for ip-blacklist/post queue/flags
5 years ago
f909ed2541
feat: show editor in post diffs if available
5 years ago
b3115ea813
fix : #8410
5 years ago
58b3d608fc
feat: allow post diffs to be restored, #8406
5 years ago
7ed1a0140a
fix : #8401 , #8237
...
switch to @nodebb/socket.io-adapter-mongo
5 years ago
18d892398f
fix: add timestamp to initial username history
5 years ago
53a9517d54
fix: crash in export posts if post content is undefined
5 years ago
0041c02465
fix: messaging unread
...
dont mark chat room unread and then read right away for the user sending the message
5 years ago
066b442e18
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
bb3aa54006
feat: merge changes
...
allow selecting main topic to merge into
allow specifying a new title for merge topic
upon merge go to correct topic
new tests for merging with options
5 years ago
a024cc1344
fix: whitespace
5 years ago
0595e71078
fix: typo
5 years ago
89b010249d
fix : #8392 , clear group member cache when group is renamed
5 years ago
8627bee541
fix : #8386 , use backgroundImage everywhere
5 years ago
4acb3fb210
feat: #8387 expose global and admin privs to flags detail page
5 years ago
3be4d5f7d5
feat: redirect /me to user profile
5 years ago
daeceb45bd
fix: missing space in ACP menu dropdown
5 years ago
942cc4b132
fix : #8385
5 years ago
67aca822e6
feat: account content deletion, closes #8381
5 years ago
a82e9bd7f6
feat: privileges for Admin Control Panel ( #8355 )
...
* feat: acp privileges (WIP)
* fix: restore global privilege hooks
* refactor: using cid 0 in admin privs
* fix: no need for zebrastripe-reset
* feat: manage:categories privilege WIP
* feat: renamed prefix to admin:, settigns and dashboard privs
* fix: nofocus on acp privs group find modal
* refactor: privileges.x.get() to not used hardcoded privs
* fix: crash if unable to get latest version
* feat: setting acp priv
* Revert "fix: crash if unable to get latest version"
This reverts commit afdb235f48eb0072d88de45f3a1e0151281095b3.
* feat: user/privilege acp privs
* fix: category selector in manage/privileges
* fix: guests potentially becoming admins
* fix: bug in setting admin privs
* fix: some last minute things + api docs
* fix: some more last minute fixes
5 years ago
30cc83c033
fix : #8374 , revert event delete
5 years ago
fd6bf0c927
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
260a482caa
fix: remove duplicate link to manage/tags in settings/tags
5 years ago
3a078f59ec
fix: tests
5 years ago
1b5d5425b4
fix: handle search tag permission as well
5 years ago
2100a03c1a
refactor: change name to privileges to match other apis
5 years ago
f6b92d241a
fix: checking correct permissions for user search ( #8371 )
...
* fix: checking correct permissions for user search
* fix: missing permissions porperty in openapi /api/search
5 years ago
842b8abb84
feat: add buildHeaderAsync ( #8367 )
...
* feat: add buildHeaderAsync
make helphers.notAllowed async
* fix: remove csrf from buildHeader
* fix: remove unused method, use middleware
* fix: /post/pid redirect doesn't need buildHeader
use buildHeaderAsync
5 years ago
dcb85ee7a1
#8344 ( #8346 )
...
* feat: wip
* feat: wrap middlewares
* feat: middleware errors
* feat: more middleware changes
* fix: remove unused async
* fix: prevent version errors from blocking acp render
* feat: wrap more middlewares
5 years ago
023942da7d
refactor: making rendering of header and footer async functions
...
* refactor: make middleware.admin.renderHeader async
* refactor: making rendering of header and footer async functions
* fix: use app.renderAsync instead of promifying it
5 years ago
922d49be0b
fix(style): switch..case
5 years ago
5a2b515431
feat: #8349 , remove user posts from queue if user is deleted
5 years ago
e603ebc0c6
fix : #8323 , let admins send validation emails without timeout
5 years ago
2c9e865763
fix: retry failed setObject calls
5 years ago
0633ad3277
fix: acp menu items
...
- Shuffled items in settings
- Moved post-queue and ip-blacklist to front-end
- Removed Settings > Sockets, merged with Settings > Advanced
5 years ago
a83f4259e8
fix: re-jigged tags acp pages
5 years ago
a51fff8bd1
refactor: remove general menu from ACP ( #8347 )
...
* refactor: remove general menu from ACP
* fix: incorrect translation keys, fixed tests
5 years ago
5781a2dc65
feat: fix session mismatch errors by clearing cookie on logout ( #8338 )
...
* feat: fix session mismatch errors by clearing cookie on logout
* feat: remove app.upateHeader
ported from 2.0
* feat: handle if user doesn't click button and just refreshes page
5 years ago
7d484fc0ad
refactor: use getSortedSetMembers
5 years ago
0009f54e6e
feat: add getSortedSetMembers
5 years ago
2727f472ed
feat: add the data from page into filter:middleware.renderHeader
5 years ago
ec5582b53c
feat: add privilege give/rescind hooks ( #8336 )
...
* feat: add privilege give/rescind hooks
action:privileges.categories.give/rescind
action:privileges.global.give/rescind
breaking change, privileges.categories.give/rescind and privileges.global.give/rescind use full privilege name for groups ie `groups:find` instead of `find`
* fix: tests, privileges renamed
5 years ago
cf00cda07c
refactor: src/flags.js because codeclimate
5 years ago
8d995d1eb6
refactor: flags detail page
...
- Show account moderation history
- Ban and delete quick actions
Squashed commit of the following:
commit 0e782e65f4d48ae814708e510ec9d01bcdd914e0
Author: Julian Lam <julian@nodebb.org>
Date: Tue May 26 20:24:53 2020 -0400
fix(deps): use persona 10.1.41/vanilla 11.1.17
commit 369e073d3c3189d8ce181eb3d573489cbe54d4fc
Author: Julian Lam <julian@nodebb.org>
Date: Tue May 26 20:23:24 2020 -0400
fix: allow ban and delete exported methods to have cbs
commit b83a086ea31a77ec82d161306c0b9bc115cb2a3a
Merge: 525aae1ea 256ee45d3
5 years ago
f3afba6156
feat: filter followed tids by category
5 years ago
1b9e8928eb
feat: use getSortedSetsMembers to load followed tids
5 years ago
a015af4a41
feat: add batch size to cursors
5 years ago
0a31e3e6b0
fix : #8320 , dont load moderators separately for each category
5 years ago
11bb6abb51
fix: show stack trace on startup errors
5 years ago
9600ede579
feat: up cache size
5 years ago
7f24200c73
feat: add folder to filter:uploadImage and filter:uploadFile
5 years ago
3ec05eeaf8
fix: user faster method if sorting by smallest set
5 years ago
4ee3543ea4
feat: tweak intersection code, add tests
5 years ago
6f504c4142
Remove allowFileUploads ACP option ( #8324 )
...
* feat: allow awaitable upgrade scripts
* feat: allowFileUploads removal upgrade script
* refactor: remove unnecessary ACP option `allowFileUploads`
* fix: updated upgrade script template to not use callback arg
* fix: upgrade script as per @baris
* fix: add missing await
* fix: add missing await
5 years ago
e5228179c1
Mongo intersection ( #8322 )
...
* feat: intersection without aggregation
* feat: intersection
* feat: remove debug code
5 years ago
e327d1247e
Revert "fix: #8142 invalid session warning if server-side session destroyed"
...
This reverts commit 526b3cd9ec
5 years ago
cb662e15ce
feat: improve grunt restart/rebuild speed
5 years ago
4263efa091
feat: don't overwrite req.query.lang if it exists
5 years ago
12c6bc2e07
feat: convert queries so they used indices directly
5 years ago
ae2db423ee
feat: cookie SameSite property
...
More information:
https://tools.ietf.org/html/draft-ietf-httpbis-cookie-same-site-00#section-4.1.1
https://web.dev/samesite-cookies-explained/
5 years ago
7a801abade
fix: tests on redis
5 years ago
8bf980cb63
fix: tests, handle no sessions
5 years ago
a0d76ff0a6
fix : #8318 , clean expired sessions on login and get
5 years ago
2587112f9d
feat: if only one value is passed used faster function
5 years ago
81e33b9391
fix : #8317
5 years ago
526b3cd9ec
fix : #8142 invalid session warning if server-side session destroyed
...
Resolved regression caused by 5a0c7c1497
5 years ago
5fd81c5c04
fix: check privileges before exporting post/topic data
5 years ago
f0323b6cfa
feat: closes #8316 , add more data to export profile
5 years ago
1d3fa3bc4e
feat: throw error if uid is missing for update
5 years ago
dfae664e29
fix: exporting posts
5 years ago
bdda022238
fix: undefined uid when downloading posts
5 years ago
1ba6929cb3
fix : #8311 , fix allowUserHomePage value
...
was always sending 1 even if allowUserHomePage was disabled in acp
5 years ago
0e58fa33eb
feat: match hook property to topic property
5 years ago
bfad457275
feat: add methods for adding/removing tags from topics
5 years ago
e20ad5c56e
fix: dont crash if topic is null
5 years ago
c47a1c4df4
fix: convert cids to string for comparison
5 years ago
97c086aba9
fix: missing await
5 years ago
337be368eb
fix: category selector disabled categories
5 years ago
a73c755b05
feat: closes #8308 , edit post notif for watched topic posts
5 years ago
edf9fe3b7f
feat: add null tests for sorted sets
5 years ago
6a5e86dc66
fix : #8305 , don't use null values
5 years ago
aad0880f7c
feat: add filter:categories.getRecentTopicReplies
...
pass req.query to getRecentTopicReplies
5 years ago
7e42988489
refactor: shorter function
5 years ago
c4545381d7
feat: Add hooks for user blocks ( #8296 )
...
* Add hooks for user blocks
* change naming
* Fix the filter...
fixes #8109
5 years ago
7d08184372
fix: winston showing json object
5 years ago
0431d75f0d
fix : #8297 , uids.length is different than topics.length
5 years ago
fcb81cb8ca
fix : #8297 guest handles shown in category.tpl
5 years ago
16a98eaf50
fix: only add to set if numRecentReplies>0
5 years ago
b25b51bd97
feat: add action:post.updatePostVoteCount
5 years ago
6c59683b16
refactor: change to action:categories.updateRecentTid
5 years ago
ecd622fdf5
fix: failing tests @julianlam
5 years ago
51933c1fcb
feat: add filter:categories.updateRecentTid
5 years ago
478ed6c16f
refactor: match core field name pinned
5 years ago
0053e779e8
feat: response:router.page, dep. filter variant
5 years ago
9839346ec3
fix : #8290 , if there are no filters go to ?reset=1
...
dont count ?page=1 as a filter
5 years ago
5ebcdb1806
fix : #8287 , fix users:flags as well
5 years ago
4f1128fd2b
fix: add missing await
5 years ago
9d153fd388
fix : #8287 , dont readd user after deletion
...
don't add user uid back to users:* sorted sets if they are deleted
upgrade script to fix users:* sorted sets
5 years ago
4d6b2ec3ce
fix: missing await
5 years ago
0391856d7d
fix : #8286 , rescind notif when its resolved/rejected
5 years ago
0ca84bd9f4
fix : #8284 , parse ToS on register
...
rewrite intersitials to async/await
5 years ago
0c7c70edaf
fix: crash in topic controller
5 years ago
fe03effe7d
Revert "fix: crash when res.locals.linkTags is undefined"
...
This reverts commit 7cab2b0fea
5 years ago
7cab2b0fea
fix: crash when res.locals.linkTags is undefined
5 years ago
e80b81010c
fix : #8272 user link in digest email
5 years ago
5a1c6ee7ed
fix: response hook logic
...
After some more thought, a response hook should be checking for
whether headers are sent, and executing (or not executing) the
default logic in that case.
Before, we were relying on hooks to call data.next() to continue
execution, but it makes more sense to have the listener either
send a response or not, and handle the behaviour afterwards.
5 years ago
ccc6118d30
Testing suite integration for openapi spec ( #8263 )
...
* feat: testing suite integration for openapi spec
The testing suite now takes the openapi spec into account. It will
check each route defined, make a call to it, and compare the
response with the defined schema. Any mismatches will cause the
test to fail.
* fix(openapi): removed debug stuff from tests
* fix(openapi): fixed some tests
* fix(openapi): added additional check to tests, test fixes
* fix(openapi): better tests, fixed spec errors
* fix(openapi): bad conditional in test
* fix: oops
* fix(openapi): more tests fixing
* fix(openapi): more tests
* fix(openapi): fix some more tests
* fix: verbose'd an info log
* fix: topic pagination route returns schema-optimized pagination block
* fix(openapi): more test/spec fixes
* fix(openapi): accidentally sending in authenticated jar for anon routes
* fix(openapi): more test/spec fixes
* fix(openapi): more spec fixes
* fix: timestampReadable Invalid Date
* fix(openapi): more tests... almost there
* fix(openapi): more tests fixing
* fix(openapi): finally all tests passing
* fix(openapi): added reverse test to compare response to spec
... and fixed all the tests that broke
* fix: remove tests related to group covers, as route is gone
* fix(openapi): broken test on travis
* fix(openapi): broken test on travis
* fix(openapi): broken test on travis
* fix(openapi): object cache is not present for psql
* fix: tests
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
5 years ago
4eafe0f057
fix : #8269 , return array of topics from hook
5 years ago
6e5ebb6184
feat: manifest.json improvements from #8126 ( #8264 )
...
* feat: manifest.json improvements from #8126
* Fix short title placeholder
* use lowercase letters for hex colors
5 years ago
153456278b
feat: show error if json is invalid
5 years ago
ef52461fb6
fix: remove dead picture upload code #8260
5 years ago
5bcaf71501
fix: path.resolve to logs file
5 years ago
c7ea84a2ae
fix: wrong data returned in available.groups
5 years ago
e68156e1f2
fix(deps): bump dependencies ( #8239 )
...
* fix(deps): bump dependencies
* fix(deps): commander@5
* fix(deps): use @nodebb/mubsub
5 years ago
f2f6fbf15a
fix : #8232 , unresolvable session mismatch on register cancel
5 years ago
e6a1741c2e
Support package manager: cnpm and pnpm ( #8222 )
...
* feat: support pnpm, cnpm
* feat: store supportedPackageManager in default package.json
* feat: store supportedPackageManager in src/cli/package-install.js
Co-authored-by: a632079 <a632079@qq.com>
5 years ago
3ce885fff2
fixes sitemap base url issue when using with subfolder ( #8247 )
...
* fixes sitemap base url issue when using with subfolder
* fixes sitemap base url issue when using with subfolder
* uses directly relative path
* removes prefix variable
5 years ago
d77036dbd1
fix : #8249 , don't send move notifications for deleted posts/topics
5 years ago
1136a369f3
feat: local redoc view on development mode only
5 years ago
c82a263788
Revert "fix: override ACAO header for read API spec file"
...
This reverts commit 240d90919b
5 years ago
240d90919b
fix: override ACAO header for read API spec file
5 years ago
59cf0e80d2
fix: throw error if topic does not exist
5 years ago
e93578b81d
fix: hookname
5 years ago
0d1b5a7fb1
fix : #8230 , add hook getUserDataByUserSlug
5 years ago
15d6975e96
fix: ignore case for group details route
5 years ago
740e598a5d
fix: lint
5 years ago
8e23dec84b
fix: lint
5 years ago
00e299e93e
feat: closes #8229 , add targetUid to action:password.change
5 years ago
23571224b5
feat: add parent cids to body class
5 years ago
071506eb7d
fix: invite properly
5 years ago
8f4b99a41c
fix: admins not seeing invite button
5 years ago
0b5fac75b0
fix : #8217 , add missing lang key
5 years ago
93acd13999
fix : #8206 first message in chat has false `newSet`
5 years ago
d080c7b04c
feat: add 2 hooks for modifying privileges
5 years ago
f07f4f8e1a
fix : #8202 , filter non-existing users in search by uid
5 years ago
266061c31a
fix: notification bodyShort truncated if there is a comma in topic title
5 years ago
1efb238a9a
refactor: getUsersCSV to use batch lib
5 years ago
e1c6c3b267
refactor: reorganized socket.io admin modules
5 years ago
5e91a67e78
feat: add user ip to admin/dev/info
5 years ago
cba5b23e23
feat: change option name
5 years ago
80f1bcad20
fix: call next
5 years ago
476f6717c4
feat: add no-build to ./nodebb setup
5 years ago
cf6eadb91a
fix: dont let regular users see other users watched categories
5 years ago
32ada7c4e7
fix : #8188 , fix bookmark if sorting is newest_to_oldest
5 years ago
ac241fb830
fix: duplicate ID + label
5 years ago
f0db240a1d
fix : #8184 global mods unable to revoke other user sessions
5 years ago
e72a29b3fd
fix: return null if field does not exist
5 years ago
14e7866745
fix : #8179 , limit length of location/website/fullname, check grouptitle
5 years ago
bc93b5676c
fix : #8175
5 years ago
41c20761e1
Remove deprecated mongo connection options, fixes #8079 ( #8174 )
...
fix #8079
Unified Topology changes the concept of connecting and causes isConnected to always return true, making any reconnection options useless. Next major version of the driver will remove isConnected entirely.
So:
- reconnect tries
- reconnectInterval
- autoReconnect
Are deprecated and don't really do anything anymore (when unified topology is used at least) other than causing warnings at startup since the 3.4 version of the driver (the current version used by NodeBB is 3.5).
Reference: http://mongodb.github.io/node-mongodb-native/3.5/reference/unified-topology/
5 years ago
3c9689a5ac
feat: settings sorted list ( #8170 )
...
* feat: settings sorted list
see https://github.com/NodeBB/nodebb-plugin-quickstart/pull/9/files for sample
5 years ago
667608a02c
fix : #8168 re-allowing slashes in homePageRoute
...
Resolves regression introduced by b0f3e48ac2
5 years ago
eddbd86837
fix: tweak to session validation in addHeaders
5 years ago
630f5d5b85
fix: only call clearCookie for logged in users
5 years ago
067034082f
fix : #6422 , update deleted/restored messages
5 years ago
4d0636f847
fix : #8163 , prevent account deletion
5 years ago
5a0c7c1497
fix: register
5 years ago
e74954407f
fix : #8157 , update recent tid when post is moved
5 years ago
b73aa84ddc
fix: tests
5 years ago
dd3893b134
fix: move start/stop every iteration
5 years ago
4abe5eb7ff
Revert "fix: #8154 , move start/stop every iteration"
...
This reverts commit 300c04cef9
5 years ago
300c04cef9
fix : #8154 , move start/stop every iteration
5 years ago
690bb69d03
fix : #8154 , respect stop
5 years ago
f23bc347b1
fix : #8156 dont allow loading members from hidden groups
5 years ago
03a02e5d1d
fix : #8155 , don't validate name on update if groupName didn't change
5 years ago
236e1e6859
fix: return correct number of suggested topics
5 years ago
398f0120b8
fix: logic for determining dailyStats hour vars
...
Reverts 9ecdb92f7c
5 years ago
9ecdb92f7c
fix: fix daily analytics being one day off
5 years ago
0b9ad416cb
fix: remove debug line
5 years ago
79737c53fd
feat: guard against accidental ommision
...
...of analytics: prefix in get*StatsForSet methods
5 years ago
d6e3f3f058
fix : #8142 , broken site if no server-side session ( #8148 )
...
* fix : #8142 , broken site if no server-side session
During the `addHeader` middleware, a check is now done to see if
`req.session.meta` is present. This value is only present if the user
has a valid server-side session. If it is missing, then it is probably
safe to assume that the server-side session was deleted (either
intentionally or accidentally). In that scenario, the client-side cookie
should be cleared.
Also, there was an issue where the sessionRefresh flag was never cleared
after a successful login, so that was fixed too.
* feat: exported method to get cookie config
* fix: don't clear cookie if cookie is being set
* fix: socket.io tests
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
5 years ago
0885ec6858
fix : #8144 pluginHooks in maintenance mode middleware
5 years ago
a5ef6b53b8
fix: admin relogin
5 years ago
c35a21d7f0
fix : #8135
5 years ago
1e50616c13
fix: handle mkdirp0.5->1.0x so it doesn't break upgrade
5 years ago
87225a90c3
fix : #8134 , upgrade mkdirp to 1.0.x
5 years ago
b959c24a2b
Merge branch 'master' of github.com:NodeBB/NodeBB
5 years ago
111ed802cf
fix: onSuccessfulLogin not working
...
In scenarios where onSuccessfulLogin was not called in the SSO plugin,
core's calling of onSuccessfulLogin was prematurely returning, because
it was checking the wrong value.
This commit fixes the issue by checking a different value.
5 years ago
8c48f94b96
fix : #8139 , dont allow restore if not deleted by self
5 years ago
9969dd6335
fix: use view_deleted when filtering, closes #8137
5 years ago
d927b763c1
fix: escape invalid rules
5 years ago
3cca929a88
fix: add missing await
5 years ago
0ae1eb4f6e
fix: missing await in SocketPosts.changeOwner
5 years ago
23810cc64b
fix : #8133 , check if user is in room before removing
5 years ago
30c503611c
refactor: messaging
5 years ago
cd1fa27a8b
fix: add missing await
5 years ago
ee4304b443
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
f799f017ab
fix: missing await
5 years ago
418c174d56
fix: dont return flag data to client
5 years ago
51236df4ed
fix: check if user has read priv before flagging
5 years ago
1f13ab8a19
fix: restrict getUsersInRoom to members
5 years ago
594cd7e176
fix : #8127 user join system message duplicated
...
- Now showing user-join message for chat owner in addition to the newly
added user
- If a modal already exists for a room when createModal is called, don't
return null, return the modal
5 years ago
bfaba89557
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
8bb5e71ebe
fix: typo in #8116
5 years ago
3fac09b1ab
fix: build step defaults to series instead of parallel
...
- The logic for the build step now defaults to series instead of
parallel, unless more than 4 CPU cores are detected by the os
library.
- The `--series` flag still exists, and will enforce build in
series, as before.
5 years ago
8e5a2276af
feat: check flag values on save (assignee and state) ( #8122 )
...
* feat: add assignee checking when updating flag
Prior to this, it was possible to update the assignee to any value (or
any user. This commit adds checking to allow only admins, global
moderators, or in the case of flagged posts, moderators.
Also some prep work was added for value checking `state`.
* feat: value checking `state` on flag update
The state should be one of the constants defined earlier in the file.
5 years ago
6a63c1a100
fix: escape system message, don't allow editing system messages
5 years ago
8c6a7954cf
fix: delete upload
5 years ago
153b1a0eaa
fix: check uploadName
5 years ago
01d1ae78c8
fix : #8120 , bubble errors from static hooks
5 years ago
b0f3e48ac2
fix: escape bootswatchSkin and homepageRoute
5 years ago
3e52557689
fix: change owner missing await
5 years ago
e3952674ba
fix: hsts always enabled
5 years ago
b7a57996f7
fix: escape topic.thumb
5 years ago
842916ea42
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
4eb9652a2a
fix : #8112 , don't crash hook returns no data
5 years ago
740de034fa
#8115 - log post owner changes ( #8117 )
...
* log post owner changes
* log each post separately
* use map instad of a loop
5 years ago
879acc85ae
Add disable/enable category to category edit page ( #8118 )
5 years ago
e06c1bfcd2
fix: escape config.userLang/acpLang, don't allow invalid language codes
5 years ago
61da8c29ac
fix: group create/join/update name validation
5 years ago
48f086279c
fix: don't crash if groupData is missing
5 years ago
5a8217de01
fix : #8105 , fix export json on page load
5 years ago
527745310d
fix : #8103 , fix advanced menu not displaying in ACP
5 years ago
10989cccaa
fix: meta description missing if url doesn't have post index
5 years ago
9d074731f4
fix: login with weak password
5 years ago
f6d7a24a67
fix: dont check password strength on login
5 years ago
dec157d606
fix : #8085 , fix cookie name
5 years ago
a227cbe328
refactor: async/await middleware
5 years ago
1b992d8201
fix : #8058 , fix incorrect digest setting display in ACP
5 years ago
8c314fe461
Support allowing classes
...
Otherwise `<input class="form-control">` can't work
5 years ago
3454a24b3c
refactor: change to const/let
5 years ago
a8df6d6298
fix : #8078 , dont mark notifications read without a mergeId
5 years ago
7af1c873a3
fix : #8077 , show continue chat on all profile pages
5 years ago
4fc6944377
feat: better output for cli plugins list, closes #8075
5 years ago
2679f37dec
fix: profile showing posts from deleted topics
5 years ago
05c9fe2735
feat: #5272 , allow changing user groups from manage users page
5 years ago
4d66978338
fix : #8073 , configurable necroThreshold
5 years ago
b323df2fe0
fix: allow members to search as well
5 years ago
c2cd7de891
fix : #8069 , dont show hidden groups in search
6 years ago
33fd4a1c2b
fix: missing await
6 years ago
f9a8ebfce9
feat: merge social authentication into plugins menu in ACP
...
* also reordered the menu in ACP so plugins come first
* added muted headers in desktop version to distinguish both lists
* fixes julianlam/nodebb-plugin-sso-google#21
* closes #8066
6 years ago
1bda92e3fc
fix : #8064 , break-word on post-queue
6 years ago
de404102c0
fix : #8061 , don't crash if there is a network problem
6 years ago
a688aaae51
fix : #8059 , properly mark topic unread when using mark unread for all
6 years ago
510737726c
fix: unhandled promise rejection error on reset error
...
Also, removed buildAll() on reset.
6 years ago
366ad5cd69
fix : #8050 , fix redirect after registration
6 years ago
0efe27b1f2
fix: make _csrf a secure cookie if the website is using https ( #8045 )
...
* Make _csrf a secure cookie if the website is using https
* fix style for TravsCI
* Add `url_parsed` to databasemock
6 years ago
0a96c92300
fix : #8034
6 years ago
cec0079573
refactor: shorter returns
6 years ago
efd1e88bbf
feat: convert middleware.isAdmin to async/await
6 years ago
a254520485
fix: serialize
6 years ago
1eca5b3dae
fix: show login fields if user has local password
6 years ago
f65922297d
fix abysmal postgresql performance in getSortedSetsMembers ( #8030 )
...
* refactor postgres upgrade function to use async
* add function wrapper for getting the elements of a sorted set to avoid postgres planning the query with a nested sequential scan
* fix fatal(?!) lint errors
* add missing await
* bump PostgreSQL version on Travis CI to one that isn't over 3 years out of date
6 years ago
eabc6f4763
fix: crash if post doesn't have topic data
6 years ago
e52ecfaf3f
fix: don't touch objects that don't have the required fields
6 years ago
f4381ba366
fix: add missing await to sendValidationEmail
6 years ago
dee1d44722
fix : #8007 added tfoot to clear new group button
6 years ago
df139928b6
feat: displaying one-click unsubscribe link in email footer ( #8024 )
...
closes #8016
6 years ago
480a64aaa7
feat: #7467 , pass query params when redirecting to posts
6 years ago
b5a30006e2
feat: use helpers.setupAdminPageRoute
6 years ago
645d647248
feat: wip, better digest handling (+ eventual digest resend logic) ( #7995 )
...
* feat: wip, better digest handling (+ eventual digest resend logic)
- await emailer.send call in digest.send method
- save send success to a new sorted set digest:{interval}:byUid
* feat: continuing work on digest tools
- Added ACP page to view digest settings and delivery times per user
* feat: added paginator and stub buttons for resending digest
* feat: wrapping up digest revamp
- New language strings in ACP digest page
- Client-side ACP script for digest ACP page
- Websocket call for ACP page to execute digests
- Broke out logic to retrieve user digest settings to getUsersInterval
* fix: minor cleanup
* fix : #8010 and some style suggestions from baris
* fix: resolve confusing comment
6 years ago
0037a03886
fix : #8018 , allow absolute urls in notification.path
6 years ago
59242d31aa
fix : #8010 , fix isBanned call
6 years ago
ac5c560c54
feat: add action:messaging.save
6 years ago
c4e58160cf
fix : #8003 , check children recursively
6 years ago
b91c4790d1
fix: dont show delete topics on unread
6 years ago
1cedc4a0d6
feat: #7957 , allow post queue based on group
...
allow multiple select in ACP pages
6 years ago
0e5e47f410
fix: parseInt cutoff
6 years ago
e020b85bf5
feat: add filter:topics.unreadCutoff
6 years ago
989107d9b5
feat: Add filter:topic.delete and filter:topic.restore ( #7946 ) ( #7989 )
...
* Add filter:topic.delete
* Don't return undefined data
* add topic.restore and pass canRestore to filter
* fix some bugs created by conflict resolution and new changes
* more readable hook
* fix styling for TravisCI
* literally just two newlines so that TravisCI builds again
6 years ago
cf7e0cfd2d
feat: no more session cookie for guests ( #7982 )
...
* feat: no more session cookie for guests
* fix(tests): added additional tests and fixed the broken test
6 years ago
df1efe5f96
feat: Implement WICG change-password-url ( #7072 ) ( #7990 )
...
* feat: Implement WICG change-password-url (#7072 )
* fix style for TravisCI
6 years ago
1aa520b7a0
parseInt uid in room users check ( #7988 )
...
nodebb-write-api fails this check without parsing into an int
6 years ago
b01a47cbc1
feat: log errors from mubsub
6 years ago
d679218859
feat: upgrade to sitemap5 ( #7980 )
6 years ago
f9f85fc425
fix: cli/reset.js ( #7979 )
6 years ago
ddf3812cdc
fix: passwords always expiring upon login
6 years ago
d72b0d1616
fix: delete follower/followingCount as well
6 years ago
485fbd2f14
feat: #7964 , change all categories at once
...
allow passing cids to setCategoryWatchState and category.exists
6 years ago
990508a533
feat: closes #7952 , translate widget-settings
6 years ago
554e67116f
feat: remove ability to delete events from acp
6 years ago
3775301f24
fix : #7958 , give rewards one by one
...
no need to check group.exists when leaving groups, if group doesn't exists isMember will be false anyways
6 years ago
88818a5bbf
fix: rewards page acp not loading rewards
6 years ago
f272daaf37
fix : #7960 , dont try to save size for non images
6 years ago
03827fa695
feat: resetting theme will reset skin
...
async/await cli/reset
6 years ago
565f9726f7
fix : #7941 , validate some input fields
6 years ago
661a0f5068
fix: don't show deleted topics on unread
6 years ago
6b3eb0144e
refactor: use arrow function
6 years ago
c01b0fbd8c
fix : #7951 , don't send notification for system messages
6 years ago
5b458fc7ca
fix : #7953 , allow icon only group badges
6 years ago
ac4a500402
fix: remove 0 fields
6 years ago
75bcb0f484
fix: remove unused data from post/topic/user hashes
6 years ago
205d3f9d12
fix: groups not visible on widget panes
6 years ago
c5f7b66c3a
fix: new nav items will show group select
6 years ago
7823144bd9
fix : #7940 , run upgrade scripts on startup
6 years ago
38322ec308
fix : #7949 , delete old user notifs
6 years ago
f983f536c6
fix: check threshold before setting bookmark
6 years ago
4e28e575cf
fix: mongo collection stats
6 years ago
02d38caf47
refactor: async/await
6 years ago
91e8e3905c
fix : #7947 , disable unused cookie
6 years ago
c9bf6d0fe1
fix : #7945 , show watched categories in ignored categories
6 years ago
f8c8038a06
refactor: remove log, topics.exists
6 years ago
18bf865d83
fix: db.init calls
6 years ago
dc8d721c46
refactor: async/await
6 years ago
1f0c6f3d60
refactor: async/await mongo
6 years ago
d5dda26f97
fix : #7938 , escape username in registration queue
6 years ago
603908c10a
refactor: async/await socket.io/index
6 years ago
3455c27a8d
fix : #7901 , handle group names that are translation keys
6 years ago
c5ffd8cc74
refactor: async/await image.js
6 years ago
41f8da2e7c
fix: fix the order of groups on user profile
6 years ago
b192605450
feat: add new hook to get custom category tids for unread
6 years ago
05e753c73b
refactor: remove var
6 years ago
94810fd637
feat: adding filter:login.check and loginFormEntry[] for the filter:login.build hook ( #7861 )
...
* adding filter:login.check and loginFormEntry[] for the filter:login.build hook, related to nodebb-plugin-spam-be-gone/issues/32
* do not exceed 50 lines per function
* spam-be-gone@0.6.4
6 years ago
10f168b824
fix : #7934 , return tids
6 years ago
3caa387ac6
fix: tests
6 years ago
2444ed5c88
feat: #7932 , redirect to group details after creation
...
add private/hidden on group creation modal
6 years ago
b93c826d35
feat: add new hook filteR:topics.getSortedTids
...
to let plugins replace the logic used to retrieve tids
6 years ago
13c870597e
fix: picture not showing up in change modal
6 years ago
7effc89291
fix: profile page meta tags getting escaped twice
6 years ago
9a7560049a
feat: bypass cropper for gifs
6 years ago
ffe3670ff5
feat: deprecate file.isFileTypeAllowed
...
use image.isFileTypeAllowed, this function was always meant for images
6 years ago
ed1223645e
feat: send notification to group owners when someone leaves
6 years ago
2150701f32
fix: missing await
6 years ago
ac6eb31c69
refactor: async/await flags.js
6 years ago
0ced71be39
refactor: async/await flags
6 years ago
310c6fd33f
properly filter /unread /recent /popular /top ( #7927 )
...
* feat: add failing test for pagination
* feat: test
* fix: redis tests
* refactor: remove logs
* fix: add new test
* feat: make sortedSetRangeByScore work with keys on redis
* fix: hardcoded set name
* feat: show topics from readable categories on recent/popular/top
* feat: rewrite unread topics
respect watched categories and followed topics
* fix: term + watched
6 years ago
7a0f607434
fix: account/categories
6 years ago
22b02f1407
feat: add failing test for pagination ( #7924 )
...
* feat: add failing test for pagination
* feat: test
* fix: redis tests
* refactor: remove logs
6 years ago
572bc29742
refactor: shorter map
6 years ago
039710493a
refactor: remove logs
6 years ago
b602c04463
feat: refactor getSortedSetRange to allow big arrays
6 years ago
7e7ea7a697
refactor: dont modify key
6 years ago
1f054c7ecb
fix: redis tests
6 years ago
a651d154ce
fix : #7921 , dont create wrong entries in db for flag
...
upgrade script to remove wrong entries
6 years ago
e32a55460f
refactor: remove logs
6 years ago
9ee1a882ec
refactor: async/await flags
6 years ago
625b0815bb
refactor: shorter, new Date doesnt throw
6 years ago
babb9d7c55
fix : #7913 , dont allow urls in fullname/location, validate birthday
6 years ago
bd026cb1ae
fix: upgrade scripts
6 years ago
b842057f26
refactor: remove temp var
6 years ago
f9d6912b4a
refactor: async/await file
6 years ago
223c108cc6
refactor: async/await analytics
6 years ago
96ab8d05aa
fix: only allow png/jpg/bmp in cover/profile images
6 years ago
5505628c8d
refactor: change to const
6 years ago
910b9b8864
fix : #7919 , add useUnifiedTopology
6 years ago
bbc2e95688
feat: add rss feed url for tags
6 years ago
873ec51978
fix: crash in feed
6 years ago
795d4183ca
fix: lang key
6 years ago
5b8550f060
fix: time cutoff and lang string
6 years ago
86b16629f8
refactor: returned fields
6 years ago
87f6ac59b1
fix: returned data
6 years ago
955e00fd9d
fix: dont send all category data back to recent&unread etc
6 years ago
ecf39727cc
fix : #7912
6 years ago
307abaa8cc
fix: only return necessary data for categories
6 years ago
63bd3fc597
refactor: async/await emailer
6 years ago
b9583ed838
Add privilege for accessing user information ( #7859 )
...
* Add view users info global privilege
* Show user ip only to global mods and admins
* fix missing comma
* Hide link for users without correct privilege
* move getting privilege information to getAllData
* Hide the link from Global Moderators as well
* Give Global Moderator view:users:info privilege
* Restrict ip in post menu to view:users:info
* add some trailing commas....
* Add privilege to categories test
* Add group privilege to categories test
* add upgrade script
* fix style for TravisCI
* more styling - change spaces to tabs
* some more styling fixes (hopefully final one)
* fix style for Travis CI
* hide ip in chat messages
* Don't show even hidden ips on user profile page
6 years ago
71cd602da9
feat: #7090 , abililty to hide widgets
6 years ago
de4619689b
fix: change params
6 years ago
9b151b2316
fix: remove dupe code
6 years ago
ec3b5dd95a
refactor: async/await routes/feeds
6 years ago
5de6d8857a
feat: #7760 , body-parser config
6 years ago
b110aec6ed
refactor: async/await rewards
6 years ago
a7d2b8a1fe
refactor: async/await socket.io
6 years ago
52b2d670e5
refactor: async/await
6 years ago
f05c1dae69
feat: actually cache duh
6 years ago
63bd252fba
feat: cache tags:topic:count
6 years ago
75d7ae9272
refactor: async/await
6 years ago
5c2afe5eac
refactor: async/await socket.io/topics
6 years ago
3c6c40b177
refactor: async/await controllers/user.js
6 years ago
5c0266d8c4
refactor: async/await uploads
6 years ago
3e2ed21d3d
refactor: move tos parsing to /tos
6 years ago
b81405a8cc
feat: increase size of local cache
6 years ago
ec98945a5f
refactor: remove commented out code
6 years ago
b9105ef9c6
refactor: async/await controllers/authentication
6 years ago
b99279a83c
fix: minor typo
6 years ago
22f8011686
refactor: remove async from isPasswordValid, function is sync
6 years ago
6cda369872
refactor: make categories.buildForSelectCategories non async
6 years ago
09410ff1c5
feat: don't hardcode numberic fields in user search
6 years ago
0843497dd4
fix : #7893 , check private upload setting
6 years ago
77cb4b55cb
fix : #7892 , handle string 'true'/'false'
6 years ago
a4d84a66dd
refactor: remove dupe code
6 years ago
e93ef0d7fd
refactor: async/await socket.io/posts
6 years ago
4652c68ba7
fix: dont show deleted topics in digest
6 years ago
88dfbf213f
refactor: async/await socket.io/admin
6 years ago
9b4ae4c04a
Added Postgres SSL Support ( #7887 )
...
* [Added] Postgres SSL Support
* [Added]Postgres SSL Support
* [Added] Postgres SSL Support
6 years ago
71e50bbf4e
refactor: socket.io/admin/categories async/await
6 years ago
acd9576489
fix: don't move theme/plugin to top if its already active
6 years ago
1796b65d34
feat: option to restrict group leaving, closes #7770
6 years ago
4588a4fdcf
refactor: admin groups.join socket async/await
6 years ago
30a86ed553
fix : #7853 , dissociation on post purge
6 years ago
0c4cd840a0
fix: added comment back
6 years ago
fe452762b7
fix: inability for plugins to actually alter parser sanitization config
...
/cc @pitaj
6 years ago
9b8ac89e13
fix: htmlentity instead of url encoding for room rename system message
6 years ago
dd8386d93d
refactor: password async/await
6 years ago
3a01e95380
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
2580306db9
feat: html sanitization on all filter:parse.* hooks, closes #7872
6 years ago
0164e51f9f
refactor: sitemap to async/await
6 years ago
e291a60964
fix: page count for filters
6 years ago
547bb4966d
fix : #7866 , show correct title based on digest interval
6 years ago
aea04de094
feat: update LESS to v3.x, #7855 ( #7867 )
...
* feat: #7855
* fix: tests
6 years ago
d372720749
refactor: remove hook assign
6 years ago
f31d30cd02
feat: add client side hook for quick search&normal search
6 years ago
f9a804e014
refactor: async/await users
6 years ago
19b63bfaa7
refactor: remove empty line
6 years ago
69333f59af
refactor: remove vars
6 years ago
f2912e9fe0
fix: pinned tids showing on page > 1
6 years ago
a4dec7e3ab
fix : #7860 , allow running single upgrade scripts from plugins
6 years ago
1d7e0c6341
feat: allow floating pinned topics to top in getSortedTopics
6 years ago
6f7ab5861e
feat: promisify recent.getData
6 years ago
2c4f04462f
refactor: async/await controllers
6 years ago
a67762bc32
fix: reset should not automatically build assets
6 years ago
89cd31ed28
feat: faster initial stat loading
6 years ago
cb50b3f441
feat: cache stats, mongo count sucks
6 years ago
3ff6e1bb64
feat: dashboard stats
...
show
yesterday/today
lastweek/this week
lastmonth/this month
6 years ago
aeb44faf5c
feat: add filter:search.getPosts
6 years ago
80bd52fcfa
feat: add image and imageClass to post summaries
6 years ago
5362488584
refactor: async/await controllers/tags
6 years ago
f15c7f12b3
refactor: async/await
6 years ago
0722cc4715
refactor: globalmods/groups
6 years ago
bd8736db38
refactor: controllers/category.js
6 years ago
27c27b497e
refactor: use arrow func
6 years ago
1e0190abef
fix : #7842 , groups.invite works with an array of uids
6 years ago
fa26855671
feat: #7842 , make isInvited, isPending work with uids
6 years ago
4eaa630b1c
refactor: async/await controllers/api
6 years ago
acf12e3dd8
feat: convert search controller to async/await
6 years ago
6f375482a0
refactor: async/await admin/controllers
6 years ago
592d9c82c5
fix : #7844 , add uid to events, log plugin install/uninstall events
6 years ago
c9250a01a2
refactor: async/await, remove dupe code for homepage routes
6 years ago
1a2a381ae3
feat: notification on membership acceptance, closes #7835
6 years ago
c44bf48c01
fix: removed console.logs
6 years ago
f736f0b382
fix: broken tests from 71b205a889
6 years ago
1ce33faaea
feat: additional events logged for various group actions
...
closes #7841
6 years ago
71b205a889
refactor: async/await for src/socket.io/groups.js
6 years ago
c6c13725f8
fix: typo
6 years ago
e635348693
feat: async
6 years ago
32ea04a872
feat: async/await controllers/admin/dashboard
6 years ago
647713f3fa
fix: category description getting translated in ACP
6 years ago
7162051905
fix : #7791
6 years ago
29f96b199c
fix(style): requiring parens in block bodies
6 years ago
0921230976
fix(style): updated code to follow new eslint recommendations
...
Squashed commit of the following:
commit f9ce878b269b3568f0d649309aae1af4dcfdfeef
Author: Julian Lam <julian@nodebb.org>
Date: Tue Aug 13 14:30:46 2019 -0400
fix(style): updated code to follow new eslint recommendations
commit 80dd370e413f22badb96ff2138e7991dfff6d836
Author: Julian Lam <julian@nodebb.org>
Date: Tue Aug 13 14:14:58 2019 -0400
fix(deps): update dependency sitemap to v4
Squashed commit of the following:
commit f4dd9cabb21e26fdc21f8413be822ea7c64251f8
Author: Julian Lam <julian@nodebb.org>
Date: Tue Aug 13 11:33:05 2019 -0400
fix: resolved breaking changes from sitemap v4 upgrade
commit 9043415ee16dcc27a8dcc2e4479d1bc5e2d1b60e
Merge: e3352b272 72590b346fix : #7831 , fix pagination
convert to async/await
commit c9e83f2374572264855a04156278eef256b0a20c
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date: Sun Aug 11 00:14:35 2019 -0400
fix: remove empty line
commit 30be91b26c4dd7583412c4e8d56e9c1688e48a44
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date: Sun Aug 11 00:13:41 2019 -0400
fix: remove useless catchs and empty line
commit 2e4a71c0b6104738f15ffbfe3246105b922fdfb3
Author: Renovate Bot <bot@renovateapp.com>
Date: Sat Aug 10 06:51:50 2019 +0000
chore(deps): update dependency eslint-config-airbnb-base to v14
6 years ago
d3d677daf2
fix(deps): update dependency sitemap to v4
...
Squashed commit of the following:
commit f4dd9cabb21e26fdc21f8413be822ea7c64251f8
Author: Julian Lam <julian@nodebb.org>
Date: Tue Aug 13 11:33:05 2019 -0400
fix: resolved breaking changes from sitemap v4 upgrade
commit 9043415ee16dcc27a8dcc2e4479d1bc5e2d1b60e
Merge: e3352b272 72590b346
6 years ago
72590b3462
feat: async/await admin/controllers
6 years ago
7beef91c3f
feat: async/await
6 years ago
3cc7ec63e8
feat: async/await refactor
...
controllers/accounts
6 years ago
a3541d887b
feat: async/await controllers/accounts
6 years ago
014e31533d
fix : #7831 , fix pagination
...
convert to async/await
6 years ago
292bbe3449
fix: remove empty line
6 years ago
5fce45580a
fix: remove useless catchs and empty line
6 years ago
fd5f9822bd
fix : #7823 , fix topic move readding pids when topic is deleted
6 years ago
3ecac97d7e
fix : #7826 , fix order of categories on recent dropdown
6 years ago
b734defbfa
feat: rewrite getRawPost to async/await
...
promisify SocketPosts
6 years ago
973075cfbc
feat: added new filter hook filter:post.getRawPost
6 years ago
924d332c2c
Revert "refactor: rewrote SocketPosts.getRawPost in await style"
...
This reverts commit 08530bb33f
6 years ago
06932602ab
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
e9fd49e234
feat: convert categories controller to async/await
6 years ago
08530bb33f
refactor: rewrote SocketPosts.getRawPost in await style
...
Added new filter hook filter:post.getRawPost
6 years ago
90bcd65a00
add filter:manifest.build ( #7821 )
...
* add filter:manifest.build
Added a hook that lets plugins modify manifest.json, as suggested in https://community.nodebb.org/post/59670
* Added error handling
Thanks barisusakli
* Define next
* Pass data as an object
* Remove multiple spaces
6 years ago
8d4f20865f
fix: redis pubsub not being required correctly
...
split connection logic into separate module
6 years ago
186321e646
fix: mongo.close using wrong client
6 years ago
bc6f22ebdb
fix: digest not sending topics
6 years ago
af1f7249a7
feat: test psql without defineProperty ( #7815 )
...
* feat: test psql without defineProperty
* feat: refactor psql
remove .bind calls, use module.pool.query directly
move requires to top of file
move promisify to bottom so .init etc are promisified
* feat: mongodb
move requires to bottom
* feat: redis
6 years ago
52a2e5d61d
fix : #7816 , adding GDPR and TOU interstitials earlier on route reloading
...
A use-case was presented that called for a theme to disable the
registration interstitials. However, the plugin hooks were always
fired first, and so the core interstitials could not be removed
at that time because they hadn't been added yet.
This change moved the interstitial adding to the earliest point
possible, right after plugins.loadedHooks is emptied in preparation
for plugin initialisation.
6 years ago
0e07ffa1d9
feat: send pids into filter:post.getFields hook
6 years ago
65fc06128c
feat: move cache tpl
6 years ago
3a9d83a44b
feat: async refactor
6 years ago
47e30a67be
feat: move group privs above user, add labels
6 years ago
23046bab9a
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
9780f5b975
fix : #7809 , dont check postDelay if submitting from queue
6 years ago
dec8040c09
feat: widgets/index.js
...
enable widget-essentials in tests
fix widget test
6 years ago
6a289fbac9
fix : #7789
6 years ago
4d6b687183
feat: use promise version
6 years ago
1c2540d3e1
feat: #7743 , meta/dependencies
6 years ago
96ebe7b5f7
feat: #7743 , widgets/admin
6 years ago
8bf40d04c9
fix : #7788 , fix on topic move and new post
6 years ago
053ff510bb
fix : #7788 , fix another edge case
...
ignore pids in topics that were purged/deleted
6 years ago
b10ad7b6ff
fix: topicData passed to action:topic.edit
6 years ago
c02686bfc8
feat: #7743 , meta/languages and languages
6 years ago
66aa443b7a
feat: added filter:tags.getAll plugin hook
6 years ago
102d4b0247
feat: #7743 , events
6 years ago
97d7a85060
feat: #7743 meta/errors
6 years ago
99cf47ee08
feat: get rid of async.eachSeries
6 years ago
ce91288607
fix: derpy catch
6 years ago
3c32d8600f
fix : #7788 No new posts ( #7793 )
...
* feat: debug no-new-posts
* feat: add test for user delete
* fix: timeout for flag test
* feat: shorter
6 years ago
7b90863971
feat: #7743 meta/tags.js
6 years ago
79eed9ae60
feat: #7743 meta/templates.js
6 years ago
6a486e35bb
fix: user urls in subfolder install
...
fix missing await
6 years ago
764a2b1210
feat: #7743 navigation
6 years ago
e72f3e4ffe
feat: #7743 account/posts controller
6 years ago
9b3f4b98d1
feat: #7743 finish topics controller
6 years ago
0b498acdcf
fix : #7765
6 years ago
0d047f4eb9
feat: #7743 , webserver
6 years ago
87552c559c
fix: tests
6 years ago
7dc0eaf070
feat: #7743 meta/themes.js
6 years ago
a15c50bf62
feat: #7743 , meta/sounds
6 years ago
7f72181ec8
feat: #7743 , meta/cachebuster, meta/configs
6 years ago
756a717eb8
feat: convert src/messaging/* to async/await ( #7778 )
...
* feat: src/messaging/create.js, #7743
* feat: src/messaging/data.js, #7743
* feat: src/messaging/delete.js, #7743
* feat: src/messaging/edit.js, index.js, #7743
* fix: added in missing awaits
* feat: wrapped up src/messaging/* rewrite
* refactor: messaging delete/restore similar blocks of code
6 years ago
fcf8fd51cb
feat: #7743 meta/blacklist
6 years ago
3dd806dcb8
fix: revert requires
6 years ago
69860e582b
feat: #7743 meta/index
6 years ago
c126cd8572
feat: #7743 plugins
6 years ago
f5f5f76b12
feat: #7743 plugins/data
6 years ago
17f843f991
feat: dont waste whitespace
6 years ago
34d85b5205
feat: switch to promise.all
6 years ago
f8d341014a
fix : #7763 , parse about me on all profile pages
6 years ago
faccb191ec
feat: #7743 , privileges
6 years ago
e2e33dfb1e
fix: status and groupTitle, if its not set
6 years ago
2f0a331f02
fix: don't return promise
6 years ago
44a3352003
fix: socket.io methods calling callbacks twice if method returns promise
6 years ago
4fb271c684
System chat messages ( #7771 )
...
* fix: removed duplicate checkContent call in addMessage
addMessage is called in one place (sendMessage), and the checks
are already contained there. addMessage is the lower level call
and so should be called only from within core itself.
* feat: #7330 chat system messages for join, leave, rename
* fix: add back content checking in .addMessage();
* fix: tests, and added .addSystemMessage() method
Tests were relying on message indices that changed due to the
new system messages.
* feat: add tests for system chat messages
* refactor: rewrite half of src/messaging/rooms.js, fix tests
* feat: #7743 messaging/room.js
* fix: tests for messaging/room.js, #7743
* fix: trying to fix tests
* fix: omg :rage2:
6 years ago
6d3a92b851
feat: #7743 , search.js
6 years ago
8e75646ac0
feat: shorter name
6 years ago
daed76d5d6
feat: cache group:members for priv groups
6 years ago
72def7dfa6
feat: #7743 finish groups
6 years ago
a39ca51e06
feat: #7743 , groups/index, invite, leave,membership
6 years ago
d5342a40ba
feat: #7743,groups/index,join
6 years ago
87b1148fa8
fix: tests
6 years ago
fcd4445a89
feat: #7743 , groups/delete,ownership,posts,user
6 years ago
5e8614e15b
feat: #7743 groups/cover,create,data
6 years ago
c0c6c652be
feat: #7743 , finish post module
6 years ago
c4bb467ea5
feat: #7743 posts/diff, posts/edit
6 years ago
1b2b308a7e
feat: #7743 , posts module
6 years ago
930ffd074f
fix: tests
6 years ago
a51ec591ee
feat: #7743 , finish user module
6 years ago
6fea46b6e2
feat: #7743
...
user/posts
user/profile
6 years ago
0e8ee31b90
fix : #7601 removed check for another user when sending messages
...
This is an old check back when the sorted set that messages were
appended to depended on what users were in the chat room. Once
messages were refactored (in 2017) to use roomIds, this is no
longer a limitation of the platform and users should be free to
talk to themselves all they want.
6 years ago
cd80c2638c
feat: #7743
...
user/password
user/picture
6 years ago
0a690c5710
feat: #7743
...
user/online.js
6 years ago
1c5fad6dae
feat: #7743
...
user/notifications.js
6 years ago
fe4c048198
feat: #7743
...
user/index.js
user/info.js
user/invite.js
user/jobs.js
6 years ago
3b24de4cb3
fix: mongodb tests
6 years ago
fcf3e0770b
feat: #7743 categories
6 years ago
c610eb1430
feat: #7743 , user/digest, user/email, user/follow
6 years ago
13aaf07bf5
fix: getTopicsFromSet
6 years ago
9eb1fcd4e5
fix : #7762 , allow array for isBanned
...
dont filter banned users one by one in digest
6 years ago
d6e36c3166
feat: #7743 , user/create, user/data, user/delete
6 years ago
46639be32d
fix: add flag for change post owner
6 years ago
4541caa4f8
feat: #7743 , user/block, user/categories
6 years ago
6f738c2b44
feat: #7743 notifications
6 years ago
cd2e68cb2d
feat: remove unused code, add 2 tests
6 years ago
1970214a24
feat: #7743 user/ban, up mubsub
6 years ago
53e1b349ae
Change post owner ( #7752 )
...
* feat: #7749 , allow array of keys for setObject
* feat: sortedSetRemoveBulk
* feat: test for bulk remove
* feat: #7083 , ability to change post ownership
* feat: #7083 , fix tid:<tid>:posters
* feat: #7083 , front end
* fix : #7752 , psql methods
* fix: add missing await
* fix: maybe psql
6 years ago
b24ce97602
feat: #7743 , user/approval, user/auth
6 years ago
7b95ebbb6a
fix : #7748 , if reputation system is disabled, dont check min reputation
6 years ago
8ef75be3e3
feat: #7743 , posts/votes
6 years ago
e1ecc36d04
feat: #7743 posts
6 years ago
0ac49d63d9
fix: remove left over code, use proper names
6 years ago
2c33595507
feat: #7743 user/admin.js
6 years ago
0a6cfb37c2
feat: #7743 , posts/user.js
6 years ago
332a16c868
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
fba67196e1
fix: compatibility conditional
6 years ago
805dcd7ca2
Async refactor in place ( #7736 )
...
* feat: allow both callback&and await
* feat: ignore async key
* feat: callbackify and promisify in same file
* Revert "feat: callbackify and promisify in same file"
This reverts commit cea206a9b8e6d8295310074b18cc82a504487862.
* feat: no need to store .callbackify
* feat: change getTopics to async
* feat: remove .async
* fix: byScore
* feat: rewrite topics/index and social with async/await
* fix: rewrite topics/data.js
fix issue with async.waterfall, only pass result if its not undefined
* feat: add callbackify to redis/psql
* feat: psql use await
* fix: redis 🌋
* feat: less returns
* feat: more await rewrite
* fix: redis tests
* feat: convert sortedSetAdd
rewrite psql transaction to async/await
* feat: 🐶
* feat: test
* feat: log client and query
* feat: log bind
* feat: more logs
* feat: more logs
* feat: check perform
* feat: dont callbackify transaction
* feat: remove logs
* fix: main functions
* feat: more logs
* fix: increment
* fix: rename
* feat: remove cls
* fix: remove console.log
* feat: add deprecation message to .async usage
* feat: update more dbal methods
* fix: redis :voodoo:
* feat: fix redis zrem, convert setObject
* feat: upgrade getObject methods
* fix: psql getObjectField
* fix: redis tests
* feat: getObjectKeys
* feat: getObjectValues
* feat: isObjectField
* fix: add missing return
* feat: delObjectField
* feat: incrObjectField
* fix: add missing await
* feat: remove exposed helpers
* feat: list methods
* feat: flush/empty
* feat: delete
* fix: redis delete all
* feat: get/set
* feat: incr/rename
* feat: type
* feat: expire
* feat: setAdd
* feat: setRemove
* feat: isSetMember
* feat: getSetMembers
* feat: setCount, setRemoveRandom
* feat: zcard,zcount
* feat: sortedSetRank
* feat: isSortedSetMember
* feat: zincrby
* feat: sortedSetLex
* feat: processSortedSet
* fix: add mising await
* feat: debug psql
* fix: psql test
* fix: test
* fix: another test
* fix: test fix
* fix: psql tests
* feat: remove logs
* feat: user arrow func
use builtin async promises
* feat: topic bookmarks
* feat: topic.delete
* feat: topic.restore
* feat: topics.purge
* feat: merge
* feat: suggested
* feat: topics/user.js
* feat: topics modules
* feat: topics/follow
* fix: deprecation msg
* feat: fork
* feat: topics/posts
* feat: sorted/recent
* feat: topic/teaser
* feat: topics/tools
* feat: topics/unread
* feat: add back node versions
disable deprecation notice
wrap async controllers in try/catch
* feat: use db directly
* feat: promisify in place
* fix: redis/psql
* feat: deprecation message
logs for psql
* feat: more logs
* feat: more logs
* feat: logs again
* feat: more logs
* fix: call release
* feat: restore travis, remove logs
* fix: loops
* feat: remove .async. usage
6 years ago
8a6a58ee43
feat: added new admin option newbiePostEditDuration ( #7737 )
...
* feat: added new admin option newbiePostEditDuration
Also:
- Grammar-checked a couple language strings
- Moved a couple form inputs around in new user restrictions
- Added a test for the new option
- fix: 'defore' typo
6 years ago
f3440ebfca
fix: typo
6 years ago
8b1dadb7f8
fix : #7722 , hsts deprecation warnings
6 years ago
bd640a1107
Topic await errors ( #7727 )
...
* feat: derp await
* feat: restore user.getSettings
* feat: cleanup
* feat: make tid const
* feat: cleanup
* fix: tests
* feat: deprecate filter:controllers.topic.get
* feat: rewrite post-index logic
* feat: change calculation to match others
* fix: use .async
* feat: remove try/catch wrapper
6 years ago
75ff4d7dea
feat: returning category data in tags page
...
For nodebb/nodebb-theme-persona#483
6 years ago
a0c0ef1ba4
feat: ACP analytics API route ( #7725 )
...
* feat: added API route for retrieving analytics via REST API
* feat: sets is now optional, can pass in multiple sets
* fix: moved expand and added json button to panel header
* fix: matching api params to socket method
* fix: update json api button url on graph change
* fix: updated default counts based on passed in units
6 years ago
accf48f38b
fix: upgrade script #7720
6 years ago
41bc6ca2c4
feat: add status to post summaries
6 years ago
e299cafce7
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
708df46ebe
fix: dont display post tools if there are no options
6 years ago
67b8cb8977
fix: restore uid in teasers userObj
6 years ago
667bc67f04
fix: dont allow edit if post is deleted by someone else
6 years ago
3100d803c7
feat: use arrow functions
6 years ago
f24c14d712
feat: ability to sort watched topics, closes #3735
6 years ago
d0ee312cd3
feat: use fewer system resources to draw the progress bar
...
There's reason to believe that upgrade scripts will run faster
if the system isn't spending a non-insignificant amount of
resources simply drawing the progress bar. Closes #7711
Some context: https://github.com/npm/npm/issues/11283
6 years ago
23fb904fa6
feat: removed series from upgrade script
6 years ago
cb51c239f2
feat: remove duped zadds, these are already in topics.onNewPostMade
6 years ago
f8a7cf7378
feat: log data on error
6 years ago
198d05875f
feat: cleanup, use bulk
6 years ago
3ecd703ea3
feat: #7707 , added sortedSetAddBulk
6 years ago
e48c7cd717
fix: dont show delete posts on profile
6 years ago
6a7bc1c5fb
fix: on new post add it to cid::uid::pids
6 years ago
a39f0ef592
fix : #5570 , create per category user post zsets
6 years ago
3780a58ffb
feat: shorter setsCard
6 years ago
b53a60c278
feat: show best & latest posts on profile
6 years ago
7e54d7aa35
feat: use db.sortedSetsAdd
6 years ago
29a124c412
feat: use db.sortedSetsAdd
6 years ago
68e5d7adec
fix: remove dupe code
6 years ago
39ee3980d6
fix: get uids directly for csv
6 years ago
a7600b4bbe
feat: dont log action:plugins.fireHook
6 years ago
ebfc369ade
feat: upgrade to connect-mongo 3.0.0, closes #7693
6 years ago
a251032f02
fix: typo
6 years ago
b4cc8d88cd
fix: id/for
6 years ago
25ea634787
fix : #7659 add option to change cookie link url
6 years ago
ede060a646
feat: add hook for user notifications, closes #7672
6 years ago
580f786095
feat: user/notifications refactor
6 years ago
8c331088ca
feat: send new post/topic event in batches
6 years ago
f6d3cc0ea4
feat: allowing count to be passed to ./nodebb events
6 years ago
aee47b299a
feat: awaitable websockets ( #7645 )
...
* feat: awaitable websockets
Adding in conditionals to check the method to call, and handling
it as a promise vs. a regular function depending on whether the
method itself is an asynchronous function.
* fix: switch to .then-checking for awaitable check
* fix: proper use of .then check
6 years ago
a6436716ea
feat: hooks can now return promise or call callbacks
...
* hooks can now return promise or call callbacks, either way works
* cleanups
* moar cleanups and fix callback 1st null arg
* rm unnessesary spread
6 years ago
5fa5e999f8
Plugin metrics ( #7626 )
...
* feat: add enable/disable checkbox for plugin usage
* feat: submit plugin data to packages.nodebb.org
only submit in production mode
submit once every 24 hours
dont submit for plugins that have "private": true in plugin.json
enabled on new installs
disabled on existing installs
* fix: hash not working after first send
fix statusCode
* fix: remove url
* feat: show compatibilty
* feat: add install question for submit plugin usage
6 years ago
644504ff02
fix : #7483 , show latest undeleted message as teaser
6 years ago
c7f95ccecc
feat: design revamp of ACP events page ( #7664 )
...
* feat: design revamp of ACP events page
- minor UX changes
- new filter controls, filters moved to sidebar
- form usable without js
- start/end filters NOT programmed yet
* feat: events ACP limit by date and perPage
* feat: pre-fill applied filters on template render
* fix: missing translation for ACP events perPage filter
* fix: added some comments to explain setHours behaviour
* fix: stop - start + 1
* fix: socket tests
* fix: +inf, not just inf
* fix: tests, because I am an idiot
6 years ago
4b843ba16f
fix : #7567 , allow invite and approval at the same time
6 years ago
5b85ed318a
fix : #7625 , on group rename update nav/widget items
6 years ago
48538b28be
feat: optimize group rename
...
removed async.each
6 years ago
8d319e4280
fix: psql error
6 years ago
2e6b562f1e
fix: try to fix psql 🐶
6 years ago
31ccc860d3
feat: allow multiple scores in sortedSetsAdd
6 years ago
0dca13e9c2
feat: optimize copy privileges
6 years ago
8aef689f05
fix: no need for moderate bit for global mods and admins
6 years ago
035f624758
Remove implicit mod privs. closes #6345 ( #7648 )
...
* feat: add upgrade script to give mods privs
* feat: give all privileges when making a moderator
* feat: remove implicit privs
* feat: give global mods default privs
* feat: more priv fixes
* feat: use lodash
* fix: remove implicit mod priv from topic delete
* fix: more privs
* fix: posts.canEdit
* fix: canDelete and canEdit
* fix: tests, remove console.log
* feat: shorter functions
* feat: add tests
* fix: uids
* fix: redis random test fail
6 years ago
4d9bc30d1f
feat: async3 upgrade ( #7639 )
...
* feat: async3 upgrade WIP
* fix: async.doWhilst
* fix: async early exit
* fix: psql doUntil
* fix: psql again
6 years ago
64679b37cc
fix : #7647 , fix getModeratorUids
...
sets.groupNames is an array that contains other arrays of groupnames so passing it to getMembersOfGroups returned wrong results when there were more than 1 element in it.
6 years ago
603c526287
fix: bad usage of async requisition
6 years ago
f321b426b1
fix: 7638, returnTo accidentally saved into user hash
6 years ago
157b921e14
fix : #7634 , make strip exif configurable
6 years ago
a8409fbd49
fix : #7636 , use reputation threshold for post queue
6 years ago
63e5d383d9
fix : #7623 , wait for lastonline to update on /users
6 years ago
80c0d579e3
fix : #7593 , unable to set account password if no password set
6 years ago
a8e6520559
fix : #7620 , allow adding new fields into user objects for posts
6 years ago
7ba4a864fd
fix : #7629 , new filter hook for room rename
6 years ago
7a4b68e816
fix : #7628 , log email send errors
6 years ago
f55cc66723
fix: {username} not working in notification.tpl
...
fix images going out of notification email
6 years ago
3b0459a0a5
fix: do not prevent nbb from starting
...
if a plugin returns error for filter:auth.init
6 years ago
91f0bce628
fix : #7624 , default open state on stateless flags
6 years ago
15391da51e
fix : #7431 , add /unread link to topic route
6 years ago
35d10f764a
fix : #7619
6 years ago
172e688805
fix: handle missing timestamps
6 years ago
b70e03a7b0
fix: broken test for meta tags on ajaxify
6 years ago
f326f53d4f
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
15ce23da4c
fix : #7613
6 years ago
f552cea523
fix : #7600 , removing nbsp from email CTAs ( #7606 )
...
* fix : #7600 , removing nbsp from email CTAs
* fix: added right arrow to CTA button
6 years ago
b32da57faf
fix : #7604 shortened CTA text and added custom text for some notifs ( #7605 )
...
* fix : #7604 shortened CTA text and added custom text for some notifs
Specifically, new-reply and new-chat have different CTA text as they
do not go to the forum home like other email templates send users to.
* fix: minor optimization as suggested by @barisusakli
6 years ago
a41769e61c
feat: update meta tags on ajaxify ( #7580 ), fixes #7544
...
* feat: wip -- refresh meta tags on ajaxify
* feat: wrapped up meta tags update on ajaxify feature
* fix: removed commented-out line
* fix: removed another commented-out line
6 years ago
dfab231afd
Copy group privs ( #7610 )
...
* feat: ability to copy a groups privileges
ability to copy a group's privileges to all categories, or children of current category
* feat: switch to dropdown
added copy from category to groups
* fix: indents
6 years ago
0d86781cb5
fix : #7599 image size measurement erroring out on missing path
6 years ago
3a7e99a503
fix: tests
6 years ago
bd94fbc2b1
feat: let theme know downvoting is disabled, closes https://github.com/NodeBB/NodeBB/pull/7568
...
dont load downvote data if downvoting is disabled
6 years ago
50260e137a
fix : #7576 "Disable password changes" can be sidestepped
6 years ago
e114b16d7a
fix: if editing password is disabled in ACP, prevent direct access via route/socket (related: #7576 )
6 years ago
cf5aeace6b
feat: closes #7583
6 years ago
c9ca72d0f3
fix : #7582
6 years ago
96cb29aab0
fix : #7461
6 years ago
3d938e7bf8
fix: increase batch size
6 years ago
8945ebcb81
fix: group cover upload not working for s3 upload ( #7571 )
6 years ago
07e9b67e8d
fix : #7565
6 years ago
fe6d64ccbc
fix : #7147
6 years ago
8775e7e652
fix: node12 tests
6 years ago
2c98dd5f9d
Object cache refactor ( #7558 )
...
* fix: cache refactor
db.getObjectField no longer loads entire object
db.getObjectsFields only clones data once
more tests
* feat: add back cache to redis
db.getObjectField no longer loads entire object
6 years ago
45acf80987
remove expire timestamp when banning user permanently, fixes #7547 ( #7548 )
6 years ago
c6cd6c5705
fix: add post queue to /compose POST route
6 years ago
4df925e76a
fix: remove redis object cache
6 years ago
740388492f
fix : #7545
6 years ago
9bf3517db1
fix: failing test from 00552d7183
6 years ago
00552d7183
fix: fire filter:register.complete for users approved via registration queue
6 years ago
ddffc904f4
feat: allow file uploading on registration interstitial
6 years ago
8778f00b69
fix : #7540
6 years ago
ba5e1eaa4f
feat: #7527
6 years ago
c38db4f765
feat: #7515
...
This reverts commit 81f8cfe3da
6 years ago
d8978fb142
Merge remote-tracking branch 'origin/develop'
6 years ago
d3ebda7370
fix: more graceful error handling and output for cli/reset
6 years ago
808c4909a4
fix : #6438 only apply whitelist when fields request empty ( #7528 )
...
* fix : #6438 only apply whitelist when fields request empty
* feat: explicit password retrieval denied via getUsersFields
6 years ago
eb2c3e5626
fix: don't crash if templateData is undefined
6 years ago
81f8cfe3da
Revert "feat: #7515"
...
This reverts commit ac889db16b
6 years ago
ac889db16b
feat: #7515
6 years ago
397e062a3c
fix: clear children before building tree
...
prevents infinite loop on databases that have children array saved in database
6 years ago
4f3ca4d899
fix: upgrade script date
6 years ago
3fbb6faf28
feat: update unban logic/invocation and refactor User.bans module
...
* auto unban when User.getUsersFields is called and the user is banned but has expired
* cleanups and removal of expiry_readable
* expiry_readable make an alias for backward compatibility
* User.bans.func vs User.*ban*Func
* console.log cleanups, plus todo message added
* use code util.deprecate
* fix: remove ununsed winston require
6 years ago
ed91d3f2c8
fix : #7519
6 years ago
fb58e23914
fix lint
6 years ago
e479fad792
fix : #7517
6 years ago
75ae29c1dd
fix : #7470 Properly handle recompilation of email templates
6 years ago
3871a02ccc
fix: resolve CORS error on uploading via URL
...
On uploading a new profile picture via URL, a CORS error presents
itself during the .toDataUrl() call due to misconfigured CORS
handling in the library. The change here allows cropper.js to
check crossorigin attribute in image and handle appropriately.
Also, the error handling is improved so the error is caught on
Firefox, as it sends a different error message than on Chrome.
6 years ago
dbc4d8403d
fix : #7461
6 years ago
abe4abb674
feat: add original sessionID to static:user.loggedOut
6 years ago
8cc1864aa7
fix : #7491
6 years ago
4db0efe32d
fix : #7476
6 years ago
2ee2cd528f
feat: #7501
6 years ago
b52dba5c92
fix : #7508
6 years ago
3ec9fc4098
fix : #7490 once again
6 years ago
3304ffe978
fix : #7502
6 years ago
6415ba82c4
fix : #7493 , adding robots noindex meta tag to compose and reset routes
6 years ago
86e1cdd541
fix : #7490 , handling of image sizes if no size saved in db
6 years ago
8f55ab1340
fix : #7494
6 years ago
63e16ec0a2
fix : #6911 , email throttling options set
6 years ago
33a1bf6cde
fix: throttling email output to 2 messages every second, fixes #6911
6 years ago
8d62ead329
fix : #7469 missing email logos, occasionally
6 years ago
81306fff3c
feat: allow multiple cids for getActiveUsers
6 years ago
b6440eed7a
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
fddb783ee9
fix : #7487
6 years ago
ad2d7a6991
fix: move upload_url to prestart so it is defined in upgrade scripts
6 years ago
cead89f0ba
fix : #7342
6 years ago
6bed51ef1c
chore: comment cleanup
6 years ago
24dcae2193
feat: manual password expiry. closes #7471
6 years ago
240f563ab0
fix : #7477
6 years ago
c289b904e6
fix : #7473
6 years ago
962b7f73d3
fix : #7472
6 years ago
dd8d4f206a
fix: remove async.series, dont crash if postAtIndex is undefined
6 years ago
b4a9bb10e5
fix : #7468
6 years ago
697a6597f3
fix : #7444 Re-factor handling of og:image tags ( #7463 )
...
* fix: display proper site logo or og-image with sizes in head
* fix: refactor og:image logic, #7444
- Updated logic to set additional og:image tags based on more
factors
- logo.png fallback
* feat: save image sizes on post upload, re: #7444
* fix: awaiting addTags in topic controller
* fix: pass strings to meta tags object
* fix: sending absolute image url to meta tag
* fix: removed unneeded async and requiring sync db
* feat: upgrade to calculate image sizes for all post uploads tracked
* fix: tests
6 years ago
745a9589e9
Use topics:read privilege for topic filtering use cases ( #7462 )
...
* fix: use topics:read privilege for topic filtering use cases
* fix: tests
* fix: more broken tests
6 years ago
45d7e37ae8
fix: tests
6 years ago
b48b6d75e5
fix: callbacks
6 years ago
f8fa659642
fix don't crash if settings are not passed in
6 years ago
7addc5a0e2
fix: return early if keys is empty
6 years ago
b3962c1694
fix: return early if keys is empty
6 years ago
6cd3ac5b9b
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
b71e0eb179
fix: prevent infinite loops if category is already in children
6 years ago
d2cfe6b946
Moved onSuccessfulLogin call from plugins to core, + auth verification hook ( #7416 )
...
* fix : #7412 , calling controllers.onSuccessfulLogin in core
* feat: added plugin hook for auth validation
6 years ago
b2fbeb053a
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
4732bed3db
fix : #7448
...
don't set parent to itself
6 years ago
73d14e4516
fix: return early if there are not blocked uids
6 years ago
7211dde7b9
feat: #7358
6 years ago
756dfd8ae6
fix : #7008
6 years ago
cbfbcee50f
fix : #7406
6 years ago
aecdf739fd
fix: change user/system cpu usage
6 years ago
5eaa14e746
fix: strip exif data on image uploads
6 years ago
2b6f1a05bf
feat: admin/groups style change
6 years ago
db47753877
feat: add process cpu usage to admin
6 years ago
684175f7d7
fix : #7413
6 years ago
e331f6b51d
fix : #7414
6 years ago
0360f6e1cb
fix: l2spread @baris nib
6 years ago
6c1f9c3c46
fix: restored email logo to all outgoing emails
6 years ago
e613f88b29
use params
6 years ago
23da300958
feat: pass options to digest
6 years ago
9731350812
fix: incorrect teaserPost logic
6 years ago
43c4eb2350
fix: normalized font sizes for paragraphs in digest
6 years ago
d3a10628e7
fix: broken 50% border radius on emails, failing tests
6 years ago
d813a77a62
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
6472a06515
fix: hook names getting objectified by winston
6 years ago
3a7f1c192b
fix: failing tests from revamped-emails branch
6 years ago
f32a992237
feat: revamp email templates to be more style agnostic ( #7375 )
...
* feat: re-designed digest
Updated design, logic no longer shows "no topics", just doesn't
show the list at all, teaser re-retrieved for digest so that it
always grabs a teaser even if there is no reply, changed default
email background to a light grey.
* fix: minor padding issues in digest
* fix: banned template
* fix: invitation.tpl
* fix: removed unused notif_chat and notif_post email templates
* fix: notification template
* fix: registration_accepted template
* fix: reset tpl
* fix: test tpl
* fix: email verify tpl
* fix: reset notify tpl
* fix: welcome tpl
* fix: additional minor font fixes
* fix: removed unused email header image assets
* fix: internationalised 'your daily digest' string
* fix: broken url in digest 🤦
* feat: added RTL support for emailer
/cc @PostMidnight
6 years ago
d722f3b8b6
fix: mounting of all-route middlewares to router instead of app
...
related to julianlam/nodebb-plugin-session-sharing#73
These three lines haven't changed in two years, but it makes more
sense for them to be called against the relative path router,
otherwise req.originalUrl contains the relative path, which is
not necessary.
6 years ago
f972f75202
fix: incorrect returnTo set in registerComplete
6 years ago
eafe76debb
feat: add vote status to getPostData API call
6 years ago
7a5344533e
fix: tests for #7385
6 years ago
57069a5c48
fix : #7385 better handling for errors in Adv>Databases
6 years ago
c01d43e01d
feat: quick search
6 years ago
949b10f132
fix: no relative path needed in req.session.returnTo
...
re: julianlam/nodebb-plugin-session-sharing#73
6 years ago
c2e7ae7f41
fix : #7373
6 years ago
2996a5dc25
fix : #7359
6 years ago
c6ad8fae2a
fix : #7354
6 years ago
efd7d953de
fix: uid check
6 years ago
c24dcf78b7
fix: uid checks
6 years ago
5917dec288
fix: only allow numbers as scores ( #7356 )
...
* zadd score checks
* fix: only allow numbers as scores
* fix: convert values to strings
6 years ago
fe63fca846
fix: remove debug logs
6 years ago
bcd62586e2
fix: database 0 was being replaced with undefined because 0 is falsy
6 years ago
ba90bf3114
feat: check overide
6 years ago
f2d7f75ee2
feat: check CI failure
6 years ago
2e2c3ac110
fix : #7352
6 years ago
aca0556052
fix : #7261 , banned users still get digests
6 years ago
8c68780e54
fix : #7350
6 years ago
0c09b7402d
feat: logging password resets and errors into event log
...
closes #7343 , also adds tests for password reset socket calls
6 years ago
fab52b840c
fix: prevent crash if results.stats or results.serverStatus is undefined
6 years ago
70d9c6c4ce
fix : #7232
6 years ago
8e3bf58106
fix : #7338
6 years ago
56a493d873
fix: dont crash if userData is undefined #7262
6 years ago
a2f08e7da2
fix : #7240
6 years ago
cd1209906d
fix: give default privs on new install to guests/spiders
6 years ago
c72da5595a
fix : #6806
...
3 new global privileges
view:users
view:tags
view:groups
6 years ago
9d1fcf4e36
fix: closes #7217
6 years ago
5031bfe8c0
feat: allow themes to define custom classes for categories via filter:admin.category.get
...
`datalist` isn't supported in all browsers but this will fallback to the original behavior. The first item in the list is the placeholder.
6 years ago
d75a0d7724
feat: show more unread notifs
6 years ago
6e69a9ab31
fix: merge post notifs
6 years ago
cd2f72fb73
feat: pass topic creation data to action:topic.save
6 years ago
5353960ae7
fix : #7316
6 years ago
6cd8248cae
added empty array for customActions and another indentation fix attempt, related to #7284
6 years ago
14addef67b
indentation fix #7284
6 years ago
d94f6248ca
related to https://github.com/NodeBB/NodeBB/issues/7212
6 years ago
eb21ca1190
added customAction in the registration queue users list, related to #7212
6 years ago
04232986ab
related to https://github.com/NodeBB/NodeBB/issues/7212
6 years ago
02a8ed9b11
feat: textcomplete over jquery-textcomplete, closes #7309
6 years ago
920efad04d
fix : #7300
6 years ago
70f8b418c4
fix : #6848
...
fixed in winston 3.2.0
6 years ago
f659ef4d80
feat: new hook filter:privileges.posts.edit
6 years ago
df6f75eb05
fix : #7298 privilege header misalignment
6 years ago
cf918078e5
fix : #7211
6 years ago
0edeeea2cf
Merge branch 'develop'
6 years ago
7064fd0678
fix : #7235
6 years ago
ef0e780896
fix: use ACP config value for checking online status
6 years ago
a083d5f429
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
a22a3a9861
fix: log error to prevent headers already sent
...
retry on uniq index fail
6 years ago
63061ffd37
feat: new hook filter:user.logout
...
- used for setting "next" for post logout redirection
6 years ago
0a662e4882
Add Disallow: /compose to robots.txt
6 years ago
cee47f78b2
fix : #7289 timeago shorthand toggle fails on non-existant language
...
- Exposing timeagoCodes to frontend
- Timeago language and shorthand toggling will fall back to 'en'
if the requested language does not exist
6 years ago
059a4be204
feat: explicit handling of SSO success and failure
6 years ago
831d079512
fix : #7274 incorrect handling of client script 404s
6 years ago
a23854e3ff
feat: new hook type: `response`
...
Used in authentication middleware. Instead of firing an action
hook, it now fires a response hook.
Response hooks are invoked serially, and if headers are sent from
one of the hook listeners, all subsequent hook methods are not
called.
Response hooks should only be used in situations where res.send
(or other like methods) are invoked. Existing plugin hooks that
pass in res purely for data retrieval purposes have not changed).
fixes nodebb/nodebb-plugin-write-api#101
6 years ago
f122fc44d0
fix : #7266 body does not contain skin class
...
A regression was identified where the skin was not shown in the
body class. This resolves the issue and adds a workaround so that
the fix does not become breaking for custom themes.
6 years ago
7524d3c33b
fix: generate timeago codes from files
6 years ago
2b9322e1c2
feat: additional options for SSO plugins
...
+checkState property, pass Boolean false to skip nonce checking
+callbackMethod, default 'get', you can pass in 'post', etc.
6 years ago
ed5d2d6d15
feat: get rid of disk access
6 years ago
c831ff0de3
fix: removal of timeago fallback middleware ( #7259 )
...
* fix: removal of timeago fallback middleware
Instead of loading English fallback on missing language, we opt
to not send a script tag for a missing language to begin with.
Timeago already loads with English as default, so it will just
continue to use English.
* fix: check userLang against supported language codes
* fix: cleaned up code as per @pitaj
* fix: added comments
* fix: more fixes as per @pitaj
* feat: added addl. test for timeago locales, fixed broken test
6 years ago
c14dbfc6b7
attempt to fix tests
6 years ago
65f6630722
add new hook action:plugins.firehook
6 years ago
ac655564bb
fix: post queue notifs
...
fix moderators not showing up immediately when adding them
6 years ago
e1ca2d81f9
refactor: use loash when possible ( #7230 )
6 years ago
9328eeca95
fix: escape hook method
6 years ago
428f587cbe
fix : #7208
6 years ago
a662f118a5
fix : #7054
6 years ago
b9833483ca
fix : #7209
6 years ago
70a87d4399
feat: support for one-click unsubscribe from email clients ( #7203 )
...
* feat: sending notifs via ACP creates real notification
re: #7202
* feat: basic integration for one-click unsubscription #7202
* feat: tests for #7202 + bugfix
* feat: added and organized digest unsub tests
closes #7202
6 years ago
1a3838e13c
fix: missing notification
6 years ago
7809ba2800
fix : #7193 , closes #7194
6 years ago
0263b4daec
feat: added new hook `static:sockets.validateSession` ( #7189 )
...
* feat: added new hook
* fix: improper .bind() call, +req in static:sockets.validateSession
* fix: restored original sessionStore logic, +hook
original logic to retrieve the sessionStore was not faulty, but
was changed for the sake of changing things, which ultimately
led to issues with tests, etc.
6 years ago
6f1fb4eb24
fix: # https://github.com/barisusakli/nodebb-plugin-dbsearch/issues/49
6 years ago
28459d04c6
fix : #7187
6 years ago
9aa1aa689d
fix : #7174
...
always pass string in service
6 years ago
934e1854d3
remove unnecessary escape
6 years ago
0d409610c4
fix : #7181
6 years ago
b0eaa858b5
fix : #7169 Fixed logout being broken
6 years ago
72afc1806e
fix: uid filtering
6 years ago
41fb5cca81
fix: dont crash if default cover is invalid
6 years ago
d81e0a5f5b
fix : #7146 Better RTL handling on (de-)authentication
...
- RTL is applied (or unapplied) on login and logout depending on
user language/guest-detected language.
- config is automatically saved into res.locals.config whenever
loadConfig is called
- On login/logout, buildHeader is called instead of getting config
- On logout, req.uid is deleted instead of set to 0
6 years ago
900f0a0b78
fix : #7118 , invoking autoLocale middleware on logout
...
Also:
- firing client-side hook on header update
- updating bootbox locale on header update
6 years ago
3917022a48
fix : #7139
6 years ago
7e828404f6
fix : #7116
...
dont save relative_path in db for group covers
6 years ago
f4ea2c43ab
feat: #7120
6 years ago
0c1ac4d6a2
feat: #7032
6 years ago
d31684e8b8
fix : #7131
6 years ago
fef7e13c9e
feat: small fixes
6 years ago
b2a74b4172
fix: remove cache
6 years ago
b9b9d8b2e9
feat: name topic controller
6 years ago
0cb9bba4da
feat: header
6 years ago
60390c01f1
fix: loop
6 years ago
ae0fe5e880
feat: more naming
6 years ago
f88db22ca2
feat: give the rest of the middlewares names
6 years ago
fdfbcc6efe
feat: give names to more middlewares
6 years ago
53793e1603
feat: give names to middlewares
6 years ago
4650a76036
fix : #7124
6 years ago
9f5062682d
fix: unread badge
...
- only increase unread badge if topic or category is watched
- fix logic for "there are new posts/topics" on /unread and /recent
6 years ago
d2c2d56f59
feat: change sortedSetsScore
6 years ago
99e0895e99
fix: move the check to get methods
...
all .post methods will have csrf
6 years ago
fbe6ccd773
style: lint fix
6 years ago
989879a6b5
fix : #7115
6 years ago
14c4552304
dont modify session for spiders
6 years ago
29b63ae7fb
fix : #6979
6 years ago
0eef3e1c27
fix: upgrade script key
6 years ago
00afc5b3ab
fix: remove log
6 years ago
eb7ae54f81
Category watch state ( #7109 )
...
* feat: wip, category watch change
* feat: pass data to client
* feat: allow changing state
* fix: account page categories
* fix: show in unread if topic is followed or category is watched
* feat: add default watch state to acp
* feat: save user category watch state
* feat: update unread recent pages
* fix: remove dupe code
* fix: flip conditions
* fix: handle empty arrays
* fix: ignore/watch on others profile
* feat: upgrade script for category states
if there are any users ignoring categories set their state in new zset and delete cid:<cid>:ignorers
* fix: upgrade
* fix: tests
* fix: redis count
* fix: more tests
6 years ago
ff5b04beb9
Log port number of current instance in addition to pid. ( #7110 )
6 years ago
8169739069
fix : #7108
6 years ago
62f01a839e
fix: dont save data for non-positive uids
6 years ago
f103390aa5
fix : #7103
...
update counter when user navigates to /unread
fix new topic alert on /unread
moved unread code from footer to unread
6 years ago
2f57a4b9a6
fix: dont update cid:<cid>:tids:votes if topic is pinned
6 years ago
d117df77f7
fix : #7102
6 years ago
85a07e999b
fix : #7102
6 years ago
263c918088
feat: remove uid:<uid>:ignored:cids ( #7099 )
...
use cid:<cid>:ignorers instead
6 years ago
26ccd8f626
fix: db info page
...
if there is no connection to db, connect first
6 years ago
a0f57c642c
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
a6c8e0ab4f
fix: logAttempt conditional
6 years ago
33d4956b76
fix : #7087 , server-side protection against guest blocks
6 years ago
78fa734017
feat: cache category tag whitelist
6 years ago
81aa3a0b8a
fix: don't crash in flags.validate if user blocked target
6 years ago
fe0f95a2b1
fix : #7085
6 years ago
e55fb43703
fix : #7086
6 years ago
71163421aa
fix: wrong variable #7085
6 years ago
df4f8cee4b
remove node 6
6 years ago
e65d40c937
dont return undefined from sortedSetsCard if keys is empty or falsy
6 years ago
420227faae
parseFloat scores
6 years ago
4fba1492c1
feat: added new middleware authenticateOrGuest
6 years ago
eeaee8ccef
fix: not calling authenticate middleware on resource direct access
...
routes
6 years ago
5f3d1c76c8
fix : #7038 , autoLocale logic not playing nicely with no-refresh auths ( #7059 )
...
* fix : #7038 , autoLocale logic not playing nicely with no-refresh auths
- on login, req.query.lang is deleted (since it seems to be left over)
- on logout, the middleware.autoLocale is executed, which resets
req.query.lang
- middleware.autoLocale is new, just refactored existing logic in
webserver.js into new middleware method.
* style: tests, use lodash
* fix: timeago strings not switching languages on login or out
6 years ago
a07d9898df
fix : #7071 buildSkinAsset won't rebuild continuously
6 years ago
7ca62b8399
feat: closes #7070
6 years ago
96c1dc6276
unescape email subject
7 years ago
eab297bdc9
fix : #7061
7 years ago
d7c55bc3f7
feat(email): don't escape html in notification bodies. ( #7042 )
...
allows for post replies, etc. to show the formatting of the orginal
post, rather than looking garbled.
closes #7034
7 years ago
d3c6cba33f
closes #7060
7 years ago
67ac8e3d06
closes #7053
7 years ago
54c127d1b2
feat: allow array results
7 years ago
f581c052ee
feat: #7023
...
- add category selector to privileges and category create modals
- allow category selector to work for multiple selectors on same page
7 years ago
a63ddbe2aa
fix : #7040
...
if category doesn't exist return null and 404
7 years ago
ec0c50d4e0
fix : #7041
7 years ago
8d7c3897f2
fix : #7043
7 years ago
cb7c2d8c28
fix: add missing render function
7 years ago
1f918ca8f8
Home route ( #7039 )
...
* fix: WIP home fix
* remove console.log
* fix : #6949
on redis run all tests in subfolder /forum
fix URI errors
fix sping/ping
7 years ago
8808a03307
fix : #7033
7 years ago
b86f155690
fix : #7037
7 years ago
ba619c7ec8
style(eslint): match operator-linebreak preferences
7 years ago
89c025d102
feat: close #7002 , console message if mismatched origins
7 years ago
43c3bb02e5
fix : #6991 , add timeout for version Github request
7 years ago
33d7735690
change deprecated message
7 years ago
dab1a1d638
fix for null category ( #7029 )
7 years ago
29e9310aa5
dont crash for undefined categories
7 years ago
6330d51446
less derpy output
7 years ago
ed1bf9a16f
add more info to advanced db page
7 years ago
4b486a808e
fix custom home
7 years ago
2c5e38d8f1
closes #7004
...
do not translate email subjects twice, emailer already translates the passed in subject param
7 years ago
00a066985a
cache categories:cid and cid:<cid>:children
...
these rarely change, no need to go to db for them
7 years ago
112b5c861a
change queue logic, if user has negative rep always queue their post
7 years ago
1d5816b00a
add new hook `filter:unread.categories`
7 years ago
59eeff8f0f
closes #7011
7 years ago
d0750bc587
closes #7007
7 years ago
1bb6067e19
suggested topics fix, if search doesn't return enough topics
7 years ago
8e5a6d9767
add banned:expire to user data
7 years ago
53ad2bbd6e
Categories optimize ( #6999 )
...
* WIP
* fix category page
* fix counts, and copyPrivileges
* fix lint
* more fixes,
* redis fix
* fix test
* fix category test
* remove getParentsAndChildren
7 years ago
69ef05707a
style
7 years ago
3f8e3dc3e8
Merge branch 'master' of https://github.com/NodeBB/NodeBB
7 years ago
13139fe77e
return early for guests/spiders
7 years ago
0524fd9caa
closes #6996 ( #6997 )
...
* closes #6996
* fix lint
7 years ago
7b9a2caec3
closes #6994
7 years ago
b8c08a5417
dont call db for guests
7 years ago
d8f114c982
dont check if guests/spiders are banned or load reason
7 years ago
9d28b935fd
dont load uid 0, -1 from db
7 years ago
d5af39ca5d
make 1 call for parentCids
7 years ago
01c942fc39
closes #6989
7 years ago
eba1a405d2
load category parents and childrens in one call
...
add more missing guest/spider checks
7 years ago
a6864a8055
add groupTitle test for guests
7 years ago
1c981e638b
rename query name
7 years ago
ca1e3a758b
#6986
7 years ago
48690a01b9
dont need to call multi if keys.length is 0
7 years ago
20abc7fc47
closes #6985
7 years ago
Barış Soner Uşaklı
psychobunny
Julian Lam
Barış Soner Uşaklı
Manuel Valle
cryptoethic
Opliko
Peter Jaszkowiak
Jonson Petard
hb90dev
arite
Ben Lubar
uplift
Aziz Khoury
David Karrick
jayjay9
Ricki Hirner
Ben Lubar
oh
SweetPPro