fix: dont save data for non-positive uids

v1.18.x
Barış Soner Uşaklı 6 years ago
parent 63f4b5696b
commit 62f01a839e

@ -365,7 +365,11 @@ authenticationController.onSuccessfulLogin = function (req, uid, callback) {
user.auth.addSession(uid, req.sessionID, next);
},
function (next) {
db.setObjectField('uid:' + uid + ':sessionUUID:sessionId', uuid, req.sessionID, next);
if (uid > 0) {
db.setObjectField('uid:' + uid + ':sessionUUID:sessionId', uuid, req.sessionID, next);
} else {
next();
}
},
function (next) {
user.updateLastOnlineTime(uid, next);

@ -10,6 +10,9 @@ var plugins = require('../plugins');
module.exports = function (User) {
User.logIP = function (uid, ip, callback) {
if (!(parseInt(uid, 10) > 0)) {
return setImmediate(callback);
}
var now = Date.now();
async.waterfall([
function (next) {
@ -31,10 +34,7 @@ module.exports = function (User) {
db.getSortedSetRevRange('uid:' + uid + ':ip', 0, stop, next);
},
function (ips, next) {
ips = ips.map(function (ip) {
return validator.escape(String(ip));
});
next(null, ips);
next(null, ips.map(ip => validator.escape(String(ip))));
},
], callback);
};
@ -48,9 +48,7 @@ module.exports = function (User) {
db.getSortedSetRangeWithScores('username:uid', 0, -1, next);
},
function (users, next) {
uids = users.map(function (user) {
return user.score;
});
uids = users.map(user => user.score);
plugins.fireHook('filter:user.csvFields', { fields: ['uid', 'email', 'username'] }, next);
},
function (data, next) {

@ -141,6 +141,9 @@ module.exports = function (User) {
User.auth.addSession = function (uid, sessionId, callback) {
callback = callback || function () {};
if (!(parseInt(uid, 10) > 0)) {
return setImmediate(callback);
}
db.sortedSetAdd('uid:' + uid + ':sessions', Date.now(), sessionId, callback);
};

Loading…
Cancel
Save