fix: check threshold before setting bookmark

5 years ago · f983f536c6
parent 4e28e575cf
commit f983f536c6
1 changed files with 4 additions and 1 deletions
--- a/src/socket.io/topics.js
+++ b/src/socket.io/topics.js
@ -53,7 +53,10 @@ SocketTopics.bookmark = async function (socket, data) {
 	if (!socket.uid || !data) {
 		throw new Error('[[error:invalid-data]]');
 	}
-	await topics.setUserBookmark(data.tid, socket.uid, data.index);
+	const postcount = await topics.getTopicField(data.tid, 'postcount');
+	if (data.index > meta.config.bookmarkThreshold && postcount > meta.config.bookmarkThreshold) {
+		await topics.setUserBookmark(data.tid, socket.uid, data.index);
+	}
 };

 SocketTopics.createTopicFromPosts = async function (socket, data) {