Commit Graph

8465 Commits (4439864ce0092b12de66ff4ebb0bec3975cbab49)

Author SHA1 Message Date
Julian Lam 8437130ec2 fix: early button/anchor clicks do nothing
This reverts commit a395324b52, and
fixes the issue where the ACP became unusable because of the earlier
variant of this code.

Thanks @psychobunny for spotting.
Misty (Bot) f693ce97bf Latest translations and fallbacks
Barış Soner Uşaklı a395324b52 Revert "fix: early button/anchor clicks do nothing"
This reverts commit 966d3f7654.
psychobunny 14ba1a6dbb feat: analytics:maxCache setting in ACP
I removed a TODO from core. Watch your head as flying pigs are abound
psychobunny ffbf2d6d63 feat(openapi): refactor into indiv. files to match API & tpl routing
psychobunny c7d27731b3 Revert "feat(openapi): refactor into indiv. files to match API & tpl routing"
This reverts commit 84f5e4cf3d.
Julian Lam 966d3f7654 fix: early button/anchor clicks do nothing
This solves a small UX issue where clicking on a button (or anchor
that is not meant to be ajaxified) before ajaxify.end is called
leads to nothing happening because the appropriate click handler
has not been added.

This code will intercept premature clicks, wait until ajaxify.end
is called, and then re-send the click.
Barış Soner Uşaklı ea0f3262f4 feat: , allow sort for guests
psychobunny 84f5e4cf3d feat(openapi): refactor into indiv. files to match API & tpl routing
psychobunny 9c5b690799 feat: up recommended size to 512x512 + ACP labels for PWA
psychobunny 6478b32d0e feat: upload maskable icon for PWA
Julian Lam 3fbddbe2ca fix(openapi): test for new trending plugins in ACP
Julian Lam b12e8d6312 feat: show top 5 trending plugins in new tab in Extend > Plugins
psychobunny aa268d5eeb feat: register service worker,
psychobunny 4c1e717b2b fix: update notification delay ACP help text
psychobunny 5b427a0c3b feat: option in ACP to configure notification/email delay for chats
Misty (Bot) f66cb05fcf Latest translations and fallbacks
Timothy Fike f85fe7faff
don't invite an already invited email ()
* don't invite an already invited email

* add email-invited translation string
Misty (Bot) 852ec92e93 Latest translations and fallbacks
psychobunny b6f2f0e5d0 fix: change owner modal's search should check if user is banned
psychobunny 611f3c6155 feat: allow autocomplete to pass optional params to user.search
Julian Lam f8032cd09b fix: add img-responsive to post queue post items
Misty (Bot) 7fa61fafbf Latest translations and fallbacks
Julian Lam 5ddf70221c feat: upon plugin installation via ACP, check against nbbpm first
Misty (Bot) 8b855720f8 Latest translations and fallbacks
psychobunny 2ad3305879 fix: language key in reset password
Julian Lam 0fffe28941 fix: issue where the last flag filter could not be removed
psychobunny 2cd5f959a0 feat: add row highlighting for popular and unread
psychobunny 48a8ec4ab2 feat: return to previous page and/or category after marking topic unread
... also return to category if pagination is active and previous page was another page in the thread
Misty (Bot) 6ebd2c80e7 Latest translations and fallbacks
Barış Soner Uşaklı bd9b6c99e6 feat: add missing lang key
Barış Soner Uşaklı 83d4e7efaa feat: add number of posters to topic
Barış Soner Uşaklı f2f3ba49b6 feat: hightlight matches in quick search
fix title hightlights
Barış Soner Uşaklı f8ef380b34 fix: multiword match highlight
Barış Soner Uşaklı d38c872259 feat: add loading indicator
psychobunny 82ab6cd3b1 fix: tooltip placement on navbar search
psychobunny 683c01b0d3 fix: rogue tooltip on navbar profile icon
Barış Soner Uşaklı 445a840b88 fix: , @julianlam
psychobunny 703ac1b685 fix: match api when modifying ajaxify.data.deleted (int, not bool)
Barış Soner Uşaklı 9a7c3c689f fix: lock/unlock toggle issue
Barış Soner Uşaklı 654d583059 fix: api spec
Barış Soner Uşaklı 02a48e1c64 fix: change user tooltip container to content
Barış Soner Uşaklı af43f0e48e fix: , rename /api/me to /api/self
Misty (Bot) 9e7f5b9403 Latest translations and fallbacks
Misty (Bot) bd10559121 Latest translations and fallbacks
Barış Soner Uşaklı 95c65e2da0 Merge branch 'master' of https://github.com/NodeBB/NodeBB
Barış Soner Uşaklı 23de5613bd feat: add x-posts/x-votes keys
Misty (Bot) 4f9131fdc3 Latest translations and fallbacks
Barış Soner Uşaklı 047c414841 fix: add user tooltips to body
so they don't get cutoff  in containers with overflow:hidden
Barış Soner Uşaklı ddc0ac37ab feat: allow adding nested replies to a target component
Julian Lam 43571bac38 feat: hotkey "/" to open ACP search
Julian Lam 763cec31bd feat: ctr-s for save on privileges page too
Julian Lam 8093142340 feat: ctrl-s now saves on settingsv1/v2 forms
... because nobody ever uses ctrl-s on a browser window.
Barış Soner Uşaklı 6669b23d9a feat: single href
Barış Soner Uşaklı 42298fe659 fix: clear old value on focus
hide results if input lost focus during search
Barış Soner Uşaklı c9c9dd2f9b fix: skip elements if they dont have proper index
Barış Soner Uşaklı 7148be2fd1 feat: allow passing in container to threadTools
Barış Soner Uşaklı 99f24c5997 fix: call to reskin
Julian Lam 44309ee62f fix: move necro-post to be in-line with posts
Barış Soner Uşaklı a8e18fdbe6 fix: client side crash if there are no topics
Misty (Bot) 21ae81b4af Latest translations and fallbacks
Barış Soner Uşaklı e90940949c fix: openapi
Barış Soner Uşaklı c1c617b323 feat: add topicIndex to category page
Misty (Bot) 74f14829a0 Latest translations and fallbacks
Barış Soner Uşaklı 632793b067 fix: dont use hardcoded fontawesome icons for lock pin
Barış Soner Uşaklı f6d564667e feat: switch to using topic/select component for merge
automatically add the selected tids to the merge modal
Misty (Bot) 66ef90df9f Latest translations and fallbacks
Julian Lam 762e9fe88c feat: undo for posts move
Julian Lam 65d94a3b6d fix: and change undo timeout to 10 seconds
Barış Soner Uşaklı 2bebdf017d fix: alert_id selector
Barış Soner Uşaklı 5a40d26b44 feat: , new move posts modal
Misty (Bot) 0cec103489 Latest translations and fallbacks
Barış Soner Uşaklı a34b685c65 fix: remove lang keys, remove sounds menu
Misty (Bot) 61590c7e54 Latest translations and fallbacks
Barış Soner Uşaklı 5f10d67db5
Remove sounds ()
* feat: remove sounds

* feat: remove more sounds

* feat: disable sounds plugin

* fix: openapi
Barış Soner Uşaklı 5002e0f62c feat: refactor app.js
Barış Soner Uşaklı 19c448612d feat: remove global RELATIVE_PATH
Barış Soner Uşaklı 3cd3b7a172 feat: remove app.template
Barış Soner Uşaklı 630bac2aa5 feat: remove global window.templates
Barış Soner Uşaklı fddeb5c0f8 feat: remove app.isConnected, use socket.connected
Barış Soner Uşaklı 46ab2711d4 fix: , add CSP frame-ancestors
Barış Soner Uşaklı 94da9fe55e feat: add partials/footer/js.tpl
add ajaxify.coldLoad which gets called from partials/footer/js.tpl
Peter Jaszkowiak 64a457a441
fix(bug): , custom route logic corrected ()
Barış Soner Uşaklı c495aacc3e Merge branch 'master' of https://github.com/NodeBB/NodeBB
Barış Soner Uşaklı 57f67e2b91 fix: don't toggle elements if there is no inputEl
Misty (Bot) b7db0f200e Latest translations and fallbacks
Julian Lam f743f92088
refactor: socket posts delete/restore/purge so tid is not necessary ()
* refactor: socket posts delete/restore/purge so tid is not necessary

* refactor: stop trying to be fancy

* fix: tests to not pass in tid into posts.deletePosts

* fix: some more unnecessary tid passing
Barış Soner Uşaklı 09de364e93 feat: add client side action:flag.create
Misty (Bot) 2a4f4f5aec Latest translations and fallbacks
Misty (Bot) b201bb2111 Latest translations and fallbacks
Julian Lam 0c20351702 feat: additional sorting options for flags
+ upvotes, +downvotes, +replies
Misty (Bot) 02a5fe9c68 Latest translations and fallbacks
Julian Lam 694f4b2bcf fix: accept/reject in post-queue instead of accept/delete
Julian Lam b587127560 fix: new openapi def for replies addition
Julian Lam e0c7d65a92 Revert "feat: add reply count to getPostSummaryByPids"
This reverts commit de0f4aadb8.
Julian Lam de0f4aadb8 feat: add reply count to getPostSummaryByPids
Misty (Bot) c25af08da0 Latest translations and fallbacks
Barış Soner Uşaklı 9f9164a9be fix:
Julian Lam fb3b4a0293 fix: debug logging 🐶
Julian Lam 56101ae5ae fix: ip-blacklist not working after
Julian Lam c681b4b2e0 fix: ip-blacklist not working after
Julian Lam dc5bd7601f fix: post-queue not working after
Julian Lam a93e19559d fix: missing language sources for ip-blacklist/post-queue
Julian Lam 4dc6e64a94 refactor: ip-blacklist and post-queue language files
closes 
Kyle Farris 2b785628e7
fix: removed invalid options for the sendmail transport ()
* Removed invalid options for the sendmail transport that were causing Nodemailer to return the SMTPTransport instead.

* Removed options for rate limiting in admin email interface. Added new option for toggling whether to use pooled connections.
Julian Lam b6b94a56dc refactor: moved ip-blacklist and post-queue styles/tpls to themes
This is a breaking change!, re: 
Misty (Bot) 073c4d7886 Latest translations and fallbacks
Julian Lam abb5e81d0d feat: allow undo of topic move
Julian Lam cd8e7963de feat: added alert.timeoutfn
Also, various alert methods now pass two arguments,
alert and params
Julian Lam bacee6b467 fix: missing localisation for topic move error
Julian Lam 5d60dce379 fix: select all checkbox does not re-enable bulk actions button
Misty (Bot) 5f15afff39 Latest translations and fallbacks
Barış Soner Uşaklı 4f7cfd5372 fix: openapi spec
Barış Soner Uşaklı c4ad14cb68 fix: api spec
Misty (Bot) 074d7dfd86 Latest translations and fallbacks
Julian Lam 9cbe9389f5 fix: use promises in privilege save
... instead of jQuery Deferreds
Julian Lam 7a5daff4c9 fix: overzealous click handler on flag list row
Misty (Bot) f425cecded Latest translations and fallbacks
Julian Lam 9608b44f21 fix: +comment, -debug log
Julian Lam a3a2279358 feat: logic for bulk actions in flags list,
Julian Lam 589216e720 fix: multiple alerts in the same millisecond overwrite each other
Julian Lam 2a948d32a4 Revert "test(openapi): missing commonprops addition"
This reverts commit 0dc55bbc80.
Julian Lam 0dc55bbc80 test(openapi): missing commonprops addition
Julian Lam b2271eb64f fix: client-side error in flags/detail
... as the filter form is no longer present in the details page
Misty (Bot) bb7bd1b421 Latest translations and fallbacks
Misty (Bot) 07ebc81a2f Latest translations and fallbacks
Julian Lam d935f03636 fix(openapi): tests
Julian Lam 334be11382 fix: no-widgets messaging in ACP + copy
Julian Lam 346db0d84d feat: flags list sorting, closes
Misty (Bot) 1101fa3394 Latest translations and fallbacks
Misty (Bot) 6bb60b0965 Latest translations and fallbacks
Barış Soner Uşaklı 35a538ec2a feat: allow adding multiple users to group
Misty (Bot) 7f57d39cd5 Latest translations and fallbacks
Misty (Bot) 2b930c894a Latest translations and fallbacks
Misty (Bot) ea53c95d67 Latest translations and fallbacks
Misty (Bot) 2aa36b649a Latest translations and fallbacks
Barış Soner Uşaklı 3f01f4a2b8 Revert "feat: load timeago strings client-side"
This reverts commit 558a2d739c.
Julian Lam 558a2d739c feat: load timeago strings client-side
9adaccd036 introduced the ability to
configure an assetBaseUrl, but the timeago strings were still
calling a hardcoded value as it was handled server-side. There's
no need for the strings to be loaded until timeago is initialised.
Barış Soner Uşaklı 79e847d424 fix: , only navigate if user is in same topic
Julian Lam 8ff09630b6 fix(openapi): new api definition
Julian Lam 9adaccd036 feat: +assetBaseUrl, -l10BaseUrl, -requireBaseUrl
Additional base URLs were necessary for benchpress and translator,
and in order to not clutter the API response with needless one-
time use base URLs, I decided to use a single base that is used
by all of the services, assetBaseUrl.
Misty (Bot) 75ef4bbe34 Latest translations and fallbacks
Julian Lam d6297b28e9 fix: tests
Misty (Bot) 8a6bc10eb1 Latest translations and fallbacks
Julian Lam def16f9e97 feat: introduce overridable l10nBaseUrl config value
Misty (Bot) 9846498df7 Latest translations and fallbacks
Barış Soner Uşaklı dfabd0a3fe feat: remove administrator property from public routes
Barış Soner Uşaklı 4216c277d5 feat: focus username when modal is shown
Misty (Bot) 3463fc51c6 Latest translations and fallbacks
Julian Lam 2ee6248316 refactor: for codeclimate
Julian Lam a7071bb808 fix: map instead of forEach in privileges save
Julian Lam a716a5529c
feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals ()
* feat: privileges save button, , WIP

* fix: disable firefox autocomplete on privilege form fields

* feat: closes  privilege changes commit on save

- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs

* fix(tests): remove duplicate template helper test

* fix(tests): broken template helper test

* feat: confirm dialogs for all privilege copy actions

Also, ability to add user to a privilege table without needing
to refresh the privilege table.

* feat: group row addition w/o table refresh

breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges
no longer make socket calls to the following hooks:

- filter:privileges.list, filter:privileges.admin.list,
  filter:privileges.global.list, filter:privileges.groups.list,
  filter:privileges.admin.groups.list,
  filter:privileges.gloval.groups.list

The filters are still called, but done before the helper method
is called, and the results are passed in instead. This change
should only affect you if you directly call the helper methods,
otherwise the change is transparent.

* fix: stale ajaxify data on privilege category switch

* fix: implicit privileges not showing for user privs

* fix: groups, not group, also fix tests

* fix(tests): again

* fix: wrong tpl rendered when adding group to global priv table
Misty (Bot) 8da742e065 Latest translations and fallbacks
Misty (Bot) 903c407171 Latest translations and fallbacks
Barış Soner Uşaklı e7a502e0aa feat: add ability to search groups in group details page
Barış Soner Uşaklı 519e665939 fix: , go to first unread instead of last read
Misty (Bot) 029f477434 Latest translations and fallbacks
Barış Soner Uşaklı 9e80a9efdd fix: , dont show modal on search
Barış Soner Uşaklı fb7bb8d400 feat: use category selector in category page
fix privilege shortcuts in group page after search
Barış Soner Uşaklı 560f3eb173 feat: css fixes
Barış Soner Uşaklı 91411cc47c feat: add privileges shortcut to groups list
fix issues with escape group names
Misty (Bot) caa78cc1f6 Latest translations and fallbacks
Julian Lam c705e08a76 feat: allow direct link to flag from post tools,
Barış Soner Uşaklı 8415d2f014 fix: api test
Barış Soner Uşaklı c4829fd8c2 feat: allow changing requirejs base url
Barış Soner Uşaklı bbc7737e14 feat: ability to clear cache from acp
Barış Soner Uşaklı 69fb15276c fix: tests
Barış Soner Uşaklı 8d8117ffa1 feat: reduce amount of data loaded on acp admin page
get rid of socket call and use ajaxify.data.categories
Misty (Bot) d580cf01c3 Latest translations and fallbacks
Barış Soner Uşaklı f48d155670 fix: tests
Barış Soner Uşaklı fd4c3cda42 fix: , remove new notif alert
Julian Lam 8473e165a6 fix: too small sortable handle for ACP>Manage>Categories
The handle was initially just the icon, but now it is the icon
and the category label itself.
Misty (Bot) 93d1ceccdd Latest translations and fallbacks
Misty (Bot) 43e9c25d26 Latest translations and fallbacks
Barış Soner Uşaklı db07dd8565 fix: less fixes for category dropdown
Barış Soner Uşaklı 24535a62e7 feat: make category tools in acp a dropdown
add view category, view privileges into dropdown
Barış Soner Uşaklı 609e37a67b feat: remove deprecated utils.walk
Julian Lam 55b0e902fb feat: consolidation of flags to reduce flagspam,
Squashed commit of the following:

commit c6d09396208a10c244d7b3d22ffd2d7dd1274d3a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 13:41:32 2020 -0400

    fix: more tests

commit 32f9af2a87a81fa62ecca01e71d6f0d5b9d37ba1
Merge: e50907535 4eae927d1
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:53:04 2020 -0400

    Merge remote-tracking branch 'origin/master' into singleton-flags

commit e50907535109dbdbe8f15c3e2fcdf22d90b1332a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:52:46 2020 -0400

    fix: controllers-admin test

commit fd5af99e303de48a80b0ccc166eee19175cf232b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:26:55 2020 -0400

    fix(tests): dummy commit to trigger travisCI

commit c452a6ffcfaef91403de084c4ae16795cb23c60e
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:05:09 2020 -0400

    fix(openapi): openapi spec changes

commit 8089a74e89128141ab1e6f8ff83447114b3b846b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:48:00 2020 -0400

    fix: reversing the order of reports for display purposes

commit a099892b377333561c72f1ad5b6b20ddb4ce8a96
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:45:44 2020 -0400

    refactor: run all flag creation calls in a single batch

commit b24999682f9d5a33a08a049749c1f0eb4f00facc
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:08:23 2020 -0400

    feat: handling multiple reporters per flag, 

commit 08c75c020021ada754bf0e39eae77d631b01dee5
Author: Julian Lam <julian@nodebb.org>
Date:   Thu Jul 16 20:53:18 2020 -0400

    feat: upgrade script for 
psychobunny 4c90fac412 fix: cursor for category select
psychobunny bc26883aed refactor: setting codeclimate to A
psychobunny 8769e28b28 fix: api docs for admin/manage/groups/x
psychobunny a6ae69737b Merge branch 'master' of https://github.com/NodeBB/NodeBB
psychobunny 10e4ae629c feat: highlight privs row if group is added / navigating from group page
psychobunny 53f6139b8c feat: prevent navigation away from groups page if changes are unsaved
psychobunny 2c83278f97 feat: quick access dropdown on groups page to access privileges page
Barış Soner Uşaklı 42af4b572b fix: api tests
Barış Soner Uşaklı 844f2b4ed0 feat: , allow editing category of queued topic
Barış Soner Uşaklı ec05783507 feat: remove js-enabled.css
Barış Soner Uşaklı a46adb3fd5 fix: more tests
Barış Soner Uşaklı 67ca5e3256 fix: tests
Barış Soner Uşaklı 23a9a334cd feat: short more info
Barış Soner Uşaklı 2485a55092 feat: , allow editing title before posting from queue
Barış Soner Uşaklı 8ddc8dd10f refactor: make msg pretty
Barış Soner Uşaklı 764969ab29 feat: show language when key isn't found
Barış Soner Uşaklı 1e7397b1b8 feat: allow searching categories in ACP
Barış Soner Uşaklı 320008cd49 feat: , don't scroll chat to bottom if user scrolled up
psychobunny 06143ca7d7 feat: added quick link to edit privileges on the category edit page
Julian Lam 1e14af4503 fix: composer textarea placeholder l10n /cc @pitaj
Julian Lam 9fb9185fa7 feat: hide some filters behind 'more filters' button
Julian Lam d52d7bdb10 feat: collapsible daily flags graph