6da3239230
refactor: less.render already returns promise
...
rename callback to next to match other controllers
4 years ago
c70eaa0a34
refactor: prompt.get already returns promise
4 years ago
38756a0c34
refactor: no more 🐮
4 years ago
4333d217a1
fix : #9917 , show topics as unread for guests
4 years ago
a9bc6a0962
refactor: allow array of uids for blocks.is/list
...
remove async.filter
use cacheCreate
4 years ago
9e0ce0272c
fix: don't overwrite reloadRequired with false
...
1. meta.settings.set('name', values); // reloadRequired is set to true
2. meta.settings.set('otherName', values, false); // reloadRequired was set to false, even though it should stay true until restart due to step 1
4 years ago
8e6bd7e913
refactor: show full url on error log
4 years ago
1feb111ade
perf: dont fs.open if plugin doesnt have language namespace ( #9893 )
...
closes #9892
4 years ago
b0a24d6dd5
refactor: var to const and let ( #9885 )
...
* refactor: var to const and let
* fix: missed global bootbox usage
* refactor: align with eslint expectations
4 years ago
997fb2b348
refactor: remove unused code
4 years ago
c1149d045c
fix: better nomenclature
4 years ago
3acaac4c7c
fix: html attributes ( #9877 )
...
* fix: some empty xml tag bodies
* fix: missing/wrong attributing of label tags
* fix: attribute fixes
* fix: misassociated label
* fix: missing alt attributes
* fix: some more missing associated labels
4 years ago
6c25b9dbaa
test: remove escape
4 years ago
4f9717fb08
fix: escape thumbs, allow robots meta tag
4 years ago
27e53b42f3
feat: use unread icon in mobile
4 years ago
8ad9a103b3
fix : #9866 , fire vote hooks after reputation changes ( #9867 )
4 years ago
a0df389021
fix: dont show decimails on auto approva minutes
4 years ago
a70c69fa83
fix: delete old topic tags
4 years ago
d1ff3d6298
feat: cli user management commands ( #9848 )
...
* feat: cli user management commands
* fix: consistent nomenclature
4 years ago
5aea6c6aa1
feat: #9855 , allow uid for post queue notifications
4 years ago
4404e81991
fix: switch inf. scroll to xhr ( #9854 )
...
this fixes infinitescroll when url has custom query parameters
also fixes infinitescroll for plugins like QnA
fixes infinitescroll on tags page
deprecate topics.loadMoreSortedTopics
deprecate topics.loadMoreFromSet
4 years ago
e6a17a6349
Psql multikey ( #9852 )
...
* perf: convert promise.all to single query
* perf: single query for removeBulk
* perf: list
4 years ago
ea04aeded4
perf: convert promise.all to single query ( #9851 )
4 years ago
be43cd2597
Topic Linkbacks ( #9825 )
...
* feat: WIP topic linkbacks, + failing tests
* test: don't accidentally comment out all of the post tests
* fix: rename to "backlinks"
* feat: more stub code, more failing tests
* feat: backend methods and passing tests for topic backlinks
* test: uncomment test/posts.js again
* fix: missing quotation mark in topic event helper
* fix: superfluous usage of Promise.all
* test: fix broken test -- used hardcoded (and incorrect) url
* test: parseInt shenanigans
4 years ago
f24b630e1a
feat: add userData to static:user.delete
4 years ago
6399b42826
feat: closes #9845 , sort by views
4 years ago
ff84d6c52f
Add more chat hooks, replace toobig.jpg ( #9843 )
...
* feat: more hooks for messaging
for use in global chat plugin
* fix: replace toobig.jpg
toobig.png is a real 10000x10000 image
4 years ago
ac1b9692f2
fix: handle undefined returnTo on registerAbort
4 years ago
f8d4ec6ca6
fix: psql test
4 years ago
3605ac811d
fix: possible test fix for subfolder redirect
4 years ago
58e0a366c8
fix : #9834 , missing null email check on new registrations, added tests
4 years ago
a9645475fe
feat: duplicate `requireEmailAddress` settings block to Settings > User
4 years ago
07adb49e7f
feat: mongodb driver 4.x ( #9832 )
...
* feat: mongodb driver 4.x
* feat: up dbsearach
4 years ago
6b34065f2a
refactor: remove async.waterfall from remaining upgrade scripts
4 years ago
89af00d1d5
fix : #9827 , fix reward duplication
4 years ago
30f387710c
fix : #9822 , use correct username/pwd
4 years ago
2add84a568
fix: remove unused translator
4 years ago
9f0e55ad3e
fix : #9819 , show same time info for ban
4 years ago
c437b33652
fix: crash
4 years ago
15f9aaa6ee
fix: remove caller from payload after hooks is done
...
only if it was added automatically
4 years ago
ce8ea6ea42
fix: bad uid reference
4 years ago
f194809f06
feat: move filter:topic.post hook to top of method
4 years ago
7777812e62
fix: update Topics.post and Topics.reply so that plugins can modify uid (or redirect a reply to a different topic)
...
/cc @antosik
4 years ago
c4fc7bf9b5
fix : #9818 , fix totalTime calculation
4 years ago
1ed62aa82f
fix: missing microdata in category data
4 years ago
c0a52924f1
fix : #9812 , add topics:schedule
4 years ago
18252fb9a8
refactor: no regex
4 years ago
31a6d4b39a
fix: for subfolders
4 years ago
0236ea86ad
fix: req.path doesn't have full url
4 years ago
40c9fca918
fix : #9811 , send bodyClass on 403
...
use helpers.formatApiResponse for /api/v3 routes only
4 years ago
05ddd60c5e
dont check empty emails in queue
4 years ago
58ac55c16a
refactor: remove async.waterfall
4 years ago
222dccaf67
refactor: remove async.waterfall
4 years ago
f35a0f430a
refactor: remove async.waterfall
4 years ago
ba3582b873
fix: xss on flags page via ban reason
4 years ago
819917daf2
refactor: allow plugins to replace og:image, or specify additional og:image
...
/cc @antosik
4 years ago
0c4b875e10
fix: redis batch
4 years ago
3261edcc32
fix: redis processing batch+1 items every iteration
4 years ago
8b576a3704
fix : #9560 , don't save post diffs if content didn't change
4 years ago
2657804c1f
fix : #9790 , fix sorting of more than one page of pinned topics
4 years ago
3ecbb624d8
fix: privileges added by plugins ( #9802 )
...
* fix: privileges added by plugins
when copying a categories privileges, privileges added by plugins will be copied as well
when purging a category privileges added by plugins will be purged as well
show plugin privileges in privileges.<categories/admin/global>.get
show plugin privileges in privileges.<categories/admin/global>.userPrivileges
show plugin privileges in privileges.<categories/admin/global>.groupPrivileges
* fix: typo
4 years ago
71ed50b9c1
fix : #9800 , don't send all welcome test emails to test@example.org @julianlam
4 years ago
92d1ee31e4
Add authenticateRequest middleware ( #9795 )
...
* Add authenticateRequest middleware
to Post routes
* Fix linting error
4 years ago
397835a05a
feat: allow removing multiple items from list
4 years ago
7f48edc02a
feat: add uid to filter:user.saveSettings
4 years ago
84ff1152f7
feat: headers for global privs #9717 ( #9762 )
...
* feat: headers for global privs #9717
* fix: don't spoil headers to adminPrivs
Co-authored-by: Julian Lam <julian@nodebb.org>
4 years ago
006fc700dd
feat: add ACP option to require email address on new registration
4 years ago
34afb74762
fix: browsers autocompleting smtp fields when they should not
4 years ago
bf0c02a71e
feat: a slightly less ugly rewards panel
4 years ago
a7855c4cc4
fix: dashboard graph controls
4 years ago
0ce4b87d85
fix : #9781 ( #9782 )
4 years ago
856ba78a5f
fix: replace logic in isPrivilegedOrSelfAndPasswordMatch to use privileges.users.canEdit
4 years ago
cdaea61136
fix: handle missing uid in deprecated socket call
4 years ago
0a41741b7e
refactor: deprecate picture update socket call, new API routes for picture update
4 years ago
e33e046f15
fix: use privileges.users.canEdit for image upload priv check
4 years ago
a48bbdbfe3
fix: errors from registerComplete
4 years ago
60de084475
fix: simplify logic for fullname and email blanking in user retrieval (getUserDataByUserSlug)
...
Previous logic seemed to match the logic used in privileges.users.canEdit, except
the latter allows plugins to modify the value.
4 years ago
1e2bda13d0
fix: lint
4 years ago
488f0978a4
fix: manifest error
4 years ago
72710b8040
fix : #9772 , regression from 70a04bc105
4 years ago
dd4e66e22c
fix: push back some deprecations, remove deprecated stuff scheduled for v1.18.0
4 years ago
1f91a31327
Priv hook fix ( #9775 )
...
* fix : #9773 , fire hooks properly for priv changes
* fix: admin/global group privs
dont allow invalid privs
4 years ago
4ac701d747
fix: deprecate userData.showHidden as it is functionally equivalent to userData.canEdit
4 years ago
6869920e06
fix : #9773 , fire hooks properly for priv changes ( #9774 )
4 years ago
6afeac375b
fix: automated tests are a good thing to have
4 years ago
ae793b4a44
chore: found some hooks that don't play well docgen
4 years ago
3df79683f5
feat: create folders in ACP uploads #9638 ( #9750 )
...
* feat: create folders in ACP uploads #9638
* fix: openapi
* test: missing tests
* fix: eslint
* fix: tests
4 years ago
61f02f17d8
feat: column based view on wide priv. tables ( #9699 )
...
* feat: column based view on wide priv. tables
* fix: add group/user
* feat: copy buttons to work on visible privs
* feat: show what's being copied in modal
* feat: optional title and message for category selector modal
4 years ago
e59d357533
feat: als ( #9749 )
...
* feat: als
* fix: up test timeout
* fix: don't overwrite caller if it already exists
* fix: up test timeout for psql
4 years ago
dd15065706
Fix [MONGODB DRIVER] Warning: bulk operation `remove` has been deprecated, please use `delete` ( #9746 )
...
Co-authored-by: Brophy <paul.brophy@bastage.net>
4 years ago
0743554dd4
fix: pluginPaths
4 years ago
13878e9f14
fix : #9730 , show warning if plugin is active but not installed
4 years ago
c354cde347
fix : #9719 , only apply to non https
4 years ago
6659e95a4a
refactor: remove promisify from redis, ioredis supports promises nati… ( #9728 )
...
* refactor: remove promisify from redis, ioredis supports promises natively
* refactor: remove unused util
4 years ago
a288f51f42
fix: allow smaller than 5mins for admin relogin duration
...
setting the value to 1min in ACP wasn't working
4 years ago
794bf01b21
feat: allow changing default search in
4 years ago
9de64bf516
fix : #9698 , pass along query params in redirect
4 years ago
358ad74054
feat: closes #9684 , allow event deletion
...
fix: topic events appearing before necro messages
feat: add move topic event
feat: add ability to delete specific topic events via events.purge
4 years ago
a370c26f73
feat: re-add FontAwesome font for compatibility
4 years ago
093ac1c09a
fix: remove unnecessary quote
4 years ago
41762e6603
feat: update to FontAwesome 5.15, resolve #6976
4 years ago
8fb53252a8
refactor: get rid of async.waterfall/each
4 years ago
42dbd40253
refactor: remove unused async
4 years ago
6b6a7d4b8a
refactor: remove waterfall
4 years ago
d509a307f0
Remove some deprecated/unnecessary code ( #9688 )
...
* refactor: remove mkdirp promisify
* refactor: remove old session deletion API route
* refactor: remove middleware.isAdmin
* refactor: remove templateValues.config.bootswatchSkin
* fix: unused dependencies
4 years ago
0c81642997
fix : #9681 , update posts in queue if target tid is merged
4 years ago
4a521ea218
fix: email update interstitial to not error on empty email field (on new registration)
4 years ago
70a04bc105
feat: removed registerAndLoginUserCallback local helper, added handling if a bad interstitial doesn't go away nor throw errors
4 years ago
0e05cbe1f7
feat: show instructional modal after email change request
4 years ago
e95df2f066
refactor: move interstitials into its own file in `src/user/`
4 years ago
324a12b6c3
feat: return back to profile after editing email
4 years ago
b3c916414b
feat: allow registration interstitial abort to also follow returnTo
4 years ago
96398faa3c
feat: plumb current session id into email removal/confirmation flow, so all other sessions are revoked except for the current session
...
This utilises the new argument in user.auth.revokeAllSessions
4 years ago
b0a4a1d3e4
feat: allow revokeAllSessions method to revoke all sessions except that which is passed in (new arg)
4 years ago
f53fc1ad0b
feat: return generic 404 on invalid confirm code
4 years ago
824a72b220
fix: updated ACP > Manage > Users to handle users with no email address
4 years ago
d5b5b7d531
fix: allowed reset and reset_notify emails to go out to unconfirmed email addresses
4 years ago
ccf004f1f4
refactor: added user.email.remove method, updated email interstitial to handle email removal
4 years ago
414d733d76
fix: bug where confirmation email was sent to the old email address, not the new one
4 years ago
3bcd1f1438
fix: email validation flow, so that it actually works, fixed event logging bug, new email verification template
4 years ago
caf8968791
fix: accidental early return in confirmByCode, tests, race condition
...
A race condition caused mongo/psql tests to fail.
4 years ago
a917210c5b
feat: invites no longer require email
4 years ago
81611ae1c4
fix(emails): broken test for api/user/email/:email
...
+ fixed broken tests due to unexpected behaviour for email confirmation
4 years ago
c4e3362bd3
feat(emails): restore ability for admins to edit a user's email address [breaking]
...
The edited user's email will be automatically confirmed
4 years ago
afd2d8dab1
feat(emails): pass req in to filter:registration.interstitial
4 years ago
7d115c8ef2
fix(emails): dont allow retrieving user data if showemail is false @julianlam
4 years ago
e726048e0c
fix(emails): don't automatically associate email during user creation if passed in at registration
4 years ago
f52919990b
feat(emails): display current email in interstitial form
4 years ago
b4b65ecd98
fix(emails): remove debug log
4 years ago
087e6020e4
refactor(email): validation checking methods, +tests fix
4 years ago
50517020a2
feat(emails): upgrade script for includeUnverifiedEmails
4 years ago
be97aa6f13
feat(emails): +includeUnverifiedEmails ACP setting
4 years ago
69c96dd23c
refactor(emails): more work in update email interstitial, interstitial skipping, email change on confirmation, deprecation of requireEmailConfirmation
4 years ago
f365bc4600
refactor(emails): interstitial for adding/updating email
4 years ago
74aaa0a926
feat: show different registration intersitial lead text on new account vs. existing
4 years ago
7c1d1c777b
refactor(emails): remove email validation on client and server side
4 years ago
12b2a979a0
feat: removal of emailExists socket listener
4 years ago
04b1f702cd
feat: add loggedin/guest class to body
4 years ago
340ccb2498
style: lint fix
4 years ago
d1959a258b
fix : #9670 return 4xx errors instead of 5xx on flag routes, when unauthenticated or not privileged [breaking]
4 years ago
6c47a060c1
fix : #9668 , add raw info to psql database page
4 years ago
ef4e74bfc8
refactor: client-side to use flag notes API
4 years ago
cc6cbfcdc4
Flags API ( #9666 )
...
* feat: new routes for flags API
+ flag get
+ flag creation, migration from socket method
+ flag update, migration from socket method
* fixed bug where you could not unassign someone from a flag
* feat: tests for new flags API
added missing files for schema update
* fix: flag tests to use Write API instead of sockets
* feat: flag notes API + tests
* chore: remove debug line
* test: fix breaking test on mongo
4 years ago
4a56388ec3
feat: store topic tags in topic hash ( #9656 )
...
* feat: store topic tags in topic hash
breaking: remove color info from tags (use css)
* fix: remove unused tag modal
* fix: tag search
4 years ago
415416d2a7
fix: translate language keys if passed in to formatApiResponse
4 years ago
7036c3751e
feat: internationalize API error messages
4 years ago
a54a3ee1ca
fix: return proper API-style response if exception caught by error handler on v3 routes [breaking]
4 years ago
ff78969c2c
fix: lint
4 years ago
55d7e55867
fix: tests
4 years ago
6ed7e937ce
refactor: fix wording
4 years ago
47c8c69264
fix: keep query string on redirects
4 years ago
5fd190f7c4
feat: #9651 , change category desc to multiline
4 years ago
8e0561f226
perf: cache Topics.getTopicsTags
4 years ago
10ddfff38f
perf: bypass getMultipleUserSettings
4 years ago
e03782f218
fix(docs): #9648
4 years ago
c9348efbdc
feat: add merge/fork hooks
4 years ago
b896484351
fix : #9634 , re-jig top bar of Admin > Manage > Users
4 years ago
97c8569a79
fix: hide private user data in api/v3/users/[uid]
4 years ago
d9e2190a6b
fix: numThumb upgrade script
4 years ago
fee782c436
fix: acp dashboard sometimes not loading on cold load
4 years ago
849049765b
fix : #9636 , sanitize all attributes in meta and link tags
4 years ago
acdbd04913
fix : #9627
4 years ago
db65360c0d
fix(post-queue): moderatedCids is an array of numbers ( #9631 )
4 years ago
52596902a6
feat: #9617 update fa link
4 years ago
909db3ae71
Merge branch 'master' of https://github.com/NodeBB/NodeBB
4 years ago
ab6f062ff9
fix: prevent crash in expandObjBy #9618
4 years ago
1bf263c4a2
9622 ( #9625 )
...
* fix : #9622
dont allow regular user to remove system tags
* refactor: add guest/spider check to isPrivileged
string/trim tag
4 years ago
0d975bc4fb
fix: dont show system tags in whitelist dropdown to regular users
4 years ago
84e065752f
fix : #9622 ( #9623 )
...
dont allow regular user to remove system tags
4 years ago
73f40e96a5
fix : #9620 , fix notif delay
4 years ago
c92fc19b5c
fix : #9619 , add group chat filter to /notifications
4 years ago
3cd9434b56
fix: scope
4 years ago
1eda538da5
fix : #9615 , catch exceptions in renderOverride
4 years ago
46a454f194
feat: add bodyClass to 500 page
4 years ago
8168c6c407
fix: purge uploaded images accordingly #9606 ( #9611 )
...
* fix: purge uploaded images accordingly
* fix: tests
* fix: relative paths
4 years ago
a2400f6baf
fix: accidental unnecessarily strict conditional that effectively rendered SSO state checking opt-in instead of opt-out
4 years ago
f9728aff2c
feat: clear reset tokens on successful login
4 years ago
5c42b3eab0
test: fixed broken tests from #9605 , removed token clean on token usage as it is superceded by token clean on generation (+ associated test)
4 years ago
f6c14d6b62
fix: introduce artificial delay + delay fudging on invalid email during reset token generation
4 years ago
229f96f872
fix : #9605 , expire all active reset tokens for a uid if that uid generates a new one
4 years ago
8c952aa381
fix: lint
4 years ago
be19f27f40
feat: add filter:categories.categorySearch
4 years ago
cc0cf99fed
feat: allow nested properties on category page ( #9601 )
...
* feat: allow nested properties on category page
* fix: remove debug
* fix: remove debug
4 years ago
8ea58432c9
feat: show ip on acp manage users
...
update url on search
show matching ip when searching by ip
add ip to export csv
4 years ago
6695927ea9
fix: pagination on acp users search
4 years ago
05cc7ccb60
feat: make undoTimeout configurable, closes #9599
4 years ago
2b42e7edb0
chore: lint
4 years ago
6f73261186
fix: extra ')'
4 years ago
d07229aa6b
chore: fix indentation
4 years ago
edcba61aa9
fix: disallow editing of other users' notes
...
Feel free to close this if it is intentional, but as you are not allowed to delete other users notes I expect you shouldn't be able to edit them. Editing another users post also changes ownership, allowing you to then delete it.
I also added `error:` to the errormessage so that they display properly.
4 years ago
ca72aa93d7
Locks bug failing test ( #9595 )
...
* test: failing test for issue
* fix : #9593 , don't lock if email is identical to username
* fix: lock calls after first call
* fix: add back email check
* test: remove invalid test
Co-authored-by: Julian Lam <julian@nodebb.org>
4 years ago
816856b0c6
feat: introduce boolean res.locals flag to bypass session reroll (used by session-sharing)
...
The session reroll logic is still standard practice, but in some cases, it is not necessary or causes UX issues. An issue opened in session sharing (julianlam/nodebb-plugin-session-sharing#95 ) brought this to attention in that parsing the cookie to log in the user caused a reroll (as expected), but caused the session open on other tabs to be mismatched. If "re-validate" was turned on, it basically meant that it was not possible to use NodeBB with multiple tabs.
Session sharing now sets `reroll` to `false` if re-validate is enabled.
4 years ago
286644d0b8
fix : #9592 , check session
4 years ago
3717df610a
fix: don't crash if session doesn't exist
4 years ago
66cae54ee3
fix: lint
4 years ago
57e46e41e3
feat: allow modifying default category privileges
4 years ago
16e0bca570
fix: improper use of filename extensions
4 years ago
d8d6c98970
fix: return null
4 years ago
ac7b093f99
feat: add filter:notifications.create
4 years ago
3fb7444580
fix: returnOriginal deprecation
...
https://github.com/mongodb/node-mongodb-native/pull/2808
4 years ago
3d5fef6e80
feat: pass req.query to getUnreadData
4 years ago
d2960aeb09
feat: added GET user route for api v3
4 years ago
48b8e3bb3f
fix: error when trying to trim an object
4 years ago
9ebfdeb7ee
fix : #9580 , proper 404 when ajaxifying
4 years ago
09f5179216
fix: lint
4 years ago
77dde41f7b
feat: keep query string when redirecting category
4 years ago
951e71a0e5
fix : #9567 fix tests
4 years ago
5215c30ade
fix : #9567 , use regular 404
4 years ago
3d6bdeb3df
feat: add req.query to flags.list/getCount
4 years ago
d35c64b1a2
feat: add filter:flags.getFlagIdsWithFilters
4 years ago
1ec9739629
switch to request-promise-native ( #9561 )
...
* refactor: cli/upgrade async/await
async/await cli/upgrade-plugins
remove unused payload.files
* fix: add missing await
* refactor: use request-promise-native
4 years ago
ac86937c88
refactor: cli/upgrade async/await ( #9558 )
...
* refactor: cli/upgrade async/await
async/await cli/upgrade-plugins
remove unused payload.files
* fix: add missing await
4 years ago
1ce595083a
fix: ioredis upgrade fix, maybe
4 years ago
4afca6900b
feat: add filter:user.getWatchedCategories
4 years ago
1d9cfe1e96
fix: bug where interstitial errors were not properly passed to the front-end via req.flash
4 years ago
518157d9fa
feat: pass req.query to getUserDataByUserSlug
4 years ago
0551642a35
fix : #9553 , use same fields for user search results in acp
4 years ago
94c12e3771
feat: #9508 , add cluster support
4 years ago
a3d6c56ec3
feat: #9551
4 years ago
ffa8016355
fix: lint
4 years ago
fad5988ed6
fix: tests
4 years ago
074ee859c4
fix: tests
4 years ago
1f3e660108
feat: add template to hook
4 years ago
a2442ee914
feat: add filter:account.getPostsFromUserSet
4 years ago
dd81dd03e0
fix( #9508 ): switch to ioredis ( #9545 )
...
* switch to ioredis
also need this fix in redisearch:
redis-search.js:98
```
redisClient.multi(cmds).exec(function(err, ids) {
if (err) {
return callback(err);
}
var errRes = ids[resultIndex];
if (errRes[0]) {
return callback(errRes[0]);
}
callback(null, errRes[1]);
});
```
* dbsearch compatible with ioredis
* fixed dbsearch?
4 years ago
0096cf178a
refactor: bubble other errors
4 years ago
a9bb108802
fix: wrong error message checked
4 years ago
ec6d1e2321
fix : #9507 session reroll causes socket.io to become confused ( #9534 )
...
* fix : #9507 session reroll causes socket.io to become confused
* fix: added return
* fix: simpler logic for error handling
* fix: overly sensitive catch
4 years ago
f6b583bb9d
feat: #9533 , allow redirect in build hooks
4 years ago
2c22b06feb
fix: isObjectField(s) empty field
4 years ago
7c1e163d82
Revert "feat: add _hooks metadata object to all hooks that have object-type params"
...
This reverts commit 46899ccadb
4 years ago
46899ccadb
feat: add _hooks metadata object to all hooks that have object-type params
4 years ago
d8e4fd4cdd
feat: add filter:categories.copySettingsFrom
4 years ago
084c985117
feat: guard against multiple resolves
4 years ago
5fe97b9c2e
revert: sync hooks
4 years ago
6ed8890c2e
fix : #9512 , fix chat icon if no privileges
4 years ago
b40fc4b64d
feat: #9511 send notifications on accept/reject
4 years ago
a478dc7ee8
feat: add filter:middleware.autoLocale
4 years ago
308252f566
fix : #9503 , dont error in markUnread if room doesnt exist
...
this prevents deleting the user if they are the only person in the chat room
4 years ago
9e07efc126
fix: use socket.request.headers
4 years ago
ed534f34f5
fix: buildReqObject headers for socket.io calls
4 years ago
01956af43a
feat: remove sync hooks support
4 years ago
4e490f6058
test: fix redis tests
4 years ago
92de49be00
test: add test for undefined fields in getObjectsFields
4 years ago
1db8920b18
refactor: make debug handler async
4 years ago
8b79c7f139
fix: regress. rescheduling shouldn't add to sets that pinning removed… ( #9477 )
...
* fix: regress. rescheduling shouldn't add to sets that pinning removed from
* test: remove the also from tests
4 years ago
9b71b087ec
feat: lang strings
4 years ago
435067aa5f
test: remove logs
4 years ago
2ea468daa3
test: clear cache between runs, require middleware later in helpers
4 years ago
d15e27107e
test: log
4 years ago
354e0a822d
test: remove equals
4 years ago
4dd3844680
fix: logic is hard
4 years ago
2e9efc0e8a
fix: wrong variable for cache
4 years ago
fa0c92a7c4
fix: eslint
4 years ago
ea22cd302a
fix: use req.ip instead, since guests can upload as well
4 years ago
a9978fcfd2
feat: rate limit file uploads
4 years ago
36f119a96a
fix : #9492 , keep query params on redirect
4 years ago
8faa6e4515
feat: filter flags by username #8489 ( #9451 )
...
* feat: filter flags by username #8489
* feat: toggle flag filter text
4 years ago
1fee6a702a
fix : #9487 , session data gathered during a session is lost upon login
...
e.g. returnTo, tids_viewed, etc.
4 years ago
697ed3bf37
feat: roll session identifier on login, as security best practice
...
see: https://owasp.org/www-community/attacks/Session_fixation
4 years ago
e845c34b52
fix: registration interstitials not handling promise rejections properly
4 years ago
4494728cf8
feat: allow different slugs
4 years ago
60eed8d89f
fix: let recent replies respect oldest/newest sort settings
4 years ago
6907837fce
fix : #9483 , fix events count display
4 years ago
161081e960
fix: escape flag reason
4 years ago
fd3bc605c6
feat: remove sort again
4 years ago
2dc3283f19
fix: updateCategoryTagsCount
4 years ago
f9df6431c9
revert: revert tag sort
4 years ago
036f935fa9
fix : #9473 ( #9476 )
4 years ago
397baf0254
refactor: widgets ( #9471 )
4 years ago
f65d2162f8
feat: update hook
...
Hook payload updated to pass login strategy (if overridden, this value will be something other than 'local'), and explicitly pass error if the login failed.
4 years ago
f32ea1737a
fix : #9466 , don't call leaveRoom in maintenance mode
4 years ago
a0dd90804c
fix: exempt ST from being del/res via last main posts ( #9468 )
4 years ago
784600d930
fix : #9462 , on install copy default favicon
4 years ago
05f2236193
feat: add reverse of recent to getSortedTopics
4 years ago
9c52fd2e74
fix : #9450 express session saved even if saveUninitialized explicitly passed in
4 years ago
285aa36556
feat: allow exists methods to work with arrays and single id
4 years ago
d16b45fd2d
feat: pass all data to filter:category.get
4 years ago
aa0137b1c4
feat: rescheduling (editing ST) ( #9445 )
4 years ago
9e1f72a435
feat: optional urlMethod param for loginStrategies
4 years ago
2a03012e2c
fix: ./nodebb help with commander@7 ( #9434 )
...
hopefully this one last as long as the last one did
4 years ago
728ac5ff72
perf: increase batch size for notifs, run parallel
4 years ago
344575dde1
feat: add hooks to language loading ( #9426 )
...
and flushNamespace method
4 years ago
edf80cfb3b
fix: hide titleRaw for deleted topics as well
4 years ago
a1ee1a2a76
chore: remove log
4 years ago
c5dda64fa8
fix : #9410 , fix post queue
...
items in the cache were parsed over and over again
4 years ago
9052db930f
fix: privilege tables
4 years ago
077330b764
feat: scheduled topics ( #9399 )
...
* feat: scheduled topics
* refactor: linting fixes
* fix: tests
* fix(test): race condition
* fix: make a single request
4 years ago
67b09cba5f
fix : #9420 , paginate after loading notifications
4 years ago
e42b152f16
fix : #9414 , use posts:view_deleted
4 years ago
a94d96514e
feat: show link if category is a link
4 years ago
2ceda70a97
fix: preserve order when changing parent
4 years ago
d00268c9b8
refactor: style, no need to convert length to string
4 years ago
d8ff9851a3
fix: typo in switch..case
4 years ago
801570e4cf
fix : #9404 , show signatures if the target user has signature privilege
4 years ago
75553b246c
fix: sorting when filtering by uid
4 years ago
98b72ca572
fix: allow local (and overridden) login strategies to pass Error objects back
4 years ago
6aa60b63b5
fix: category search not using uid
4 years ago
56523aa148
revert: change toPid truthy
4 years ago
90d64fe1df
fix : #9398 , crash on post flag
4 years ago
a8f7b24452
fix : #9395 , pass all data from client to Topics.reply ( #9396 )
...
* fix : #9395 , pass all data from client to Topics.reply
so plugins can set custom fields
refactor and use setDefaultPostData
* fix: circular json error
* refactor: change params
4 years ago
4ac38ab2bc
fix: lint
4 years ago
eb360351e5
fix : #9394 , fix guest handles
4 years ago
5c59354c58
fix : #9389 , allow admins to add themselves to private groups
4 years ago
4327a09d76
feat: allow optional fields argument on db.getObject(s) ( #9385 )
4 years ago
f316c4d4b8
refactor: remove uncessary check
4 years ago
e789fe8d2a
fix : #9383 , don't show deleted topic titles in inf scroll
4 years ago
cc489708ee
fix : #9378 , crash on verifyToken if API Token settings not saved (null case error)
4 years ago
35700d1634
fix: closes #9382 , fix digest topic links
4 years ago
668508cc37
feat: closes #9380 , add category filtering and topic tools to tag page
4 years ago
34b9aaedee
feat: allow sync function ( #9379 )
...
* feat: allow sync function
* fix: remove async
4 years ago
e725beaa4a
Revert "feat: allow filter functions that return promises or the data directly"
...
This reverts commit e6c52cf26c
4 years ago
e6c52cf26c
feat: allow filter functions that return promises or the data directly
4 years ago
53f67ff396
fix: regression from filter hook change
4 years ago
52082e1296
feat: add resolve flag to post tools
4 years ago
2a939aad8d
fix: regression via c1b3079d93
...
Also refactored privilege render logic so that it no longer needs a server-side hack to render column count
4 years ago
4cbd13fd9c
feat: hide revert button in ACP > Privileges until privileges change
4 years ago
46270f9f20
feat: bring back static hook timeout
4 years ago
d05d7091ae
refactor: remove async.each/reduce from hooks for better stack traces
4 years ago
0d3979efd0
refactor: use hooks.fire
4 years ago
9382fc6dc5
fix : #9370 , show correct teaser index if sorting is newest to oldest
4 years ago
1982edfde3
refactor: fix variable name
4 years ago
3c60ccfd4d
feat: upgrade connect-mongo, closes https://github.com/NodeBB/NodeBB/pull/9367
4 years ago
f71cb0e427
feat: pass interstital errors to individual partials as well as to registerComplete
4 years ago
5eb3132dae
feat: add filter:plugins.firehook
4 years ago
ebccc7940b
fix: don't copy if src doesn't exist
4 years ago
754283d37b
feat: copy default favicon if it doesn't exist
4 years ago
771a8955a4
fix : #9362 best not to check file exists on every page load; copying favicon to uploads/system folder instead
4 years ago
ad5654952a
fix : #9362
4 years ago
678e8f0fde
fix: regression where login redirect for admin routes didn't go to local=1
4 years ago
4b5450853d
feat: allow missing (or non-array) middlewares argument in route helper methods
4 years ago
e74df53997
feat: pass modified params, only affects filter hooks
4 years ago
696c489524
feat: add back topic id input
4 years ago
166d65a1ba
fix: add back middleware.authenticateOrGuest
4 years ago
e3b2c00db1
fix: request authentication called twice in account routes
4 years ago
7da061f0d7
refactor: automatically authenticate all requests setup through route helpers ( #9357 )
...
* refactor: automatically authenticate all requests setup through route helpers
* fix: removed connect-ensure-login dependency
* fix: bug with some middlewares not defined outside route helper methods
4 years ago
3aa26c4df2
fix : #9339 , only log email errors once per digest, notification push
...
show notice in acp
4 years ago
3f42d40c78
fix: winston.info
4 years ago
0021c6019e
refactor: async listen testSocket
4 years ago
c5e257888a
fix : #9351 bad logic when inserting rows to privilege tables, also a missing tfoot 🦶
4 years ago
bfd512b99b
feat: expose username validation logic to user lib, new hook `filter:username.check`
4 years ago
e5133a78f8
feat: add $.deserialize to client side
4 years ago
902a88c25e
feat: remove promise-pollyfil
4 years ago
c1b3079d93
feat: category privilege API routes
...
closes #9342
4 years ago
c8b78654d9
fix: bad assignment
4 years ago
fbe9215b17
fix : #9348 incorrect redirect via connect-ensure-login
4 years ago
0af9d26fe5
feat: change uploadCroppedPicture to use updateProfile as well
4 years ago
a598abcd8e
feat: use updateProfile for picture change
...
so it triggers action:user:updateProfile
4 years ago
f806befd2f
fix: bug where loginSeconds setting was ignored for local login
4 years ago
1155b0c42f
feat: allow payload to be passed to emailer test method
4 years ago
00a68a9548
feat: add additional flag hooks [breaking]
...
`action:flags.create` on initial flag creation
`action:flags.notify` on notification to admins and moderators
`action:flags.addReport` on flag report addition (called during initial flag create, too)
4 years ago
069ac60f62
feat: add uid of user who created flag to action:flags.create
4 years ago
b9fd2c87f3
chore: bump deps ( #9335 )
...
* chore: bump deps
* fix: husky git hooks
4 years ago
2737f6531b
fix: notif pruning
4 years ago
02f08111cf
feat: keep notifs for one month, load 50 notifications instead of 30
4 years ago
9bf94ad50f
fix: allow interstitial callbacks to be functional (no cb required)
4 years ago
cdf5d18f54
fix: don't publish before pubClient is connected
4 years ago
86b0c57d7a
feat: also pass in uid to `filter:email.prepare`
4 years ago
27ea3dcb2f
feat: new hook `filter:email.prepare`
4 years ago
bf90d15881
feat: new hook static:email.send
...
deprecates filter:email.send
4 years ago
0dad568cbe
perf: faster category tags upgrade script
4 years ago
95033ef756
perf: use setObjectBulk
4 years ago
a07509f770
perf: make upgrade script faster
4 years ago
48f1e265f4
fix: remove unused async
4 years ago
0959b1248b
perf: make upgrade script faster
...
use bulkAdd/remove
4 years ago
14a6c349c2
feat: show time info for upgrade scripts
4 years ago
293b7c2650
refactor: privileges, export modules directly ( #9325 )
...
fix unused/commented out methods in admin privileges
4 years ago
984c9dd915
fix: in setupPageRoute helper, buildHeader after plugin hooks have fired
...
To allow for a plugin to call doLogin and have it properly reflect in the header
4 years ago
73dc64d9ff
feat: add dashboard sub-pages to ACP menu
4 years ago
0804d54759
spec: schema docs for new ACP dashboard subpage routes
4 years ago
2f89b0d791
feat: recent logins sessions table in dashbaord subpage
4 years ago
e1ed514b10
feat: topics dashboard details subpage
4 years ago
c57c77030e
feat: update user list in dashboard/users on graph update
4 years ago
f8e1a74c26
fix: wrong qs param, allow string to be passed to util.getDaysArray
4 years ago
cc93822436
feat: show list of recent users in dashboard/users
4 years ago
6fdcae7320
feat: req.query parsing and dynamically loading data instead
4 years ago
f561799f74
refactor: abstract out some client side dashboard code into modules, analytics subpages for users, topics, and logins
4 years ago
079a13d41a
feat: new hooks for notifications get/getCount
4 years ago
0d59fe3d2b
fix( #9315 ): api v3 post, put, del JSON
...
also allow `app.alertError` to be called without an argument
also fix `./nodebb build --dev` to actually build in dev mode
4 years ago
dbe5f7027b
fix: wrong call to sortedSetAdd
4 years ago
16d3c45782
feat: report login statistics from analytics data, instead of its own zset
4 years ago
9a9f366d3b
feat: track login sessions for admin dashboard reporting
4 years ago
020f0b8322
fix: session not persisting to database in some scenarios
...
In some edge cases (e.g. SSO plugin redirecting the user immediately), with modern browsers, the request is never "completed" for speed. This causes a condition where the session object never persists to the database, even though it has changed. This added line forces a db persist on a successful login.
Context: https://github.com/expressjs/session/pull/484
4 years ago
504fd107c7
feat: track successful logins in analytics
4 years ago
d3a9e76ae2
test(user): added additional tests for icon background colour
4 years ago
955021247e
feat(user): icon background selector in change picture modal
4 years ago
fbccf6e22f
refactor(user): all plugins to change list of icon background colours
...
One notable change is line 200, where a conditional was changed. The conditional used to check for `user.hasOwnProperty('picture')` and was added so that icons would only be included in the response if the picture was requested. This doesn't seem to apply as picture could be set regardless (see default avatar logic above), so I explicitly check `requestedFields` now.
4 years ago
ed3d9dcbbf
feat: pass post object to filter:post.tools
4 years ago
0e07f3c9ba
feat: allow defining a list of system tags
4 years ago
25c8f02634
fix : #9307 , use _.flatten
4 years ago
2fef462782
fix: awaiting res.render in send404 controller
...
>
> A plugin wanted to use `response:rotuer.page` to 404 a specific page on some condition. res.render returns early in send404 and so must be awaited otherwise multiple responses will be sent
4 years ago
65c57c730c
docs: added comment re: #9305
4 years ago
34096b73ef
fix: do not overwrite `config.port` from URL, if it's already set
...
If URL was set to something like `http://example.com:8080 `, and port
was set to 4567, keep listening on port 4567 and keep linking through
URL that was specified.
This allows to listen on port 4567, while having NGINX (or any proxy)
set to listen on port 8080 and route traffic to port 4567.
So NodeBB can be "hidden" behind proxy while URL can still contain
non-standard port, i.e., port different than 80 and 443.
4 years ago
8686fbfa3f
fix: switch back to getSortedSetRange
...
/cc @barisusakli
4 years ago
9ce6f8ad93
feat: add tag filter to getSortedTopics
4 years ago
5286f20862
refactor: remove dupe code
4 years ago
7223074f1d
feat: ability to re-order topic thumbnails
4 years ago
91734a6484
fix: settings v3
4 years ago
0738dae895
feat: #9304 , add category/topic/username to post queue notification emails
4 years ago
8f0386d9ac
feat: add failing test for list append/prepend with list ( #9303 )
...
* feat: add failing test for list append/prepend with list
* feat: mongo/psql
* feat: improve test
4 years ago
1ae8dda8a8
chore: extra console.log
4 years ago
7ebb6d3056
fix: thumbs.associate logic fix + tests
4 years ago
7665adf7d1
fix: missing awaits, possible test fix
4 years ago
9a6cf3d967
fix : #9301 , dont call sitemapstream if there are no entries in categories/pages/topics.xml
4 years ago
50664487b9
test: additional tests for topic thumbs
4 years ago
807b0d4348
fix: properly incase its the same path
4 years ago
76bcc0c99c
fix: numThumbs count on associate
4 years ago
1490b32d1b
fix: missing cache deletion calls for post-queue cache
...
/cc @barisusakli
4 years ago
3e6640efb2
refactor: thumbs.associate accepts both relative path and url in path arg
4 years ago
a4b4a5566d
feat: link to post-queue from topic event
4 years ago
8fd78ce512
feat: post-queue topic event
4 years ago
3f35fd335d
feat: add post-queue cache
4 years ago
36f2021186
refactor: move post queue retrival code to posts.getQueuedPosts
4 years ago
b81508c4e2
fix: init topic events from webserver.js
4 years ago
6074a0fbbf
refactor: call topic events init from within file itself
4 years ago
cc275e1016
Revert "feat: newsletter opt-in/out in UCP, closes #21"
...
This reverts commit 3c7cd9a6c4
4 years ago
3c7cd9a6c4
feat: newsletter opt-in/out in UCP, closes #21
4 years ago
3595473485
feat: load user posts/topics via xhr on infinitescroll
4 years ago
b753c69cfe
fix: check null topics
4 years ago
58cd797e4c
fix: guard against null topics
4 years ago
c953b1b3d1
fix : #9292 , messageobj.content already parsed
4 years ago
4b2bf12fd1
feat: #9294 , put new categories at top
4 years ago
9d17f397c0
fix(remountable-routes): more fixes to remountable routes
...
fix: ensure proper admin privilege checking on remounted `/admin` mount
fix: guard against plugins sending back missing mounts
fix: no need to make addRemountableRoutes awaitable
4 years ago
16c1d6e937
style(remountable-routes): abstract removable routes code to a separate local fn
4 years ago
1f28713f1a
refactor(remountable-routes): rename `src/routes/accounts.js` to `src/routes/user.js` to better match the route prefix
4 years ago
bc68e990af
fix(remountable-routes): bug with user routes remounting to itself
4 years ago
9021f071d4
feat(remountable-routes): allow category and account routes to be remounted
4 years ago
f01af62b53
feat(remountable-routes): allow /admin and /post to be remountable
4 years ago
92758ec50d
refactor(remountable-routes): allow certain route prefixes to be mounted elsewhere
4 years ago
765db86d4e
fix: clear category cache on copy parent
4 years ago
ed3e9ce2e2
fix: delete category cache key on category create
4 years ago
c61cc37bba
fix: typo
4 years ago
cf4002bcc9
perf: cache base_url
4 years ago
5ce2820799
perf: single call to get digest topics, dont send duplicate topics
4 years ago
90d5c9da44
perf: single db call to add all uids
4 years ago
a5fa212fc7
fix: wait for event.log to finish before killing process
4 years ago
0185ea1b4f
perf: make digests a little bit faster
...
and use batch.processArray
dont load data for users who have no email or have not confirmed their emails
4 years ago
b6493f896f
fix: tests, only generate csrf_token on 404 gets
4 years ago
94f72d6093
fix : #9287 , generate csrf_token on 404
4 years ago
783786cf8c
fix: do not blindly escape a notification's bodyLong
...
For 7+ years we were escaping this value, but it is in many cases already sanitized (as it may be a post content). For those cases when it is not, I now run it through parse.raw.
Instead of escaping, it now strips p, img, and a tags.
4 years ago
670cde78da
feat: add invalid event name to error message
4 years ago
cc9d6fd08b
chore: eslint max-len
4 years ago
5c2f0f0557
chore: eslint no-restricted-syntax
4 years ago
115d19e289
chore: eslint prefer-rest-params, prefer-spread
4 years ago
23f212a4c0
chore: eslint prefer-destructuring
4 years ago
8d1462ffd8
chore: eslint object-curly-newline
4 years ago
62869bae3d
chore: eslint function-paren-newline
4 years ago
dab3b23575
chore: eslint no-var, vars-on-top
4 years ago
b56d9e12b5
chore: eslint prefer-arrow-callback
4 years ago
707b55b6a5
chore: eslint prefer-template
4 years ago
4ee0f1459d
chore: eslint import/newline-after-import
4 years ago
dad01e3051
chore: eslint no-bitwise
4 years ago
fca17cb713
fix: move service worker back to relative_path/service-worker.js
4 years ago
a4878a5b22
fix: markread selector
4 years ago
7eebcbdbbc
perf: only load thumbs for topics that actually have thumbs
4 years ago
47299ea587
Categories refactor ( #9257 )
...
* feat: wip categories pagination
* feat: add subCategoriesPerPage setting
* feat: add load more sub categories button to category page
* fix: openapi spec
* feat: show sub categories left on category page
hide button when no more categories left
* breaking: rename categories to allCategories on /search
categories contains the search results
* fix: spec
* refactor: remove cidsPerPage
* fix: tests
* feat: use component for subcategories
* fix: prevent negative subCategoriesLeft
* feat: new category filter/search WIP
* feat: remove categories from /tag
* fix: dont load all categories when showing move modal
* feat: allow adding custom categories to list
* breaking: dont load entire category tree on post queue
removed unused code
add hooks to filter/selector
add options to filter/selector
* feat: make selector modal work again
* feat: replace old search module
* fix: topic move selector
* feat: dont load all categories on create category modal
* fix: fix more categorySelectors
* feat: dont load entire category tree on group details page
* feat: dont load all categories on home page and user settings page
* feat: add pagination to /user/:userslug/categories
* fix: update schemas
* fix: more tests
* fix: test
* feat: flags page, dont return entire category tree
* fix: flag test
* feat: categories manage page
dont load all categories
allow changing root category
clear caches properly
* fix: spec
* feat: admins&mods page
dont load all categories
* fix: spec
* fix: dont load all children when opening dropdown
* fix: on search results dont return all children
* refactor: pass all options, rename options.cids to options.selectedCids
* fix : #9266
* fix: index 0
* fix: spec
* feat: #9265 , add setObjectBulk
* refactor: shoter updateOrder
* feat: selectors on categories/category
* fix: tests and search filter
* fix: category update test
* feat: pagination on acp categories page
show order in set order modal
* fix: allow drag&drop on pages > 1 in /admin/manage/categories
* fix: teasers for deep nested categories
fix sub category display on /category page
* fix: spec
* refactor: use eslint-disable-next-line
* refactor: shorter
4 years ago
e40af441c9
fix: cache key collision
4 years ago
a6fa351b72
feat: pass req.session into buildReqObject
4 years ago
4f97639009
feat: new hook `action:login.continue`
4 years ago
67e3fb6498
fix: register returnTo logic to match login route
...
Login route saves the previous page by checking for the X-Return-To header. This header is automatically set by ajaxify.
Login takes this value and saves it to `req.session`.
Up until now, `/register` saved the previous URL in a hidden input, and redirected based on that value, but it occasionally conflicted with req.session.returnTo. It was also confusing because it did not match how login handled the values.
This commit updates the route handling so it works identically to `/login`.
4 years ago
492cbc6227
fix: tests
...
/cc @pitaj
4 years ago
5e5d37c38f
fix( #9252 ): pass site domain to nodemailer ( #9254 )
4 years ago
f79aeef889
fix: posts.uploads.sync dissociates uploaded thumbs of the main pid
4 years ago
c729adeb08
fix: privileges page - tweak icon position and width, group name wrapping
4 years ago
970bd06fd2
refactor: improvements
4 years ago
53e0d4d2e0
feat: banned-users group
4 years ago
cabec378f4
fix: openapi test specs
4 years ago
7c9674de6c
fix: include admins
4 years ago
a2a7557cc0
refactor: update dom after diff deletion better
4 years ago
eaf9d2e44a
fix: include admins, limit to category mods, correct privilege name
4 years ago
72b050b4a8
test: post diff deletion tests
4 years ago
eb642f40b9
feat: #9109 , ability to delete a post's diffs
4 years ago
fffdc4e0ca
feat: #9234 , add pagination to /api/recent/posts/:term?
4 years ago
2bc74cffe6
fix : #9127 , scope service worker to relative_path for the forum ( #9239 )
...
Adds a `Service-Worker-Allowed` header on `assets/src/service-worker.js` URL and uses `scope` option during registration to ensure the service worker is correctly scoped to the entire forum and only the forum.
4 years ago
d1364c3130
Categories refactor ( #9233 )
...
* feat: wip categories pagination
* feat: add subCategoriesPerPage setting
* feat: add load more sub categories button to category page
* fix: openapi spec
* feat: show sub categories left on category page
hide button when no more categories left
* breaking: rename categories to allCategories on /search
categories contains the search results
* fix: spec
* refactor: remove cidsPerPage
* fix: tests
* feat: use component for subcategories
* fix: prevent negative subCategoriesLeft
4 years ago
d6f60f4502
fix: broken test after sorted-lists logic change
4 years ago
d5d24594e8
feat: allow sorted-lists on multiple pages
...
If multiple sorted-lists were on separate pages, saving one page would erase the sorted-lists saved on the other page. This was caused by naive deletion of the sorted-lists index on settings save.
At the same time, a bug was found where if fewer items were passed in, only that many items were removed from the database, leaving leftover orphan data in the database.
The logic now:
- Only removes sorted-lists if they are passed in (and empty)
- Deletes all sorted list items, not just the items passed in.
4 years ago
9834f72fc7
fix: clear all locks on restart
4 years ago
f6cd2862bd
feat: #9232 , add profile picture into exported zip
4 years ago
a8be6fb8fb
fix: regression where `filter:settings.set` no longer received sorted-lists
4 years ago
5bc1f5b4e8
fix : #9231 , fix redis pubsub connection
...
regression from fdfbc90255
4 years ago
05c53394f3
fix: tests
4 years ago
7419922040
fix: improper override of req.body.username in login logic
4 years ago
b820d23401
feat: new hook `filter:login.override`, deprecate `action:auth.overrideLogin`
4 years ago
473d5f4aba
fix: full settings hash not passed through to action:settings.set
...
The sorted lists were being filtered out
4 years ago
eb96046e97
Revert "refactor: use Map to track sorted lists in Settings.set()"
...
This reverts commit 65de2e76b4
4 years ago
65de2e76b4
refactor: use Map to track sorted lists in Settings.set()
4 years ago
a5bf9779fd
fix : #9223 , don't overwrite stmp settings
4 years ago
3052256db3
chore: deprecation notices for plugins using plugin old hook methods
4 years ago
15ba0abb34
docs: update deprecation-removal version for plugin hook helper methods in 1.18.0
4 years ago
e8429f509b
fix: handle delete and update for categories:name zset
4 years ago
34c42c6fa3
feat: ability to search categories, #8813
4 years ago
a1c014462c
revert: bring back backwards compat
4 years ago
647d3ba810
fix: removed methods
4 years ago
fb84c78544
chore: remove deprecated `User.emailConfirm` [breaking]
...
Use `User.email.confirmByCode` instead.
4 years ago
5a775e09dc
chore: remove deprecated plugin hook `filter:privileges:isUserAllowedTo` [breaking]
...
Use `filter:privileges:isAllowedTo` instead.
4 years ago
d41de481a4
chore: remove deprecated plugin hook methods [breaking]
...
Call plugins.hooks.fire() instead.
4 years ago
cc0d562e9a
chore: more removals of thumb specific backwards-compatibility [breaking]
4 years ago
5f9f241e37
chore: remove deprecated `filter:admin/header.build` hook [breaking]
...
Use `filter:middleware.renderAdminHeader` instead.
4 years ago
84dfdfe659
chore: remove deprecated v2 style responses for thumbs upload route [breaking]
4 years ago
2ad0d0d0d8
chore: remove deprecated getObject routes [breaking]
...
`/api/post/pid/:pid`, `/api/topic/tid/:tid`, `/api/category/cid/:cid` have now been removed in favour of routes in the Write API (`/api/v3/(posts|topics|categories)/:id`)
4 years ago
7b090c588b
fix: incorrect return for Thumbs.get() if thumbs were disabled
4 years ago
dc84559d0b
feat(topic-events): topic events GET route in write API
4 years ago
449c379d22
feat(topic-events): server-side tests for topic events
4 years ago
0d4a377558
feat(topic-events): clear out topic events when a topic is purged
4 years ago
8e93bf7362
feat(topic-events): client-side handling on topic event log
4 years ago
df2fdd56ba
fix(topic-events): repeated invocations of Posts.addTopicEvents caused dupes to be added to DOM
4 years ago
cec3fc934d
refactor(topic-events): break out some logic in events.get into local modifyEvent method
...
+ events.log now returns a complete event object
4 years ago
611d1f872d
feat(topic-events): support for uids in topic event payloads
4 years ago
425eca145b
refactor(topic-events): fire topic event logging in topics/tools instead, pass uid into payload
4 years ago
ab2e1ecb40
feat(topic-events): work in progress topic events logic and client-side implementation
4 years ago
8ff07bc196
fix: update js concatenation logic to bundle scripts.rjs into minfile regardless of build environment
...
The slowdown is fairly insignificant (< .1s), and the only change is the minified file is identical across environments, which is better from a debugging standpoint
4 years ago
412d285850
fix(hooks): fallback handling for core invocations of hooks.fire
...
+ .on() which is the same as .register()
4 years ago
f975063b7d
fix : #7125 , allow list for page route, configurable via plugin hook
4 years ago
8b72479f62
fix: remove 'filters' and 'categories' from flag details API return [breaking]
...
These options were originally used when the flag filters were shown in the sidebar. This has seen been removed, and so the information is now superfluous
4 years ago
1603566bcc
fix: filtering logic of flags [breaking]
...
When combining filters, the old logic assumed that every filter was
exclusive, unless that filter contained multiple items, in which
case it was added to a list of "or" filters that returned all
matching flags.
A fault was discovered in that if you passed in multiple "or"
states, it did not return flags with the expected filtering.
e.g. open flags, closed flags, flags of cid 1, flags of cid 2
This could return open flags of cid 3, since all of the filters
were "OR"'d.
This logic change updates the behaviour so disparate OR sets are
intersected (ANDed).
4 years ago
942d924779
fix: error on flag list if no flag filters were saved in session
4 years ago
6b1c97db79
feat: feature flag for auto-resolving a user's flags on ban [breaking]
...
The default behaviour has now been changed to 'off'. Going forward, a user's flags will no longer automatically resolve on ban.
4 years ago
35c92d0cff
fix: mod cid filter accidentally saved in session
4 years ago
27cae0d5d8
fix: missing return for #9217
4 years ago
b2b1450e5d
fix : #9217 , render 400 error page on bad access to /register
4 years ago
78896fc623
fix: redis check compat tests
4 years ago
fdfbc90255
feat: async/await redis connection
4 years ago
33bf1b0e2c
feat: async/await psql connection
4 years ago
672959c13f
feat: add group name to csv event
4 years ago
a186ea0fe3
fix: registration completion overriding returnTo if it was already set
4 years ago
280285cda9
feat: allow interstitial callbacks to be async functions [breaking]
...
This change is breaking in the sense that if you have written
interstitial callbacks before that are async functions _with_ a
callback, those are no longer allowed. You will not need to call
next() as that argument will no longer be passed in to async
functions.
4 years ago
5c1b742979
fix: add missing user delete event types
4 years ago
7fb583dcfd
Merge branch 'master' of https://github.com/NodeBB/NodeBB
4 years ago
c608b0e8a3
fix: https://github.com/NodeBB/nodebb-plugin-webhooks/issues/3
4 years ago
d85ad10d34
fix: restored sanity checks for post move socket calls
4 years ago
966c4117ec
refactor(api): post move to write API
4 years ago
e118e59ce0
refactor(api): post diffs to use write API
4 years ago
c2e2370655
feat: add filter:email.cancel to allow plugins to cancel sending emails
4 years ago
f5fcd232f6
fix: regression caused by 77ab46686d
...
Access checks were added for topic GET route, but occasionally a post_uuid is passed in, which is available to everyone, and so checks should be skipped
4 years ago
4fb907875e
fix: don't crash if fullname is not a string
...
https://community.nodebb.org/topic/15291/upgrade-error-fullname-substr-is-not-a-function
4 years ago
1374e0eeba
refactor: change var to const
4 years ago
00ba89b6d6
fix : #9204 , bypass groupname length check for system group in upgrade script
4 years ago
9938a139fe
fix: add missing await
4 years ago
25ab99b91d
refactor: single remove call
4 years ago
ab11435ed5
feat: grant plugins the ability to specify options to the SSO handler
...
... to be handled in the plugin itself (overriding the passport prototype's authorizationParams method)
+ new hook filter:auth.options
4 years ago
9b289eca9d
fix: ssoState passed to strategies even if not called for
4 years ago
77ab46686d
fix: access checks for tags and thumbs get route
4 years ago
c0fb1cb59c
fix : #9194 global mods unable to pin or unpin topics
4 years ago
ef16cd2e6f
fix : #9192 , exit after logging error
4 years ago
69419571a9
fix: make sure inviter user exists
4 years ago
89e6c75d58
fix : #9185 , fix string boolean values
4 years ago
66da6bcd1c
fix : #9184 proper relative_path usage in topic thumbs.get
4 years ago
b742229e59
fix : #9169 , re-adding v2-style behaviour so as to not break the API... yet
4 years ago
aa95cc7d60
Merge branch 'master' of https://github.com/NodeBB/NodeBB
4 years ago
eaf62d39fd
fix : #9177 , handled multiple deleted users properly
4 years ago
4ede18ce5f
fix: broken test caused by errant .pop(), missing await
4 years ago
c07e1e16af
feat: add unread-count badge if navigator contains /flags route
4 years ago
6a1311b4bc
refactor: flags lib to have a separate getFlagIdsWithFilters method
...
added quick filter for unresolved flags
4 years ago
6cb5888c13
fix: unescape header navigation originalRoute [breaking]
4 years ago
03a0e72fae
refactor: split out logic dedicated to calculating unread counts, to a separate local method
4 years ago
e14b67786c
Solve Custom home page route error bug ( #9180 )
...
When you select Custom Route as home you get a 404 error "/custom not found" error.
This because 'homePageRoute' property was used instead of 'homePageCustom'
4 years ago
7069735aa2
Merge branch 'master' of https://github.com/NodeBB/NodeBB
4 years ago
da54697075
fix : #9176 , limit description size
4 years ago
97d678fd2a
fix: return a user object, not an array of user objects (in v3 login check route)
4 years ago
8c86f5bcec
fix: bad execution flow in utilities.login
4 years ago
534224133b
fix: random loadFiles added by errant vscode autocompletion
4 years ago
8bbb320867
feat: handle HTTP 429 as a response code
4 years ago
56f929ed4f
feat: add write API route for checking login credentials
4 years ago
1cf0032d9f
feat: allow override of local fns in login controller, 400 instead of 500 for wrong login type [breaking]
4 years ago
6cbb77afda
fix: add missing breadcrumb on /user/<slug>/categories
4 years ago
f0dd302c77
perf: use only required calls
4 years ago
a51c5698c7
fix: `--help` usage info
...
yargs (via nconf) would exit when detecting a help flag
also improves the speed of `./nodebb help build`
4 years ago
171017c38c
fix : #9130 , remove timestamp prefix from thumbnail names in API response
4 years ago
8c31afae7d
feat: #9173 , show installed plugin versions in ./nodebb plugins
4 years ago
b9ba44edd7
fix : #9166 missing relative path in topic thumbs modal and topic list
4 years ago
1968bf50f1
fix : #9163 , fix total connection count on ACP
...
sockets.sockets is a JS map in 3.x
4 years ago
edb8da1ef9
feat(api): closes #9123 category and topic routes migrated to Write API
4 years ago
9ecfac9b68
feat(api): #9123 , migrate rest of the getObject controllers to Write API
4 years ago
cdff8d286a
chore(api): add deprecation notices re: #9123
4 years ago
e267f29584
feat(api): #9123 , migrate /api/post/pid/:pid to Write API
4 years ago
33290850ee
fix : #9126 , skip base64 and long values
4 years ago
c1ecfd1ebf
feat: #9135 , don't try to reconnect forever
4 years ago
a555f02415
fix: inability for admins with setting privilege to save plugin settings
4 years ago
895e3d939e
fix : #9149 , server-side handling of disableChatMessageEditing
4 years ago
d27815a8c0
fix : #9149 , incorrect client-side `disableChatMessageEditing` value for admins/gmods
4 years ago
2874036024
fix: tests
4 years ago
223f0a5515
feat(acp): admin tags privilege
4 years ago
fb46a8d975
feat(acp): admins-mods privilege
4 years ago
5b8558e9a5
feat: allow dashes in privilege group names
4 years ago
3aa5beb832
feat: allow multiple privileges to be defined for a given admin socket call
4 years ago
fcc1e24ad0
feat: rename admin middleware header hook
4 years ago
da191341e8
feat(acp): added new admin privilege for groups management
4 years ago
80ee3dfbd1
fix(api): tests
4 years ago
931105e6cb
fix: dont show deleted posts in navigator
4 years ago
32e36f7b2e
feat(api): group ownership API route, switch client-side to use API route
4 years ago
1cd2689cf6
refactor(api): deprecated groups update socket in favour of API lib
4 years ago
34ccabe3ab
fix: bad assignment logic in middleware.renderHeader
4 years ago
75b1bbd09f
feat: explicitly add filter:admin/header.build hook
...
As it is not fired during middleware.processRender
4 years ago
05d8b3c339
chore: add deprecation notice to topic thumb tpl value
4 years ago
da4f91186b
fix : #9113 , wrong path separator used in thumbs.get
4 years ago
2be396ff6e
fix: email testing and settings change from ACP
...
- changing email SMTP settings wouldn't apply the first time
- "Send Test Email" now will report emailer errors in most cases
4 years ago
713f029dc8
fix: removing ability to specify deprecated topic 'thumb' on topic creation
4 years ago
600807fbe1
fix: don't return deleted: 0 for ephemeral groups
4 years ago
438fa5c88f
fix: send fewer items to client-side for ACP settings/email page
4 years ago
878ee06715
refactor: schema backreference test to use map instead of reduce, properly check write-api routes
4 years ago
a2152dd100
feat: update html-to-text closes https://github.com/NodeBB/NodeBB/pull/8810
4 years ago
4404e32ed9
fix : #9117 , lower query before search
4 years ago
ab96f526d6
feat: remove max age since cache is cleared when thumbs change
4 years ago
2d5a224b06
perf: don't load thumbs if disabled globally, cache thumb results
4 years ago
d28581eb6a
feat: show alt text instead of images in teasers ( #9107 )
...
* feat: show alt text instead of images in teasers
* refactor: from utils to local function
4 years ago
8f938eba19
fix : #9074 , fix svg uploads
4 years ago
ab98740821
fix : #9100 topic thumbs in OG image tags
4 years ago
74d73313fd
feat: migration of old topic thumbs to new format
...
closes #9099
4 years ago
378a3a6945
fix: update version removal comments to 1.17 for some features
4 years ago
4c87f30184
feat: allow plugins to override ACP relogin challenge
...
- used in 2factor
4 years ago
80de572aa1
feat: add user.email.confirmByUid for sso plugins
4 years ago
05dd859714
fix: postgres is slow ™️
4 years ago
9f62df15bd
chore: appease codeclimate
4 years ago
24e754d120
feat: add thumbs to category data return
4 years ago
edf67f349f
fix: use getSortedSetRange instead of getSortedSetsMembers
4 years ago
bd5c4a5cff
fix: tests
4 years ago
e83baa97a0
fix: bad topic thumbs logic on local thumb upload
4 years ago
3e54b70c06
fix : #9092 , Topic thumbnails do not work with third-party uploaders
4 years ago
2170c40007
fix: iteration logic bug
4 years ago
9342d611be
fix: enable topic thumbnails across the board [breaking]
4 years ago
a30c8ab5c8
feat: clent-side modal for managing topic thumbs
...
closes #9087
4 years ago
67cf5e83b7
fix: changes to thumb resizing logic
...
- Resized thumb no longer skews aspect ratio
- Thumbs resized down to maximum thumb size by WIDTH only
- image.checkDimensions() now returns dimensions
4 years ago
37c367d6ff
feat: raise maximum thumb size to 512
4 years ago
1c5cdb5121
feat: associate topic thumbs with post uploads (for the mainPid)
4 years ago
08736b1812
fix: use file lib instead of direct fs module access
4 years ago
c043cfebd6
fix: added back missing topic thumb tests that were removed in last commit
4 years ago
340387c18a
fix : #9055 , non-standard API response from addThumbs route
...
Also removed old thumb upload router handler, and updated uploadPost handling in composer to match new response schema
4 years ago
c09c238e3f
fix: do not allow thumb deletion route to arbitrarily delete other files in uploads folder
4 years ago
5950683316
feat: closes #9048 , tests for topic thumbs routes, write API schema
4 years ago
4152aa552e
feat: tests for topic thumbs
...
Also added some error checking to addThumbs controller
4 years ago
ef7d6db912
feat: server-side work for #9047
...
- rename Thumbs.commit to Thumbs.migrate
- new PUT method that calls Thumbs.migrate
- `checkThumbPrivileges` now takes a single object parameter (ins. of req/res)
4 years ago
b5d910f53b
feat: core work for #9042 , thumb deletion now accepts uuids
...
+ common data validation for thumb addition and deletion
4 years ago
1f0c1cd229
fix: references to since-removed Topics.thumbs.resizeAndUpload
4 years ago
90497e3ef5
feat: more work on topic thumbs refactor
...
- addThumb and deleteThumb are now protected routes (duh)
- new getThumbs route GET /api/v3/topics/<tid>/thumbs
- Updated `assert.path` middleware to better handle if relative paths are received with upload_url
- Slight refactor of thumbs lib to use validator to differentiate between tid and UUID
4 years ago
43dc3e3e48
fix : #9041 , remove Topics.thumbs.resizeAndUpload()
4 years ago
708b1c338f
fix : #9040
4 years ago
1257aa981e
feat: expose uploaded thumbnails to client-side via API
...
+ plugin hook: filter:topics.getThumbs
4 years ago
7e9e08f718
feat: server-side routes for handling multiple topic thumbnails
...
closes #8994 , requires 'topic-thumb-refactor' branch of composer-default
4 years ago
98cd9e3549
feat: allow uploadThumb controller to be called in code
...
it, and uploadsController.upload() now return the results of their operation
4 years ago
4fc9da81a9
refactor: topic thumbs lib to topics.thumbs
4 years ago
0f480be658
fix : #9085 , dont prevent admins from deleting other users
4 years ago
efa4eca0fe
fix : #9045 , no post usage info if '/files/' path received
4 years ago
60e7de0d13
feat: move upgrade script and make it shorter
4 years ago
6037f5ee2c
chore: add comment for clarification
4 years ago
1f32d38778
fix: default values, clamp postsPerPage/topicsPerPage to max
4 years ago
9da0ed400e
fix : #9081 , load raw settings before merging
4 years ago
bb6cc49c16
perf: dont build identical langs
4 years ago
86f0f82be7
fix : #9068
4 years ago
4a0d883359
breaking: #8808 , remove utils.slugify
4 years ago
1c45fa1ba5
feat: socket.io 3 changes ( #8845 )
...
* feat: socket.io 3 changes
* feat: replace socketio-wildcard with socket.onAny
up socket.io-redis to 6.x
* feat: remove mongodb/psql socket.io adapters
* feat: show data on fail
* fix: tests
* fix: typo
* fix: logger test fix
* fix: logger.io_close
* chore: up deps
* chore: update readme to reflect redis requirement
* fix: increase timeout show data if test fails
4 years ago
d2888d1d1f
Category tags ( #8938 )
...
* feat: wip category tags
* fix: tag search
* feat: remove debug
* fix: returns of searchTags and autocomplete
* fix: alpha sort
* fix: redis
* fix: delete zsets on category purge, fix another test
* fix: test
4 years ago
792e9e703e
fix: dont strip tags
4 years ago
91c20ceca5
fix : #9065 , settings v2/v3 conflict
4 years ago
970ccb5a68
fix : #9063 , missing handler for passwordless accounts in admin.checkPrivileges middleware
4 years ago
6669496dba
Navigator ( #9049 )
...
* feat: navigator changes
* fix: remove extra code
* feat: add lang keys
4 years ago
648f6215ef
fix: redirect external with absolute urls
4 years ago
458bfc0faf
fix: external path for subfolder installs
4 years ago
64ac483ddd
fix : #9032
4 years ago
fcb10ebdbb
feat: add socket connect/disconnect action hooks
4 years ago
5d00b0895b
fix: sso redirect on /login & /api/login
4 years ago
3ea66f84e1
fix: use file lib instead of directly accessing fs (for Assert.path)
4 years ago
ef6c3b0029
fix: check uid as well
4 years ago
7e867cf95e
fix : #7597 , fix progress bar of cover/profile uploads
...
send big cover images in chunks
4 years ago
6f68f4d20a
fix : #9032 , fix login redirect for sso plugins
4 years ago
86b7f8a5d4
fix : #8962 , dont show null for purged targets
4 years ago
5f0f476b57
feat: #9005 , use timestamp in profile/cover images
...
delete current one if keepAllUserImages is turned off
fix typo in data
4 years ago
954dc5b7be
feat: #8983 , update pin tooltip in topic
4 years ago
53abada5f0
Revert "feat: option to allow auto-joining of groups (optionally skip the "request membership" step)"
...
This reverts commit 685f3c6aa6
4 years ago
685f3c6aa6
feat: option to allow auto-joining of groups (optionally skip the "request membership" step)
4 years ago
c1a7968d23
feat: user notification settings for group.leave event
4 years ago
f7558c6052
fix: notification on group.leave incorrectly showing "Guest has left X group"
4 years ago
b46d2f93e6
fix : #9019 , add missing lang strings
4 years ago
e45b5cba81
fix : #9018
4 years ago
f7c738deda
fix : #8997 , don't send notifications if uids already in group
4 years ago
1eb5fabdb1
feat: #8900 , postQueue setting for category
4 years ago
14bb0a4469
feat: #8960 , update view count after merge
4 years ago
4317cdea34
fix : #9002 ban templates not user friendly
4 years ago
202dcef42e
fix : #9010 , show rest of info even if clusterMonitor priv is not granted
4 years ago
d46740f860
fix : #9007 revoke old sessions after adding
4 years ago
700736535c
fix: guests dont always have sid
4 years ago
a4fe4d3cf5
fix: allow guests to see their replies immediately
4 years ago
92d1b8a65f
fix: privs headers
4 years ago
4c650aeead
feat: #8989 , convert widget nav to dropdown
4 years ago
5080f35752
fix : #8991 , logout on password reset, dont verify email if password expired
...
dont allow same password on reset
4 years ago
3cd0c9a476
fix : #8998 , allow guests to use write api to post/reply
4 years ago
5a137a0dd6
fix: guest handles to user displayname as well
4 years ago
546f58bf1f
fix: timestamp in queue, add post queue strings
4 years ago
7f5efc3e93
fix : #8992 , set email:confirmed for first admin user
4 years ago
80f0750bd4
fix: typo in upgrade script, closes #8990
4 years ago
9ab4fb412b
fix: order
4 years ago
d3c04afb98
fix : #8982 , copy color on tag rename, dont copy if target exists
...
refresh page on tag rename
4 years ago
acb576662e
fix(spec): from 6e6a7a8f8a
4 years ago
6e6a7a8f8a
fix : #8969 , export csv to file
4 years ago
007a3258a0
feat: add handler for 501 api response
4 years ago
f4d217d829
fix : #8980 , fix lang string
4 years ago
bf171adc83
fix : #8979
4 years ago
1e7cf1cbc4
fix : #8971 , disallow flags of privileged users (mods, gmods, admins)
4 years ago
dadb2527da
fix : #8974 , with password login for approval queue
4 years ago
ad8e770037
feat: add pinExpiry and pinExpiryISO to topic data
4 years ago
a56a657759
fix: missing select/clear all checkbox added to category privileges template ( #8967 )
4 years ago
ba3981e270
fix: use package.name for theme.id ( #8965 )
...
Prevents cases like #8953
4 years ago
07fe959ce5
chore: remove test code
4 years ago
b8cafefce2
fix: winston usages
4 years ago
414caac01b
fix : #8957
4 years ago
47a19d6763
fix: error message
4 years ago
5bb5ec4618
fix : #8954 , clear purged replies and toPids ( #8959 )
...
* fix : #8954 , clear purged replies and toPids
* fix: redis test
4 years ago
21d6225ce0
fix: 'already-deleting' error on subsequent account content deletions
4 years ago
93863bb3c6
fix : #8949 , faster upgrade script
4 years ago
6771ca150a
fix: add topic uid to infinitescroll
4 years ago
c037779fa1
feat: add topicOwnerPost #8778
4 years ago
ac734b8335
fix : #8912
4 years ago
4f37eddc5e
feat: clear reset tokens on user delete
4 years ago
e32cd31ec6
fix : #8918
4 years ago
3af4d13fa5
fix: basepath for r.js modules
4 years ago
00e75de736
feat: select/clear all checkboxes in privilege table ( #8941 )
4 years ago
1c0e8c1663
fix: move meta.getServerTime call to admin namespace
4 years ago
90434a4668
Revert "fix(spec): always show thumb in topic response"
...
This reverts commit 493c568a75
4 years ago
493c568a75
fix(spec): always show thumb in topic response
4 years ago
0ca40af834
fix : #8939 , fix username change notification getting filtered out
4 years ago
906d7d734b
refactor: move API banned response handler to separate internal method
4 years ago
afb26bfe48
feat: show ban reason and expiry in write api responses, if user is banned
4 years ago
eab4ca7104
fix: bug with Topics.resizeAndUploadThumb not checking for extension validity
4 years ago
2b73a14e42
fix : #8933
4 years ago
6e5ec3f895
feat: automatically unban users in onSuccessfulLogin
...
This allows write API (and probably SSO login) to go through unimpeded if a user's ban has expired. Closes nodebb/nodebb-plugin-write-api#126
4 years ago
77f0bff54f
fix : #8929 , fix popular, top rss feed urls
4 years ago
8f4060819f
Merge branch 'master' of https://github.com/NodeBB/NodeBB
4 years ago
5dd3b03125
fix: a derp
4 years ago
b18e7e319b
fix: spec
4 years ago
4ca62dc45b
fix: improper handling of scheme-relative URLs in topic thumb logic
4 years ago
3f337b5d7c
feat: #8925 , #8924
4 years ago
5fa098326f
fix: https://github.com/NodeBB/NodeBB/pull/8685
...
fix category link redirect on cold load
fix helpers.redirect if passed in url is external
fix ajaxify so it doesn't slice first character of external url
4 years ago
f33a9185ff
fix: on OP edit, call helper method to upload and resize thumb
4 years ago
9ee1fb490e
fix: https://github.com/NodeBB/NodeBB/pull/8759
5 years ago
672d4da078
feat: human readable uptime
5 years ago
6e2da9966e
refactor: move plugin hook methods to plugin.hooks.*
5 years ago
3b1c03ed50
feat: allow ACP API access to bearer tokens
...
closes nodebb/nodebb-plugin-write-api#132
5 years ago
98a05e4dde
chore: add missing plugin hook deprecation warning
5 years ago
ef3df47a6d
refactor: remove breaking change in pin expiry
5 years ago
046d0b1637
feat: allow pins to expire (if set) ( #8908 )
...
* fix: add back topic assert middleware for pin route
* feat: server-side handling of pin expiries
* refactor: togglePin to not require uid parameter [breaking]
* feat: automatic unpinning if pin has expiration set
* feat: client-side modal for setting pin expiration
* refactor: categories.getPinnedTids to accept multiple cids
... in preparation for pin expiry logic, direct access to *:pinned zsets is discouraged
* fix: remove references to since-removed jobs file for topics
* feat: expire pins when getPinnedTids is called
* refactor: make the togglePin change non-breaking
The 'action:topic.pin' hook now sends uid again, as before. However, if it is a system action (that is, a pin that expired), 'system' will be sent in instead of a valid uid
5 years ago
1be08b2e8b
fix: guest displayname
5 years ago
dbd814c25f
fix: spec, only call modifyUser on unique user objects
5 years ago
903e9d82b8
feat: #8637
5 years ago
ae5d4405c0
fix: setting
5 years ago
9ca44e6f54
feat: add displayname into user obj #8637 ( #8909 )
...
* feat: add displayname into user obj #8637
* fix: spec
* perf: dont load settings if acp setting is turned off
5 years ago
8d060065a0
fix: spec
5 years ago
e9585b9be2
fix: group userTitles translation escapes
5 years ago
965671a97b
fix: remove params from error log
5 years ago
fa4177c3bc
fix : #6407 , fix feeds
...
display latest posts instead of oldest in topic rss feed
fix missing await that was causing rss_tokens to not function
fix feed test
more tests for getTopicWithPosts
5 years ago
4e9b10ab76
feat: #5274
5 years ago
fb567a7a33
feat: #4456
5 years ago
a6afcfd531
feat: #8475 , allow flagging self posts
...
dont count flags towards self posts
dont allow flagging your own account
5 years ago
a87ccccc9c
fix: benchpress warnings
5 years ago
dfdc0c420c
fix: benchpress warnings
5 years ago
a0b7a82350
feat(api): account deletion routes for the Write API ( #8881 )
...
* feat(api): account deletion routes for the Write API
* refactor: rewrite client-side calls to account deletion to use api
* style: apply DRY
5 years ago
120999bf63
feat: #7550 , show message if post is queued when js is disabled
5 years ago
35f932cd64
feat: #8171 , add oldCategory if topic is moved
5 years ago
b44ddecdf8
feat: #8204 , separate notification type for group chats
5 years ago
1d6bcbebde
feat: https://github.com/NodeBB/NodeBB/issues/8147
5 years ago
e1d7c4d8aa
fix: internal helper method hasGlobalPrivilege, DRY
5 years ago
3ccebf112e
feat: invites regardless of registration type, invite privilege, groups to join on acceptance ( #8786 )
...
* feat: allow invites in normal registration mode + invite privilege
* feat: select groups to join from an invite
* test: check if groups from invitations have been joined
* fix: remove unused variable
* feat: write API versions of socket calls
* docs: openapi specs for the new routes
* test: iron out mongo redis difference
* refactor: move inviteGroups endpoint into write API
* refactor: use GET /api/v3/users/:uid/invites/groups
Instead of GET /api/v3/users/:uid/inviteGroups
* fix: no need for /api/v3 prefix when using api module
* fix: tests
* refactor: change POST /api/v3/users/invite
To POST /api/v3/users/:uid/invites
* refactor: make helpers.invite awaitable
* fix: restrict invite API to self-use only
* fix: move invite groups controller to write api, +tests
* fix: tests
Co-authored-by: Julian Lam <julian@nodebb.org>
5 years ago
d30ea25629
feat(deps): benchpressjs@2.2.1 ( #8887 )
...
Better warnings, faster template compiles
5 years ago
452d7f2b17
Create verified/unverified user groups ( #8889 )
...
Co-authored-by: Tudor-Dan Ravoiu <tudor-dan.ravoiu@ubisoft.com>
5 years ago
e4d2764d4c
fix : #8884 , remove header/footer cache
5 years ago
5598130a92
refactor: async/await controllers/index.js
5 years ago
f14e42d8bc
fix : #8883
5 years ago
8fbe832460
refactor: less dupe code
5 years ago
8518404e22
feat: allow groups to specify which cids to show member posts from ( #8875 )
...
* feat: allow groups to specify which cids to show member posts from
* docs: fix tests for openapi
* fix: test breakage caused by improper conditional
* feat: server-side checking of memberPostCids for validity
* feat: admin panel template update to select categories to include
* refactor: privilege helpers.isUserAllowedTo
... to helpers.isAllowedTo, allowing group names to be passed in
5 years ago
51b7eca119
fix: run every hour, dont show message if average_time is 0
5 years ago
04f4429f72
Resolve #7514 - optional timer for registration queue ( #8796 )
...
* feat: #7514 Optional timer for registration queue
* feat: show minutes in average time
* fix: don't show total number of minutes
* feat: implement requested changes
* fix: just store minutes instead of milliseconds
* feat: set default values
5 years ago
bcccb331db
docs: openapi schema for user/group exist check, session deletion
5 years ago
dc9668e417
fix: pass length to messaging checkContent hook
5 years ago
567c5f2056
fix : #8869 , dont escape category title,description twice
5 years ago
f300c933a5
refactor: move session revocation route to write api
5 years ago
9c5c32d4a5
feat: #8864 , add action:events.log
5 years ago
62c0454cfe
feat: show db info side by side
5 years ago
a0164b1c38
fix: use header/footer cache in prod
5 years ago
05a92885f2
fix: add missing maxAge to cache
5 years ago
2e44639210
fix: guest header/footer cache
...
allow clearing individual caches
5 years ago
f1f9b225b0
feat: #8824 , cache refactor ( #8851 )
...
* feat: #8824 , cache refactor
ability to disable caches
ability to download contents of cache
refactor cache modules to remove duplicated code
* fix: remove duplicate hit/miss tracking
check cacheEnabled in getUncachedKeys
5 years ago
6255874e32
feat: move mkdirp to beforeBuild so it doesnt get called twice
5 years ago
74951f5967
fix : #8846 , possible fix
5 years ago
0b30efba31
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
16d03975a0
fix: winston error message
5 years ago
d263192271
feat: group exists API call in write api
5 years ago
1446cec77f
feat: user exist route in write api
5 years ago
6b196a207f
fix: permanent redirect on user api redirect shorthand
5 years ago
f2bb42c076
fix: user exist route needs no authentication
5 years ago
60e1e99b4f
feat: new shorthand route /api/v3/users/bySlug/:userslug
...
closes #8844
5 years ago
512f6de6de
feat: allow passwords with length > 73 characters ( #8818 )
...
* feat: allow passwords longer than 73 characters
Context: A bcrypt/blowfish limitation means that password length is capped at 72 characters. We can get around this without compromising on security
by hashing all incoming passwords with SHA512, and then sending that to bcrypt.
https://dropbox.tech/security/how-dropbox-securely-stores-your-passwords
* feat: add additional test for passwords > 73 chars
* fix: remove 'password-too-long' error message and all invocations
* test: added test to show that a super long password won't bring down NodeBB
* fix: remove debug log
* Revert "fix: remove 'password-too-long' error message and all invocations"
This reverts commit 1e312bf7ef7e119fa0f1bd3517d756ca013d5e79.
* fix: added back password length checks, but at 512 chars
As processing a large string still uses a lot of memory
5 years ago
c61dee4b62
fix : #8840 , don't crash if /compose route is called with no query params
5 years ago
9e3eb5d41a
feat: #8821 , allow guest topic views
5 years ago
f68bce86a9
fix: XSS in event:banned messaging modal
5 years ago
76cd5b0fc1
fix : #8836 , truncate fullname
5 years ago
eec630f1ef
fix(acp): max-height for plugin menu list
5 years ago
891a1ea2af
fix : #8827 , do not require admin:users privilege to ban users
5 years ago
4b63f9937c
fix: check is banned in buildHeader
...
remove unused banReason
remove generateHeader function
5 years ago
a338f52780
feat: #8823 , remove hardcoded write concern
5 years ago
08ff4041aa
fix: missing await
5 years ago
c0f699e655
fix: disallow registration attempts with password length > 4096
...
This is a stopgap measure for v1.15.0
5 years ago
4818ec377e
fix: missing await
5 years ago
6e85920cb6
feat: allow mods/admins to see deleted posts on user profile
5 years ago
87bff6cd65
fix: broken test
5 years ago
dda5d42610
fix: restore old behaviour of empty json w/ 401 code in admin middleware
5 years ago
15e0731dd9
fix: deprecate middleware.isAdmin
...
Also, handle admin logout timer in middleware.admin.checkPrivileges
5 years ago
4439864ce0
fix: post editing not taking plugin hook results into account
5 years ago
a02ae6f5df
refactor: simpler check in user.blocks.filter
5 years ago
27016d221c
feat: rearrange buttons on manage/users
5 years ago
57ed6be78b
fix : #8805 define our own name for write API v3
5 years ago
266d7587b2
refactor: remove usage of middlewares
...
Specifically, middleware.isAdmin|exposePrivilegeSet|exposePrivileges
5 years ago
a6a52430ce
fix: remove setCategorySort and setTopicSort
5 years ago
aa8faf58a0
refactor: remove /users/{uid}/settings/{setting} route
...
@baris Also, I am now allowing the following properties to be saved in User.saveSettings:
- categoryTopicSort
- topicPostSort
- setCategorySort
- setTopicSort
5 years ago
6ac73ccb7e
feat: #8801 , disable express compression by default
5 years ago
3c98cd3d95
fix: topic object in post editing data return
5 years ago
1392d064a1
fix(writeapi): normalizing data
5 years ago
ec03af7a38
feat: allow passing subset of user settings on update route
5 years ago
618e098305
fix: bug where token generation route would fail on null case
5 years ago
b156b8b573
feat: wip, write api tests framework
...
re-using read api tests if possible
5 years ago
2e9f27d8ff
fix: typo
5 years ago
93bdfe2f10
perf: reorder async calls
5 years ago
88a07e69b5
feat: add filter:category.getFields
5 years ago
a05905f196
performance improvements ( #8795 )
...
* perf: nconf/winston/render
cache nconf.get calls
modify middleware.pageView to call next earlier
don't call winston.verbose on every hook see https://github.com/winstonjs/winston/issues/1669
translate header/footer separately and cache results for guests
* fix: copy paste fail
* refactor: style and fire hook only log in dev mode
* fix: cache key, header changes based on template
* perf: change replace
* fix: add missing await
* perf: category
* perf: lodash clone
* perf: remove escapeRegexChars
5 years ago
0db0231cff
feat: move postercount to topic hash
5 years ago
203db47b30
fix: return early for guests/spiders
5 years ago
156e1396f2
fix: #8789,cache meta.settings
5 years ago
a7b6d0dfe5
feat: add free and total mem usage to info
5 years ago
c26f2b6599
feat(writeapi): user settings API
5 years ago
db63f5e3f0
fix : #8781
5 years ago
177a961000
feat: new filter filter:teasers.configureStripTags
5 years ago
d68ffea80d
feat: send 'Vary' header when ACAO header set
5 years ago
1f43e98f8b
fix: allow admins adding users to global moderators
...
add new test
5 years ago
bbafa1b82a
Revert "fix: [breaking] send configured config URL as origin if not custom"
...
This reverts commit 205a10308e
5 years ago
a691be5952
fix: incorrect logic for post history editable bool
5 years ago
205a10308e
fix: [breaking] send configured config URL as origin if not custom
...
This is a breaking change if your install uses multiple URLs to access. You will need to update the Access-Control-Allow-Origin header in ACP > Advanced > Headers to supply all URLs you use to access your site
5 years ago
7a019494e8
feat: add filter.topics.getPostReplies
5 years ago
7a8f704900
fix : #8776 some users unable to restore old versions via history
5 years ago
b26e9b5993
fix : #8595 , dont save escaped data when renaming groups
5 years ago
ea31f50554
refactor: show more lines of stack trace
5 years ago
7bddec93ec
fix: sortby
5 years ago
b3619d3d47
fix : #8774
5 years ago
ff4fcc23b6
Update bundled logos with new branding ( #8702 )
...
* feat: updating logo assets, square logos missing still
* fix: squared logo for touch icon and notification fallback
* fix: update link to favicon
* feat: add default touch icon sizes, if one isn't uploaded
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
5 years ago
e362c342a3
fix : #8630 , sort extra deps
5 years ago
d9a16855d0
refactor: posts api
5 years ago
272e73da53
refactor: post restore/delete/purge
5 years ago
9738e20207
refactor: merge post.edit
...
fix: dont fadeout/fadeint if title/post didnt change
5 years ago
2279e37261
refactor: deprecate socket.emit('users.search') use api route
5 years ago
083c74e059
refactor: api categories
5 years ago
e78c498e84
fix: missing doTopicAction, fix wrong api params
5 years ago
bc880ee0ca
refactor: remove sockets.reqFromSocket
5 years ago
9d81660e24
Revert "Revert "fix: appropriate 404 handling for write API calls""
...
This reverts commit 135c2d6c7d
5 years ago
Barış Soner Uşaklı
Barış Soner Uşaklı
gasoved
Julian Lam
Peter Jaszkowiak
psychobunny
uplift
SAES:RPG
opliko
Anton Grigoryev
Mats
ahwayakchih
Manuel Valle
Tudor-Dan Ravoiu
Opliko