Locks bug failing test (#9595)

* test: failing test for issue

* fix: #9593, don't lock if email is identical to username

* fix: lock calls after first call

* fix: add back email check

* test: remove invalid test

Co-authored-by: Julian Lam <julian@nodebb.org>

src/user/create.js

@@ -19,14 +19,14 @@ module.exports = function (User) {
 			data.email = String(data.email).trim();
 		}
 
-		try {
-			await lock(data.username, '[[error:username-taken]]');
-			if (data.email) {
-				await lock(data.email, '[[error:email-taken]]');
-			}
+		await User.isDataValid(data);
 
-			await User.isDataValid(data);
+		await lock(data.username, '[[error:username-taken]]');
+		if (data.email && data.email !== data.username) {
+			await lock(data.email, '[[error:email-taken]]');
+		}
 
+		try {
 			return await create(data);
 		} finally {
 			await db.deleteObjectFields('locks', [data.username, data.email]);