12506 Commits (aafb7f6ec752ef2c5c852156732fbb294c7aa9fe)

Author SHA1 Message Date
Julian Lam cf4f5447bb fix: #10906, allow `middleware.checkAccountPermissions` to be called with either uid or userslug in params
Previously, the middleware only worked with userslug params
2 years ago
Barış Soner Uşaklı b5dd89e1c0
feat: store topic title and tags in diffs (#10900)
* feat: store topic title and tags in diffs

allow restoring post diff if tags didn't change

* test: fix tests, fast computer problems
2 years ago
Julian Lam fe249fa577 fix: listen to -d flag on cli upgrade 2 years ago
Barış Soner Uşaklı ebd7c05c4c feat: paginate recentposts.rss and
category/1/recentposts.rss
2 years ago
Julian Lam 6061d611ea Merge remote-tracking branch 'origin/master' into develop 2 years ago
Barış Soner Uşaklı 8aa1596d23 chore: bring back treding plugins 2 years ago
Barış Soner Uşaklı 3d5a6b39d6 lint: fix lint 2 years ago
Barış Soner Uşaklı b392450c36 perf: disable trending plugins, too slow due to nbbpm 2 years ago
Opliko 665f36b707 feat: add quiet to action:settings.set
Makes it possible to ignore quiet updates without abusing the `filter` hook
2 years ago
Julian Lam 67cb70352f fix: missing escape on ACP category backgroundImage property 2 years ago
Julian Lam 15b1561fd3 feat: introduce ACP defined option to rescind notif or do nothing on flag resolve/reject
/cc #10867
3 years ago
Julian Lam d05705183f refactor: move export generation logic to v3 controller, GET/HEAD routes for exports
re: #10384
3 years ago
Julian Lam 0cda5aa3e3 feat: allow v3 api to handle 202 and 204 response codes as well. 3 years ago
Julian Lam 8b7cf48ade Merge remote-tracking branch 'origin/master' into develop 3 years ago
Julian Lam 9b96c33d5d fix: wrap passport.authenticate to pass in keepSessionInfo if not already set 3 years ago
Julian Lam 65b3996ac6 fix: removing duplicate session rerolling code (as it is in passport@^0.6 now) 3 years ago
Julian Lam 20ebf0a1e0 Merge remote-tracking branch 'origin/master' into develop 3 years ago
Barış Soner Uşaklı bc37a5c516 fix: parseInt caller.uid closes #10849 3 years ago
Barış Soner Uşaklı fc9b436f3e Merge branch 'master' of https://github.com/NodeBB/NodeBB 3 years ago
Barış Soner Uşaklı 489fb3a36f fix: missing req, closes #10847 3 years ago
Julian Lam 4dc7fa050f fix: #10845, disallow inline viewing of uploaded html files 3 years ago
Julian Lam 990ad6a11a Merge remote-tracking branch 'origin/master' into develop 3 years ago
Julian Lam ec048a01ba fix: #10841, incorrect conditional in email interstitial partial 3 years ago
Barış Soner Uşaklı aba420a3f3 feat: setting to show signatures only once in topics, closes #10071 3 years ago
Barış Soner Uşaklı 14c79763dd refactor: use group.slug on acp group urls closes #8277 3 years ago
Barış Soner Uşaklı e06e526e54 fix: don't crash if post is undefined 3 years ago
Barış Soner Uşaklı 33458701c1 test: passport0.6 (#10638)
* test: passport0.6

* test: make logout async, fix lint

* test: keepSessionInfo flag

* revert: csrf load
3 years ago
Opliko 3975fa2e45 fix: return at least one in sizeCalculation (#10832)
if post content is empty post cache should still consider its size to be at least one. fixes #10831
3 years ago
Barış Soner Uşaklı 4a3e36a766 fix: don't crash if post is undefined 3 years ago
Opliko a9bbb586fc
feat: allow plugins to add to admin cache list (#10833)
* feat: allow plugins to add to admin cache list

resolves  #10820

plugins will have to use `filter:admin.cache.get` hook and just add their own cache to the object there.

* feat: add dump to ttlCache and expose properties

* feat: also expose properties under their current names

* feat: display TTL if set
3 years ago
Barış Soner Uşaklı 6b2a6f9006
test: passport0.6 (#10638)
* test: passport0.6

* test: make logout async, fix lint

* test: keepSessionInfo flag

* revert: csrf load
3 years ago
Opliko 15ca460c8f
fix: return at least one in sizeCalculation (#10832)
if post content is empty post cache should still consider its size to be at least one. fixes #10831
3 years ago
Julian Lam 9b753d6d57
TTL Cache (#10816)
* refactor: move src/cacheCreate.js to src/cache/lru.js

* fix: call new library location for lru cache creator

* feat: add ttl cache

* fix: update upload throttler to use ttl cache instead of lru cache

* chore: add missing dependency

* fix: avoid pubsub conflicts

* fix: use get instead of peek, which is not available in ttl-cache
3 years ago
Julian Lam c07d595662
Update to lru-cache@^7 (#10815)
* chore(deps): bump lru-cache from 6.0.0 to 7.13.1 in /install

Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 6.0.0 to 7.13.1.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-lru-cache/compare/v6.0.0...v7.13.1)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(lru-cache): remove unneeded `length` params for cache creation, as `maxSize` was not used in those init calls, also renamed some methods to match new method names in lru-cache [breaking]

Added deprecation notices for old params

* fix: replace three direct calls to lru-cache with call to cacheCreate, moved cache creation call in uploads to run on first init as config is not populated at lib init

* test: move configs init above cache reset calls in databasemock

* move some more code above cache clear

* refactor: remove unused

* test: lru

* test: more debug

* test: on more test

* use await helpers.uploadFile

* fix: tests remove logs

* fix: acp cache page

* fix: add in one more guard again cache instantiation with `length` prop but no `maxSize` prop

* fix(deps): bump markdown

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
3 years ago
Opliko b3a37a7f35 feat: support packageManager property in package.json
resolves #10714
3 years ago
Julian Lam 38bf30c8ca fix: adapt to breaking change in commander 3 years ago
Julian Lam d0255fc6a5 fix: move panel-offset setting code back to theme header 3 years ago
Julian Lam c6782a2173 Merge remote-tracking branch 'origin/master' into develop 3 years ago
Julian Lam 9d27e90740 fix: don't require password challenge if no password is set in user account 3 years ago
Julian Lam 287f4c2c41 fix: do not throw if password passed into `isPasswordCorrect` is invalid, just return false 3 years ago
Julian Lam 7fcee42be9 feat: present a password challenge on email update flow 3 years ago
Barış Soner Uşaklı 7e8ad785f4 fix: don't crash if req.body.username is not string
Error: req.body.username.trim is not a function
File: authenticationController.login (/usr/src/app/src/controllers/authentication.js:247:40)
3 years ago
Barış Soner Uşaklı 55c5588a4b fix: don't crash if target/user is undefined
Error: TypeError: Cannot read properties of undefined (reading 'displayname')
File: Flags.notify (/usr/src/app/src/flags.js:812:89)
3 years ago
Julian Lam 9ee1afbb0f Merge branch 'master' into develop 3 years ago
Julian Lam 06f089afda test: fix user email tests 3 years ago
Barış Soner Uşaklı d73f0f9ccb perf: make single db call 3 years ago
Julian Lam e092bfeb46 Merge remote-tracking branch 'origin/master' into develop 3 years ago
Julian Lam cba9047f67 fix: #10805, hide unconfirmed emails from user data retrieval methods 3 years ago
Julian Lam 3e062a7f29 fix: use different emoji on NodeBB Ready — again because procrastination 3 years ago
Barış Soner Uşaklı cd438b328a fix: unnecessary escape 3 years ago
Barış Soner Uşaklı f64a69132a Merge branch 'develop' of https://github.com/NodeBB/NodeBB into develop 3 years ago
Julian Lam dc3a6a29bc fix: #10783, do not purge files without a timestamp prefix 3 years ago
Julian Lam 89173f17ca fix: #10798, logic error in COEP header; helmet config 3 years ago
Julian Lam 5176fb1544 feat: add emoji to startup logs, because procrastination. 3 years ago
Julian Lam dcacd815a9 refactor: invert helmet configuration 3 years ago
Julian Lam 820bc994d8
feat: UI changes for ACP > Manage > Categories (#10782)
* Revert "Revert "feat: cross origin opener policy options (#10710)""

This reverts commit 46050ace1a.

* Revert "Revert "chore(i18n): fallback strings for new resources: nodebb.admin-settings-advanced""

This reverts commit 9f291c07d3.

* feat: closes #10719, don't trim children if category is marked section

* feat: fire hook to allow plugins to filter the pids returned in a user profile

/cc julianlam/nodebb-plugin-support-forum#14

* fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints

* fix: better looking placeholder text for ACP search

* fix: bug where fallback to forum search was not working due to client-side error

* feat: allow plugins to toggle whether IPs are shown in the users CSV export

* feat: Allow defining active plugins in config (#10767)

* Revert "Revert "feat: cross origin opener policy options (#10710)""

This reverts commit 46050ace1a.

* Revert "Revert "chore(i18n): fallback strings for new resources: nodebb.admin-settings-advanced""

This reverts commit 9f291c07d3.

* feat: closes #10719, don't trim children if category is marked section

* feat: fire hook to allow plugins to filter the pids returned in a user profile

/cc julianlam/nodebb-plugin-support-forum#14

* fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints

* feat: Allow defining active plugins in config

resolves #10766

* fix: assign the db result to files properly

* test: add tests with plugins in config

* feat: better theme change handling

* feat: add visual indication that plugins can't be activated

* test: correct hooks

* test: fix test definitions

* test: remove instead of resetting nconf to avoid affecting other tests

* test: ... I forgot how nconf worked

* fix: remove negation

* docs: improve wording of error message

* feat: reduce code duplication

* style: remove a redundant space

* fix: remove unused imports

* fix: use nconf instead of requiring config.json

* fix: await...

* fix: second missed await

* fix: move back from getActiveIds to getActive

* fix: use paths again?

* fix: typo

* fix: move require into the function

* fix: forgot to change back to getActive

* test: getActive returns only id

* test: accedently commented out some stuff

* feat: added note to top of plugins page if \!canChangeState

Co-authored-by: Julian Lam <julian@nodebb.org>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>

* feat: show an informative message when no plugins are found after filtering

fixes #10771

* Latest translations and fallbacks

* Latest translations and fallbacks

* chore(deps): bump ace-builds from 1.7.1 to 1.8.1 in /install

Bumps [ace-builds](https://github.com/ajaxorg/ace-builds) from 1.7.1 to 1.8.1.
- [Release notes](https://github.com/ajaxorg/ace-builds/releases)
- [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.7.1...v1.8.1)

---
updated-dependencies:
- dependency-name: ace-builds
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: swap out icons in ACP > Manage > Categories to more intuitive ones, remove extra placeholder div

* fix: hide expando button if no subcategories; remove attempt at establishing common vars, increased spacing between categories in list

* fix: buggy expando state on category drag/drop

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
Co-authored-by: Opliko <opliko.reg@protonmail.com>
Co-authored-by: Misty Release Bot <deploy@nodebb.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 years ago
Julian Lam 6840a7423b feat: show an informative message when no plugins are found after filtering
fixes #10771
3 years ago
Opliko 23cb67a112 feat: Allow defining active plugins in config (#10767)
* Revert "Revert "feat: cross origin opener policy options (#10710)""

This reverts commit 46050ace1a.

* Revert "Revert "chore(i18n): fallback strings for new resources: nodebb.admin-settings-advanced""

This reverts commit 9f291c07d3.

* feat: closes #10719, don't trim children if category is marked section

* feat: fire hook to allow plugins to filter the pids returned in a user profile

/cc julianlam/nodebb-plugin-support-forum#14

* fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints

* feat: Allow defining active plugins in config

resolves #10766

* fix: assign the db result to files properly

* test: add tests with plugins in config

* feat: better theme change handling

* feat: add visual indication that plugins can't be activated

* test: correct hooks

* test: fix test definitions

* test: remove instead of resetting nconf to avoid affecting other tests

* test: ... I forgot how nconf worked

* fix: remove negation

* docs: improve wording of error message

* feat: reduce code duplication

* style: remove a redundant space

* fix: remove unused imports

* fix: use nconf instead of requiring config.json

* fix: await...

* fix: second missed await

* fix: move back from getActiveIds to getActive

* fix: use paths again?

* fix: typo

* fix: move require into the function

* fix: forgot to change back to getActive

* test: getActive returns only id

* test: accedently commented out some stuff

* feat: added note to top of plugins page if \!canChangeState

Co-authored-by: Julian Lam <julian@nodebb.org>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
3 years ago
Julian Lam a6af47da02 feat: allow plugins to toggle whether IPs are shown in the users CSV export 3 years ago
Julian Lam 1b9c68196f fix: better looking placeholder text for ACP search 3 years ago
Julian Lam 0529f2fb5d fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints 3 years ago
Julian Lam c26be43ac5 feat: fire hook to allow plugins to filter the pids returned in a user profile
/cc julianlam/nodebb-plugin-support-forum#14
3 years ago
Barış Soner Uşaklı 7e80cc1033 feat: closes #10719, don't trim children if category is marked section 3 years ago
Julian Lam ad072c03d1 Revert "Revert "feat: cross origin opener policy options (#10710)""
This reverts commit 46050ace1a.
3 years ago
Tong Ho bbc7f2afba fix: cannot turn off all networks 3 years ago
Tong Ho 2e088a8ef0 fix: cannot setting networks for sharing posts 3 years ago
Julian Lam c93bd0105e fix: expire email validation tokens on password change 3 years ago
Julian Lam 0d58e8a6af fix: remove extraneous console.log 3 years ago
Julian Lam 3c41ae04cd fix: #10733, extraneous apostrophes in plugin upgrader 3 years ago
Julian Lam 60114219c1 fix: get version from install/package.json instead 3 years ago
Julian Lam 8d701ec3e2 fix: #10739, always re-add theme to active plugins, on theme set 3 years ago
Julian Lam f38b2a737a fix: improper handling of single vs. multiple inputs for hidePrivateData 3 years ago
Julian Lam ecf0e8ce22 fix: observe user-specific and ACP-specific hiding rules for fullname 3 years ago
Julian Lam 3f5ae893c6 refactor: allow user.hidePrivateData() to handle an array of `userData` 3 years ago
Julian Lam 17e44ff5c9 feat: fire hook to allow plugins to filter the pids returned in a user profile
/cc julianlam/nodebb-plugin-support-forum#14
3 years ago
Barış Soner Uşaklı be917e8d39 feat: closes #10719, don't trim children if category is marked section 3 years ago
Julian Lam 0d68643bcb Revert "Revert "feat: cross origin opener policy options (#10710)""
This reverts commit 46050ace1a.
3 years ago
Julian Lam 43f9e6c8e4 fix: handle ENOENT on file deletion, closes #10645 3 years ago
Julian Lam 46050ace1a Revert "feat: cross origin opener policy options (#10710)"
This reverts commit 881323583f.
3 years ago
Barış Soner Uşaklı 881323583f
feat: cross origin opener policy options (#10710) 3 years ago
Julian Lam 22368b996e refactor: move orphan cleaning logic to its own method, added tests for getOrphans and cleanOrphans 3 years ago
Julian Lam 88aee43947 feat: new cronjob and ACP option to delete orphans after configurable number of days, closes #10659 3 years ago
Julian Lam bef236f371 chore: remove unnecessary `affected` set from deprecated plugin hook 3 years ago
Julian Lam b9d4724e0f feat: allowed plugins to modify email verification details prior to db saving or email send/plugin fire
+ new hook `filter:user.verify`
- hook `filter:user.verify.code`
3 years ago
Julian Lam 3a015eb8e3 fix: no need to pass in empty Set in deprecated hooks 3 years ago
Barış Soner Uşaklı b6f8e2fd05 fix: #10692 3 years ago
Julian Lam a04da673fa fix: #10690, all uploads in `uploads/files` showing orphaned 3 years ago
Julian Lam 7f870beb59 fix: bug where post associations are not shown when the directory is `files` 3 years ago
Julian Lam ece733eddc feat: pass absolute url to post into post tools response, #10566 3 years ago
Julian Lam a35642601c fix: buildBreadcrumbs naively prepending relative path even if absolute paths are passed in 3 years ago
Barış Soner Uşaklı 191fb9f443 test: fix tests again 3 years ago
Barış Soner Uşaklı e802fab87f fix: get rid of math.random in utils.generateUUID 3 years ago
Barış Soner Uşaklı 7e4d2852f6 fix: #10528, gray out disabled nav items
use enabled property if present
change default to true, so added nav items are enabled by default
3 years ago
Barış Soner Uşaklı 0084b563f3 fix: #10631, fix user digest setting display acp 3 years ago
Julian Lam 54ff768f51 chore: remove optional `middleware` parameter from setupPageRoute and setupAdminPageRoute calls 3 years ago
Barış Soner Uşaklı c926358d73 feat: add mute history, closes #10596 3 years ago
Barış Soner Uşaklı 9acdc6808c feat: allow unban/unmute on flag details page. closes #10593 3 years ago
Barış Soner Uşaklı b17a81bfb0 fix: translate api error messages to user lang, closes #10623, 3 years ago
Barış Soner Uşaklı 3a009f96cd fix: closes #10621, convert \r\n to \n so it isn't counted as 2 characters 3 years ago
Barış Soner Uşaklı b860c2605c feat: paginaton for admins-mods, closes #10610
ability to select categoriest to see children
3 years ago