Commit Graph

766 Commits (81f8cfe3da3b1d1521ad08a118bf1edb4abd7fef)

Author SHA1 Message Date
Barış Soner Uşaklı a7267df404 closes
Barış Soner Uşaklı 4504bbae52 2 diff test
Barış Soner Uşaklı 229e49cf8f closes , closes
Barış Soner Uşaklı 65dc530df5 some controller tests
Barış Soner Uşaklı d977934c66 adjust username test
Barış Soner Uşaklı 8e8058ec6e closes
Julian Lam 445b92ae38 Revert "fix some tests"
This reverts commit 2551df80f7.
Barış Soner Uşaklı cdc3ef09e9 closes
Julian Lam 2551df80f7 fix some tests
Barış Soner Uşaklı 9132743870
Julian Lam 5dc25a3c00 Merge remote-tracking branch 'origin/master' into chat-kick-support
Julian Lam a08572b800 kick support for chats,
Barış Soner Uşaklı beadcd7857 fix tests, remove dupe exposeUid
Julian Lam dc386b5b23 Merge branch 'master' into user-blocking
Julian Lam a0643b63df uncommenting tests again
Julian Lam 8db98b5cf4 additional UCP integration for
Barış Soner Uşaklı bc18b489e6 fix group test
Barış Soner Uşaklı 9ae5946e7a Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Julian Lam 3951bb9532 Merge remote-tracking branch 'origin/master' into user-blocking
Barış Soner Uşaklı 505e511e4d fix tests
Julian Lam 322d8236d2 added test for User.blocks.is, re:
Julian Lam 032ec8b443 tests!!! glorious tests!!!
re: 
Julian Lam 1f1e055509 updated post association code to only associate files that exist, closes
Julian Lam 0f13ae3c87 added isOrphan method,
Julian Lam 2e125293e6 save reverse association of md5 of upload to pid,
Julian Lam 850f59a1ae additional functionality, integration, and testing for
Julian Lam 5943389b7a tests for
Julian Lam 6088c37f5a Revert "fixing tests"
Turns out baris already fixed them

This reverts commit 3bc0266aa4.
Julian Lam 3bc0266aa4 fixing tests
Barış Soner Uşaklı ed289ebeab two more text fixes
Julian Lam 65c8457898 fixing tests that broke due to gdpr requirement
Barış Soner Uşaklı 04979f86a8 delete users uploads on account delete
store uid:<uid>:uploads
Barış Soner Uşaklı 0070f5c1b2 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Julian Lam 0158b1aa91 Various password logic fixes on client and server-side
Fixes 
Fixes 
Barış Soner Uşaklı ae0f1847ae allow multiple origins for access-control-allow-origin header
add access-control-allow-credentials header to acp
Julian Lam bf2e905ced fixed tests, closes
Peter Jaszkowiak eaae5b52cd ACP quick actions ()
* ACP quick actions

- Moved restart, build & restart, and logout into separate buttons
- Moved buttons on mobile into the side menu
- Added version and upgrade alert to header / mobile menu
- Moved version checking to server-side with a cache for rate limiting
- Changed "reload" translations to "rebuild and restart"

* Change info alert to black-on-white to match focused search bar

* Fix tests

* Fallback for failed fetch of latest version
Barış Soner Uşaklı fde44cb9b9 pass array to groups.destroy
pass array to db.sortedSetRemove
Barış Soner Uşaklı be5c237388 fix decr/incrObjectField if key in array doesn't exist create it
Barış Soner Uşaklı 6a9a73c86c changes to leaveAllGroups
Groups.destroy can take an array of groupnames
Groups.leave can take an array of groupnames
db.incrObjectField/decrObjectField can take an array of keys
db.sortedSetRemove can take an array of keys and values
db.setRemove can take an array of keys
Barış Soner Uşaklı 7221b71b68 add test for srem with multi elements
Baris Usakli 959a742c63 add llen to dbal
Julian Lam 9ea6dbc0e7 fix flag tests
Barış Soner Uşaklı bce640e514 closes
Julian Lam c93f943bef Merge branch 'develop'
Barış Soner Uşaklı e1c6761087 closes
Barış Soner Uşaklı 7b45a6ea8b Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Julian Lam 0d65cec3d0 fixing tests
Baris Usakli 9b78b95c47 fix tests
Julian Lam 1ce448f2a1 Merge remote-tracking branch 'origin/master' into develop
Barış Soner Uşaklı 15e9bbac92 closes
Barış Soner Uşaklı 723f31a362 closes
Baris Usakli e99d4a5c61 closes
Baris Usakli ecc2b9560d parseInt data.hidden add tests
Barış Soner Uşaklı 7a2d6fe22d Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Barış Soner Uşaklı b084a596fa closes
Barış Soner Uşaklı 155e20d216 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Barış Soner Uşaklı 0a5d16d1cd closes
Barış Soner Uşaklı 33a8cb947e Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Barış Soner Uşaklı d8b5d40668 closes
Julian Lam 457194b333 Merge branch 'master' into develop
Barış Soner Uşaklı f3fda152bf closes
Barış Soner Uşaklı 72140e5338 closes , closes
Ben Lubar 5b1ed21634 [database/mongo] Improve speed of sortedSetRank ()
* [database/mongo] Improve speed of sortedSetRank

* [database/mongo] Fix sortedSetRank to filter by _key
Julian Lam c47987b305 fixed test for error when adding self to chat
Julian Lam f37b9d786d Merge remote-tracking branch 'origin/master' into develop
Barış Soner Uşaklı a2ba01b0d7 fix test
Barış Soner Uşaklı 2f3b7279be closes
Julian Lam ec07247854 Merge remote-tracking branch 'origin/master' into develop
Baris Usakli ecf6c0f3ec closes
Barış Soner Uşaklı 7eab9f6ab0 add missing ;
Barış Soner Uşaklı fdb221c106 fix helper test
Peter Jaszkowiak 4387d5d466 Ensure installed correct version of modules on startup, bump dependencies ()
* Ensure installed correct version of modules

* Bump dependencies

* Bump promise-polyfill

* Fix emailer test

* Fix auto-install regression

introduced in 9b5e0f9e95
Julian Lam d1ccd78ac2 Merge remote-tracking branch 'origin/master' into develop
Barış Soner Uşaklı 8446a733e5 closes
Barış Soner Uşaklı 87d40e9e78 fix increment to use data
Barış Soner Uşaklı ff6c6a54c1 make upload permissions global
give upload image permission to registered users on install
add global privileges to app.user.privileges for client side use
Julian Lam 82a95a03be Chat message soft deletion -- closes
Squashed commit of the following:

commit f84c06bdcc45f24ef7ffde6a8f33b48d8f97fc36
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Dec 18 14:42:47 2017 -0500

    added restore handler for chat messages

commit 725cd370c6ea1e8f4a28298350f3dc024d4e668e
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Dec 18 14:23:52 2017 -0500

    backend logic and testing complete for deletion and restoration of chat messages

commit 072da758319cc93fa4c6f8bc0d672a1b716dc06e
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Dec 18 13:52:35 2017 -0500

    changing message delete logic to not remove mids, but to filter when retrieving

commit 68bf373305ab82737658a7c31dc5549af4d6d69f
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Dec 18 12:37:58 2017 -0500

    logic to handle deletion of a deleted chat message -- added some failing tests

commit 6899d0d234fa752e227188aa69cfcabd0d0500cc
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Dec 18 11:35:36 2017 -0500

    chat message deletion logic
Julian Lam 88b47f357b removed user.uploadFromUrl and associated logic as cropped image modal supercedes it @pichalite
Barış Soner Uşaklı 108c3c980a show invalid url error if request.head fails
Barış Soner Uşaklı b778c8433a change hook name
Barış Soner Uşaklı b55087dab7 closes
Barış Soner Uşaklı ea83be50a1 closes
Barış Soner Uşaklı 18b559bab0 fix test name
Barış Soner Uşaklı 2bf275fe29
Barış Soner Uşaklı 2455df438c fix test
Barış Soner Uşaklı 43180d4b83
Barış Soner Uşaklı 8e04e86e24 closes
Barış Soner Uşaklı 19ae8dc7e7 closes
Baris Usakli 3551d7d68e closes
Barış Soner Uşaklı e6d31c8bd2 add referer check to /api/admin/users/csv
Barış Soner Uşaklı e3fd402070 escape email in registration queue and invites
Barış Soner Uşaklı a7a3f3619b dont allow login with invalid ip, escape ip display on user/info page
caoyi da5997a06e Fix typo ()
Fix typo
Julian Lam 78c83f2561 fixing tests
Barış Soner Uşaklı 4f2f84e47c
Baris Usakli a19537dc25 closes
Baris Usakli b19310049d closes
Baris Usakli d9c38c7e4f closes
Julian Lam e83813c531
Emailer tests for Digest.getSubscribers ()
* added additional tests for Digest.getSubscribers

* added another test and tweaked existing digest list building tests
Barış Soner Uşaklı 07ed3807d8 remove console.log
Barış Soner Uşaklı caaa72b752 closes
Barış Soner Uşaklı d96674da64 add test for composer fix
Baris Usakli dbf815ed47 closes
Peter Jaszkowiak 4fcedc6f31 Enable imports in custom email templates ()
* Enable imports in custom email templates

* Compile emails on config change

* Add error logging

* Add emailer tests

* Fix tests

* Only build when config changes
Barış Soner Uşaklı 3bf7faf5fc increase rate limit delay
Peter Jaszkowiak 11b9cb7688 Fix , `action:home.get:*` returned to previous functionality ()
Added tests to confirm `buildHeader` is used and `/api` works
Peter Jaszkowiak f5385e38bf Add `/me*` route which redirects to `/user/[userslug]*` ()
* Add `/me*` route which redirects to the current user's information

- `/me` -> `/user/[usertslug]`
- `/me/bookmarks` -> `/user/[userslug]/bookmarks`
- `/me/settings` -> `/user/[userslug]/settings`

etc

* Add tests for `/me/*`
Baris Usakli e68e5122e2 add test to check breadcrumbs on home route
Baris Usakli 5604c62776 use the first set for sorting
Baris Usakli eeedba697b closes
Barış Soner Uşaklı 1d50c74cdc should error with no content
Barış Soner Uşaklı e4ea4d5134 move composer routes to its own file
Barış Soner Uşaklı 0316f51cdb show values if test fails
Peter Jaszkowiak bbdc55cb3a Better fix for ()
* Better fix for 

Also a nice newline so the line doesn't get overwritten when running `./nodebb upgrade`

* Optimizations for custom homepage

Move it into a separate module
Barış Soner Uşaklı 760c061b1d closes
Barış Soner Uşaklı 4551ee4768 some more tests
Barış Soner Uşaklı 8810f0f2a9 remove dupe meta
Julian Lam 7e0d0e0eb5 Merge remote-tracking branch 'origin/develop'
Peter Jaszkowiak dfad76120d Support npm@5 and yarn ()
* Support npm@5 and yarn

Use package.default.json
Partial 

- Overwrite package.json with package.default.json values
- `dependencies` field is merged with package.default.json version taking precidence
- `./nodebb upgrade` automatically does those things and runs `git pull`
- use `./nodebb upgrade --dev` to avoid the `git pull`

* added logic to preserve extraneous plugins installed in node_modules/

* Don't automatically git pull

* Simplify package-install, run it on upgrade just in case
Barış Soner Uşaklı 3dd83237b8 add some debug for failed tests
Baris Usakli c9465403f5 closes
Peter Jaszkowiak adc47fd053 Use relative linking ()
* Use relative linking

* Add copyFile method and tests

Closes 

* Fix relative linking on Windows

Hard links and junctions don't work with relative paths

* Fix tests

* Revert ghange to gitignore
Barış Soner Uşaklı 18f4f27fe0 closes
Barış Soner Uşaklı 5b2a674a4f closes
Barış Soner Uşaklı 25cd21fba8 closes
Barış Soner Uşaklı 6b1af76f08 closes
Barış Soner Uşaklı d5d6748c71 closes
Baris Usakli 47143a4a09 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Baris Usakli a500e0019c closes
Barış Soner Uşaklı c453fc7275 add widget reset test
Barış Soner Uşaklı a11058bce2 closes
Peter Jaszkowiak 62ae171432 Merge remote-tracking branch 'origin/master' into develop
Barış Soner Uşaklı 5d45f9fff2 fix lint
Barış Soner Uşaklı 6a2019c646 closes
Peter Jaszkowiak f336726173 Bump dependencies ()
* Bump dependencies

* Fix mocha v4 requiring --exit flag

Use nyc instead of the istanbul binary

* Print out summary instead of full report
Barış Soner Uşaklı e7318a1cea Mongo cache ()
* cache mongodb objects

remove user settings cache since it is cached at the object level

* removed indexOf from isMemberOfSets

* change has to get, change maxAge to 0
Barış Soner Uşaklı 108f84fd19 add type to dbal
Baris Usakli c4310395c9 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
# Conflicts:
#	package.json
Baris Usakli 8733f51f86 remove test for unused code
Barış Soner Uşaklı 797857e1d2 remove old test
Peter Jaszkowiak 60a42aa651 Merge branch 'translator-optimization' into develop
Peter Jaszkowiak 46fafb20b9 Remove string.js dependency
Barış Soner Uşaklı 557dfd5b47 testing new socket.io-client extraHeaders ()
* testing new socket.io-client extraHeaders

* change mongodb installation
Julian Lam df5178ce78 fixed typo in outgoing route test, and added new test for javascript protocol
Peter Jaszkowiak 1c35213934 Fix and forking while debugging ()
* Fix forking while debugging

Debugger address in use no longer happens

* Fix cropper error
Barış Soner Uşaklı b70f328520 closes
Peter Jaszkowiak da9da8190f Bump dependencies
Bumping eslint & configs meant making some linting fixes

For future reference, the `xmlhttprequest-ssl` library must be of equal versioning to the one in `engine.io-client`, otherwise it won't be deduped which causes the socket.io tests to fail
Peter Jaszkowiak dc87d7fc0f Use .js instead of .jst
Fix 
Baris Usakli c49837143c fix test
Baris Usakli 1358a89305 closes
Julian Lam 1034626896 Merge remote-tracking branch 'origin/develop'
Peter Jaszkowiak e8aa8c62f6 Update jsdom
Barış Soner Uşaklı bc6edba6df change post queue test
Barış Soner Uşaklı 5cc39e8546 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
# Conflicts:
#	package.json
#	src/views/admin/manage/ip-blacklist.tpl
Peter Jaszkowiak abffc29128 Use Benchpress ()
* Use Benchpress

* Use Benchpress.compileParse

* Error for template load failure

* Use benchpressjs package

* Compile templates on demand

* Fix user settings page

* Fix admin search to exclude `.jst` files

* Fix 500-embed

So ajaxify can still show an error if the server goes down
Barış Soner Uşaklı a46db9616c fix message delete and add test
Barış Soner Uşaklı 329bfeeb3b convert min/max to float
Barış Soner Uşaklı ff88be91fa Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Baris Usakli dc9b21021a escape moderation notes
Baris Usakli bc0645dc26 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Baris Usakli 37a8247293 add test for teaser content escape
Baris Usakli 575c9a41cd Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Barış Soner Uşaklı f161bbf956 Post queue ()
* 

* add user to post queue table

* add time of post into queue

add posting restrictions to queue

* fix shouldQueueLogic for guests

* add test for post-queue route
Barış Soner Uşaklı fc0e5421d6 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Baris Usakli c21f64c27f closes
Baris Usakli bc6b1a8f56 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
# Conflicts:
#	public/src/admin/extend/plugins.js
Baris Usakli 24bbf8fe00 closes
Baris Usakli de55c8e431 closes
Baris Usakli e071f94173 test debugParams.js
Julian Lam 303f1146b2 added upload_url to nconf vars @pitaj
Baris Usakli 875672522e Merge remote-tracking branch 'refs/remotes/origin/master' into develop
# Conflicts:
#	src/search.js
Baris Usakli a9dbdc75af closes
Barış Soner Uşaklı b3f6c423c6 fix test
Baris Usakli 5ce9f898b2 fix test
Julian Lam 84c1a182e5 Merge remote-tracking branch 'origin/master' into develop
Baris Usakli e9639833c5 add router.all
Julian Lam 1247b4b53b linting
Baris Usakli 28073cc91a lint
Peter Jaszkowiak 904f22522e Merge pull request from NodeBB/scoped-plugins
Support scoped plugin npm packages
Also fix logging in VS Code with the inspector debugger
Julian Lam 184dacf1d7 Merge branch 'master' into develop
Julian Lam c4fbed24f8 Squashed commit of the following:
commit 9c86d9b2904e14927cd7e9679b92aec0951d1063
Merge: ebfa63a 5a7f811
Author: Julian Lam <julian@nodebb.org>
Date:   Thu Jul 20 08:41:39 2017 -0400

    Merge branch 'noscript-login' of https://github.com/An-dz/NodeBB into noscript

commit 5a7f81185e8f9bd7d2d011c3d495988be7e437a3
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Mon Jul 17 23:07:14 2017 -0300

    Rename clashing variable 'next'

commit ebfa63a984073a58c17aa408c363cdb03ef89985
Merge: c1801cd f159d0d
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Jul 17 16:30:40 2017 -0400

    Merge branch 'noscript-logout' of https://github.com/An-dz/NodeBB into noscript

commit c1801cda14e6363491e30b659902e2ae71f7e1f7
Merge: 7a5f9f3 9fd542d
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Jul 17 16:30:31 2017 -0400

    Merge branch 'noscript-register' of https://github.com/An-dz/NodeBB into noscript

commit 7a5f9f35abc834bb72ddddc9ca07d34f2fde8353
Merge: 44851f9 d37b95c
Author: Julian Lam <julian@nodebb.org>
Date:   Mon Jul 17 16:30:10 2017 -0400

    Merge branch 'noscript-compose' of https://github.com/An-dz/NodeBB into noscript

commit f159d0d9ef1b7f600e830a96fdb4b9c87c79bb4a
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Thu Jul 6 12:16:38 2017 -0300

    Prevent form submit

    Required for theme change

commit d37b95cb71d32d4483190609798e244c331db165
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Thu Jul 6 01:49:52 2017 -0300

    Prevent link action with scripts

    Required for the theme change that changes the buttons to `a` tags.

commit 9fd542d8970b7d1a4126f4edc4b44eab7d708fb0
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 19:57:56 2017 -0300

    Fix tests

commit cdad5bf8c2891ad76f7441fd4d8a74b058a14e6d
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 19:09:17 2017 -0300

    Update error handling

commit 4ff11cd136a4fb98483f837e2cebc741380dfe76
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 17:29:08 2017 -0300

    Remove async waterfall

commit df01d44e821a70c984b89e9585a325c3e02c6e37
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 16:59:43 2017 -0300

    Set noscript compose as noscript at start

commit 4bcc380da72239b8315cc849a77a3036e06e4a12
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 16:59:12 2017 -0300

    Remove last useless next

commit b5eac6fea11e209934c0648a7e75ad07a2167123
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 18:35:08 2017 -0300

    Last function requires no next

commit 20a5cce6e6e32a454c304c448383707ec44c75a8
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 18:06:58 2017 -0300

    Remove more useless next calls

commit 85ee22a79bcbbb1995106f43d4c74d6ba9206cab
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 17:46:07 2017 -0300

    Remove useless next calls

commit 7d984c47ad24faac1fe537dee4a5a7d697e8634c
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 15:45:31 2017 -0300

    Support old themes

commit 4a09dfbd08253115c342a9e829c4e6940cecb8cc
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 15:37:23 2017 -0300

    Moved all error handling into helpers function

commit 391aa6e67ef9ab67304005e14ac0633cdb630713
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Thu Jun 8 15:37:37 2017 -0300

    ESLint - Fix mixed conditionals

commit 80ccc6fd581d791f31e7ab62de8de611837bfc3c
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 18:08:15 2017 -0300

    Compose without scripts

commit 2aca811256721238ca0cede4954213d369009885
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 18:00:44 2017 -0300

    Register without scripts

commit 097bb51577fb26f8e22f86dc274cb670ab606a8a
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 16:42:15 2017 -0300

    Logout without scripts

commit d497e08109891079656fee1c145043a9c0e55f2e
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 16:27:10 2017 -0300

    Login without script
Peter Jaszkowiak dc324b36b2 Add test for Plugins.showInstalled
Baris Usakli 18181260e7 closes
Baris Usakli f1f8a587d4 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
# Conflicts:
#	package.json
Barış Soner Uşaklı 0f5be5ae25 remove plugin.hook check
Julian Lam c2f1d254cc Merge branch 'master' into develop
Barış Soner Uşaklı 923bd86662 Widgets refactor ()
* widgets refactor

render widgets server side
widgets can use all the data the template can use

* fix tests
Baris Usakli e0de922ede Revert "widgets refactor"
This reverts commit 9e94edb5aa.
Baris Usakli 9e94edb5aa widgets refactor
render widgets server side
widgets can use all the data the template can use
Julian Lam 121a629de6 linting
Julian Lam 09621a3a3d fixes
Julian Lam 3f2c183cbd Merge branch 'master' into develop
Peter Jaszkowiak 1471fbdc14 Fix tests
Baris Usakli 5167c1aa4f Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Baris Usakli 2f8f69d6af test monthly digest
Baris Usakli 74ed033e4a fix digest test
Marc-Aurèle DARCHE 6248e5562f Fix /apple-touch-icon not sending uploaded file
This fixes the following error:

$ wget https://nodebb.yourdomain/apple-touch-icon

28/6 09:57:06 [28332] - error: /apple-touch-icon
 Error: ENOENT: no such file or directory, stat '/home/sweet/nodebb/public/assets/uploads/system/touchicon-orig.png'
    at Error (native)
Baris Usakli 1b0c6741f8 Merge remote-tracking branch 'refs/remotes/origin/master' into develop
Barış Soner Uşaklı 8d8f0a391f Merge pull request from NodeBB/private-feeds
Private feeds, closes