Enable imports in custom email templates (#6052)
* Enable imports in custom email templates * Compile emails on config change * Add error logging * Add emailer tests * Fix tests * Only build when config changesv1.18.x
Peter Jaszkowiak
7 years ago
committed by
Barış Soner Uşaklı
parent
415940af02
commit
4fcedc6f31
@ -0,0 +1,141 @@
|
||||
'use strict';
|
||||
|
||||
var SMTPServer = require('smtp-server').SMTPServer;
|
||||
var assert = require('assert');
|
||||
var fs = require('fs');
|
||||
var path = require('path');
|
||||
|
||||
var Plugins = require('../src/plugins');
|
||||
var Emailer = require('../src/emailer');
|
||||
var Meta = require('../src/meta');
|
||||
|
||||
describe('emailer', function () {
|
||||
var onMail = function (address, session, callback) { callback(); };
|
||||
var onTo = function (address, session, callback) { callback(); };
|
||||
|
||||
var template = 'test';
|
||||
var email = 'test@example.org';
|
||||
var language = 'en-GB';
|
||||
var params = {
|
||||
subject: 'Welcome to NodeBB',
|
||||
};
|
||||
|
||||
before(function (done) {
|
||||
var server = new SMTPServer({
|
||||
allowInsecureAuth: true,
|
||||
onAuth: function (auth, session, callback) {
|
||||
callback(null, {
|
||||
user: auth.username,
|
||||
});
|
||||
},
|
||||
onMailFrom: function (address, session, callback) {
|
||||
onMail(address, session, callback);
|
||||
},
|
||||
onRcptTo: function (address, session, callback) {
|
||||
onTo(address, session, callback);
|
||||
},
|
||||
});
|
||||
|
||||
server.on('error', function (err) {
|
||||
throw err;
|
||||
});
|
||||
server.listen(4000, done);
|
||||
});
|
||||
|
||||
// TODO: test sendmail here at some point
|
||||
|
||||
it('plugin hook should work', function (done) {
|
||||
var error = new Error();
|
||||
|
||||
Plugins.registerHook('emailer-test', {
|
||||
hook: 'filter:email.send',
|
||||
method: function (data, next) {
|
||||
assert(data);
|
||||
assert.equal(data.to, email);
|
||||
assert.equal(data.subject, params.subject);
|
||||
|
||||
next(error);
|
||||
},
|
||||
});
|
||||
|
||||
Emailer.sendToEmail(template, email, language, params, function (err) {
|
||||
assert.equal(err, error);
|
||||
|
||||
Plugins.unregisterHook('emailer-test', 'filter:email.send');
|
||||
done();
|
||||
});
|
||||
});
|
||||
|
||||
it('should build custom template on config change', function (done) {
|
||||
var text = 'a random string of text';
|
||||
|
||||
// make sure it's not already set
|
||||
Emailer.renderAndTranslate('test', {}, 'en-GB', function (err, output) {
|
||||
assert.ifError(err);
|
||||
|
||||
assert.notEqual(output, text);
|
||||
|
||||
Meta.configs.set('email:custom:test', text, function (err) {
|
||||
assert.ifError(err);
|
||||
|
||||
// wait for pubsub stuff
|
||||
setTimeout(function () {
|
||||
Emailer.renderAndTranslate('test', {}, 'en-GB', function (err, output) {
|
||||
assert.ifError(err);
|
||||
|
||||
assert.equal(output, text);
|
||||
done();
|
||||
});
|
||||
}, 500);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
it('should send via SMTP', function (done) {
|
||||
var from = 'admin@example.org';
|
||||
var username = 'another@example.com';
|
||||
|
||||
onMail = function (address, session, callback) {
|
||||
assert.equal(address.address, from);
|
||||
assert.equal(session.user, username);
|
||||
|
||||
callback();
|
||||
};
|
||||
|
||||
onTo = function (address, session, callback) {
|
||||
assert.equal(address.address, email);
|
||||
|
||||
callback();
|
||||
done();
|
||||
};
|
||||
|
||||
Meta.configs.setMultiple({
|
||||
'email:smtpTransport:enabled': '1',
|
||||
'email:smtpTransport:user': username,
|
||||
'email:smtpTransport:service': 'nodebb-custom-smtp',
|
||||
'email:smtpTransport:port': 4000,
|
||||
'email:smtpTransport:host': 'localhost',
|
||||
'email:smtpTransport:security': 'NONE',
|
||||
'email:from': from,
|
||||
}, function (err) {
|
||||
assert.ifError(err);
|
||||
|
||||
// delay so emailer has a chance to update after config changes
|
||||
setTimeout(function () {
|
||||
assert.equal(Emailer.fallbackTransport, Emailer.transports.smtp);
|
||||
|
||||
Emailer.sendToEmail(template, email, language, params, function (err) {
|
||||
assert.ifError(err);
|
||||
});
|
||||
}, 200);
|
||||
});
|
||||
});
|
||||
|
||||
after(function (done) {
|
||||
fs.unlinkSync(path.join(__dirname, '../build/public/templates/emails/test.js'));
|
||||
Meta.configs.setMultiple({
|
||||
'email:smtpTransport:enabled': '0',
|
||||
'email:custom:test': '',
|
||||
}, done);
|
||||
});
|
||||
});
|
||||
Loading…
Reference in New Issue