Commit Graph

8278 Commits (445a840b8802c49bbc295dccea60a499717554fc)

Author SHA1 Message Date
Julian Lam 558a2d739c feat: load timeago strings client-side
9adaccd036 introduced the ability to
configure an assetBaseUrl, but the timeago strings were still
calling a hardcoded value as it was handled server-side. There's
no need for the strings to be loaded until timeago is initialised.
Barış Soner Uşaklı 79e847d424 fix: , only navigate if user is in same topic
Julian Lam 8ff09630b6 fix(openapi): new api definition
Julian Lam 9adaccd036 feat: +assetBaseUrl, -l10BaseUrl, -requireBaseUrl
Additional base URLs were necessary for benchpress and translator,
and in order to not clutter the API response with needless one-
time use base URLs, I decided to use a single base that is used
by all of the services, assetBaseUrl.
Misty (Bot) 75ef4bbe34 Latest translations and fallbacks
Julian Lam d6297b28e9 fix: tests
Misty (Bot) 8a6bc10eb1 Latest translations and fallbacks
Julian Lam def16f9e97 feat: introduce overridable l10nBaseUrl config value
Misty (Bot) 9846498df7 Latest translations and fallbacks
Barış Soner Uşaklı dfabd0a3fe feat: remove administrator property from public routes
Barış Soner Uşaklı 4216c277d5 feat: focus username when modal is shown
Misty (Bot) 3463fc51c6 Latest translations and fallbacks
Julian Lam 2ee6248316 refactor: for codeclimate
Julian Lam a7071bb808 fix: map instead of forEach in privileges save
Julian Lam a716a5529c
feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals ()
* feat: privileges save button, , WIP

* fix: disable firefox autocomplete on privilege form fields

* feat: closes  privilege changes commit on save

- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs

* fix(tests): remove duplicate template helper test

* fix(tests): broken template helper test

* feat: confirm dialogs for all privilege copy actions

Also, ability to add user to a privilege table without needing
to refresh the privilege table.

* feat: group row addition w/o table refresh

breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges
no longer make socket calls to the following hooks:

- filter:privileges.list, filter:privileges.admin.list,
  filter:privileges.global.list, filter:privileges.groups.list,
  filter:privileges.admin.groups.list,
  filter:privileges.gloval.groups.list

The filters are still called, but done before the helper method
is called, and the results are passed in instead. This change
should only affect you if you directly call the helper methods,
otherwise the change is transparent.

* fix: stale ajaxify data on privilege category switch

* fix: implicit privileges not showing for user privs

* fix: groups, not group, also fix tests

* fix(tests): again

* fix: wrong tpl rendered when adding group to global priv table
Misty (Bot) 8da742e065 Latest translations and fallbacks
Misty (Bot) 903c407171 Latest translations and fallbacks
Barış Soner Uşaklı e7a502e0aa feat: add ability to search groups in group details page
Barış Soner Uşaklı 519e665939 fix: , go to first unread instead of last read
Misty (Bot) 029f477434 Latest translations and fallbacks
Barış Soner Uşaklı 9e80a9efdd fix: , dont show modal on search
Barış Soner Uşaklı fb7bb8d400 feat: use category selector in category page
fix privilege shortcuts in group page after search
Barış Soner Uşaklı 560f3eb173 feat: css fixes
Barış Soner Uşaklı 91411cc47c feat: add privileges shortcut to groups list
fix issues with escape group names
Misty (Bot) caa78cc1f6 Latest translations and fallbacks
Julian Lam c705e08a76 feat: allow direct link to flag from post tools,
Barış Soner Uşaklı 8415d2f014 fix: api test
Barış Soner Uşaklı c4829fd8c2 feat: allow changing requirejs base url
Barış Soner Uşaklı bbc7737e14 feat: ability to clear cache from acp
Barış Soner Uşaklı 69fb15276c fix: tests
Barış Soner Uşaklı 8d8117ffa1 feat: reduce amount of data loaded on acp admin page
get rid of socket call and use ajaxify.data.categories
Misty (Bot) d580cf01c3 Latest translations and fallbacks
Barış Soner Uşaklı f48d155670 fix: tests
Barış Soner Uşaklı fd4c3cda42 fix: , remove new notif alert
Julian Lam 8473e165a6 fix: too small sortable handle for ACP>Manage>Categories
The handle was initially just the icon, but now it is the icon
and the category label itself.
Misty (Bot) 93d1ceccdd Latest translations and fallbacks
Misty (Bot) 43e9c25d26 Latest translations and fallbacks
Barış Soner Uşaklı db07dd8565 fix: less fixes for category dropdown
Barış Soner Uşaklı 24535a62e7 feat: make category tools in acp a dropdown
add view category, view privileges into dropdown
Barış Soner Uşaklı 609e37a67b feat: remove deprecated utils.walk
Julian Lam 55b0e902fb feat: consolidation of flags to reduce flagspam,
Squashed commit of the following:

commit c6d09396208a10c244d7b3d22ffd2d7dd1274d3a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 13:41:32 2020 -0400

    fix: more tests

commit 32f9af2a87a81fa62ecca01e71d6f0d5b9d37ba1
Merge: e50907535 4eae927d1
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:53:04 2020 -0400

    Merge remote-tracking branch 'origin/master' into singleton-flags

commit e50907535109dbdbe8f15c3e2fcdf22d90b1332a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:52:46 2020 -0400

    fix: controllers-admin test

commit fd5af99e303de48a80b0ccc166eee19175cf232b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:26:55 2020 -0400

    fix(tests): dummy commit to trigger travisCI

commit c452a6ffcfaef91403de084c4ae16795cb23c60e
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:05:09 2020 -0400

    fix(openapi): openapi spec changes

commit 8089a74e89128141ab1e6f8ff83447114b3b846b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:48:00 2020 -0400

    fix: reversing the order of reports for display purposes

commit a099892b377333561c72f1ad5b6b20ddb4ce8a96
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:45:44 2020 -0400

    refactor: run all flag creation calls in a single batch

commit b24999682f9d5a33a08a049749c1f0eb4f00facc
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:08:23 2020 -0400

    feat: handling multiple reporters per flag, 

commit 08c75c020021ada754bf0e39eae77d631b01dee5
Author: Julian Lam <julian@nodebb.org>
Date:   Thu Jul 16 20:53:18 2020 -0400

    feat: upgrade script for 
psychobunny 4c90fac412 fix: cursor for category select
psychobunny bc26883aed refactor: setting codeclimate to A
psychobunny 8769e28b28 fix: api docs for admin/manage/groups/x
psychobunny a6ae69737b Merge branch 'master' of https://github.com/NodeBB/NodeBB
psychobunny 10e4ae629c feat: highlight privs row if group is added / navigating from group page
psychobunny 53f6139b8c feat: prevent navigation away from groups page if changes are unsaved
psychobunny 2c83278f97 feat: quick access dropdown on groups page to access privileges page
Barış Soner Uşaklı 42af4b572b fix: api tests
Barış Soner Uşaklı 844f2b4ed0 feat: , allow editing category of queued topic
Barış Soner Uşaklı ec05783507 feat: remove js-enabled.css
Barış Soner Uşaklı a46adb3fd5 fix: more tests
Barış Soner Uşaklı 67ca5e3256 fix: tests
Barış Soner Uşaklı 23a9a334cd feat: short more info
Barış Soner Uşaklı 2485a55092 feat: , allow editing title before posting from queue
Barış Soner Uşaklı 8ddc8dd10f refactor: make msg pretty
Barış Soner Uşaklı 764969ab29 feat: show language when key isn't found
Barış Soner Uşaklı 1e7397b1b8 feat: allow searching categories in ACP
Barış Soner Uşaklı 320008cd49 feat: , don't scroll chat to bottom if user scrolled up
psychobunny 06143ca7d7 feat: added quick link to edit privileges on the category edit page
Julian Lam 1e14af4503 fix: composer textarea placeholder l10n /cc @pitaj
Julian Lam 9fb9185fa7 feat: hide some filters behind 'more filters' button
Julian Lam d52d7bdb10 feat: collapsible daily flags graph
Julian Lam e3e55f25d0 refactor: flag sanity checks, +feat: flag limits
- Added new config flag:limitPerTarget, to disallow flags after an item has
  already been flagged x times (default 0, or infinite)
- New zset flags:byTarget, score is the number of times a flag has been made
  against that item
- "already-flagged" translation key removed, now "post-already-flagged" or
  "user-already-flagged" -- this fixed bug where flagging a user you've already
  flagged would tell you you've already flagged this post already.
- Refactored Flags.canFlag to throw errors only, instead of returning boolean
- Updated ACP form inputs for reputation settings page to be more bootstrappy
- +1 upgrade script
Julian Lam 1441720962 feat: logic for flag note editing,
Julian Lam f85a45c722 feat: logic for flag note deletion,
Barış Soner Uşaklı 5e984d10f0 fix:
Julian Lam 2286ee2a61 fix: invalid session error modal during logout
A brief flash can be seen, but this is exacerbated by slow
connections and/or slow server response.
Julian Lam 3379d65f36 feat: fire action:flag.showModal on flag modal appearance
Barış Soner Uşaklı 00d39fb32c feat: , export groups members as csv
Barış Soner Uşaklı 3dcf538773 feat: , allow wildcard search for uid/email
Barış Soner Uşaklı 46a6686300 fix: category search in selector
Barış Soner Uşaklı c513b88dff feat: , daily downvote limits
Barış Soner Uşaklı 4adbf87c6c feat: warn user if whitelisted tags are less than minTags
Barış Soner Uşaklı 658dd03b03
feat: add tools to recent/unread ()
* feat: add tools to recent/unread

* fix: open api spec

* fix: more api spec
Julian Lam 4f51838df8 feat: fire new hooks on chat message editing
Barış Soner Uşaklı 9eb748b985 fix: , fix url to merged topic in subfolder installs
Barış Soner Uşaklı 5f1865c0b7 fix: openapi
Barış Soner Uşaklı 65c0adc720 fix: openapi
Barış Soner Uşaklı ac6b571ed5 fix: dont allow searching by email/ip if not privileged
Julian Lam c468942f14 fix(openapi): tests
Julian Lam f3441fce4f fix: admin privileges client-side regression
Julian Lam da29b947bf feat: add js-enabled.css to list of preloaded css files
Barış Soner Uşaklı bd228d5ee7 feat: fix blocksCount not being returned on user profile
add hook action:user.blocks.toggle
Misty (Bot) fe908cc022 Latest translations and fallbacks
Julian Lam 6cb31791ff feat: polish for user blocks UX
Misty (Bot) a1a5424047 Latest translations and fallbacks
Julian Lam 6931f29d53 feat: allow flagging of user acounts from post tools menu
Misty (Bot) 1b1e9b6725 Latest translations and fallbacks
Misty (Bot) e66b526ca0 Latest translations and fallbacks
Barış Soner Uşaklı e09ab3dc19 feat: closes , allow configuring max topic count
Barış Soner Uşaklı 2355d9d5dd fix: escape navigation item fields, theme:id, category fields
Misty (Bot) c0857f6390 Latest translations and fallbacks
Misty (Bot) 9b20d0ce20 Latest translations and fallbacks
Barış Soner Uşaklı e53a18f219 fix: ,
Barış Soner Uşaklı bffb830d87 feat: add missing translation key
Barış Soner Uşaklı c718b7293e feat: , min/max tags per category
Barış Soner Uşaklı ed4b5caf2c fix: copy settings showing empty category selection
Barış Soner Uşaklı 0482fb2998 feat: use tags partial instead of post_bar
Barış Soner Uşaklı 8482a54a68 fix: don't init autocomplete if user doesn't have privs
Barış Soner Uşaklı 4f6b6c5631 feat: hide elements if search element is a direct child of dropdown
this fixes themes if they put the search input inside the dropdown
Misty (Bot) d50f7c7dfa Latest translations and fallbacks
Barış Soner Uşaklı f03ca0867b fix: tests
Barış Soner Uşaklı 8383992dcc feat: move export functions into child processes
Barış Soner Uşaklı 48b41debe6
fix: vulnerability in cover and admin uploads ()
* fix: vulnerability in cover and admin uploads

* fix: remove old test

* fix: update tests
Misty (Bot) 76c577fa3c Latest translations and fallbacks
Misty (Bot) 55f8f99bcd Latest translations and fallbacks
Julian Lam 040e6a9a4c fix: reverse tabnabbing exploit in post images
Misty (Bot) 757cfe80be Latest translations and fallbacks
Misty (Bot) f5b3713313 Latest translations and fallbacks
Barış Soner Uşaklı bfd7eafe5b fix: ban
Barış Soner Uşaklı b459592a4e Merge branch 'master' of https://github.com/NodeBB/NodeBB
Barış Soner Uşaklı f70d1648c6 feat: show more relevant snippets
Julian Lam 4cae893f49 fix(openapi): tests for
Julian Lam 35a06a8419 feat: breadcrumbs for ip-blacklist/post queue/flags
Misty (Bot) 7fe9c1a26d Latest translations and fallbacks
Julian Lam 5a367ecbb4 fix: remove use of 'hidden' class in navbar toggling
Julian Lam f909ed2541 feat: show editor in post diffs if available
Julian Lam 2515aa77ba fix: bug where category privs page thought it was on admin
Julian Lam b3115ea813 fix:
Misty (Bot) cdf81159df Latest translations and fallbacks
Julian Lam d5af976915 feat: flags' quick assignment
Barış Soner Uşaklı 42466d3c6e fix: add missing translations
Julian Lam 58b3d608fc feat: allow post diffs to be restored,
Misty (Bot) 8f81651e2f Latest translations and fallbacks
Barış Soner Uşaklı 3a80a1651a feat: add missing translation
Barış Soner Uşaklı 6349fa03e1 feat: more search changes
Barış Soner Uşaklı 4b38533b15 feat: more merge/search fixes
Barış Soner Uşaklı bb3aa54006 feat: merge changes
allow selecting main topic to merge into
allow specifying a new title for merge topic
upon merge go to correct topic
new tests for merging with options
Barış Soner Uşaklı 8591f5d2cc fix: return false
Barış Soner Uşaklı 5fd05dc942 feat: more search & merge fixes
Barış Soner Uşaklı c4bdeae06e feat: merge improvements wip
Barış Soner Uşaklı a255c8f6fd fix: language
Julian Lam 6a96944247 fix(openapi): api change for
Misty (Bot) 2287963388 chore: latest translations and fallbacks
Barış Soner Uşaklı d92032dad1 fix: prevent logout form from submitting
Julian Lam 4d60eac60f feat: options to delete account, content, or both
Julian Lam 67aca822e6 feat: account content deletion, closes
Julian Lam 656b391fc5 feat: add missing language files for
Misty (Bot) 8019d316e2 Latest translations and fallbacks
Barış Soner Uşaklı 50703db879 fix: , dont break history
Barış Soner Uşaklı 0c265a41d4 fix: , go to hash when entering topic
Julian Lam a82e9bd7f6
feat: privileges for Admin Control Panel ()
* feat: acp privileges (WIP)

* fix: restore global privilege hooks

* refactor: using cid 0 in admin privs

* fix: no need for zebrastripe-reset

* feat: manage:categories privilege WIP

* feat: renamed prefix to admin:, settigns and dashboard privs

* fix: nofocus on acp privs group find modal

* refactor: privileges.x.get() to not used hardcoded privs

* fix: crash if unable to get latest version

* feat: setting acp priv

* Revert "fix: crash if unable to get latest version"

This reverts commit afdb235f48eb0072d88de45f3a1e0151281095b3.

* feat: user/privilege acp privs

* fix: category selector in manage/privileges

* fix: guests potentially becoming admins

* fix: bug in setting admin privs

* fix: some last minute things + api docs

* fix: some more last minute fixes
Barış Soner Uşaklı 30cc83c033 fix: , revert event delete
Julian Lam 09184f4027 fix: new language tag for select_tags
Julian Lam 260a482caa fix: remove duplicate link to manage/tags in settings/tags
Misty (Bot) 73055bfccc Latest translations and fallbacks
Barış Soner Uşaklı 1b5d5425b4 fix: handle search tag permission as well
Barış Soner Uşaklı 2100a03c1a refactor: change name to privileges to match other apis
cryptoethic f6b92d241a
fix: checking correct permissions for user search ()
* fix: checking correct permissions for user search

* fix: missing permissions porperty in openapi /api/search