fix: race condition where `navigator.update` was called when it should not be

isekai-main
Julian Lam 2 years ago
parent 9f9a835fcb
commit fa643eb808

@ -581,9 +581,9 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct
function animateScroll() { function animateScroll() {
function reenableScroll() { function reenableScroll() {
// Re-enable onScroll behaviour // Re-enable onScroll behaviour
$(window).on('scroll', navigator.delayedUpdate); setTimeout(() => { // fixes race condition from jQuery — onAnimateComplete called too quickly
const scrollToRect = scrollTo.get(0).getBoundingClientRect(); $(window).on('scroll', navigator.delayedUpdate);
navigator.update(scrollToRect.top); }, 50);
} }
function onAnimateComplete() { function onAnimateComplete() {
if (done) { if (done) {

Loading…
Cancel
Save