From fa643eb80893e3e5d51dab8eea8f06f9c9c7e93d Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Mon, 19 Sep 2022 11:09:22 -0400 Subject: [PATCH] fix: race condition where `navigator.update` was called when it should not be --- public/src/modules/navigator.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/public/src/modules/navigator.js b/public/src/modules/navigator.js index 2dcbdb6aec..e6933999c7 100644 --- a/public/src/modules/navigator.js +++ b/public/src/modules/navigator.js @@ -581,9 +581,9 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct function animateScroll() { function reenableScroll() { // Re-enable onScroll behaviour - $(window).on('scroll', navigator.delayedUpdate); - const scrollToRect = scrollTo.get(0).getBoundingClientRect(); - navigator.update(scrollToRect.top); + setTimeout(() => { // fixes race condition from jQuery — onAnimateComplete called too quickly + $(window).on('scroll', navigator.delayedUpdate); + }, 50); } function onAnimateComplete() { if (done) {