Merge pull request #5916 from NodeBB/uglify-errors

Catch uglify errors

src/meta/minifier.js

@@ -230,23 +230,23 @@ function minifyJS(data, callback) {
 			scripts[ref.filename] = ref.source;
 		});
 
-		try {
+		var minified = uglifyjs.minify(scripts, {
-			var minified = uglifyjs.minify(scripts, {
+			sourceMap: {
-				sourceMap: {
+				filename: data.filename,
-					filename: data.filename,
+				url: data.filename + '.map',
-					url: data.filename + '.map',
+				includeSources: true,
-					includeSources: true,
+			},
-				},
+			compress: false,
-				compress: false,
+		});
-			});
 
-			async.parallel([
+		if (minified.error) {
-				async.apply(fs.writeFile, data.destPath, minified.code),
+			return callback(minified.error);
-				async.apply(fs.writeFile, data.destPath + '.map', minified.map),
-			], callback);
-		} catch (e) {
-			callback(e);
 		}
+
+		async.parallel([
+			async.apply(fs.writeFile, data.destPath, minified.code),
+			async.apply(fs.writeFile, data.destPath + '.map', minified.map),
+		], callback);
 	});
 }
 actions.minifyJS = minifyJS;