fix: reverse uid checks

v1.18.x
Barış Soner Uşaklı 5 years ago
parent 303bffdb5f
commit 7331faed9f

@ -4,7 +4,6 @@ const _ = require('lodash');
const db = require('../database'); const db = require('../database');
const user = require('../user'); const user = require('../user');
const cache = require('../cache'); const cache = require('../cache');
module.exports = function (Groups) { module.exports = function (Groups) {
@ -25,7 +24,7 @@ module.exports = function (Groups) {
}; };
Groups.isMember = async function (uid, groupName) { Groups.isMember = async function (uid, groupName) {
if (!uid || parseInt(uid, 10) <= 0 || !groupName) { if (!uid || !(parseInt(uid, 10) > 0) || !groupName) {
return false; return false;
} }
@ -66,7 +65,7 @@ module.exports = function (Groups) {
}; };
Groups.isMemberOfGroups = async function (uid, groups) { Groups.isMemberOfGroups = async function (uid, groups) {
if (!uid || parseInt(uid, 10) <= 0 || !groups.length) { if (!uid || !(parseInt(uid, 10) > 0) || !groups.length) {
return groups.map(groupName => groupName === 'guests'); return groups.map(groupName => groupName === 'guests');
} }
const cachedData = {}; const cachedData = {};

Loading…
Cancel
Save