From 7331faed9f0872bce460ec1a5c90b06b65e0c490 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Wed, 29 Jul 2020 11:48:32 -0400
Subject: [PATCH] fix: reverse uid checks

---
 src/groups/membership.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/groups/membership.js b/src/groups/membership.js
index c0e30820bb..e2b0bfc93a 100644
--- a/src/groups/membership.js
+++ b/src/groups/membership.js
@@ -4,7 +4,6 @@ const _ = require('lodash');
 
 const db = require('../database');
 const user = require('../user');
-
 const cache = require('../cache');
 
 module.exports = function (Groups) {
@@ -25,7 +24,7 @@ module.exports = function (Groups) {
 	};
 
 	Groups.isMember = async function (uid, groupName) {
-		if (!uid || parseInt(uid, 10) <= 0 || !groupName) {
+		if (!uid || !(parseInt(uid, 10) > 0) || !groupName) {
 			return false;
 		}
 
@@ -66,7 +65,7 @@ module.exports = function (Groups) {
 	};
 
 	Groups.isMemberOfGroups = async function (uid, groups) {
-		if (!uid || parseInt(uid, 10) <= 0 || !groups.length) {
+		if (!uid || !(parseInt(uid, 10) > 0) || !groups.length) {
 			return groups.map(groupName => groupName === 'guests');
 		}
 		const cachedData = {};