Introduced new method ".loadImages()" in posts client side lib
to handle viewport height changes when loading images. Requires
nodebb-plugin-markdown@5.0.0
@BenLubar @boomzillawtf
The old behaviour would scroll the post anchor to the midline, but
this was inferior UX for long posts since the top half of the
screen is essentially stuff you didn't want to see.
The new logic is as follows:
- If the target post is smaller than the browser viewport, it will
scroll in such a way that the entire post is vertically centered
(post midline matching viewport midline)
- If the target post is larger than the browser viewport, it will
scroll in such a way that the top of the post is located just
under the navbar, maximizing the target post's content.
- Updated themes to relocate their anchors to in between posts
If you `require(['string'], function (stringLib) { S = stringLib; })` it is an async call and thus you need to ensure any usage of `S` happens when this is resolved.
- Fixes issue with parentheses in translations (closes#4107)
- No longer marking translation keys invalid if they contain HTML,
as that was probably not performant. Instead, parameters will
simply be escaped via the StringJS library.
Guests now trigger topic notifications, and the translator has
been updated so that translations inside translations are
handled in a way that doesn't cause the translator to explode.
Closes#2668
commit 3d4f494ed3257bceda8f6f82057cab83f0f252b3
Author: Julian Lam <julian@designcreateplay.com>
Date: Fri Dec 11 12:06:42 2015 -0500
theme minvers for #2668
commit b608ce61854f8195143685bb9753b80d32b26e95
Author: Julian Lam <julian@designcreateplay.com>
Date: Fri Dec 11 12:01:03 2015 -0500
Allowing chat modal to edit and delete messages
re: #2668
commit 0104db90a4070582f3938b6929dae35f985bac35
Author: Julian Lam <julian@designcreateplay.com>
Date: Fri Dec 11 11:51:23 2015 -0500
Fixed issue where newSet calculations were off
... sometimes.
Also, rendering of edited messages now parses a template partial,
instead of just replacing the content.
commit 5cb6ca600425ca9320c599b32306e93dcc5aa4ce
Author: Julian Lam <julian@designcreateplay.com>
Date: Fri Dec 11 11:07:12 2015 -0500
If edited content matches existing content...
... then edit is aborted.
commit 6e7495247b1895589c716db29f919a934087b924
Author: Julian Lam <julian@designcreateplay.com>
Date: Fri Dec 11 11:05:08 2015 -0500
some linting and fixed issue where new msgs when deleted would crash server
commit db4a9e40d6dff44569c2437378121db8fdf75cf8
Author: Julian Lam <julian@designcreateplay.com>
Date: Tue Dec 8 17:25:56 2015 -0500
Message deletion for #2668, and fixed bug
Fixed bug where chat modal would spawn even though user was sitting
on the /chats page.
commit a5aa2498ab4a8bba02a6daa43a9dbed7b3e37976
Author: Julian Lam <julian@designcreateplay.com>
Date: Tue Dec 8 14:55:23 2015 -0500
wiring up the edit button, #2668
commit 5f2afdcf6f2b9eae6b5873ca100149e65e3d385d
Author: Julian Lam <julian@designcreateplay.com>
Date: Tue Dec 8 14:20:39 2015 -0500
added indicator to show if and when a message had been edited
commit e8301132d525c1b9fd46c98cdb282ac7ea7a0d7f
Author: Julian Lam <julian@designcreateplay.com>
Date: Tue Dec 8 14:06:39 2015 -0500
Allowing editing of chat messages
commit bfd991be1cb1769599f7d5d2b1638e313c3c2dcb
Author: Julian Lam <julian@designcreateplay.com>
Date: Tue Dec 8 10:33:49 2015 -0500
Added messageId to messages object return
commit 0306ee6657b3288dd4547c66869d7d4ece0b31ad
Author: Julian Lam <julian@designcreateplay.com>
Date: Tue Dec 8 08:20:17 2015 -0500
WIP #2668
Initially, the removed block of code was used to stop the chat modal
from popping up altogether, since the /chats page was usable on
mobile. Since the re-design, only the contact list is shown on
mobile, leaving the modal as the main way to communicate. So, this
intercepting code is actually interfering now.
As I did not realise both groups and users call the same
coverPhoto lib, the removeFn has to be in the user client js,
and not in the coverPhoto lib.
... of course, it *could* be in there, but it would be hacky.
Raphael Beer
barisusakli
Julian Lam
psychobunny
Julian Lam
pichalite
Barış Soner Uşaklı
pichalite
Ole R