Introduced new method ".loadImages()" in posts client side lib
to handle viewport height changes when loading images. Requires
nodebb-plugin-markdown@5.0.0
@BenLubar @boomzillawtf
The old behaviour would scroll the post anchor to the midline, but
this was inferior UX for long posts since the top half of the
screen is essentially stuff you didn't want to see.
The new logic is as follows:
- If the target post is smaller than the browser viewport, it will
scroll in such a way that the entire post is vertically centered
(post midline matching viewport midline)
- If the target post is larger than the browser viewport, it will
scroll in such a way that the top of the post is located just
under the navbar, maximizing the target post's content.
- Updated themes to relocate their anchors to in between posts
If you `require(['string'], function (stringLib) { S = stringLib; })` it is an async call and thus you need to ensure any usage of `S` happens when this is resolved.
- Fixes issue with parentheses in translations (closes#4107)
- No longer marking translation keys invalid if they contain HTML,
as that was probably not performant. Instead, parameters will
simply be escaped via the StringJS library.
psychobunny
barisusakli
Julian Lam
Barış Soner Uşaklı
pichalite
pichalite
Julian Lam
Ole R