240f563ab0
fix : #7477
6 years ago
c289b904e6
fix : #7473
6 years ago
962b7f73d3
fix : #7472
6 years ago
dd8d4f206a
fix: remove async.series, dont crash if postAtIndex is undefined
6 years ago
b4a9bb10e5
fix : #7468
6 years ago
697a6597f3
fix : #7444 Re-factor handling of og:image tags ( #7463 )
...
* fix: display proper site logo or og-image with sizes in head
* fix: refactor og:image logic, #7444
- Updated logic to set additional og:image tags based on more
factors
- logo.png fallback
* feat: save image sizes on post upload, re: #7444
* fix: awaiting addTags in topic controller
* fix: pass strings to meta tags object
* fix: sending absolute image url to meta tag
* fix: removed unneeded async and requiring sync db
* feat: upgrade to calculate image sizes for all post uploads tracked
* fix: tests
6 years ago
745a9589e9
Use topics:read privilege for topic filtering use cases ( #7462 )
...
* fix: use topics:read privilege for topic filtering use cases
* fix: tests
* fix: more broken tests
6 years ago
45d7e37ae8
fix: tests
6 years ago
b48b6d75e5
fix: callbacks
6 years ago
f8fa659642
fix don't crash if settings are not passed in
6 years ago
7addc5a0e2
fix: return early if keys is empty
6 years ago
b3962c1694
fix: return early if keys is empty
6 years ago
6cd3ac5b9b
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
b71e0eb179
fix: prevent infinite loops if category is already in children
6 years ago
d2cfe6b946
Moved onSuccessfulLogin call from plugins to core, + auth verification hook ( #7416 )
...
* fix : #7412 , calling controllers.onSuccessfulLogin in core
* feat: added plugin hook for auth validation
6 years ago
b2fbeb053a
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
4732bed3db
fix : #7448
...
don't set parent to itself
6 years ago
73d14e4516
fix: return early if there are not blocked uids
6 years ago
7211dde7b9
feat: #7358
6 years ago
756dfd8ae6
fix : #7008
6 years ago
cbfbcee50f
fix : #7406
6 years ago
aecdf739fd
fix: change user/system cpu usage
6 years ago
5eaa14e746
fix: strip exif data on image uploads
6 years ago
2b6f1a05bf
feat: admin/groups style change
6 years ago
db47753877
feat: add process cpu usage to admin
6 years ago
684175f7d7
fix : #7413
6 years ago
e331f6b51d
fix : #7414
6 years ago
0360f6e1cb
fix: l2spread @baris nib
6 years ago
6c1f9c3c46
fix: restored email logo to all outgoing emails
6 years ago
e613f88b29
use params
6 years ago
23da300958
feat: pass options to digest
6 years ago
9731350812
fix: incorrect teaserPost logic
6 years ago
43c4eb2350
fix: normalized font sizes for paragraphs in digest
6 years ago
d3a10628e7
fix: broken 50% border radius on emails, failing tests
6 years ago
d813a77a62
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
6472a06515
fix: hook names getting objectified by winston
6 years ago
3a7f1c192b
fix: failing tests from revamped-emails branch
6 years ago
f32a992237
feat: revamp email templates to be more style agnostic ( #7375 )
...
* feat: re-designed digest
Updated design, logic no longer shows "no topics", just doesn't
show the list at all, teaser re-retrieved for digest so that it
always grabs a teaser even if there is no reply, changed default
email background to a light grey.
* fix: minor padding issues in digest
* fix: banned template
* fix: invitation.tpl
* fix: removed unused notif_chat and notif_post email templates
* fix: notification template
* fix: registration_accepted template
* fix: reset tpl
* fix: test tpl
* fix: email verify tpl
* fix: reset notify tpl
* fix: welcome tpl
* fix: additional minor font fixes
* fix: removed unused email header image assets
* fix: internationalised 'your daily digest' string
* fix: broken url in digest 🤦
* feat: added RTL support for emailer
/cc @PostMidnight
6 years ago
d722f3b8b6
fix: mounting of all-route middlewares to router instead of app
...
related to julianlam/nodebb-plugin-session-sharing#73
These three lines haven't changed in two years, but it makes more
sense for them to be called against the relative path router,
otherwise req.originalUrl contains the relative path, which is
not necessary.
6 years ago
f972f75202
fix: incorrect returnTo set in registerComplete
6 years ago
eafe76debb
feat: add vote status to getPostData API call
6 years ago
7a5344533e
fix: tests for #7385
6 years ago
57069a5c48
fix : #7385 better handling for errors in Adv>Databases
6 years ago
c01d43e01d
feat: quick search
6 years ago
949b10f132
fix: no relative path needed in req.session.returnTo
...
re: julianlam/nodebb-plugin-session-sharing#73
6 years ago
c2e7ae7f41
fix : #7373
6 years ago
2996a5dc25
fix : #7359
6 years ago
c6ad8fae2a
fix : #7354
6 years ago
efd7d953de
fix: uid check
6 years ago
c24dcf78b7
fix: uid checks
6 years ago
5917dec288
fix: only allow numbers as scores ( #7356 )
...
* zadd score checks
* fix: only allow numbers as scores
* fix: convert values to strings
6 years ago
fe63fca846
fix: remove debug logs
6 years ago
bcd62586e2
fix: database 0 was being replaced with undefined because 0 is falsy
6 years ago
ba90bf3114
feat: check overide
6 years ago
f2d7f75ee2
feat: check CI failure
6 years ago
2e2c3ac110
fix : #7352
6 years ago
aca0556052
fix : #7261 , banned users still get digests
6 years ago
8c68780e54
fix : #7350
6 years ago
0c09b7402d
feat: logging password resets and errors into event log
...
closes #7343 , also adds tests for password reset socket calls
6 years ago
fab52b840c
fix: prevent crash if results.stats or results.serverStatus is undefined
6 years ago
70d9c6c4ce
fix : #7232
6 years ago
8e3bf58106
fix : #7338
6 years ago
56a493d873
fix: dont crash if userData is undefined #7262
6 years ago
a2f08e7da2
fix : #7240
6 years ago
cd1209906d
fix: give default privs on new install to guests/spiders
6 years ago
c72da5595a
fix : #6806
...
3 new global privileges
view:users
view:tags
view:groups
6 years ago
9d1fcf4e36
fix: closes #7217
6 years ago
5031bfe8c0
feat: allow themes to define custom classes for categories via filter:admin.category.get
...
`datalist` isn't supported in all browsers but this will fallback to the original behavior. The first item in the list is the placeholder.
6 years ago
d75a0d7724
feat: show more unread notifs
6 years ago
6e69a9ab31
fix: merge post notifs
6 years ago
cd2f72fb73
feat: pass topic creation data to action:topic.save
6 years ago
5353960ae7
fix : #7316
6 years ago
6cd8248cae
added empty array for customActions and another indentation fix attempt, related to #7284
6 years ago
14addef67b
indentation fix #7284
6 years ago
d94f6248ca
related to https://github.com/NodeBB/NodeBB/issues/7212
6 years ago
eb21ca1190
added customAction in the registration queue users list, related to #7212
6 years ago
04232986ab
related to https://github.com/NodeBB/NodeBB/issues/7212
6 years ago
02a8ed9b11
feat: textcomplete over jquery-textcomplete, closes #7309
6 years ago
920efad04d
fix : #7300
6 years ago
70f8b418c4
fix : #6848
...
fixed in winston 3.2.0
6 years ago
f659ef4d80
feat: new hook filter:privileges.posts.edit
6 years ago
df6f75eb05
fix : #7298 privilege header misalignment
6 years ago
cf918078e5
fix : #7211
6 years ago
0edeeea2cf
Merge branch 'develop'
6 years ago
7064fd0678
fix : #7235
6 years ago
ef0e780896
fix: use ACP config value for checking online status
6 years ago
a083d5f429
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
a22a3a9861
fix: log error to prevent headers already sent
...
retry on uniq index fail
6 years ago
63061ffd37
feat: new hook filter:user.logout
...
- used for setting "next" for post logout redirection
6 years ago
0a662e4882
Add Disallow: /compose to robots.txt
6 years ago
cee47f78b2
fix : #7289 timeago shorthand toggle fails on non-existant language
...
- Exposing timeagoCodes to frontend
- Timeago language and shorthand toggling will fall back to 'en'
if the requested language does not exist
6 years ago
059a4be204
feat: explicit handling of SSO success and failure
6 years ago
831d079512
fix : #7274 incorrect handling of client script 404s
6 years ago
a23854e3ff
feat: new hook type: `response`
...
Used in authentication middleware. Instead of firing an action
hook, it now fires a response hook.
Response hooks are invoked serially, and if headers are sent from
one of the hook listeners, all subsequent hook methods are not
called.
Response hooks should only be used in situations where res.send
(or other like methods) are invoked. Existing plugin hooks that
pass in res purely for data retrieval purposes have not changed).
fixes nodebb/nodebb-plugin-write-api#101
6 years ago
f122fc44d0
fix : #7266 body does not contain skin class
...
A regression was identified where the skin was not shown in the
body class. This resolves the issue and adds a workaround so that
the fix does not become breaking for custom themes.
6 years ago
7524d3c33b
fix: generate timeago codes from files
6 years ago
2b9322e1c2
feat: additional options for SSO plugins
...
+checkState property, pass Boolean false to skip nonce checking
+callbackMethod, default 'get', you can pass in 'post', etc.
6 years ago
ed5d2d6d15
feat: get rid of disk access
6 years ago
c831ff0de3
fix: removal of timeago fallback middleware ( #7259 )
...
* fix: removal of timeago fallback middleware
Instead of loading English fallback on missing language, we opt
to not send a script tag for a missing language to begin with.
Timeago already loads with English as default, so it will just
continue to use English.
* fix: check userLang against supported language codes
* fix: cleaned up code as per @pitaj
* fix: added comments
* fix: more fixes as per @pitaj
* feat: added addl. test for timeago locales, fixed broken test
6 years ago
c14dbfc6b7
attempt to fix tests
6 years ago
65f6630722
add new hook action:plugins.firehook
6 years ago
ac655564bb
fix: post queue notifs
...
fix moderators not showing up immediately when adding them
6 years ago
e1ca2d81f9
refactor: use loash when possible ( #7230 )
6 years ago
9328eeca95
fix: escape hook method
6 years ago
428f587cbe
fix : #7208
6 years ago
a662f118a5
fix : #7054
6 years ago
b9833483ca
fix : #7209
6 years ago
70a87d4399
feat: support for one-click unsubscribe from email clients ( #7203 )
...
* feat: sending notifs via ACP creates real notification
re: #7202
* feat: basic integration for one-click unsubscription #7202
* feat: tests for #7202 + bugfix
* feat: added and organized digest unsub tests
closes #7202
6 years ago
1a3838e13c
fix: missing notification
6 years ago
7809ba2800
fix : #7193 , closes #7194
6 years ago
0263b4daec
feat: added new hook `static:sockets.validateSession` ( #7189 )
...
* feat: added new hook
* fix: improper .bind() call, +req in static:sockets.validateSession
* fix: restored original sessionStore logic, +hook
original logic to retrieve the sessionStore was not faulty, but
was changed for the sake of changing things, which ultimately
led to issues with tests, etc.
6 years ago
6f1fb4eb24
fix: # https://github.com/barisusakli/nodebb-plugin-dbsearch/issues/49
6 years ago
28459d04c6
fix : #7187
6 years ago
9aa1aa689d
fix : #7174
...
always pass string in service
6 years ago
934e1854d3
remove unnecessary escape
6 years ago
0d409610c4
fix : #7181
6 years ago
b0eaa858b5
fix : #7169 Fixed logout being broken
6 years ago
72afc1806e
fix: uid filtering
6 years ago
41fb5cca81
fix: dont crash if default cover is invalid
6 years ago
d81e0a5f5b
fix : #7146 Better RTL handling on (de-)authentication
...
- RTL is applied (or unapplied) on login and logout depending on
user language/guest-detected language.
- config is automatically saved into res.locals.config whenever
loadConfig is called
- On login/logout, buildHeader is called instead of getting config
- On logout, req.uid is deleted instead of set to 0
6 years ago
900f0a0b78
fix : #7118 , invoking autoLocale middleware on logout
...
Also:
- firing client-side hook on header update
- updating bootbox locale on header update
6 years ago
3917022a48
fix : #7139
6 years ago
7e828404f6
fix : #7116
...
dont save relative_path in db for group covers
6 years ago
f4ea2c43ab
feat: #7120
6 years ago
0c1ac4d6a2
feat: #7032
6 years ago
d31684e8b8
fix : #7131
6 years ago
fef7e13c9e
feat: small fixes
6 years ago
b2a74b4172
fix: remove cache
6 years ago
b9b9d8b2e9
feat: name topic controller
6 years ago
0cb9bba4da
feat: header
6 years ago
60390c01f1
fix: loop
6 years ago
ae0fe5e880
feat: more naming
6 years ago
f88db22ca2
feat: give the rest of the middlewares names
6 years ago
fdfbcc6efe
feat: give names to more middlewares
6 years ago
53793e1603
feat: give names to middlewares
6 years ago
4650a76036
fix : #7124
6 years ago
9f5062682d
fix: unread badge
...
- only increase unread badge if topic or category is watched
- fix logic for "there are new posts/topics" on /unread and /recent
6 years ago
d2c2d56f59
feat: change sortedSetsScore
6 years ago
99e0895e99
fix: move the check to get methods
...
all .post methods will have csrf
6 years ago
fbe6ccd773
style: lint fix
6 years ago
989879a6b5
fix : #7115
6 years ago
14c4552304
dont modify session for spiders
6 years ago
29b63ae7fb
fix : #6979
6 years ago
0eef3e1c27
fix: upgrade script key
6 years ago
00afc5b3ab
fix: remove log
6 years ago
eb7ae54f81
Category watch state ( #7109 )
...
* feat: wip, category watch change
* feat: pass data to client
* feat: allow changing state
* fix: account page categories
* fix: show in unread if topic is followed or category is watched
* feat: add default watch state to acp
* feat: save user category watch state
* feat: update unread recent pages
* fix: remove dupe code
* fix: flip conditions
* fix: handle empty arrays
* fix: ignore/watch on others profile
* feat: upgrade script for category states
if there are any users ignoring categories set their state in new zset and delete cid:<cid>:ignorers
* fix: upgrade
* fix: tests
* fix: redis count
* fix: more tests
6 years ago
ff5b04beb9
Log port number of current instance in addition to pid. ( #7110 )
6 years ago
8169739069
fix : #7108
6 years ago
62f01a839e
fix: dont save data for non-positive uids
6 years ago
f103390aa5
fix : #7103
...
update counter when user navigates to /unread
fix new topic alert on /unread
moved unread code from footer to unread
6 years ago
2f57a4b9a6
fix: dont update cid:<cid>:tids:votes if topic is pinned
6 years ago
d117df77f7
fix : #7102
6 years ago
85a07e999b
fix : #7102
6 years ago
263c918088
feat: remove uid:<uid>:ignored:cids ( #7099 )
...
use cid:<cid>:ignorers instead
6 years ago
26ccd8f626
fix: db info page
...
if there is no connection to db, connect first
6 years ago
a0f57c642c
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
a6c8e0ab4f
fix: logAttempt conditional
6 years ago
33d4956b76
fix : #7087 , server-side protection against guest blocks
6 years ago
78fa734017
feat: cache category tag whitelist
6 years ago
81aa3a0b8a
fix: don't crash in flags.validate if user blocked target
6 years ago
fe0f95a2b1
fix : #7085
6 years ago
e55fb43703
fix : #7086
6 years ago
71163421aa
fix: wrong variable #7085
6 years ago
df4f8cee4b
remove node 6
6 years ago
e65d40c937
dont return undefined from sortedSetsCard if keys is empty or falsy
6 years ago
420227faae
parseFloat scores
6 years ago
4fba1492c1
feat: added new middleware authenticateOrGuest
6 years ago
eeaee8ccef
fix: not calling authenticate middleware on resource direct access
...
routes
6 years ago
5f3d1c76c8
fix : #7038 , autoLocale logic not playing nicely with no-refresh auths ( #7059 )
...
* fix : #7038 , autoLocale logic not playing nicely with no-refresh auths
- on login, req.query.lang is deleted (since it seems to be left over)
- on logout, the middleware.autoLocale is executed, which resets
req.query.lang
- middleware.autoLocale is new, just refactored existing logic in
webserver.js into new middleware method.
* style: tests, use lodash
* fix: timeago strings not switching languages on login or out
6 years ago
a07d9898df
fix : #7071 buildSkinAsset won't rebuild continuously
6 years ago
7ca62b8399
feat: closes #7070
6 years ago
96c1dc6276
unescape email subject
6 years ago
eab297bdc9
fix : #7061
6 years ago
d7c55bc3f7
feat(email): don't escape html in notification bodies. ( #7042 )
...
allows for post replies, etc. to show the formatting of the orginal
post, rather than looking garbled.
closes #7034
6 years ago
d3c6cba33f
closes #7060
6 years ago
67ac8e3d06
closes #7053
6 years ago
54c127d1b2
feat: allow array results
6 years ago
f581c052ee
feat: #7023
...
- add category selector to privileges and category create modals
- allow category selector to work for multiple selectors on same page
6 years ago
a63ddbe2aa
fix : #7040
...
if category doesn't exist return null and 404
6 years ago
ec0c50d4e0
fix : #7041
6 years ago
8d7c3897f2
fix : #7043
6 years ago
cb7c2d8c28
fix: add missing render function
6 years ago
1f918ca8f8
Home route ( #7039 )
...
* fix: WIP home fix
* remove console.log
* fix : #6949
on redis run all tests in subfolder /forum
fix URI errors
fix sping/ping
6 years ago
8808a03307
fix : #7033
6 years ago
b86f155690
fix : #7037
6 years ago
ba619c7ec8
style(eslint): match operator-linebreak preferences
6 years ago
89c025d102
feat: close #7002 , console message if mismatched origins
6 years ago
43c3bb02e5
fix : #6991 , add timeout for version Github request
6 years ago
33d7735690
change deprecated message
6 years ago
dab1a1d638
fix for null category ( #7029 )
6 years ago
29e9310aa5
dont crash for undefined categories
6 years ago
6330d51446
less derpy output
6 years ago
ed1bf9a16f
add more info to advanced db page
6 years ago
4b486a808e
fix custom home
6 years ago
2c5e38d8f1
closes #7004
...
do not translate email subjects twice, emailer already translates the passed in subject param
6 years ago
00a066985a
cache categories:cid and cid:<cid>:children
...
these rarely change, no need to go to db for them
6 years ago
112b5c861a
change queue logic, if user has negative rep always queue their post
6 years ago
1d5816b00a
add new hook `filter:unread.categories`
6 years ago
59eeff8f0f
closes #7011
6 years ago
d0750bc587
closes #7007
6 years ago
1bb6067e19
suggested topics fix, if search doesn't return enough topics
6 years ago
8e5a6d9767
add banned:expire to user data
6 years ago
53ad2bbd6e
Categories optimize ( #6999 )
...
* WIP
* fix category page
* fix counts, and copyPrivileges
* fix lint
* more fixes,
* redis fix
* fix test
* fix category test
* remove getParentsAndChildren
6 years ago
69ef05707a
style
6 years ago
3f8e3dc3e8
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
13139fe77e
return early for guests/spiders
6 years ago
0524fd9caa
closes #6996 ( #6997 )
...
* closes #6996
* fix lint
6 years ago
7b9a2caec3
closes #6994
6 years ago
b8c08a5417
dont call db for guests
6 years ago
d8f114c982
dont check if guests/spiders are banned or load reason
6 years ago
9d28b935fd
dont load uid 0, -1 from db
6 years ago
d5af39ca5d
make 1 call for parentCids
6 years ago
01c942fc39
closes #6989
6 years ago
eba1a405d2
load category parents and childrens in one call
...
add more missing guest/spider checks
6 years ago
a6864a8055
add groupTitle test for guests
6 years ago
1c981e638b
rename query name
6 years ago
ca1e3a758b
#6986
6 years ago
48690a01b9
dont need to call multi if keys.length is 0
6 years ago
20abc7fc47
closes #6985
6 years ago
b331ca26a1
add search to acp
6 years ago
63c0a9a3b7
closes #6928
6 years ago
fc1c4acccf
closes #6960
6 years ago
b83e50f286
remove delayImageLoading from api @julianlam
6 years ago
94e10c8c32
closes #6972
6 years ago
f75e2ed1ee
fix lint
6 years ago
c36ddec08b
promisify plugins
6 years ago
33986f38e3
closes #6954
6 years ago
1ce15e69ab
dont require search and moustrap on topic page until needed
6 years ago
e17c4b2766
uid fixes
6 years ago
c02d584b53
reduce initial js payload/requests
6 years ago
f1a6d39537
dont crash if a loginStrategies is undefined
6 years ago
c72299ad71
refactor widgets admin
...
so we dont load the widget-settings.tpl in the upgrade script and only load areas
6 years ago
9fecad138c
limit number of js files minified, dont crash upgrade script of widget-settings is not found
6 years ago
f0dead7aba
more tooltip work
6 years ago
21402ba803
check joindate
6 years ago
d0b67b00db
closes #6949
6 years ago
adb647a8ae
export express app from webserver
6 years ago
f96208a0c8
fix(uploads): ugly filenames on uploaded asset downloading
...
During regular processing, a timestamp is prepended to the filename
for any uploaded files. We don't want this to be part of the filename
if an end-user elects to download the file.
This commit adds a middleware to strip out that portion of the
basename and adds the appropriate Content-Disposition header for
files in /uploads/files
Fixes #6953
6 years ago
57b39d5ba2
fix(acp): small UI fixes for ACP privileges category selector ( #6946 )
...
- Add dropdown chevron
- Change translations
- Safety against `category` not an object
6 years ago
c5a093e1f2
closes #6950
6 years ago
7dabd13fea
remove unused
6 years ago
de14102ee7
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
d9452bf3d4
fix: custom navigation item not showing groups
6 years ago
b3f96d28aa
fix(acp): hard-to-discover dropdown selector in ACP
...
Made the dropdown an MDL button fab with better positioning via
a p.lead so that it is more easily discoverable and obvious that
it is a button that can be pressed.
Fixes #6899
6 years ago
a57d94194f
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
157a7d1f0e
prevent possible crash if category.posts is undefined
6 years ago
c593ffd75f
closes #6944
6 years ago
d63db8d20f
arrow function
6 years ago
69bb3293ee
misc fixes
...
handle spider uids properly
6 years ago
afa84023a2
closes #6942
6 years ago
96e986a865
optimize suggested topics/search
6 years ago
07f83c5078
fix redis tests
6 years ago
f8e219c323
handle empty set, add test
6 years ago
afa6c71b72
make it a method use batch
6 years ago
f9036e2a6f
Update groups members' title when changing group name ( #6939 )
...
* Update groups members' title when changing group name
* Fix eslint
6 years ago
18219bd5f3
closes #6938
6 years ago
e6c4af7f6f
fix lint
6 years ago
e1eebef398
does this work
6 years ago
e14b0b38be
derprelic
6 years ago
485fbf7386
show more lines in stack
6 years ago
b6771836cf
closes #6937
6 years ago
3425370adb
dont use indexOf in map
6 years ago
973b5fcfe0
closes #6932
6 years ago
2c5157aeaa
use max.min
6 years ago
2ee743d65c
add itemsPerPage to search api
6 years ago
62787368c6
add searchonly option to searh api
6 years ago
4724901588
use series
6 years ago
d027207f88
fix: flags detail page crash if reporter blocks author
...
Fixed an issue where the flags detail page would crash if the
reporting user flagged a post and then proceeded to block the
post author.
Retrieval of a flag's target data should be irrespective of
block status.
fixes #6925
6 years ago
95cc27f1ff
style(eslint): enforcing newline on chained calls
6 years ago
a5022ce425
fix : #6922 , skin assets not including plugin LESS files
6 years ago
64b9dabff8
chore(deps): update dependency eslint-config-airbnb-base to v13 ( #6599 )
...
* chore(deps): update dependency eslint-config-airbnb-base to v13
* chore: #6599 , linting 😬
6 years ago
75816deca7
add cache to redis ( #6917 )
...
* add cache to redis
move out cache module from mongo
* fix redis tests
* add callback noop
* fix typo
* del cache on field delete
* make redis/mongo caches separate
6 years ago
501b3a79ca
Refactor skins to be built on server-side ( #6849 )
...
* WIP
* using bootswatch from npm instead of bootswatch CDN url
* feat: on-demand client css building for skins
* added ability for client-side to select a skin
* updated loading and saving logic of bootstrapSkin on client side user settings
* fix: broken test for #6849
6 years ago
84433f29ab
Do not require a full refresh on login/logout ( #6841 )
...
* no-refresh login as well, plus lots of fixes for missing config on login
* replace config with new set on logout as well
* passing new payload data into new action:app.loggedIn hook, and old action:app.loggedOut hook
* fixed issues with socket.io not properly representing uid on server
* some light refactoring and cleanup
* minor cleanup, fixed spa logout not working after login
* have reconnection handler for socket.io wait 2s to confirm disconnection before reporting -- stops flicker if reconnecting immediately
* Dynamically replace chat and slideout menu on updateHeader()
... instead of just the menu items.
* more efficient calls to Benchpress and translator /cc @pitaj
* fix: chats and notification handlers not working after login
* fix: accidentally calling cb multiple times
6 years ago
968be7d8de
make lint happy
6 years ago
3c611d85ed
closes #6912
...
- on category setParent dialog do not show children of current category
- break recursion if category parentCid is equal to child cid to prevent
infinite loop
- dont allow setting the parentCid of a category to one of it's children
6 years ago
6f47446171
closes #6910
6 years ago
3c8939a80d
fix: interstitial redirects failing if done via ajaxify
6 years ago
2df19c0ae4
fix typo
6 years ago
ed7399f9ed
shorter code
6 years ago
412358b070
#6903
6 years ago
67d3b29204
#6903
6 years ago
ff38abc225
move bcrypt into password
6 years ago
4e297921c4
dont show object cache if it doesnt exist
6 years ago
4caaa046d7
dont load post data again
...
shorter async.parallel
6 years ago
d3e4daebec
posts/delete cleanup
6 years ago
0de60cfdca
fix mongodb tests
6 years ago
8ca36ad122
closes #6890
6 years ago
157bea6966
fix: username trim on login, closes #6894
6 years ago
5ccdc1c017
internationalising english labels in session time ACP block, #6883
6 years ago
58b088c054
update html on session time ACP block, #6883
6 years ago
2e579ee0f9
closes #6883
6 years ago
5ee4529a8e
if source has no parentCid assume 0
6 years ago
9918389a43
closes #6884
6 years ago
7aa937a657
remove dupe code in mongodb sorted
6 years ago
ea1e8fb8fe
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
c27be9db5a
Recent refactor ( #6879 )
...
* wip
* fix inf scroll
* remove duplicated code
* remove dupe code in /unread
* use topicList
* update tag page to use topicList
* fix tests
* combine ifs
* remove more dupe code
* disable timeout
6 years ago
66ed48e088
closes #6875
6 years ago
4919e9efa3
feat: allow disabling of GDPR features via ACP toggle, closes #6847
6 years ago
51792da430
dont crash if there is nothing to write
6 years ago
12f3f56b01
change to .exists
6 years ago
566564ed74
fix redis tests
...
fixed typo in groups/data.js
added postcount,viewcount to int fields
6 years ago
fb6067a7ca
only parse if field is requested
6 years ago
f3a679e268
remove parseInts
6 years ago
aca50f1fe1
dont crash if topic is moved to pinned topic
6 years ago
da22940b80
dont retry absolute paths
6 years ago
ebd4b19a65
moved req.user up
6 years ago
9c03881d5a
add threshold for image resizing
6 years ago
369e4854d2
remove parseInts
6 years ago
541997a755
fix lint
6 years ago
40f9ee3003
dont crash if topic does not exist
6 years ago
2f198583c4
change to this
6 years ago
a2aae7f805
shorter error message
6 years ago
69253d9a7f
use chart.js legend
6 years ago
1d15449076
write analytics before exiting
6 years ago
5b842c98ac
fix typo
6 years ago
9f36ce3997
#6862
6 years ago
a73bcabad8
don't call .jpeg quality on pngs
6 years ago
44a957faca
remove more parseints
6 years ago
728e7bdae9
remove more parseInts
6 years ago
537b7ff7e8
remove more parseInts
6 years ago
a228dc2de9
closes #6797
6 years ago
82cda248f3
fix plugin requires
6 years ago
138154a71c
move modules
6 years ago
5293a6515c
fix lint
6 years ago
fdbefa3d1f
remove more parseInts
6 years ago
175e13edf6
group data
6 years ago
c738dc7d3e
remove some more parseInts
6 years ago
7a44424214
parse '123' to 123 if it has no default
6 years ago
d07e3e6d97
if not in defaults use string
6 years ago
4fff5e9baf
closes #6855
6 years ago
881185ae59
closes #6857
6 years ago
ab7657d445
closes #6854
6 years ago
ac39112271
remove more parseInts
6 years ago
9c022afae1
Parse int ( #6853 )
...
* Store config fields as JSON in the db
Fewer parseInts
* Remove unnecessary parseInts
* remove some dupe code add tests
* remove console.log
* remove more parseInts
* WIP: read meta.configs defaults from defaults.json
remove more parseInts
* more work
* add log for failing test
* update admin pwd
* fix tests, dont require posts/cache before configs are initialized
* handle saves
* Test boolean conditions
* remove more parseInts
* Fix boolean values
* remove lots more parseInts
* removed json parsing
* renamed var to number
* categories dont have timestamp
6 years ago
60c58870af
remove hotswap ( #6835 )
6 years ago
92744a7200
closes #6852
6 years ago
ee2f9e9434
remove some parseInts
6 years ago
f5fe91286e
closes #6851
6 years ago
f53984aeae
refactor user/category data
6 years ago
c3a903142a
closes #6850
6 years ago
b2b33ffa57
topics data refactor
6 years ago
26d4e0852f
use includes instead of indexOf
...
use _.uniq instead of filter&indexOf
6 years ago
a6c70412db
temp fix for #6848
6 years ago
54c638c3c8
fix upgrade script for notification types
6 years ago
5ef708d765
fix navigation
6 years ago
250e8c01ff
closes #5008
6 years ago
da1a90a470
add search test
6 years ago
e6546e6263
#6848
...
this handles winston.error(err);
6 years ago
9dd65cf772
closes #6822
6 years ago
8b8feb5b88
remove emitter
6 years ago
9251912282
move methods from posts to posts/data
6 years ago
baf91089a6
remove unused methods
6 years ago
444fd70ba3
test pubsub
6 years ago
b4d8b7cf38
move sorted topics code out of recent
6 years ago
837f411783
closes #6843
6 years ago
986511e718
try with higher timeout
6 years ago
1d15dc089b
revert isCluster
6 years ago
0aebb9caf8
closes #6844
6 years ago
154d7076d9
dont pass options
6 years ago
9dbe68a9cb
testing again
6 years ago
aa567a5f2d
print out connString and opts
6 years ago
2d8d234c57
test mongodb again
6 years ago
f4df89fe90
closes #6840
6 years ago
8079d3d3b7
add tids used to returned data
6 years ago
85c60316ed
upgrade to winston 3.1, closes #6590 ( #6838 )
...
* upgrade to winston 3.1
* fix winston in web/install and tests
6 years ago
6c15aee888
add cache hits/misses to posts cache
6 years ago
b57db7fd8e
update groups join to take array of group names ( #6834 )
...
* allow groups.join to take an array of group names
* pass an array to groups.join/leave in privileges
* split up groups/membership
* add hits/miss to group cache
* fix typo
6 years ago
c06480b82e
add tests for blocked users teaser/unread
6 years ago
687adea5dd
closes #6836
6 years ago
d4db8c2d42
removed reset
6 years ago
c9a415c469
check if process.send exists
6 years ago
1024a0efa1
add reset to pubsub for tests
6 years ago
a0f5461860
don't set and read from topic hash in parallel ( #6831 )
...
this was causing a test to fail, although very rarely
6 years ago
1ec2d511b2
remove unnecessary code
6 years ago
ba21c5170a
moved increase/decrease
...
moved these two methods into addPostToTopic&removePostFromTopic
6 years ago
e615391b22
convert values to string before removing
6 years ago
5c7dd54815
fix zsets and update them on post move, closes #6823 ( #6827 )
6 years ago
702be3f6de
https://github.com/NodeBB/nodebb-theme-persona/issues/363
6 years ago
ed9b3a31df
fix navigation items not getting saved if they are not modified at all
...
if you add 2 nav items and dont make any changes they weren't being saved, adding order fixes this issue
6 years ago
cf1173b0c4
closes https://github.com/NodeBB/nodebb-theme-persona/issues/408
6 years ago
a3d463916c
closes #6822
6 years ago
5e1c33bb3b
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
a4d5c81de5
closes #6819
6 years ago
3886a704e0
fix lint
6 years ago
84737b5a49
use buildForSelect
6 years ago
6dc84deca9
allow admins mods to watch/ignore categories for other users
6 years ago
71905bb2c6
fix watched categories
6 years ago
9ed4239d8e
small changes and test for user/:slug/categories
6 years ago
523a2dc54c
Add settings page to control watched categories ( #6648 )
...
* Add settings page to control watched categories
* Fix passing undefined to pushUnreadCount
6 years ago
1df9961eb4
make lint happy
6 years ago
8df6838561
closes #6816
6 years ago
b58ab48485
add test for /sessions controller
6 years ago
002522834c
closes #6815
6 years ago
b033d6f115
add tid to post-purge event
6 years ago
13a1497617
closes #6801
6 years ago
7bc69e9182
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
1bea247748
add username/email to user-delete event
6 years ago
49ba5af5fa
closes #6810 ( #6813 )
6 years ago
48d49cfcad
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
d1491feed9
add tid to topic rename and post delete restore events
6 years ago
f77091d1ed
change user delete so it returns quickly
6 years ago
f45d24d351
change if to !== 0
6 years ago
b7eaf4191e
return correct post count if its out of sync
6 years ago
77beaf2e15
Allow local login,closes #6800 ( #6803 )
...
* WIP
* reset groups cache after every suite
6 years ago
d92ef9ca11
remove id
6 years ago
cf4ea94e6d
Fix single-host-cluster socket.io ( #6802 )
...
It was silently dropping every message because every node thought it was the master node.
6 years ago
f95308bf33
move sharp require into the method it is used in src/file.js
6 years ago
ebabcc5e3c
if authenticate middleware is overridden by plugin, check for req.user and return notAllowed helper otherwise
...
/cc @LudwikJaniuk
6 years ago
4b970a1072
use lodash, load 3 posts per iteration
6 years ago
18d0deeccb
update deprecated methods ( #6794 )
6 years ago
1cb2e1e368
remove console.log switch to series
6 years ago
c9dfb4e109
closes #6790
6 years ago
02046889ec
closes #6691
6 years ago
11b655163e
Only run the DDL for session storage on the primary instance. ( #6788 )
...
This fixes a restart loop caused by deadlocks in large clusters.
6 years ago
1590452697
filter topics you cant read @benlubar
6 years ago
95501e8fee
closes #6738 closes #6290 ( #6785 )
...
* closes #6738 closes #6290
* fix test, delete keys
* delete all bans on user delete
* fix upgrade script to actually read reason
6 years ago
4570daa033
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
3ed856f587
change if
6 years ago
9724ef083e
remove v from query
6 years ago
786311fa64
use value
6 years ago
5a69f979a8
update processSortedSet to use withScores
6 years ago
cf75c79611
Unread changes closes #6781 ( #6783 )
...
* WIP
* more unread work
* faster teaser block handling
if user doesn't have anyone blocked don't check
* much faster filtering of blocked posts
* add missing uid
* add tidsByFilter to return
* dont load all pids to find previous non-blocked teaser
* fix unread filters
they no longer use unread/new unread/watched etc they are query strings now
* shorter nav item code
* add unreplied to filters
fix icons not clearing to 0
dont increment unread counters if there is a reply in a topic where you ignored the topic creator
6 years ago
7f863b8af0
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
17ce482c9f
closes #6780
6 years ago
7787c9b4bb
fix wrong year on upgrade script
6 years ago
24601694db
fix wrong year on upgrade script
6 years ago
edefab1d69
closes #6728
...
add option to disable a category on creation
show disabled categories on manage privileges
6 years ago
4d5e164fd2
closes #6778
6 years ago
59b988a205
change test so it checks url
6 years ago
71ccd67665
closes #6722
...
calculate size of base64 image from buffer, still not perfect but better than string.length
6 years ago
b7ead6dc9c
Replace jimp with sharp ( #6774 )
...
* add probe image size and max image size
* replace jimp and image-probe with sharp
* better name for test
* resize with just path
* resize thumb inplace
* use filename
6 years ago
69c7260fe9
dont let sending more than max invites via bulk invite
6 years ago
669a5135e1
closes #6768
6 years ago
dff86b1ac9
closes #6740
...
* flag notifications will go to the flag details page instead of the post or user that was flag
* if you assign a flag to yourself you won't get a notification about it
@benlubar
6 years ago
089bf5d8bb
closes #6773
6 years ago
382d06bbb0
fixes #6765 -- no need to have gmods and admins access login sessions page
6 years ago
d996ea27be
closes #6763
6 years ago
6a377568d2
closes #6764 fix typo in notif rescind
6 years ago
08dfb3470c
fix tests
6 years ago
b43bfa3d5b
closes #6759
...
-moved user.blocks.filter from unread controller to getUnreadTopics so
topics are filtered at other places this function is called
- when a new post is made do not send it to uids that have blocked the
poster
- update getUnreadTids so it does not return topics that have new posts
from blocked users
- update hasReadTopics so it does not return false data if topic has new
posts from blocked users
6 years ago
41aae6f418
closes #6749
6 years ago
37ca5a1c63
filter falsy teasers
7 years ago
93d52ef338
default to 'recent' sort
7 years ago
25fed0aa8d
change isPasswordCorrect to return false if user does not have password
7 years ago
6f18cf368b
closes #6741
7 years ago
446b125c83
escape post content
7 years ago
c7f3b76b4e
DRY req props that depend on auth ( fix #6727 ) ( #6731 )
...
* DRY req props that depend on auth (fix #6727 )
authentication leads to req.loggedIn and req.uid being set. However, a
later authentication event might outdate them. Here, I create one
function for setting those properties, and make sure it also is called
on the `action:middleware.authenticate` hook, which would be such an
authentication event. If there are other places, those should be added
as well.
* fix lint errors
* fix lint error
* change exports
7 years ago
3e1b007f9f
escape title in post queue
7 years ago
97a3079bc0
Optimize PostgreSQL session store.
...
- Sets session ID to be a constant-sized character field inline in the
table instead of a variable-length character field compressed outside
of the row.
- Changes the session data from "json" to "jsonb" which is faster and
smaller on disk with the drawback of not maintaining key order and
whitespace (which we don't care about at all)
- Adds a clustered index on the session expiration timestamp, which will
make periodic session purging much faster.
(For an example, WTDWTF currently has 482355 sessions in the table, and
because there is no index on the expiration timestamp, PostgreSQL must
check all the rows in the table every time.)
This upgrade script can run concurrently with a live NodeBB instance,
but any action that touches sessions will wait until the upgrade script
is done.
Does not touch the database if the database driver is not set to
PostgreSQL or if there is a Redis database configured.
7 years ago
c2c925cacd
closes #6678
7 years ago
29836aaad9
rename session account middleware to sessions, plural, prep for fixing #6678
7 years ago
5b45b2f72c
closes #6729
7 years ago
0519f84734
Promisify modules ( #6723 )
...
* WIP promisify
* promisify psql
* ability to skip some keys
* dont promisify client object
* remove async
* clone entire module so it has all properties
* add shim for node 6
* ignore sessionStore as well
* ignore pool on psql
7 years ago
c1725442ea
added progress bar to username_email_history upgrade script
7 years ago
545e678e8a
fixes #6726
7 years ago
5c04ec2d63
removed client-side chat message length check in favour of server-side check, firing new hook on messaging.checkContent for hooks to intercept
7 years ago
1e3cdc99ac
fixes #6702
7 years ago
a06b33a713
fix html characters when cloning children categories
7 years ago
aaa9561b7f
Revert "moved filter:post.getPostSummaryByPids to before parsePosts call"
...
This reverts commit cf82407a8f
7 years ago
cf82407a8f
moved filter:post.getPostSummaryByPids to before parsePosts call
...
/@pitaj
7 years ago
ae4016d9e0
add getCateries to helpers
7 years ago
12940b577b
closes #6703
7 years ago
2ce6a85756
properly closes #6698
7 years ago
f751d21d1e
removed debug line
7 years ago
f9d3484ec6
fixes #6543
7 years ago
ed9dc113b0
sanitizing notes in flags details page, fixes #6698
7 years ago
a77630c6be
closes #6697
7 years ago
33228bb7fe
PostgreSQL database driver ( #5861 )
...
* [test/database/list] Fix test list 4 being used in two different tests
* [database/postgres] PostgreSQL database driver
* [database/postgres] Make transactions work based on continuation scope.
* [database/postgres] Implement nested transactions
* eslint --fix
* Add database changes from earlier this week to the PostgreSQL driver.
* Fix typo
* Fix postgres.incrObjectFieldBy returning undefined instead of null when given NaN
* [database/postgres] Fix sortedSetsCard returning an array of strings.
* Update socket.io postgres adapter
* Fix PostgreSQL erroring when multiple updates are made to the same sorted set entry in a single operation.
Add a test case to catch this error.
* Fix lint errors.
* Only prune sessions on one instance in a cluster to avoid deadlocks.
They're caught and handled by the database server, but they spam the logs.
* Fix arguments.slice.
7 years ago
3cccbbc1f2
Add option to enable/disable HSTS
...
Also fix HSTS middleware being added twice.
7 years ago
1c286e4536
not even used
7 years ago
fa499aef18
closes #6680
7 years ago
e7bd0cea74
fix lint
7 years ago
bcef32c5af
closes #6645
7 years ago
546b13b897
fix lint and tests
7 years ago
79ffae608e
closes #6675
7 years ago
4200cff47c
closes #6662
7 years ago
3c6c0ed7a1
restoring passwordExpiry for use in continueLogin, fixed tests, hopefully
7 years ago
786af5fbb3
derp
7 years ago
b6a5419ca1
closes #6674
7 years ago
4f8815eb78
closes #6646
7 years ago
ea2bd33bfa
fixes #6608 , restored template values in widget containers
7 years ago
7dfe953526
closes #6672
7 years ago
48197e2d25
this upgrade script was written in 2018, not 2017, heh
7 years ago
c7d6cacd98
closes #6658
7 years ago
44373afc52
Fix socket.io not working properly in single-host clusters. ( #6669 )
...
This is because we don't use the cluster module, so the master nodejs process doesn't know about any of the clients through the socket API.
7 years ago
3522ad0e05
Revert "closes #6664"
...
This reverts commit f27a0d252c
7 years ago
f27a0d252c
closes #6664
7 years ago
506467ad6f
closes #6663
7 years ago
c1e98eefa7
Allow single-host clusters to not send pubsub and socket.io messages through the database. ( #6659 )
...
* Allow single-host clusters to not send pubsub and socket.io messages through the database.
* Fix lint errors.
7 years ago
87b6808c4e
refactor to use getCidsByPrivilege
...
switch to .includes
7 years ago
f1a6537fc2
Add notification frequencies from nodebb-plugin-upvote-notifications. ( #6640 )
...
* Add notification frequencies from nodebb-plugin-upvote-notifications.
https://github.com/boomzillawtf/nodebb-plugin-upvote-notifications
* Fix editing settings clearing upvote notification preferences.
7 years ago
e35d4a7d85
closes #6283
7 years ago
04d31fe1d4
Precompile all templates
...
- Benchpress compilation is 33x faster now
- Native module with JS fallback and pre-built binaries
- Dev template build is <1sec now
- Minified template build is ~5sec (uglify accounts for almost all)
7 years ago
7558046e75
add brute-force protection for change password and email actions
7 years ago
91f9c60660
closes #6643
7 years ago
85a55d1740
closes
7 years ago
cfb9784527
closes #6641
7 years ago
16a7728ab8
fix redis warnings
7 years ago
cc6a683bc4
closes #6631
7 years ago
65b4bafb16
Fix @scoped themes
7 years ago
7cd8274c0f
Add series flag for `./nodebb build`
7 years ago
8eea6017fe
parseInt uid
7 years ago
7a53fa9469
Added block and unblock button to profile dropdown menu, #6560
7 years ago
a34584e8f5
fixed blocking cache derp
7 years ago
f09b1acfb7
closes #6627
7 years ago
4ed079555e
Merge remote-tracking branch 'refs/remotes/origin/master' into blocks
7 years ago
3449cf321b
add back cache and pubsub
7 years ago
ae0563375e
derp
7 years ago
ad8ac2bdff
removed unused checkPassword socket call
7 years ago
fb42862ec7
check password validity in user delete socket call
7 years ago
cb8e62cd7c
fixes #6626
7 years ago
584f88e092
blocks WIP
7 years ago
c2b0be1f2c
if stack is undefined fallback to message and then to hardcoded string
7 years ago
ee64437f8a
fix runJobs
7 years ago
7e6007e146
revoke all sessions on email change
7 years ago
be0ef799ee
closes #6592
7 years ago
002cde1057
added progress bar to ip hash upgrade script
7 years ago
9912c400b6
closes #6612
7 years ago
5cf662e565
closes #6613
7 years ago
625ab1a46b
remove deprecated method
7 years ago
57b7c7ede4
closes #6607
7 years ago
82b2a20d0c
user tests
7 years ago
d158f79a3b
Merge branch 'master' of https://github.com/NodeBB/NodeBB
7 years ago
95f1a82884
closes #6591
7 years ago
6485fc3129
removing extra console logging #6596
7 years ago
68c9c8c5d9
fixes #6596
7 years ago
f72412fa38
Merge branch 'master' of https://github.com/NodeBB/NodeBB
7 years ago
df8c22e9c7
Allow new "withScores" option in batch.processSortedSet ( #6602 )
7 years ago
fe80186ddf
add withscores
7 years ago
f830322ee9
closes #6597
7 years ago
bc437c8da3
fix popular rss feed url
7 years ago
ccad95cf73
closes #6579
7 years ago
f7a0815b46
fix redis tests
7 years ago
2c3fd5fbce
remove some dupe code
7 years ago
e8d7a23e2e
remove deprecated methods
7 years ago
2fd2accf8c
add tests for top topics
...
fix popular page displaying 18 topics per page
7 years ago
956aa55253
Added server hook action:analytics.increment
7 years ago
b71d64e8c3
remove fake pubsub
7 years ago
1f8b4bf820
closes #6576
7 years ago
81341e86ee
log fired hooks
7 years ago
17e7fe3070
Fixed wrong callback given to groups.join
7 years ago
e7cd552e33
closes #6568
7 years ago
9e90d1ea5d
closes #6557
7 years ago
70ff2d9b88
Support scoped theme packages
7 years ago
d656c65c9a
closes #6567 prevent crash if category is undefined
7 years ago
274b33e9e1
move addPostData before modifyPostPrivilege
7 years ago
acf2f2a776
move modifyPostByPrivilege call before filtering posts so index is correct
7 years ago
cb3b2bd27b
closes #6562
7 years ago
a37dc1856f
#6561
7 years ago
Andrew Rodrigues
Julian Lam
Barış Soner Uşaklı
Aziz Khoury
Ricki Hirner
Peter Jaszkowiak
Barış Soner Uşaklı
Ben Lubar
oh
SweetPPro
Zheyu Shen
renovate[bot]
André Zanghelini
LudwikJaniuk
Ben Lubar
Jimb Esser
Sebastian G. Marinescu
Dravere