Julian Lam
84dfda59e6
fix : #10144 , automatically delete uploads from disk on post purge, ACP option to keep uploads on disk if desired
3 years ago
Julian Lam
d92da828a3
refactor: move post upload tests to its own file
3 years ago
Barış Soner Uşaklı
2dbdd1818f
test: fix occasional test failure
3 years ago
Julian Lam
a2c7d69e1b
fix: remove extraneous devDependencies on package merge
...
/cc @pitaj
3 years ago
Julian Lam
9e4147f07c
chore: use source and current local vars, + docs
3 years ago
Julian Lam
0f788b8eaa
fix : #10257 , topic thumbs not deleting on topic deletion
3 years ago
Julian Lam
606808760e
test: add test to verify that a sorted set is automatically deleted if its last element is removed ( #10261 )
...
* test: add test to verify that a sorted set is automatically deleted if its last element is removed
* fix: remote empty zsets when all elements have been removed #yolo
* Revert "fix: remote empty zsets when all elements have been removed #yolo"
This reverts commit 0ac73244bb6ffd802007a252a35844c589ce8721.
* fix: altered behaviour in module.exists instead of zrem
3 years ago
Julian Lam
d34471f69f
fix: regression in package.json merging logic that caused extraneous packages to not be removed
3 years ago
Julian Lam
689c125cd3
fix : #10229 , package merging should deep merge nested objects
...
+ tests
3 years ago
Julian Lam
a0a3870611
fix: use fs.promises
3 years ago
Julian Lam
1b8eeaf840
feat: more tests for ensuring downvoted posts are added to the :votes zset
3 years ago
Julian Lam
aa8914a153
feat: v3 user email tests
3 years ago
Julian Lam
d1b1f50bb2
test: stricter isValidationPending check
3 years ago
Julian Lam
fc2c755c64
fix: properly unregister hooks in emailer tests
3 years ago
Julian Lam
dee9cca3c8
fix: email ban tests
3 years ago
Julian Lam
e25c0313d1
Revert "refactor: emailer.send and emailer.sendToEmail returns Boolean based on message being successfully sent"
...
This reverts commit f0e32ff182
.
3 years ago
Julian Lam
ea27eaf166
feat: no more sending emails to banned users, + feature flag
3 years ago
Julian Lam
f0e32ff182
refactor: emailer.send and emailer.sendToEmail returns Boolean based on message being successfully sent
...
Note that of course this doesn't mean the message was _delivered_, just sent off.
This will stop issues where emailer errors crash NodeBB
3 years ago
Barış Soner Uşaklı
680e36da67
test: fix derp
3 years ago
Barış Soner Uşaklı
a214f9a61b
test: up acp plugin page timeout
3 years ago
Barış Soner Uşaklı
10949184ca
test: add failing guest csrf test ( #10169 )
...
* test: add failing guest csrf test
* test: use correct var
* fix: use applyCsrf for guests as well
3 years ago
Barış Soner Uşaklı
6c1e184c74
test: fix util test
3 years ago
Barış Soner Uşaklı
9b75b1ede2
test: update tag tests, fix linux symlink error
3 years ago
Julian Lam
d95b4ee29a
fix: assertion check to ensure messages are in the room when editing/deleting, etc
3 years ago
Julian Lam
82768fcf6e
chore: remove debug logs in test/api.js
3 years ago
Julian Lam
aaa6f752d0
refactor: put message api calls behind `/messages` prefix, #10097
3 years ago
Julian Lam
e747998cba
test: fix user tests calling deprecated socket methods
3 years ago
Julian Lam
16ba16cdc4
fix: deprecate chats.leave
3 years ago
Julian Lam
fe17c94c35
feat: `DELETE /api/v3/chats/:roomId/users` and `DELETE /api/v3/chats/:roomId/users/:uid`
3 years ago
Julian Lam
6294beea0b
fix: re-allow kicking of the other party in a 1-to-1 chat
3 years ago
Julian Lam
d62ee84637
feat: `POST /chats/:roomId/users`
3 years ago
Julian Lam
6eea6451d2
feat: `GET /chats/:roomId/users` [breaking]
3 years ago
Julian Lam
b292960594
feat: `GET /chats/:roomId/:mid`
3 years ago
Julian Lam
f48ed3658a
feat: `PUT /chats/:roomId/:mid`
3 years ago
Julian Lam
140f9d2481
fix: isFinite check for room assertion, more test migrating
3 years ago
Julian Lam
e745e21242
chore: use apiv3 for room rename tests
3 years ago
Julian Lam
c990211cf2
refactor: rewrite messaging tests to use API v3 calls when available, rewrote a bunch of tests to async..await
3 years ago
Julian Lam
eeffb9d978
feat: `POST /api/v3/chats/:roomId`
3 years ago
Barış Soner Uşaklı
1264dcb555
test: add email interstitial tests
3 years ago
Barış Soner Uşaklı
5e08f7e604
test: don't use csrf_token for get,head, options
3 years ago
Barış Soner Uşaklı
0e273ab25a
test: fix tests
3 years ago
Barış Soner Uşaklı
1f063058f0
breaking: remove socket.emit('user.exists')
...
remove socket.emit('user.deleteAccount')
remove socket.emit('user.follow')
remove socket.emit('user.unfollow')
remove socket.emit('user.saveSettings')
3 years ago
Barış Soner Uşaklı
6b45dee9c5
breaking: remove socket.emit('user.changeUsernameEmail')
...
remove socket.emit('user.changePassword')
remove socket.emit('user.updateProfile')
3 years ago
Barış Soner Uşaklı
f918a38164
breaking: remove socket.emit('topics.follow')
...
remove socket.emit('topics.changeWatching')
3 years ago
Barış Soner Uşaklı
68fd087567
test: remove old test
3 years ago
Barış Soner Uşaklı
6ad0472106
breaking: remove socket.emit('topics.post')
...
remove socket.emit('topics.search')
remove socket.emit('topics.getTopic')
3 years ago
Barış Soner Uşaklı
49641a3217
breaking: remove socket.emit('user.banUsers');
...
remove socket.emit('user.unbanUsers');
3 years ago
Barış Soner Uşaklı
4604a5724c
breaking: remove socket.emit('posts.reply')
...
remove socket.emit('posts.getPost')
3 years ago
Barış Soner Uşaklı
6d95684bc8
breaking: remove socket.emit('user.changePicture')
3 years ago
Barış Soner Uşaklı
0d694c781c
breaking: remove socket.emit('user.search')
3 years ago
Barış Soner Uşaklı
02ea17ea1b
breaking: remove deprecated groups socket calls
...
socket.emit('groups.join') removed use `PUT /api/v3/groups/:slug/membership/:uid`
socket.emit('groups.leave') removed use `DELETE /api/v3/groups/:slug/membership/:uid`
socket.emit('groups.grant') removed, `PUT /api/v3/groups/:slug/ownership/:uid`
socket.emit('groups.rescind') removed, `DELETE /api/v3/groups/:slug/ownership/:uid`
socket.emit('groups.update') removed, `PUT /api/v3/groups/:slug`
socket.emit('groups.create') removed, `POST /api/v3/groups`
socket.emit('groups.delete') removed, `DELETE /api/v3/groups`
3 years ago
Julian Lam
bc7707aa88
fix : #9484 show user history only to admins and gmods
3 years ago
Baris Usakli
20e76699a2
lint: missing ;
3 years ago
Baris Usakli
0d1e57dce0
breaking: remove deprecated methods
...
socket.emit('topics.delete') removed use `DELETE /api/v3/topics/state`
socket.emit('topics.restore') removed use `PUT /api/v3/topics/state`
socket.emit('topics.purge') removed use `DELETE /api/v3/topics`
socket.emit('topics.lock') removed use `PUT /api/v3/topics/lock`
socket.emit('topics.unlock') removed use `DELETE /api/v3/topics/lock`
socket.emit('topics.pin') removed use `PUT /api/v3/topics/pin`
socket.emit('topics.unpin') removed use `DELETE /api/v3/topics/pin`
3 years ago
Barış Soner Uşaklı
bd1cb2d4f9
breaking: remove socket.emit('posts.delete')
...
remove socket.emit('posts.restore')
remove socket.emit('posts.purge')
remove socket.emit('posts.deletePosts')
remove socket.emit('posts.purgePosts')
3 years ago
Barış Soner Uşaklı
ec1d5e38da
breaking: remove socket.emit('posts.upvote')
...
socket.emit('posts.downvote')
socket.emit('posts.unvote')
3 years ago
Barış Soner Uşaklı
8427c5d9db
breaking: remove socket.emit('posts.move')
3 years ago
Barış Soner Uşaklı
4247f62441
breaking: remove socket.emit('posts.edit')
3 years ago
Barış Soner Uşaklı
f7418ccd47
breaking: remove socket.emit('posts.bookmark/unbookmark')
3 years ago
Barış Soner Uşaklı
5c3d5f1f40
test: make it async
3 years ago
Barış Soner Uşaklı
26f00ffb60
test: fix
3 years ago
Barış Soner Uşaklı
e3c0f0be0a
refactor: remove unused
3 years ago
Barış Soner Uşaklı
07e2741ea6
breaking: remove deprecated admin.groups methods
3 years ago
Barış Soner Uşaklı
a8afdc6019
fix : #10069 , don't modify fields array
...
use a single setObjectFields for the profile update
3 years ago
Barış Soner Uşaklı
830166d120
fix : #10067 , count posts instead of incr/decr
3 years ago
Barış Soner Uşaklı
45d755b6ae
breaking: remove socket.emit('categories.getCategory')
3 years ago
Barış Soner Uşaklı
cc3f82bc83
breaking: remove socket.emit('admin.categories.setPrivilege') and socket.emit('admin.categories.getPrivilegeSettings')
3 years ago
Barış Soner Uşaklı
0b9c01f9a0
breaking: remove deprecated socket.emit('admin.categories.update')
3 years ago
Barış Soner Uşaklı
ba5d2e7b81
breaking: remove deprecated socket.emit('admin.categories.purge')
3 years ago
Barış Soner Uşaklı
b335372348
breaking: remove deprecated socket.emit('admin.categories.create')
3 years ago
Barış Soner Uşaklı
10c19af2ad
breaking: remove deprecated socket.emit('admin.categories.getAll')
3 years ago
Barış Soner Uşaklı
f8f0a83b52
test: one more getTopicPosts test
3 years ago
Barış Soner Uşaklı
906dc5675e
fix: handle start=0 stop=0 for topics.getTopicPosts
...
add more tests
3 years ago
Barış Soner Uşaklı
a29535833f
fix : #10052 , dont use spaces in tag class name
3 years ago
Barış Soner Uşaklı
6ea3b51f12
Zincrybulk ( #9975 )
...
* feat: zincry bulk
* feat: psql bulk incr placeholder
* test: redis test fix
* test: redis test
3 years ago
Barış Soner Uşaklı
7b99dc46eb
test: utils.params
3 years ago
Barış Soner Uşaklı
1cdb0b1e19
fix: don't crash if tid is falsy
3 years ago
Barış Soner Uşaklı
cd2040ac6b
test: regular user shouldn't see admin:privileges
3 years ago
Barış Soner Uşaklı
5843122178
test: add missing tests
3 years ago
Barış Soner Uşaklı
8117b7f22f
breaking: remove deprecated post diff socket calls
3 years ago
Barış Soner Uşaklı
7434cbf66f
test: add api token tests
3 years ago
Julian Lam
6c07433dea
refactor: use routePrefixMap instead of routeRegexpMap, +tests ( #10035 )
...
* refactor: use routePrefixMap instead of routeRegexpMap, +tests
Currently tests fail because privilege pages resolve if passed garbage... hmm
* fix: priv check paths
remove /v3 from path as well
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
3 years ago
Barış Soner Uşaklı
404a877408
test: add missing tests
3 years ago
Barış Soner Uşaklı
2bdb4906ec
test: upgrade.runParticular
3 years ago
Barış Soner Uşaklı
6dcdf1d342
breaking: remove setTopicSort/setCategorySort
3 years ago
Barış Soner Uşaklı
c17ec996e0
test: add missing acp root category test
3 years ago
Barış Soner Uşaklı
a7d1dfb65c
breaking: remove deprecated socket user create/delete functions
...
add missing tests
3 years ago
Barış Soner Uşaklı
217aae4c81
test: cache dump test
3 years ago
Barış Soner Uşaklı
c93d7fdbdd
breaking: remove deprecated uploads.delete
3 years ago
Barış Soner Uşaklı
79de48c57f
breaking: remove deprecated methods
3 years ago
Barış Soner Uşaklı
bc120dba68
test: add missing controllers
3 years ago
Barış Soner Uşaklı
edf7c647e8
test: fix tpl name
3 years ago
Barış Soner Uşaklı
6d186ff10d
test: add mising email.test tpls
3 years ago
Barış Soner Uşaklı
754cdab896
test: debug routes in dev
3 years ago
Barış Soner Uşaklı
1280d9ae85
test: add digest route test
3 years ago
Barış Soner Uşaklı
2473d5d873
fix : #10027 , properly auto confirm first user
3 years ago
Barış Soner Uşaklı
f11bc33ac5
test: digest
3 years ago
Barış Soner Uşaklı
0e72512509
test: fix function name
3 years ago
Barış Soner Uşaklı
d375dcb873
test: submitUsage
3 years ago
Barış Soner Uşaklı
d7c32ccbc2
test: remove log
3 years ago
Barış Soner Uşaklı
29b3587d91
test: middleware/expose.js
3 years ago
Barış Soner Uşaklı
fa1ac04dc6
lint: fix
3 years ago
Barış Soner Uşaklı
c5f08fdc81
breaking: remove socket.io/flags.js
...
refactor: helpers.loginUser returns a single object {jar, csrf_token}
3 years ago
Barış Soner Uşaklı
fb363957d1
refactor: tab rules
3 years ago
Barış Soner Uşaklı
4359e5c97c
refactor: remove tabs after declaration
3 years ago
Barış Soner Uşaklı
aac0792ab8
test: mainPost removed from inf scroll
3 years ago
Barış Soner Uşaklı
8379c11b22
refactor: setObjectBulk to match sortedSetAddBulk
3 years ago
Barış Soner Uşaklı
ae64b9f495
test: add another assert for random failing test
3 years ago
Barış Soner Uşaklı
e3f5b706a5
test: show body when test fails
3 years ago
Julian Lam
b912a564e3
fix: accidentally not clearing email when said email is confirmed for a different uid
3 years ago
Barış Soner Uşaklı
30cce14204
test: fix tpl test
3 years ago
Barış Soner Uşaklı
3386893b58
test: dbsearch no longer has staticDir
3 years ago
Barış Soner Uşaklı
4ac9270a2a
test: increase timeout
3 years ago
Barış Soner Uşaklı
66e7cdac7a
fix : #9973 , ignore if assigning to same parent
3 years ago
Barış Soner Uşaklı
d27c9696e3
feat: add node 16 ( #9847 )
...
* feat: add node 16
* fix: check errors in fork
* test: add use-spawn
* test: another test
* Revert "test: another test"
This reverts commit 606efe26fe1decd5d9269d63d5b649441ba2203b.
* test: another test
* fix: lint
* fix: remove spawn-wrap
* test: comment out plugin installs
* fix: lint
* test: uncomment all tests except npm i
* fix: lint
* test: bring back tests
* test: remove leftover override
3 years ago
Barış Soner Uşaklı
67cb249122
fix : #9972
3 years ago
Julian Lam
10bb8cf747
test: fix account export test routes
3 years ago
Barış Soner Uşaklı
62ac9a8bbb
test: add test aliases.buildTargets
3 years ago
Barış Soner Uşaklı
bda5d14425
test: empty query params for search
3 years ago
Barış Soner Uşaklı
25ebbd6563
fix: windows tests
3 years ago
Barış Soner Uşaklı
c8b2fc46dc
fix: translator path traversal
3 years ago
Julian Lam
fa1afbcf4a
test: restore commented-out i18n test
3 years ago
Barış Soner Uşaklı
f7967bdf68
feat: #8053 , biweekly digest option
3 years ago
Julian Lam
35af763418
feat: added failing i18n tests
3 years ago
Julian Lam
bd893cdaa3
fix: extra debug log
3 years ago
Julian Lam
154ffea01b
test: moved topic event and topic thumb tests to subfolder for better organisation
3 years ago
Barış Soner Uşaklı
63109c0705
test: possible fix to timeout
3 years ago
Barış Soner Uşaklı
8654a996d3
test: increase timeout
3 years ago
Barış Soner Uşaklı
e6a17a6349
Psql multikey ( #9852 )
...
* perf: convert promise.all to single query
* perf: single query for removeBulk
* perf: list
3 years ago
Barış Soner Uşaklı
ea04aeded4
perf: convert promise.all to single query ( #9851 )
3 years ago
Julian Lam
be43cd2597
Topic Linkbacks ( #9825 )
...
* feat: WIP topic linkbacks, + failing tests
* test: don't accidentally comment out all of the post tests
* fix: rename to "backlinks"
* feat: more stub code, more failing tests
* feat: backend methods and passing tests for topic backlinks
* test: uncomment test/posts.js again
* fix: missing quotation mark in topic event helper
* fix: superfluous usage of Promise.all
* test: fix broken test -- used hardcoded (and incorrect) url
* test: parseInt shenanigans
3 years ago
Peter Jaszkowiak
ff84d6c52f
Add more chat hooks, replace toobig.jpg ( #9843 )
...
* feat: more hooks for messaging
for use in global chat plugin
* fix: replace toobig.jpg
toobig.png is a real 10000x10000 image
3 years ago
Barış Soner Uşaklı
ff850b2431
fix: lint
3 years ago
Barış Soner Uşaklı
4f8647a59c
test: dashboard
3 years ago
Barış Soner Uşaklı
9fe9ab0869
test: add tests for admin privileges
3 years ago
Barış Soner Uşaklı
123354ca36
fix: psql tests
3 years ago
Barış Soner Uşaklı
3605ac811d
fix: possible test fix for subfolder redirect
3 years ago
Barış Soner Uşaklı
3479832593
test: add missing tests
3 years ago
Julian Lam
8cb475482a
test: remove debug log
3 years ago
Julian Lam
4eacfef02b
fix: missing relative path in test
3 years ago
Julian Lam
58e0a366c8
fix : #9834 , missing null email check on new registrations, added tests
3 years ago
Julian Lam
cb69934ad0
test: no need to create fake interstitial as NodeBB comes with some by default
3 years ago
Barış Soner Uşaklı
07859f7e8c
fix: ban info test
3 years ago
Barış Soner Uşaklı
896ff2152f
fix: up timeout for psql tests
3 years ago
Barış Soner Uşaklı
2657804c1f
fix : #9790 , fix sorting of more than one page of pinned topics
3 years ago
Barış Soner Uşaklı
397835a05a
feat: allow removing multiple items from list
3 years ago
Barış Soner Uşaklı
0ce4b87d85
fix : #9781 ( #9782 )
3 years ago
Julian Lam
8cbad61e8a
test: added test for external image via new change picture API
3 years ago
gasoved
3df79683f5
feat: create folders in ACP uploads #9638 ( #9750 )
...
* feat: create folders in ACP uploads #9638
* fix: openapi
* test: missing tests
* fix: eslint
* fix: tests
3 years ago
Barış Soner Uşaklı
e59d357533
feat: als ( #9749 )
...
* feat: als
* fix: up test timeout
* fix: don't overwrite caller if it already exists
* fix: up test timeout for psql
3 years ago