5791 Commits (3b55e657140c274a0ea61c5791c29b8eb041c4d9)
 

Author SHA1 Message Date
Barış Soner Uşaklı 3b55e65714 Merge pull request #1664 from char101/patch-6
Fix callback execution in redis search
12 years ago
Charles 90b2d766f7 Fix callback execution in redis search
`callback` should be passed to `reds.search` otherwise the execution will be overlapped. 

For example in the plugin `nodebb-plugin-dbsearch':

```javascript
db.searchRemove('topic', tid, function() {
	if (typeof title === 'string' && title.length) {
		db.searchIndex('topic', title, tid);
	}

	if (typeof callback === 'function') {
		callback();
	}
});
```

The actual execution is like this

```
1402387863.625553 [0 127.0.0.1:16660] "zrevrangebyscore" "nodebbtopicsearch:object:6" "+inf" "0"
1402387863.625891 [0 127.0.0.1:16660] "MULTI"
1402387863.626043 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:word:123" "1" "6"
1402387863.626052 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:object:6" "1" "123"
1402387863.626060 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:word:TST" "1" "6"
1402387863.626065 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:object:6" "1" "TST"
1402387863.626071 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:word:AN0" "1" "6"
1402387863.626076 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:object:6" "1" "AN0"
1402387863.626083 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:word:TPK" "1" "6"
1402387863.626092 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:object:6" "1" "TPK"
1402387863.626104 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:word:ETTT" "1" "6"
1402387863.626116 [0 127.0.0.1:16660] "zadd" "nodebbtopicsearch:object:6" "1" "ETTT"
1402387863.626130 [0 127.0.0.1:16660] "EXEC"
1402387863.626253 [0 127.0.0.1:16660] "del" "topic:6:tags"
1402387863.626281 [0 127.0.0.1:16660] "MULTI"
1402387863.626515 [0 127.0.0.1:16660] "del" "nodebbtopicsearch:object:6"
1402387863.626524 [0 127.0.0.1:16660] "EXEC"
```

The key nodebbtopicsearch:object is added and then just being deleted again.
12 years ago
Barış Soner Uşaklı a7bd83a549 Merge pull request #1663 from char101/patch-5
Fix relative path on topic replaceState
12 years ago
Charles c7b308d65e Fix relative path on topic replaceState 12 years ago
barisusakli b9c30aa42d possible fix to #1660
modified the tagsinput source to use keypress instead of keydown for the
confirmKeys
12 years ago
Julian Lam a40b06c304 latest translations 12 years ago
Julian Lam d66bead245 Merge remote-tracking branch 'origin/master' 12 years ago
Julian Lam b655474150 fixed #1661 12 years ago
barisusakli 833aa0f738 derp 12 years ago
barisusakli b81f3552bb fixed typo 12 years ago
barisusakli b5071d504f removed timing #1654 12 years ago
barisusakli d4b48cd2ac closes #1654 12 years ago
barisusakli aadca3a675 fix calls to removeRelativePath in ajaxify.js 12 years ago
barisusakli db84ced78f removeRelativePath public 12 years ago
barisusakli 4bdbce9cd8 use removeRelativePath in app.js too 12 years ago
Barış Soner Uşaklı 26309b5d65 Merge pull request #1658 from char101/patch-4
Fix removeRelativePath
12 years ago
Charles 9734403114 Fix removeRelativePath
Instead of checking the existence of relative_path (without /) anywhere on the url, it really should check that the url only starts with the relative_path.

Example

```
relative_path = /forum
without / = forum
url = /category/forum/5
removeRelativePath = ory/forum/5
```
12 years ago
barisusakli 974e0823d8 copyright 12 years ago
barisusakli ee88693448 callback 12 years ago
barisusakli 178f567659 closes #1655 12 years ago
barisusakli b7f71ca0b4 fixes removePostFromTopic
remove the pid from the votes set too
12 years ago
barisusakli bf04749f5e fixes posttools.ismain 12 years ago
barisusakli d32dfd98b7 remove main post if page is greater than 1
this fixes pagination after the main post change
12 years ago
barisusakli 7610c11cd1 closes #450
backup database before upgrade!
upgrade script will take the first post of each topic and set the
`mainPid` property on the topic. then it will remove that pid from the
sorted sets for that topic, this was done to make alternative sorting
work.

added a new sorted set called `tid:<id>:posts:votes` that is used to
sort topic posts by vote count, the original sorted set `tid:<id>:posts`
is used to sort by oldest first or newest first.

the main post is added to the returned posts array on topic load and is
always at the top.
theme changes are minimal just a few new data properties on the posts
and the sorting dropdown.
hopefully didn't miss anything too critical.
12 years ago
psychobunny c5b8a7b163 filter:templates.get_virtual for ajaxifying to virtual templates 12 years ago
Julian Lam b648e84836 latest translations and fallbacks 12 years ago
Julian Lam 57f40e1e1c Merge pull request #1648 from char101/patch-1
Add relative_path to authentication redirects
12 years ago
Julian Lam b44cbc89ad Merge branch 'master' of github.com:Fastinyoh/NodeBB into Fastinyoh-master 12 years ago
Julian Lam 8587dd11d8 closed #1653 -- removed that spinner thing npm uses now. 12 years ago
Charles 5f1b1ad2bf Also add relative_path to destination
Because the destination url does not include the relative_path
12 years ago
Charles ce083573a9 Fix typo 12 years ago
Charles f26a250b01 Add relative_path to authentication redirects 12 years ago
dhingey b57dbc37cd Fix relative path URL bugs in the plugin API.
Fixes plugin-related 404 URLs, as well as the plugin directory URL
for installations which use a relative path.
12 years ago
psychobunny d5c6b6c334 modifying installation instructions as per @a5mith 12 years ago
psychobunny 201a309801 added documentation for the hooks I created yesterday 12 years ago
barisusakli f609098ca7 moved secondry db config message #1645 12 years ago
barisusakli 8d0c659f08 small fix to redirect 12 years ago
barisusakli 61b79de3e8 closes #1641 12 years ago
psychobunny a0bdd06a6a filter:user.custom_fields - ability to add custom fields into userData 12 years ago
psychobunny 013f62cd7d action:user.verify & filter:user.verify.code - plugins can now override the verification system 12 years ago
psychobunny 31adf7084d filter:register.complete - plugins can redirect the user elsewhere post-registration 12 years ago
psychobunny 4bb8762746 send in the entire registration form for userData 12 years ago
barisusakli d1c2c87510 fixed double index in post notification 12 years ago
psychobunny 5ac788565f eventEmitter.any 12 years ago
barisusakli e1491e4182 fixed wrong admin tags on admin/user/search 12 years ago
barisusakli 7d0eb9afaa closes #1463 12 years ago
barisusakli 6b93095204 more link fixes 12 years ago
barisusakli efe04c12d3 closes #1635
if email isnt confirmed, show a warning in account/edit and let users
resend confirm email
12 years ago
barisusakli 930f1e4789 default off 12 years ago
barisusakli 65e9f68d73 change requireEmail default to off 12 years ago