10956 Commits (2eb7c2842a070b6fff96108fe03815b4076868ed)

Author SHA1 Message Date
Julian Lam 4b0cb26b34 fix: empty "manage" menu showing in ACP
... if no privileges corresponding to those menu items
are given
5 years ago
Julian Lam cc2686057c fix: hide nodebb version in ACP for non-superadmins 5 years ago
Julian Lam cf2f1e956a refactor: changed way middleware was exported 5 years ago
Julian Lam f00595b32d fix: change how admin middlewares are exported 5 years ago
Julian Lam ae68a254d7 fix: one less return, to appease codeclimate 5 years ago
Julian Lam 03bd76dea2 fix: inability to access /admin if not superadmin
There was an odd issue where non-superadmins could not use
the /admin route to access the ACP, even though they had
appropriate access. For whatever reason, it could not
be reliably reproduced on my dev. As it turns out, the
reason was because I was checking the wrong privilege,
and my dev database had this wrong privilege leftover
from the initial development of the ACP admin privileges
feature. Dumb.

Anyhow, that fixes this issue.
5 years ago
Barış Soner Uşaklı 29e3ab247d fix: #8560, fix old upgrade script
db.connect no longer exists at the root
5 years ago
Julian Lam 6521e4dac4 Revert "feat: expose global/admin privileges to all routes"
This reverts commit 4737f937ee.
5 years ago
Julian Lam 4737f937ee feat: expose global/admin privileges to all routes
@barisusakli revert if necessary 😬
5 years ago
Andrew Rodrigues 7daba7ddc1
fix: #8570 5 years ago
Julian Lam 3efe2362e2 fix: sorting the flags list by newest is not considered a filter
... as it is default
5 years ago
Julian Lam 334be11382 fix: no-widgets messaging in ACP + copy 5 years ago
Julian Lam 346db0d84d feat: flags list sorting, closes #8569 5 years ago
Julian Lam cabe62a06c fix: #8568 perPage not acting like a filter 5 years ago
Barış Soner Uşaklı 35a538ec2a feat: allow adding multiple users to group 5 years ago
Barış Soner Uşaklı f1e82b6441 feat: add filter:group.getOwnersAndMembers 5 years ago
Julian Lam 9c70b6620e feat: pass uid into filter:flags.list 5 years ago
Barış Soner Uşaklı 31c2b7d946 fix: #8562 5 years ago
Julian Lam 2adae87949 fix: progress bar clobbering upgrade script name 5 years ago
Julian Lam ac75c9a052 fix: tweak upgrade script progress bar to only update 100 times in total 5 years ago
Julian Lam 80a2a700ce fix: navigation title unescape upgrade script tweak 5 years ago
Julian Lam 7456a0e34e fix: new language key for error handling 5 years ago
Julian Lam de8eebbd7c fix: upgrade scripts not run properly if schemaDate is present
Only affected VERY old installs that don't use schemaLog
5 years ago
Barış Soner Uşaklı 0189945996 refactor: remove util.promisify calls 5 years ago
Barış Soner Uşaklı bfaf648ec3 fix: #8556, catch errors from admin check 5 years ago
Barış Soner Uşaklı 326827382a fix: upgrade script for 1.15.0 5 years ago
Barış Soner Uşaklı 846b7d2430 refactor: change pwd change logic
add one more test
5 years ago
Julian Lam 16cee1b03b fix: improper targetUid check during password change 5 years ago
Julian Lam 0903eb4b8c feat: limit privileges column to superadmins only 5 years ago
Peter Jaszkowiak 1d170e0c1c
fix: #8547, remove old deps during upgrade (#8557) 5 years ago
Julian Lam 12edd18b46 feat: use nodebb-scoped bootswatch
closes #8527
5 years ago
Barış Soner Uşaklı 6e91885836 feat: use assetBaseUrl instead of hardcoding 5 years ago
Barış Soner Uşaklı 3f01f4a2b8 Revert "feat: load timeago strings client-side"
This reverts commit 558a2d739c.
5 years ago
Julian Lam 558a2d739c feat: load timeago strings client-side
9adaccd036 introduced the ability to
configure an assetBaseUrl, but the timeago strings were still
calling a hardcoded value as it was handled server-side. There's
no need for the strings to be loaded until timeago is initialised.
5 years ago
Julian Lam 9adaccd036 feat: +assetBaseUrl, -l10BaseUrl, -requireBaseUrl
Additional base URLs were necessary for benchpress and translator,
and in order to not clutter the API response with needless one-
time use base URLs, I decided to use a single base that is used
by all of the services, assetBaseUrl.
5 years ago
Barış Soner Uşaklı 33c5988c34 refactor: rewrite src/upgrade.js with async/await 5 years ago
Barış Soner Uşaklı 231d34d0aa fix: upgrade script 5 years ago
Barış Soner Uşaklı 8887f0edaa fix: don't allow duplicate upgrade script names 5 years ago
Julian Lam 9e3fd0e479 Revert "feat: #8493, plugin helper for standardised link/button injection"
This reverts commit 0bbb813e4b.
5 years ago
Sam Thompson 0bbb813e4b feat: #8493, plugin helper for standardised link/button injection 5 years ago
Julian Lam 9f3b78118a fix: send hard 404 instead of soft 404 for missing modules
We used to send a soft 404 because require.js would error out on
a 404, but it seems years ago, error handling was added to the
require() call, so a hard 404 will not throw errors to the console
5 years ago
Barış Soner Uşaklı d6baf5c278 feat: show event/params on error 5 years ago
Julian Lam 68f8d6e3a1 fix: #8549 send 308 Permanent Redirect on topic/category shortlinks 5 years ago
Julian Lam def16f9e97 feat: introduce overridable l10nBaseUrl config value 5 years ago
Barış Soner Uşaklı 2c35d0ba87 refactor: change incrementViewCount and markAsRead to async/await 5 years ago
Barış Soner Uşaklı dfabd0a3fe feat: remove administrator property from public routes 5 years ago
Barış Soner Uşaklı 774e5d0429 feat: add helmet middlewares 5 years ago
Barış Soner Uşaklı c39c51139b fix: remove default helmet 5 years ago
Julian Lam a716a5529c
feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals (#8541)
* feat: privileges save button, #8537, WIP

* fix: disable firefox autocomplete on privilege form fields

* feat: closes #8537 privilege changes commit on save

- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs

* fix(tests): remove duplicate template helper test

* fix(tests): broken template helper test

* feat: confirm dialogs for all privilege copy actions

Also, ability to add user to a privilege table without needing
to refresh the privilege table.

* feat: group row addition w/o table refresh

breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges
no longer make socket calls to the following hooks:

- filter:privileges.list, filter:privileges.admin.list,
  filter:privileges.global.list, filter:privileges.groups.list,
  filter:privileges.admin.groups.list,
  filter:privileges.gloval.groups.list

The filters are still called, but done before the helper method
is called, and the results are passed in instead. This change
should only affect you if you directly call the helper methods,
otherwise the change is transparent.

* fix: stale ajaxify data on privilege category switch

* fix: implicit privileges not showing for user privs

* fix: groups, not group, also fix tests

* fix(tests): again

* fix: wrong tpl rendered when adding group to global priv table
5 years ago
Julian Lam 0f10e0836b fix: remove duplicate configuration for helmet-hsts 5 years ago
Barış Soner Uşaklı e7a502e0aa feat: add ability to search groups in group details page 5 years ago
Barış Soner Uşaklı 335169f2b1 fix: don't process invalid topics, fallback to 0 score 5 years ago
Barış Soner Uşaklı 6924a22238 fix: tests 5 years ago
Barış Soner Uşaklı bb224184d8 fix: #8539, enforce content checks for post queue 5 years ago
Barış Soner Uşaklı 776e34a80f refactor: rewrite src/install with async/await 5 years ago
Julian Lam 6c00ec8435 refactor: removed rather redundant flag reporters zset 5 years ago
Julian Lam 0f2b6f1ff7 fix: bug; additional reports could be added by the same user repeatedly 5 years ago
Barış Soner Uşaklı 519e665939 fix: #8538, go to first unread instead of last read 5 years ago
Barış Soner Uşaklı 0d698a079e fix: #8533, validate and retry password during setup 5 years ago
Barış Soner Uşaklı 9e80a9efdd fix: #8534, dont show modal on search 5 years ago
Barış Soner Uşaklı fb7bb8d400 feat: use category selector in category page
fix privilege shortcuts in group page after search
5 years ago
Barış Soner Uşaklı 560f3eb173 feat: css fixes 5 years ago
Barış Soner Uşaklı 91411cc47c feat: add privileges shortcut to groups list
fix issues with escape group names
5 years ago
Julian Lam fcdbdf63a3 refactor: flags object in post tools 5 years ago
Barış Soner Uşaklı f1974fb900 refactor: pass only needed data 5 years ago
Barış Soner Uşaklı 9f346c53ab fix: language string 5 years ago
Barış Soner Uşaklı f89ec20574 feat: allow passing groupName to user.search 5 years ago
Julian Lam c705e08a76 feat: allow direct link to flag from post tools, #8531 5 years ago
Barış Soner Uşaklı c4829fd8c2 feat: allow changing requirejs base url 5 years ago
Barış Soner Uşaklı 9df871bee2 fix: tests 5 years ago
Barış Soner Uşaklı bbc7737e14 feat: ability to clear cache from acp 5 years ago
Barış Soner Uşaklı 69fb15276c fix: tests 5 years ago
Barış Soner Uşaklı 8d8117ffa1 feat: reduce amount of data loaded on acp admin page
get rid of socket call and use ajaxify.data.categories
5 years ago
Barış Soner Uşaklı 7331faed9f fix: reverse uid checks 5 years ago
Barış Soner Uşaklı 303bffdb5f feat: remove require fallback for plugins 5 years ago
Barış Soner Uşaklı 2dfe9d49f4 fix: acp view category button if category is a link 5 years ago
Barış Soner Uşaklı 762b0be4b4 feat: remove /assets/stylesheet.css 5 years ago
Barış Soner Uşaklı 5e5815f051 fix: #8515, fix login redirect on subfolder 5 years ago
Barış Soner Uşaklı fd4c3cda42 fix: #4695, remove new notif alert 5 years ago
Julian Lam 8473e165a6 fix: too small sortable handle for ACP>Manage>Categories
The handle was initially just the icon, but now it is the icon
and the category label itself.
5 years ago
Barış Soner Uşaklı 24535a62e7 feat: make category tools in acp a dropdown
add view category, view privileges into dropdown
5 years ago
Barış Soner Uşaklı 37e56d94ce feat: series upload 5 years ago
Barış Soner Uşaklı 8bd63f61e0 feat: resolve flag on delete/purge/ban/delete account 5 years ago
Barış Soner Uşaklı c54b6b9c7e refactor: startup 5 years ago
Barış Soner Uşaklı 57135761ca fix: move check inside lock 5 years ago
Barış Soner Uşaklı af91c26a6f refactor: get rid of bind calls 5 years ago
Barış Soner Uşaklı e045436c07 feat: 8502, don't change topics sitemaps on every reply
sort by topic creation in ascending order
5 years ago
Barış Soner Uşaklı 0a9ea91fea feat: allow building custom languages during dev 5 years ago
Barış Soner Uşaklı d1cb405d86 fix: #7351, display less errors with location and error message 5 years ago
Julian Lam 55b0e902fb feat: consolidation of flags to reduce flagspam, #8510
Squashed commit of the following:

commit c6d09396208a10c244d7b3d22ffd2d7dd1274d3a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 13:41:32 2020 -0400

    fix: more tests

commit 32f9af2a87a81fa62ecca01e71d6f0d5b9d37ba1
Merge: e50907535 4eae927d1
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:53:04 2020 -0400

    Merge remote-tracking branch 'origin/master' into singleton-flags

commit e50907535109dbdbe8f15c3e2fcdf22d90b1332a
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:52:46 2020 -0400

    fix: controllers-admin test

commit fd5af99e303de48a80b0ccc166eee19175cf232b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:26:55 2020 -0400

    fix(tests): dummy commit to trigger travisCI

commit c452a6ffcfaef91403de084c4ae16795cb23c60e
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:05:09 2020 -0400

    fix(openapi): openapi spec changes

commit 8089a74e89128141ab1e6f8ff83447114b3b846b
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:48:00 2020 -0400

    fix: reversing the order of reports for display purposes

commit a099892b377333561c72f1ad5b6b20ddb4ce8a96
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:45:44 2020 -0400

    refactor: run all flag creation calls in a single batch

commit b24999682f9d5a33a08a049749c1f0eb4f00facc
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:08:23 2020 -0400

    feat: handling multiple reporters per flag, #8510

commit 08c75c020021ada754bf0e39eae77d631b01dee5
Author: Julian Lam <julian@nodebb.org>
Date:   Thu Jul 16 20:53:18 2020 -0400

    feat: upgrade script for #8510
5 years ago
Barış Soner Uşaklı 3761f05c98 feat: change invalid language codes to default lang 5 years ago
Barış Soner Uşaklı ce6b20c4b7 feat: remove topics.async.getTopicData usage 5 years ago
Barış Soner Uşaklı 0cea713691 feat: remove deprecated checkGlobalPrivacySettings 5 years ago
Barış Soner Uşaklı a0da2ba774 feat: remove deprecated isAdmin method 5 years ago
Barış Soner Uşaklı 2cdb935f1d feat: remove file.isFileTypeAllowed 5 years ago
Barış Soner Uşaklı 4eae927d14 feat: remove deprecated hooks 5 years ago
psychobunny a6ae69737b Merge branch 'master' of https://github.com/NodeBB/NodeBB 5 years ago
psychobunny 2c83278f97 feat: quick access dropdown on groups page to access privileges page 5 years ago
Barış Soner Uşaklı 844f2b4ed0 feat: #8524, allow editing category of queued topic 5 years ago
Barış Soner Uşaklı 7260646d6c fix: #8500, allow regular users select topics on unread 5 years ago