11723 Commits (161081e960b3bf446544ff88c893f5aeefb217df)

Author SHA1 Message Date
Julian Lam 1cf0032d9f feat: allow override of local fns in login controller, 400 instead of 500 for wrong login type [breaking] 4 years ago
Barış Soner Uşaklı 6cbb77afda fix: add missing breadcrumb on /user/<slug>/categories 4 years ago
Barış Soner Uşaklı f0dd302c77 perf: use only required calls 4 years ago
Peter Jaszkowiak a51c5698c7 fix: `--help` usage info
yargs (via nconf) would exit when detecting a help flag

also improves the speed of `./nodebb help build`
4 years ago
Julian Lam 171017c38c fix: #9130, remove timestamp prefix from thumbnail names in API response 4 years ago
Barış Soner Uşaklı 8c31afae7d feat: #9173, show installed plugin versions in ./nodebb plugins 4 years ago
Julian Lam b9ba44edd7 fix: #9166 missing relative path in topic thumbs modal and topic list 4 years ago
Barış Soner Uşaklı 1968bf50f1 fix: #9163, fix total connection count on ACP
sockets.sockets is a JS map in 3.x
4 years ago
Julian Lam edb8da1ef9 feat(api): closes #9123 category and topic routes migrated to Write API 4 years ago
Julian Lam 9ecfac9b68 feat(api): #9123, migrate rest of the getObject controllers to Write API 4 years ago
Julian Lam cdff8d286a chore(api): add deprecation notices re: #9123 4 years ago
Julian Lam e267f29584 feat(api): #9123, migrate /api/post/pid/:pid to Write API 4 years ago
Barış Soner Uşaklı 33290850ee fix: #9126, skip base64 and long values 4 years ago
Barış Soner Uşaklı c1ecfd1ebf feat: #9135, don't try to reconnect forever 4 years ago
Julian Lam a555f02415 fix: inability for admins with setting privilege to save plugin settings 4 years ago
Julian Lam 895e3d939e fix: #9149, server-side handling of disableChatMessageEditing 4 years ago
Julian Lam d27815a8c0 fix: #9149, incorrect client-side `disableChatMessageEditing` value for admins/gmods 4 years ago
Julian Lam 2874036024 fix: tests 4 years ago
Julian Lam 223f0a5515 feat(acp): admin tags privilege 4 years ago
Julian Lam fb46a8d975 feat(acp): admins-mods privilege 4 years ago
Julian Lam 5b8558e9a5 feat: allow dashes in privilege group names 4 years ago
Julian Lam 3aa5beb832 feat: allow multiple privileges to be defined for a given admin socket call 4 years ago
Barış Soner Uşaklı fcc1e24ad0 feat: rename admin middleware header hook 4 years ago
Julian Lam da191341e8 feat(acp): added new admin privilege for groups management 4 years ago
Julian Lam 80ee3dfbd1 fix(api): tests 4 years ago
Barış Soner Uşaklı 931105e6cb fix: dont show deleted posts in navigator 4 years ago
Julian Lam 32e36f7b2e feat(api): group ownership API route, switch client-side to use API route 4 years ago
Julian Lam 1cd2689cf6 refactor(api): deprecated groups update socket in favour of API lib 4 years ago
Julian Lam 34ccabe3ab fix: bad assignment logic in middleware.renderHeader 4 years ago
Julian Lam 75b1bbd09f feat: explicitly add filter:admin/header.build hook
As it is not fired during middleware.processRender
4 years ago
Julian Lam 05d8b3c339 chore: add deprecation notice to topic thumb tpl value 4 years ago
Julian Lam da4f91186b fix: #9113, wrong path separator used in thumbs.get 4 years ago
Peter Jaszkowiak 2be396ff6e fix: email testing and settings change from ACP
- changing email SMTP settings wouldn't apply the first time
- "Send Test Email" now will report emailer errors in most cases
4 years ago
Julian Lam 713f029dc8 fix: removing ability to specify deprecated topic 'thumb' on topic creation 4 years ago
Julian Lam 600807fbe1 fix: don't return deleted: 0 for ephemeral groups 4 years ago
Julian Lam 438fa5c88f fix: send fewer items to client-side for ACP settings/email page 4 years ago
Julian Lam 878ee06715 refactor: schema backreference test to use map instead of reduce, properly check write-api routes 4 years ago
Barış Soner Uşaklı a2152dd100 feat: update html-to-text closes https://github.com/NodeBB/NodeBB/pull/8810 4 years ago
Barış Soner Uşaklı 4404e32ed9 fix: #9117, lower query before search 4 years ago
Barış Soner Uşaklı ab96f526d6 feat: remove max age since cache is cleared when thumbs change 4 years ago
Barış Soner Uşaklı 2d5a224b06 perf: don't load thumbs if disabled globally, cache thumb results 4 years ago
gasoved d28581eb6a
feat: show alt text instead of images in teasers (#9107)
* feat: show alt text instead of images in teasers

* refactor: from utils to local function
4 years ago
Barış Soner Uşaklı 8f938eba19 fix: #9074, fix svg uploads 4 years ago
Julian Lam ab98740821 fix: #9100 topic thumbs in OG image tags 4 years ago
Julian Lam 74d73313fd feat: migration of old topic thumbs to new format
closes #9099
4 years ago
Julian Lam 378a3a6945 fix: update version removal comments to 1.17 for some features 4 years ago
Julian Lam 4c87f30184 feat: allow plugins to override ACP relogin challenge
- used in 2factor
4 years ago
Barış Soner Uşaklı 80de572aa1 feat: add user.email.confirmByUid for sso plugins 4 years ago
Julian Lam 05dd859714 fix: postgres is slow™️ 4 years ago
Julian Lam 9f62df15bd chore: appease codeclimate 4 years ago
Julian Lam 24e754d120 feat: add thumbs to category data return 4 years ago
Julian Lam edf67f349f fix: use getSortedSetRange instead of getSortedSetsMembers 4 years ago
Julian Lam bd5c4a5cff fix: tests 4 years ago
Julian Lam e83baa97a0 fix: bad topic thumbs logic on local thumb upload 4 years ago
Julian Lam 3e54b70c06 fix: #9092, Topic thumbnails do not work with third-party uploaders 4 years ago
Julian Lam 2170c40007 fix: iteration logic bug 4 years ago
Julian Lam 9342d611be fix: enable topic thumbnails across the board [breaking] 4 years ago
Julian Lam a30c8ab5c8 feat: clent-side modal for managing topic thumbs
closes #9087
4 years ago
Julian Lam 67cf5e83b7 fix: changes to thumb resizing logic
- Resized thumb no longer skews aspect ratio
- Thumbs resized down to maximum thumb size by WIDTH only
- image.checkDimensions() now returns dimensions
4 years ago
Julian Lam 37c367d6ff feat: raise maximum thumb size to 512 4 years ago
Julian Lam 1c5cdb5121 feat: associate topic thumbs with post uploads (for the mainPid) 4 years ago
Julian Lam 08736b1812 fix: use file lib instead of direct fs module access 4 years ago
Julian Lam c043cfebd6 fix: added back missing topic thumb tests that were removed in last commit 4 years ago
Julian Lam 340387c18a fix: #9055, non-standard API response from addThumbs route
Also removed old thumb upload router handler, and updated uploadPost handling in composer to match new response schema
4 years ago
Julian Lam c09c238e3f fix: do not allow thumb deletion route to arbitrarily delete other files in uploads folder 4 years ago
Julian Lam 5950683316 feat: closes #9048, tests for topic thumbs routes, write API schema 4 years ago
Julian Lam 4152aa552e feat: tests for topic thumbs
Also added some error checking to addThumbs controller
4 years ago
Julian Lam ef7d6db912 feat: server-side work for #9047
- rename Thumbs.commit to Thumbs.migrate
- new PUT method that calls Thumbs.migrate
- `checkThumbPrivileges` now takes a single object parameter (ins. of req/res)
4 years ago
Julian Lam b5d910f53b feat: core work for #9042, thumb deletion now accepts uuids
+ common data validation for thumb addition and deletion
4 years ago
Julian Lam 1f0c1cd229 fix: references to since-removed Topics.thumbs.resizeAndUpload 4 years ago
Julian Lam 90497e3ef5 feat: more work on topic thumbs refactor
- addThumb and deleteThumb are now protected routes (duh)
- new getThumbs route GET /api/v3/topics/<tid>/thumbs
- Updated `assert.path` middleware to better handle if relative paths are received with upload_url
- Slight refactor of thumbs lib to use validator to differentiate between tid and UUID
4 years ago
Julian Lam 43dc3e3e48 fix: #9041, remove Topics.thumbs.resizeAndUpload() 4 years ago
Julian Lam 708b1c338f fix: #9040 4 years ago
Julian Lam 1257aa981e feat: expose uploaded thumbnails to client-side via API
+ plugin hook: filter:topics.getThumbs
4 years ago
Julian Lam 7e9e08f718 feat: server-side routes for handling multiple topic thumbnails
closes #8994, requires 'topic-thumb-refactor' branch of composer-default
4 years ago
Julian Lam 98cd9e3549 feat: allow uploadThumb controller to be called in code
it, and uploadsController.upload() now return the results of their operation
4 years ago
Julian Lam 4fc9da81a9 refactor: topic thumbs lib to topics.thumbs 4 years ago
Barış Soner Uşaklı 0f480be658 fix: #9085, dont prevent admins from deleting other users 4 years ago
Julian Lam efa4eca0fe fix: #9045, no post usage info if '/files/' path received 4 years ago
Barış Soner Uşaklı 60e7de0d13 feat: move upgrade script and make it shorter 4 years ago
Julian Lam 6037f5ee2c chore: add comment for clarification 4 years ago
Barış Soner Uşaklı 1f32d38778 fix: default values, clamp postsPerPage/topicsPerPage to max 4 years ago
Barış Soner Uşaklı 9da0ed400e fix: #9081, load raw settings before merging 4 years ago
Barış Soner Uşaklı bb6cc49c16 perf: dont build identical langs 4 years ago
Barış Soner Uşaklı 86f0f82be7 fix: #9068 4 years ago
Barış Soner Uşaklı 4a0d883359 breaking: #8808, remove utils.slugify 4 years ago
Barış Soner Uşaklı 1c45fa1ba5
feat: socket.io 3 changes (#8845)
* feat: socket.io 3 changes

* feat: replace socketio-wildcard with socket.onAny

up socket.io-redis to 6.x

* feat: remove mongodb/psql socket.io adapters

* feat: show data on fail

* fix: tests

* fix: typo

* fix: logger test fix

* fix: logger.io_close

* chore: up deps

* chore: update readme to reflect redis requirement

* fix: increase timeout show data if test fails
4 years ago
Barış Soner Uşaklı d2888d1d1f
Category tags (#8938)
* feat: wip category tags

* fix: tag search

* feat: remove debug

* fix: returns of searchTags and autocomplete

* fix: alpha sort

* fix: redis

* fix: delete zsets on category purge, fix another test

* fix: test
4 years ago
Barış Soner Uşaklı 792e9e703e fix: dont strip tags 4 years ago
Barış Soner Uşaklı 91c20ceca5 fix: #9065, settings v2/v3 conflict 4 years ago
Julian Lam 970ccb5a68 fix: #9063, missing handler for passwordless accounts in admin.checkPrivileges middleware 4 years ago
Barış Soner Uşaklı 6669496dba
Navigator (#9049)
* feat: navigator changes

* fix: remove extra code

* feat: add lang keys
4 years ago
Barış Soner Uşaklı 648f6215ef fix: redirect external with absolute urls 4 years ago
Barış Soner Uşaklı 458bfc0faf fix: external path for subfolder installs 4 years ago
Barış Soner Uşaklı 64ac483ddd fix: #9032 4 years ago
Barış Soner Uşaklı fcb10ebdbb feat: add socket connect/disconnect action hooks 4 years ago
Barış Soner Uşaklı 5d00b0895b fix: sso redirect on /login & /api/login 4 years ago
Julian Lam 3ea66f84e1 fix: use file lib instead of directly accessing fs (for Assert.path) 4 years ago
Barış Soner Uşaklı ef6c3b0029 fix: check uid as well 4 years ago
Barış Soner Uşaklı 7e867cf95e fix: #7597, fix progress bar of cover/profile uploads
send big cover images in chunks
4 years ago
Barış Soner Uşaklı 6f68f4d20a fix: #9032, fix login redirect for sso plugins 4 years ago
Barış Soner Uşaklı 86b7f8a5d4 fix: #8962, dont show null for purged targets 4 years ago
Barış Soner Uşaklı 5f0f476b57 feat: #9005, use timestamp in profile/cover images
delete current one if keepAllUserImages is turned off
fix typo in data
4 years ago
Barış Soner Uşaklı 954dc5b7be feat: #8983, update pin tooltip in topic 4 years ago
psychobunny 53abada5f0 Revert "feat: option to allow auto-joining of groups (optionally skip the "request membership" step)"
This reverts commit 685f3c6aa6.
4 years ago
psychobunny 685f3c6aa6 feat: option to allow auto-joining of groups (optionally skip the "request membership" step) 4 years ago
psychobunny c1a7968d23 feat: user notification settings for group.leave event 4 years ago
psychobunny f7558c6052 fix: notification on group.leave incorrectly showing "Guest has left X group" 4 years ago
Barış Soner Uşaklı b46d2f93e6 fix: #9019, add missing lang strings 4 years ago
Barış Soner Uşaklı e45b5cba81 fix: #9018 4 years ago
Barış Soner Uşaklı f7c738deda fix: #8997, don't send notifications if uids already in group 4 years ago
Barış Soner Uşaklı 1eb5fabdb1 feat: #8900, postQueue setting for category 4 years ago
Barış Soner Uşaklı 14bb0a4469 feat: #8960, update view count after merge 4 years ago
psychobunny 4317cdea34 fix: #9002 ban templates not user friendly 4 years ago
Barış Soner Uşaklı 202dcef42e fix: #9010, show rest of info even if clusterMonitor priv is not granted 4 years ago
Barış Soner Uşaklı d46740f860 fix: #9007 revoke old sessions after adding 4 years ago
Barış Soner Uşaklı 700736535c fix: guests dont always have sid 4 years ago
Barış Soner Uşaklı a4fe4d3cf5 fix: allow guests to see their replies immediately 4 years ago
Barış Soner Uşaklı 92d1b8a65f fix: privs headers 4 years ago
Barış Soner Uşaklı 4c650aeead feat: #8989, convert widget nav to dropdown 4 years ago
Barış Soner Uşaklı 5080f35752 fix: #8991, logout on password reset, dont verify email if password expired
dont allow same password on reset
4 years ago
Barış Soner Uşaklı 3cd0c9a476 fix: #8998, allow guests to use write api to post/reply 4 years ago
Barış Soner Uşaklı 5a137a0dd6 fix: guest handles to user displayname as well 4 years ago
Barış Soner Uşaklı 546f58bf1f fix: timestamp in queue, add post queue strings 4 years ago
Barış Soner Uşaklı 7f5efc3e93 fix: #8992, set email:confirmed for first admin user 4 years ago
Barış Soner Uşaklı 80f0750bd4 fix: typo in upgrade script, closes #8990 4 years ago
Barış Soner Uşaklı 9ab4fb412b fix: order 4 years ago
Barış Soner Uşaklı d3c04afb98 fix: #8982, copy color on tag rename, dont copy if target exists
refresh page on tag rename
4 years ago
Julian Lam acb576662e fix(spec): from 6e6a7a8f8a 4 years ago
Barış Soner Uşaklı 6e6a7a8f8a fix: #8969, export csv to file 4 years ago
Julian Lam 007a3258a0 feat: add handler for 501 api response 4 years ago
Barış Soner Uşaklı f4d217d829 fix: #8980, fix lang string 4 years ago
Barış Soner Uşaklı bf171adc83 fix: #8979 4 years ago
Julian Lam 1e7cf1cbc4 fix: #8971, disallow flags of privileged users (mods, gmods, admins) 4 years ago
Barış Soner Uşaklı dadb2527da fix: #8974, with password login for approval queue 4 years ago
Julian Lam ad8e770037 feat: add pinExpiry and pinExpiryISO to topic data 4 years ago
gasoved a56a657759
fix: missing select/clear all checkbox added to category privileges template (#8967) 4 years ago
Peter Jaszkowiak ba3981e270
fix: use package.name for theme.id (#8965)
Prevents cases like #8953
4 years ago
Barış Soner Uşaklı 07fe959ce5 chore: remove test code 4 years ago
Barış Soner Uşaklı b8cafefce2 fix: winston usages 4 years ago
Barış Soner Uşaklı 414caac01b fix: #8957 4 years ago
Barış Soner Uşaklı 47a19d6763 fix: error message 4 years ago
Barış Soner Uşaklı 5bb5ec4618
fix: #8954, clear purged replies and toPids (#8959)
* fix: #8954, clear purged replies and toPids

* fix: redis test
4 years ago
Julian Lam 21d6225ce0 fix: 'already-deleting' error on subsequent account content deletions 4 years ago
Barış Soner Uşaklı 93863bb3c6 fix: #8949, faster upgrade script 4 years ago
Barış Soner Uşaklı 6771ca150a fix: add topic uid to infinitescroll 4 years ago
Barış Soner Uşaklı c037779fa1 feat: add topicOwnerPost #8778 4 years ago
Julian Lam ac734b8335 fix: #8912 4 years ago
Barış Soner Uşaklı 4f37eddc5e feat: clear reset tokens on user delete 4 years ago
Barış Soner Uşaklı e32cd31ec6 fix: #8918 4 years ago
Barış Soner Uşaklı 3af4d13fa5 fix: basepath for r.js modules 4 years ago
gasoved 00e75de736
feat: select/clear all checkboxes in privilege table (#8941) 4 years ago
psychobunny 1c0e8c1663 fix: move meta.getServerTime call to admin namespace 4 years ago
Julian Lam 90434a4668 Revert "fix(spec): always show thumb in topic response"
This reverts commit 493c568a75.
4 years ago
Julian Lam 493c568a75 fix(spec): always show thumb in topic response 4 years ago
Barış Soner Uşaklı 0ca40af834 fix: #8939, fix username change notification getting filtered out 4 years ago
Julian Lam 906d7d734b refactor: move API banned response handler to separate internal method 4 years ago
Julian Lam afb26bfe48 feat: show ban reason and expiry in write api responses, if user is banned 4 years ago
Julian Lam eab4ca7104 fix: bug with Topics.resizeAndUploadThumb not checking for extension validity 4 years ago
Barış Soner Uşaklı 2b73a14e42 fix: #8933 4 years ago
Julian Lam 6e5ec3f895 feat: automatically unban users in onSuccessfulLogin
This allows write API (and probably SSO login) to go through unimpeded if a user's ban has expired. Closes nodebb/nodebb-plugin-write-api#126
4 years ago
Barış Soner Uşaklı 77f0bff54f fix: #8929, fix popular, top rss feed urls 4 years ago
Barış Soner Uşaklı 8f4060819f Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Julian Lam 5dd3b03125 fix: a derp 4 years ago
Barış Soner Uşaklı b18e7e319b fix: spec 4 years ago
Julian Lam 4ca62dc45b fix: improper handling of scheme-relative URLs in topic thumb logic 4 years ago
Barış Soner Uşaklı 3f337b5d7c feat: #8925, #8924 4 years ago
Barış Soner Uşaklı 5fa098326f fix: https://github.com/NodeBB/NodeBB/pull/8685
fix category link redirect on cold load
fix helpers.redirect if passed in url is external
fix ajaxify so it doesn't slice first character of external url
4 years ago
Julian Lam f33a9185ff fix: on OP edit, call helper method to upload and resize thumb 4 years ago
Barış Soner Uşaklı 9ee1fb490e fix: https://github.com/NodeBB/NodeBB/pull/8759 4 years ago
Barış Soner Uşaklı 672d4da078 feat: human readable uptime 4 years ago
Julian Lam 6e2da9966e refactor: move plugin hook methods to plugin.hooks.* 4 years ago
Julian Lam 3b1c03ed50 feat: allow ACP API access to bearer tokens
closes nodebb/nodebb-plugin-write-api#132
4 years ago
Julian Lam 98a05e4dde chore: add missing plugin hook deprecation warning 4 years ago
Barış Soner Uşaklı ef3df47a6d refactor: remove breaking change in pin expiry 4 years ago
Julian Lam 046d0b1637
feat: allow pins to expire (if set) (#8908)
* fix: add back topic assert middleware for pin route

* feat: server-side handling of pin expiries

* refactor: togglePin to not require uid parameter [breaking]

* feat: automatic unpinning if pin has expiration set

* feat: client-side modal for setting pin expiration

* refactor: categories.getPinnedTids to accept multiple cids

... in preparation for pin expiry logic, direct access to *:pinned zsets is discouraged

* fix: remove references to since-removed jobs file for topics

* feat: expire pins when getPinnedTids is called

* refactor: make the togglePin change non-breaking

The 'action:topic.pin' hook now sends uid again, as before. However, if it is a system action (that is, a pin that expired), 'system' will be sent in instead of a valid uid
4 years ago
Barış Soner Uşaklı 1be08b2e8b fix: guest displayname 4 years ago
Barış Soner Uşaklı dbd814c25f fix: spec, only call modifyUser on unique user objects 4 years ago
Barış Soner Uşaklı 903e9d82b8 feat: #8637 4 years ago
Barış Soner Uşaklı ae5d4405c0 fix: setting 4 years ago
Barış Soner Uşaklı 9ca44e6f54
feat: add displayname into user obj #8637 (#8909)
* feat: add displayname into user obj #8637

* fix: spec

* perf: dont load settings if acp setting is turned off
4 years ago
Barış Soner Uşaklı 8d060065a0 fix: spec 4 years ago
Barış Soner Uşaklı e9585b9be2 fix: group userTitles translation escapes 4 years ago
Barış Soner Uşaklı 965671a97b fix: remove params from error log 4 years ago
Barış Soner Uşaklı fa4177c3bc fix: #6407, fix feeds
display latest posts instead of oldest in topic rss feed
fix missing await that was causing rss_tokens to not function
fix feed test
more tests for getTopicWithPosts
4 years ago
Barış Soner Uşaklı 4e9b10ab76 feat: #5274 4 years ago
Barış Soner Uşaklı fb567a7a33 feat: #4456 4 years ago
Barış Soner Uşaklı a6afcfd531 feat: #8475, allow flagging self posts
dont count flags towards self posts
dont allow flagging your own account
4 years ago
Barış Soner Uşaklı a87ccccc9c fix: benchpress warnings 4 years ago
Barış Soner Uşaklı dfdc0c420c fix: benchpress warnings 4 years ago
Julian Lam a0b7a82350
feat(api): account deletion routes for the Write API (#8881)
* feat(api): account deletion routes for the Write API

* refactor: rewrite client-side calls to account deletion to use api

* style: apply DRY
4 years ago
Barış Soner Uşaklı 120999bf63 feat: #7550, show message if post is queued when js is disabled 4 years ago
Barış Soner Uşaklı 35f932cd64 feat: #8171, add oldCategory if topic is moved 4 years ago
Barış Soner Uşaklı b44ddecdf8 feat: #8204, separate notification type for group chats 4 years ago
Barış Soner Uşaklı 1d6bcbebde feat: https://github.com/NodeBB/NodeBB/issues/8147 4 years ago
Julian Lam e1d7c4d8aa fix: internal helper method hasGlobalPrivilege, DRY 4 years ago
gasoved 3ccebf112e
feat: invites regardless of registration type, invite privilege, groups to join on acceptance (#8786)
* feat: allow invites in normal registration mode + invite privilege

* feat: select groups to join from an invite

* test: check if groups from invitations have been joined

* fix: remove unused variable

* feat: write API versions of socket calls

* docs: openapi specs for the new routes

* test: iron out mongo redis difference

* refactor: move inviteGroups endpoint into write API

* refactor: use GET /api/v3/users/:uid/invites/groups

Instead of GET /api/v3/users/:uid/inviteGroups

* fix: no need for /api/v3 prefix when using api module

* fix: tests

* refactor: change POST /api/v3/users/invite

To POST /api/v3/users/:uid/invites

* refactor: make helpers.invite awaitable

* fix: restrict invite API to self-use only

* fix: move invite groups controller to write api, +tests

* fix: tests

Co-authored-by: Julian Lam <julian@nodebb.org>
4 years ago
Peter Jaszkowiak d30ea25629
feat(deps): benchpressjs@2.2.1 (#8887)
Better warnings, faster template compiles
4 years ago
Tudor-Dan Ravoiu 452d7f2b17
Create verified/unverified user groups (#8889)
Co-authored-by: Tudor-Dan Ravoiu <tudor-dan.ravoiu@ubisoft.com>
4 years ago
Barış Soner Uşaklı e4d2764d4c fix: #8884, remove header/footer cache 4 years ago
Barış Soner Uşaklı 5598130a92 refactor: async/await controllers/index.js 4 years ago
Barış Soner Uşaklı f14e42d8bc fix: #8883 4 years ago
Barış Soner Uşaklı 8fbe832460 refactor: less dupe code 4 years ago
Julian Lam 8518404e22
feat: allow groups to specify which cids to show member posts from (#8875)
* feat: allow groups to specify which cids to show member posts from

* docs: fix tests for openapi

* fix: test breakage caused by improper conditional

* feat: server-side checking of memberPostCids for validity

* feat: admin panel template update to select categories to include

* refactor: privilege helpers.isUserAllowedTo

... to helpers.isAllowedTo, allowing group names to be passed in
4 years ago
Barış Soner Uşaklı 51b7eca119 fix: run every hour, dont show message if average_time is 0 4 years ago
Opliko 04f4429f72
Resolve #7514 - optional timer for registration queue (#8796)
* feat: #7514 Optional timer for registration queue

* feat: show minutes in average time

* fix: don't show total number of minutes

* feat: implement requested changes

* fix: just store minutes instead of milliseconds

* feat: set default values
4 years ago
Julian Lam bcccb331db docs: openapi schema for user/group exist check, session deletion 4 years ago
Julian Lam dc9668e417 fix: pass length to messaging checkContent hook 4 years ago
Barış Soner Uşaklı 567c5f2056 fix: #8869, dont escape category title,description twice 4 years ago
Julian Lam f300c933a5 refactor: move session revocation route to write api 4 years ago
Barış Soner Uşaklı 9c5c32d4a5 feat: #8864, add action:events.log 4 years ago
Barış Soner Uşaklı 62c0454cfe feat: show db info side by side 4 years ago
Barış Soner Uşaklı a0164b1c38 fix: use header/footer cache in prod 4 years ago
Barış Soner Uşaklı 05a92885f2 fix: add missing maxAge to cache 4 years ago
Barış Soner Uşaklı 2e44639210 fix: guest header/footer cache
allow clearing individual caches
4 years ago
Barış Soner Uşaklı f1f9b225b0
feat: #8824, cache refactor (#8851)
* feat: #8824, cache refactor

ability to disable caches
ability to download contents of cache
refactor cache modules to remove duplicated code

* fix: remove duplicate hit/miss tracking

check cacheEnabled in getUncachedKeys
4 years ago
Barış Soner Uşaklı 6255874e32 feat: move mkdirp to beforeBuild so it doesnt get called twice 4 years ago
Barış Soner Uşaklı 74951f5967 fix: #8846, possible fix 4 years ago
Barış Soner Uşaklı 0b30efba31 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Barış Soner Uşaklı 16d03975a0 fix: winston error message 4 years ago
Julian Lam d263192271 feat: group exists API call in write api 4 years ago
Julian Lam 1446cec77f feat: user exist route in write api 4 years ago
Julian Lam 6b196a207f fix: permanent redirect on user api redirect shorthand 4 years ago
Julian Lam f2bb42c076 fix: user exist route needs no authentication 4 years ago
Julian Lam 60e1e99b4f feat: new shorthand route /api/v3/users/bySlug/:userslug
closes #8844
4 years ago
Julian Lam 512f6de6de
feat: allow passwords with length > 73 characters (#8818)
* feat: allow passwords longer than 73 characters

Context: A bcrypt/blowfish limitation means that password length is capped at 72 characters. We can get around this without compromising on security
by hashing all incoming passwords with SHA512, and then sending that to bcrypt.

https://dropbox.tech/security/how-dropbox-securely-stores-your-passwords

* feat: add additional test for passwords > 73 chars

* fix: remove 'password-too-long' error message and all invocations

* test: added test to show that a super long password won't bring down NodeBB

* fix: remove debug log

* Revert "fix: remove 'password-too-long' error message and all invocations"

This reverts commit 1e312bf7ef7e119fa0f1bd3517d756ca013d5e79.

* fix: added back password length checks, but at 512 chars

As processing a large string still uses a lot of memory
4 years ago
Barış Soner Uşaklı c61dee4b62 fix: #8840, don't crash if /compose route is called with no query params 4 years ago
Barış Soner Uşaklı 9e3eb5d41a feat: #8821, allow guest topic views 4 years ago
Julian Lam f68bce86a9 fix: XSS in event:banned messaging modal 4 years ago
Barış Soner Uşaklı 76cd5b0fc1 fix: #8836, truncate fullname 4 years ago
psychobunny eec630f1ef fix(acp): max-height for plugin menu list 4 years ago
Julian Lam 891a1ea2af fix: #8827, do not require admin:users privilege to ban users 4 years ago
Barış Soner Uşaklı 4b63f9937c fix: check is banned in buildHeader
remove unused banReason
remove generateHeader function
4 years ago
Barış Soner Uşaklı a338f52780 feat: #8823, remove hardcoded write concern 4 years ago
Barış Soner Uşaklı 08ff4041aa fix: missing await 4 years ago
Julian Lam c0f699e655 fix: disallow registration attempts with password length > 4096
This is a stopgap measure for v1.15.0
4 years ago
Barış Soner Uşaklı 4818ec377e fix: missing await 4 years ago
Barış Soner Uşaklı 6e85920cb6 feat: allow mods/admins to see deleted posts on user profile 4 years ago
Julian Lam 87bff6cd65 fix: broken test 4 years ago
Julian Lam dda5d42610 fix: restore old behaviour of empty json w/ 401 code in admin middleware 4 years ago
Julian Lam 15e0731dd9 fix: deprecate middleware.isAdmin
Also, handle admin logout timer in middleware.admin.checkPrivileges
4 years ago
Julian Lam 4439864ce0 fix: post editing not taking plugin hook results into account 4 years ago
Barış Soner Uşaklı a02ae6f5df refactor: simpler check in user.blocks.filter 4 years ago
Barış Soner Uşaklı 27016d221c feat: rearrange buttons on manage/users 4 years ago
Julian Lam 57ed6be78b fix: #8805 define our own name for write API v3 4 years ago
Julian Lam 266d7587b2 refactor: remove usage of middlewares
Specifically, middleware.isAdmin|exposePrivilegeSet|exposePrivileges
4 years ago
Julian Lam a6a52430ce fix: remove setCategorySort and setTopicSort 4 years ago
Julian Lam aa8faf58a0 refactor: remove /users/{uid}/settings/{setting} route
@baris Also, I am now allowing the following properties to be saved in User.saveSettings:
- categoryTopicSort
- topicPostSort
- setCategorySort
- setTopicSort
4 years ago
Barış Soner Uşaklı 6ac73ccb7e feat: #8801, disable express compression by default 4 years ago
Julian Lam 3c98cd3d95 fix: topic object in post editing data return 4 years ago
Julian Lam 1392d064a1 fix(writeapi): normalizing data 4 years ago
Julian Lam ec03af7a38 feat: allow passing subset of user settings on update route 4 years ago
Julian Lam 618e098305 fix: bug where token generation route would fail on null case 4 years ago
Julian Lam b156b8b573 feat: wip, write api tests framework
re-using read api tests if possible
4 years ago
Barış Soner Uşaklı 2e9f27d8ff fix: typo 4 years ago
Barış Soner Uşaklı 93bdfe2f10 perf: reorder async calls 4 years ago
Barış Soner Uşaklı 88a07e69b5 feat: add filter:category.getFields 4 years ago
Barış Soner Uşaklı a05905f196
performance improvements (#8795)
* perf: nconf/winston/render

cache nconf.get calls
modify middleware.pageView to call next earlier
don't call winston.verbose on every hook see https://github.com/winstonjs/winston/issues/1669
translate header/footer separately and cache results for guests

* fix: copy paste fail

* refactor: style and fire hook only log in dev mode

* fix: cache key, header changes based on template

* perf: change replace

* fix: add missing await

* perf: category

* perf: lodash clone

* perf: remove escapeRegexChars
4 years ago
Barış Soner Uşaklı 0db0231cff feat: move postercount to topic hash 4 years ago
Barış Soner Uşaklı 203db47b30 fix: return early for guests/spiders 4 years ago
Barış Soner Uşaklı 156e1396f2 fix: #8789,cache meta.settings 4 years ago
Barış Soner Uşaklı a7b6d0dfe5 feat: add free and total mem usage to info 4 years ago
Julian Lam c26f2b6599 feat(writeapi): user settings API 4 years ago
Barış Soner Uşaklı db63f5e3f0 fix: #8781 4 years ago
Julian Lam 177a961000 feat: new filter filter:teasers.configureStripTags 4 years ago
Julian Lam d68ffea80d feat: send 'Vary' header when ACAO header set 4 years ago
Barış Soner Uşaklı 1f43e98f8b fix: allow admins adding users to global moderators
add new test
4 years ago
Barış Soner Uşaklı bbafa1b82a Revert "fix: [breaking] send configured config URL as origin if not custom"
This reverts commit 205a10308e.
4 years ago
Julian Lam a691be5952 fix: incorrect logic for post history editable bool 4 years ago
Julian Lam 205a10308e fix: [breaking] send configured config URL as origin if not custom
This is a breaking change if your install uses multiple URLs to access. You will need to update the Access-Control-Allow-Origin header in ACP > Advanced > Headers to supply all URLs you use to access your site
4 years ago
Barış Soner Uşaklı 7a019494e8 feat: add filter.topics.getPostReplies 4 years ago
Julian Lam 7a8f704900 fix: #8776 some users unable to restore old versions via history 4 years ago
Barış Soner Uşaklı b26e9b5993 fix: #8595, dont save escaped data when renaming groups 4 years ago
Barış Soner Uşaklı ea31f50554 refactor: show more lines of stack trace 4 years ago
Barış Soner Uşaklı 7bddec93ec fix: sortby 4 years ago
Barış Soner Uşaklı b3619d3d47
fix: #8774 4 years ago
Julian Lam ff4fcc23b6
Update bundled logos with new branding (#8702)
* feat: updating logo assets, square logos missing still

* fix: squared logo for touch icon and notification fallback

* fix: update link to favicon

* feat: add default touch icon sizes, if one isn't uploaded

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
4 years ago
Barış Soner Uşaklı e362c342a3 fix: #8630, sort extra deps 4 years ago
Barış Soner Uşaklı d9a16855d0 refactor: posts api 4 years ago
Barış Soner Uşaklı 272e73da53 refactor: post restore/delete/purge 4 years ago
Barış Soner Uşaklı 9738e20207 refactor: merge post.edit
fix: dont fadeout/fadeint if title/post didnt change
4 years ago
Barış Soner Uşaklı 2279e37261 refactor: deprecate socket.emit('users.search') use api route 4 years ago
Barış Soner Uşaklı 083c74e059 refactor: api categories 4 years ago
Barış Soner Uşaklı e78c498e84 fix: missing doTopicAction, fix wrong api params 4 years ago
Barış Soner Uşaklı bc880ee0ca refactor: remove sockets.reqFromSocket 4 years ago
Barış Soner Uşaklı 9d81660e24 Revert "Revert "fix: appropriate 404 handling for write API calls""
This reverts commit 135c2d6c7d.
4 years ago
Barış Soner Uşaklı 135c2d6c7d Revert "fix: appropriate 404 handling for write API calls"
This reverts commit b6cce75d97.
4 years ago
Julian Lam 9ee3cb9b62 refactor: topic follow/ignore to use api lib 4 years ago
Julian Lam 68d6818bca refactor: topic tools' actions to use api lib 4 years ago
Julian Lam 21974a77f8 feat: topic reply to use api lib (also + missing file) 4 years ago
Julian Lam 40598b368e refactor: topic creation to use api lib 4 years ago
Julian Lam b6cce75d97 fix: appropriate 404 handling for write API calls 4 years ago
Julian Lam ede9435f0e feat: send 401 for invalid-uid 4 years ago
Barış Soner Uşaklı c913900ed6 feat: async/await admin/search 4 years ago
Barış Soner Uşaklı bf480ee58b refactor: setupApiRoute signature 4 years ago
Barış Soner Uşaklı 688d7a2cc2 refactor: remove unused middleware 4 years ago
Barış Soner Uşaklı b2ff1594b8 fix: redis hget
'node_redis: The HGET command contains a invalid argument type.\n' +
'Only strings, dates and buffers are accepted. Please update your code to use valid argument types.'
4 years ago
Julian Lam e98285dbbb fix: reimplementing isPrivilegedOrSelfAndPasswordMatch 4 years ago
Barış Soner Uşaklı 84a179f48c Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Julian Lam 3f347baadb fix: socket user bans 4 years ago
Julian Lam 14f9d8b0e5 feat: send back 403 on no-privileges error 4 years ago
Julian Lam 222b4c9533 fix: broken tests from api change 4 years ago
Julian Lam 2d252f2fa4 refactor: user bans to use api lib 4 years ago
Barış Soner Uşaklı 7d86be2bc2 fix: tests 4 years ago
Barış Soner Uşaklı e367c5403e refactor: move groups.leave, fix some tests 4 years ago
Barış Soner Uşaklı bbbd9fee85 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Julian Lam 960e925e40 refactor: change password/user follow to use api lib 4 years ago
Barış Soner Uşaklı 081c4fa6d4 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Julian Lam 430e7f5834 refactor: user deletion to use api lib 4 years ago
Barış Soner Uşaklı 8ae1f81cf4 feat: refactor groups.delete 4 years ago
Julian Lam 77481947f0 refactor: socket profile update to use api lib 4 years ago
Julian Lam 31ae8a8323 refactor: socket profile update to use api lib 4 years ago
Barış Soner Uşaklı d69e503d21 feat: move groups.join to api 4 years ago
Julian Lam d07f0081b7 fix: add missing file 4 years ago
Julian Lam 23086daead refactor: user create and profile update to use api lib 4 years ago
Barış Soner Uşaklı 5e2caf19f5 refactor: use single function for api code 4 years ago
Barış Soner Uşaklı 25e4a09816 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Barış Soner Uşaklı 4418ff0716 fix: #8768 4 years ago
Julian Lam cc6e995ee2 fix: api bug where user profile editing continued even if not allowed 4 years ago
Barış Soner Uşaklı 43afe7ffab refactor: async/await src/user/approval 4 years ago
Barış Soner Uşaklı bae0f343e1 fix: module build 4 years ago
Barış Soner Uşaklı 1fd2eba6f2 refactor: async/await
src/cli/manage.js
src/meta/build.js
src/meta/css.js
src/meta/js.js
4 years ago
Barış Soner Uşaklı b295d15eae fix: tests 4 years ago
Barış Soner Uşaklı d89477cad0 refactor: use app.render 4 years ago
Julian Lam 9dd3cc0483 feat: allow plugins to define api routes
via new plugin hook static:api.routes
4 years ago
Julian Lam a4ba23899e feat: require https if nodebb is configured with https url 4 years ago
Barış Soner Uşaklı e6ea71c95a fix: test 4 years ago
Barış Soner Uşaklı 8c6a559188 fix: timestamp 4 years ago
Barış Soner Uşaklı 331d236f6e fix: #8763 4 years ago
Barış Soner Uşaklı a481024d27 fix: lastonline again 4 years ago
Barış Soner Uşaklı 71d82ec8e0 fix: caret 4 years ago
Barış Soner Uşaklı 97628e2ff2 fix: lastonline values 4 years ago
Barış Soner Uşaklı 1289c10568 fix: upgrade script 4 years ago
Barış Soner Uşaklı 59bbede8c7 fix: cant join system groups 4 years ago
Barış Soner Uşaklı a411df1321 fix: tests 4 years ago
Barış Soner Uşaklı dd7424e5b5 refactor: remove unused search call 4 years ago
Barış Soner Uşaklı 2d6ea6e505 Merge branch 'master' into admin/users 4 years ago
Barış Soner Uşaklı a2edb86dfb feat: change user search to use filters array 4 years ago
Barış Soner Uşaklı 959314c921 feat: add filter 4 years ago
Julian Lam 1e07886f30 feat: require csrf token if not using bearer token 4 years ago
Barış Soner Uşaklı 933989e013 Merge branch 'master' into admin/users 4 years ago
Barış Soner Uşaklı 682e926c6b feat: #8662, verified/unverified user groups 4 years ago
Julian Lam 30b3fedca4 fix: password reset to invalidate all existing reset tokens for that uid 4 years ago
Barış Soner Uşaklı 700e1e4340 feat: more fixes 4 years ago
Barış Soner Uşaklı 40a05b70ef feat: more work 4 years ago
Barış Soner Uşaklı b038ac07d8 feat: wip admin/users 4 years ago
Barış Soner Uşaklı 7beaf49028 feat: set unread false for guests 4 years ago
Barış Soner Uşaklı 30d6a2b84e fix: #8756, pass missing req to mock 4 years ago
Barış Soner Uşaklı 1ee9384875 fix: #8757, allow all slashes in category route 4 years ago
Barış Soner Uşaklı dc29f4dca2 refactor: switch to using slugify module 4 years ago