fix redis tests

v1.18.x
Barış Soner Uşaklı 8 years ago
parent fd0043f36a
commit fe0a5aaf28

@ -3,6 +3,9 @@
module.exports = function (redisClient, module) { module.exports = function (redisClient, module) {
module.listPrepend = function (key, value, callback) { module.listPrepend = function (key, value, callback) {
callback = callback || function () {}; callback = callback || function () {};
if (!key) {
return callback();
}
redisClient.lpush(key, value, function (err) { redisClient.lpush(key, value, function (err) {
callback(err); callback(err);
}); });
@ -10,6 +13,9 @@ module.exports = function (redisClient, module) {
module.listAppend = function (key, value, callback) { module.listAppend = function (key, value, callback) {
callback = callback || function () {}; callback = callback || function () {};
if (!key) {
return callback();
}
redisClient.rpush(key, value, function (err) { redisClient.rpush(key, value, function (err) {
callback(err); callback(err);
}); });
@ -17,11 +23,17 @@ module.exports = function (redisClient, module) {
module.listRemoveLast = function (key, callback) { module.listRemoveLast = function (key, callback) {
callback = callback || function () {}; callback = callback || function () {};
if (!key) {
return callback();
}
redisClient.rpop(key, callback); redisClient.rpop(key, callback);
}; };
module.listRemoveAll = function (key, value, callback) { module.listRemoveAll = function (key, value, callback) {
callback = callback || function () {}; callback = callback || function () {};
if (!key) {
return callback();
}
redisClient.lrem(key, 0, value, function (err) { redisClient.lrem(key, 0, value, function (err) {
callback(err); callback(err);
}); });
@ -29,6 +41,9 @@ module.exports = function (redisClient, module) {
module.listTrim = function (key, start, stop, callback) { module.listTrim = function (key, start, stop, callback) {
callback = callback || function () {}; callback = callback || function () {};
if (!key) {
return callback();
}
redisClient.ltrim(key, start, stop, function (err) { redisClient.ltrim(key, start, stop, function (err) {
callback(err); callback(err);
}); });
@ -36,6 +51,9 @@ module.exports = function (redisClient, module) {
module.getListRange = function (key, start, stop, callback) { module.getListRange = function (key, start, stop, callback) {
callback = callback || function () {}; callback = callback || function () {};
if (!key) {
return callback();
}
redisClient.lrange(key, start, stop, callback); redisClient.lrange(key, start, stop, callback);
}; };
}; };

@ -98,7 +98,7 @@ describe('List methods', function () {
}); });
}); });
it('should not get anyhing if key is falsy', function (done) { it('should not get anything if key is falsy', function (done) {
db.getListRange(null, 0, -1, function (err, data) { db.getListRange(null, 0, -1, function (err, data) {
assert.ifError(err); assert.ifError(err);
assert.equal(data, undefined); assert.equal(data, undefined);

Loading…
Cancel
Save