fix: change how admin middlewares are exported

src/middleware/admin.js

@@ -18,16 +18,13 @@ var controllers = {
 	helpers: require('../controllers/helpers'),
 };
 
-module.exports = function (middleware) {
+module.exports.buildHeader = helpers.try(async function (req, res, next) {
-	middleware.admin = {};
-
-	middleware.admin.buildHeader = helpers.try(async function (req, res, next) {
 	res.locals.renderAdminHeader = true;
 	res.locals.config = await controllers.api.loadConfig(req);
 	next();
-	});
+});
 
-	middleware.admin.renderHeader = async (req, res, data) => {
+module.exports.renderHeader = async (req, res, data) => {
 	var custom_header = {
 		plugins: [],
 		authentication: [],
@@ -80,16 +77,16 @@ module.exports = function (middleware) {
 	templateValues.template[res.locals.template] = true;
 
 	return await req.app.renderAsync('admin/header', templateValues);
-	};
+};
 
-	async function getAdminScripts() {
+async function getAdminScripts() {
 	const scripts = await plugins.fireHook('filter:admin.scripts.get', []);
 	return scripts.map(function (script) {
 		return { src: script };
 	});
-	}
+}
 
-	async function getLatestVersion() {
+async function getLatestVersion() {
 	try {
 		const result = await versions.getLatestVersion();
 		return result;
@@ -97,13 +94,13 @@ module.exports = function (middleware) {
 		winston.error('[acp] Failed to fetch latest version' + err.stack);
 	}
 	return null;
-	}
+}
 
-	middleware.admin.renderFooter = async function (req, res, data) {
+module.exports.renderFooter = async function (req, res, data) {
 	return await req.app.renderAsync('admin/footer', data);
-	};
+};
 
-	middleware.admin.checkPrivileges = async (req, res, next) => {
+module.exports.checkPrivileges = async (req, res, next) => {
 	// Kick out guests, obviously
 	if (!req.uid) {
 		return controllers.helpers.notAllowed(req, res);
@@ -131,5 +128,4 @@ module.exports = function (middleware) {
 	}
 
 	next();
-	};
 };

src/middleware/index.js

@@ -51,7 +51,7 @@ middleware.applyCSRF = function (req, res, next) {
 
 middleware.ensureLoggedIn = ensureLoggedIn.ensureLoggedIn(nconf.get('relative_path') + '/login');
 
-require('./admin')(middleware);
+middleware.admin = require('./admin');
 require('./header')(middleware);
 require('./render')(middleware);
 require('./maintenance')(middleware);