feat: convert middleware.isAdmin to async/await

src/middleware/user.js

@@ -198,35 +198,32 @@ module.exports = function (middleware) {
 		], next);
 	};
 
-	middleware.isAdmin = function isAdmin(req, res, next) {
-		async.waterfall([
-			function (next) {
-				user.isAdministrator(req.uid, next);
-			},
-			function (isAdmin, next) {
+	middleware.isAdmin = async function isAdmin(req, res, next) {
+		const isAdmin = await user.isAdministrator(req.uid);
 		if (!isAdmin) {
-					return controllers.helpers.notAllowed(req, res);
+			controllers.helpers.notAllowed(req, res);
+			return;
 		}
-				user.hasPassword(req.uid, next);
-			},
-			function (hasPassword, next) {
+		const hasPassword = await user.hasPassword(req.uid);
 		if (!hasPassword) {
-					return next();
+			next();
+			return;
 		}
 
-				var loginTime = req.session.meta ? req.session.meta.datetime : 0;
-				var adminReloginDuration = meta.config.adminReloginDuration * 60000;
-				var disabled = meta.config.adminReloginDuration === 0;
+		const loginTime = req.session.meta ? req.session.meta.datetime : 0;
+		const adminReloginDuration = meta.config.adminReloginDuration * 60000;
+		const disabled = meta.config.adminReloginDuration === 0;
 		if (disabled || (loginTime && parseInt(loginTime, 10) > Date.now() - adminReloginDuration)) {
-					var timeLeft = parseInt(loginTime, 10) - (Date.now() - adminReloginDuration);
+			const timeLeft = parseInt(loginTime, 10) - (Date.now() - adminReloginDuration);
 			if (req.session.meta && timeLeft < Math.min(300000, adminReloginDuration)) {
 				req.session.meta.datetime += Math.min(300000, adminReloginDuration);
 			}
 
-					return next();
+			next();
+			return;
 		}
 
-				var returnTo = req.path;
+		let returnTo = req.path;
 		if (nconf.get('relative_path')) {
 			returnTo = req.path.replace(new RegExp('^' + nconf.get('relative_path')), '');
 		}
@@ -239,8 +236,6 @@ module.exports = function (middleware) {
 		} else {
 			res.redirect(nconf.get('relative_path') + '/login?local=1');
 		}
-			},
-		], next);
 	};
 
 	middleware.requireUser = function (req, res, next) {