getMultipleUserFields returns err now

src/categories.js

@@ -57,8 +57,8 @@ var	RDB = require('./redis.js'),
 				}
 
 				function getActiveUsers(next) {
-					user.getMultipleUserFields(active_users, ['username', 'userslug', 'picture'], function(users) {
+					user.getMultipleUserFields(active_users, ['username', 'userslug', 'picture'], function(err, users) {
-						next(null, users);
+						next(err, users);
 					});
 				}
 
@@ -112,8 +112,8 @@ var	RDB = require('./redis.js'),
 		RDB.smembers('cid:' + cid + ':moderators', function(err, mods) {
 			if(!err) {
 				if(mods && mods.length) {
-					user.getMultipleUserFields(mods, ['username'], function(moderators) {
+					user.getMultipleUserFields(mods, ['username'], function(err, moderators) {
-						callback(null, moderators);
+						callback(err, moderators);
 					});
 				} else {
 					callback(null, []);

src/user.js

@@ -150,8 +150,7 @@ var utils = require('./../public/src/utils.js'),
 
 	User.getMultipleUserFields = function(uids, fields, callback) {
 		if(uids.length === 0) {
-			callback([]);
+			return callback(null, []);
-			return;
 		}
 
 		var returnData = [];
@@ -160,22 +159,17 @@ var utils = require('./../public/src/utils.js'),
 			return self.indexOf(value) === index;
 		});
 
-		function iterator(uid, callback) {
+		function iterator(uid, next) {
 			User.getUserFields(uid, fields, function(err, userData) {
 				if(err)
-					return callback(err);
+					return next(err);
 				returnData.push(userData);
-				callback(null);
+				next(null);
 			});
 		}
 
 		async.eachSeries(uuids, iterator, function(err) {
-			if(!err) {
+			callback(err, returnData);
-				callback(returnData);
-			} else {
-				console.log(err);
-				callback(null);
-			}
 		});
 	}
 
@@ -600,7 +594,7 @@ var utils = require('./../public/src/utils.js'),
 				topics.getTopicField(tid, 'slug', function(err, slug) {
 					var message = '<strong>' + username + '</strong> made a new post';
 
-					notifications.create(message, 5, nconf.get('url') + 'topic/' + slug + '#' + pid, 'notification_'+ Date.now(), function(nid) {
+					notifications.create(message, 5, nconf.get('relative_path') + '/topic/' + slug + '#' + pid, 'notification_'+ Date.now(), function(nid) {
 		 				notifications.push(nid, followers);
 					});
 				});

src/websockets.js

@@ -144,8 +144,9 @@ var SocketIO = require('socket.io').listen(global.server, {
 			if (uids.length === 0) {
 				io.sockets.in(roomName).emit('api:get_users_in_room', userList([], anonymousCount, 0));
 			} else {
-				user.getMultipleUserFields(uids, ['username', 'userslug'], function(users) {
+				user.getMultipleUserFields(uids, ['username', 'userslug'], function(err, users) {
-					io.sockets.in(roomName).emit('api:get_users_in_room', userList(users, anonymousCount, users.length));
+					if(!err)
+						io.sockets.in(roomName).emit('api:get_users_in_room', userList(users, anonymousCount, users.length));
 				});
 			}
 		}