moving onlineUsers from an in-memory variable to a sorted set

loader.js

@@ -133,8 +133,8 @@ Loader.addClusterEvents = function(callback) {
 							Loader.primaryWorker = parseInt(worker.id, 10);
 						}
 					break;
-					case 'user:connect':
+					// case 'user:connect':
-					case 'user:disconnect':
+					// case 'user:disconnect':
 					case 'config:update':
 						Loader.notifyWorkers(message);
 					break;

src/socket.io/index.js

@@ -26,43 +26,68 @@ var	io;
 
 var onlineUsers = [];
 
-process.on('message', onMessage);
+// process.on('message', onMessage);
+
+// function onMessage(msg) {
+// 	if (typeof msg !== 'object') {
+// 		return;
+// 	}
+
+// 	if (msg.action === 'user:connect') {
+// 		if (msg.uid && onlineUsers.indexOf(msg.uid) === -1) {
+// 			onlineUsers.push(msg.uid);
+// 		}
+// 	} else if(msg.action === 'user:disconnect') {
+// 		if (msg.uid && msg.socketCount <= 1) {
+// 			var index = onlineUsers.indexOf(msg.uid);
+// 			if (index !== -1) {
+// 				onlineUsers.splice(index, 1);
+// 			}
+// 		}
+// 	}
+// }
 
-function onMessage(msg) {
+function onUserConnect(uid, socketid) {
-	if (typeof msg !== 'object') {
+	db.sortedSetIncrBy('onlineUsers', 1, uid, function(err, score) {
-		return;
+		if (err) {
-	}
+			 return winston.error('[socket.io] Could not add socket id ' + socketid + ' (uid ' + uid + ') to the online users list.');
-
-	if (msg.action === 'user:connect') {
-		if (msg.uid && onlineUsers.indexOf(msg.uid) === -1) {
-			onlineUsers.push(msg.uid);
-		}
-	} else if(msg.action === 'user:disconnect') {
-		if (msg.uid && msg.socketCount <= 1) {
-			var index = onlineUsers.indexOf(msg.uid);
-			if (index !== -1) {
-				onlineUsers.splice(index, 1);
-			}
 		}
-	}
-}
 
-function onUserConnect(uid, socketid) {
+		winston.verbose('[socket.io] Socket id ' + socketid + ' (uid ' + uid + ') connect');
-	var msg = {action: 'user:connect', uid: uid, socketid: socketid};
+	});
-	if (process.send) {
+	// var msg = {action: 'user:connect', uid: uid, socketid: socketid};
-		process.send(msg);
+	// if (process.send) {
-	} else {
+	// 	process.send(msg);
-		onMessage(msg);
+	// } else {
-	}
+	// 	onMessage(msg);
+	// }
 }
 
 function onUserDisconnect(uid, socketid, socketCount) {
-	var msg = {action: 'user:disconnect', uid: uid, socketid: socketid, socketCount: socketCount};
+	// baris, I no longer use socketCount here, since the zset score is the # of connections, just FYI.
-	if (process.send) {
+	db.sortedSetIncrBy('onlineUsers', -1, uid, function(err, score) {
-		process.send(msg);
+		if (err) {
-	} else {
+			 return winston.error('[socket.io] Could not remove socket id ' + socketid + ' (uid ' + uid + ') from the online users list.');
-		onMessage(msg);
+		}
-	}
+
+		if (parseInt(score, 10) === 0) {
+			db.sortedSetRemove('onlineUsers', uid, function(err) {
+				if (err) {
+					winston.error('[socket.io] Could not remove uid ' + uid + ' from the online users list')
+				} else {
+					winston.verbose('[socket.io] Removed uid ' + uid + ' from the online users list, user is now considered offline');
+				}
+			});
+		}
+
+		winston.verbose('[socket.io] Socket id ' + socketid + ' (uid ' + uid + ') disconnect');
+	});
+	// var msg = {action: 'user:disconnect', uid: uid, socketid: socketid, socketCount: socketCount};
+	// if (process.send) {
+	// 	process.send(msg);
+	// } else {
+	// 	onMessage(msg);
+	// }
 }
 
 Sockets.init = function(server) {
@@ -112,6 +137,9 @@ Sockets.init = function(server) {
 		});
 	});
 
+	// Clearing the online users sorted set
+	db.delete('onlineUsers');
+
 	io.sockets.on('connection', function(socket) {
 		var hs = socket.handshake,
 			sessionID, uid;