hiding group admin and cover photo controls from non-owners, #2588

public/src/client/groups/details.js

@@ -10,8 +10,10 @@ define('forum/groups/details', ['iconSelect', 'vendor/colorpicker/colorpicker',
 		var detailsPage = $('.groups'),
 			settingsFormEl = detailsPage.find('form');
 
+		if (ajaxify.variables.get('is_owner') === 'true') {
 			Details.prepareSettings();
 			Details.initialiseCover();
+		}
 
 		$('.latest-posts .content img').addClass('img-responsive');
 
@@ -73,7 +75,6 @@ define('forum/groups/details', ['iconSelect', 'vendor/colorpicker/colorpicker',
 			previewIcon = previewEl.find('i'),
 			previewValueEl = settingsFormEl.find('[name="icon"]');
 
-		if (settingsFormEl.length) {
 		// Add color picker to settings form
 		colorBtn.ColorPicker({
 			color: colorValueEl.val() || '#000',
@@ -92,7 +93,6 @@ define('forum/groups/details', ['iconSelect', 'vendor/colorpicker/colorpicker',
 				previewValueEl.val(previewIcon.val());
 			});
 		});
-		}
 	};
 
 	Details.update = function() {
@@ -165,6 +165,7 @@ define('forum/groups/details', ['iconSelect', 'vendor/colorpicker/colorpicker',
 		});
 
 		coverEl.find('.save').on('click', Details.cover.save);
+		coverEl.addClass('initialised')
 	};
 
 	// Cover Photo Handling Code