closes #747

public/src/forum/admin/users.js

@@ -187,18 +187,13 @@ define(function() {
 					var username = $('#search-user').val();
 
 					jQuery('.fa-spinner').removeClass('none');
-					socket.emit('api:admin.user.search', username);
 
-				}, 250);
-			});
-
-			initUsers();
-
-			handleUserCreate();
-
-			socket.removeAllListeners('api:admin.user.search');
+					socket.emit('api:admin.user.search', username, function(err, data) {
+						console.log(data);
+						if(err) {
+							return app.alertError(err.message);
+						}
 
-			socket.on('api:admin.user.search', function(data) {
 						var html = templates.prepare(templates['admin/users'].blocks['users']).parse({
 							users: data
 						}),
@@ -221,6 +216,12 @@ define(function() {
 
 						initUsers();
 					});
+				}, 250);
+			});
+
+			initUsers();
+
+			handleUserCreate();
 
 			function onUsersLoaded(users) {
 				var html = templates.prepare(templates['admin/users'].blocks['users']).parse({

public/src/forum/users.js

@@ -47,16 +47,13 @@ define(function() {
 				jQuery('#user-notfound-notify').html('<i class="fa fa-spinner fa-spin"></i>');
 
 				setTimeout(function() {
-					socket.emit('api:admin.user.search', username);
-				}, 500); //replace this with global throttling function/constant
-
-			}, 250);
-		});
-
-		socket.removeAllListeners('api:admin.user.search');
+					socket.emit('api:admin.user.search', username, function(err, data) {
+						console.log(err, data);
+						if(err) {
+							return app.alert(err.message);
+						}
 
-		socket.on('api:admin.user.search', function(data) {
-			if (data === null) {
+						if (!data) {
 							$('#user-notfound-notify').html('You need to be logged in to search!');
 							$('#user-notfound-notify').parent().addClass('btn-warning label-warning');
 							return;
@@ -79,6 +76,10 @@ define(function() {
 						}
 
 					});
+				}, 500); //replace this with global throttling function/constant
+
+			}, 250);
+		});
 
 		socket.on('api:user.isOnline', function(data) {
 			if(getActiveSection() == 'online' && !loadingMoreUsers) {

src/user.js

@@ -487,9 +487,9 @@ var bcrypt = require('bcrypt'),
 
 	User.search = function(username, callback) {
 		if (!username) {
-			callback([]);
-			return;
+			return callback([]);
 		}
+
 		db.search('user', username, function(err, uids) {
 			if (err) {
 				console.log(err);

src/websockets.js

@@ -1056,15 +1056,30 @@ websockets.init = function(io) {
 		});
 
 		socket.on('api:admin.user.search', function(username, callback) {
-			if (uid && uid > 0) {
+			if (!(uid && uid > 0)) {
+				return callback();
+			}
+
 			user.search(username, function(data) {
-					if (!callback) socket.emit('api:admin.user.search', data);
-					else callback(null, data);
+				function isAdmin(userData, next) {
+					user.isAdministrator(userData.uid, function(err, isAdmin) {
+						if(err) {
+							return next(err);
+						}
+
+						userData.administrator = isAdmin?'1':'0';
+						next();
 					});
-			} else {
-				if (!callback) socket.emit('api:admin.user.search', null);
-				else callback();
 				}
+
+				async.each(data, isAdmin, function(err) {
+					if(err) {
+						return callback({message: err.message});
+					}
+
+					callback(null, data);
+				});
+			});
 		});
 
 		socket.on('api:admin.categories.search', function(username, cid, callback) {