fixed #589

public/src/forum/accountsettings.js

@@ -10,8 +10,8 @@ define(['forum/accountheader'], function(header) {
 				showemail: $('#showemailCheckBox').is(':checked') ? 1 : 0
 			};
 
-			socket.emit('api:user.saveSettings', settings, function(success) {
+			socket.emit('api:user.saveSettings', settings, function(err) {
-				if (success) {
+				if (!err) {
 					app.alertSuccess('Settings saved!');
 				} else {
 					app.alertError('There was an error saving settings!');

src/websockets.js

@@ -340,8 +340,9 @@ module.exports.init = function(io) {
 			if (uid) {
 				user.setUserFields(uid, {
 					showemail: data.showemail
+				}, function(err) {
+					callback(err ? err.message : null);
 				});
-				callback(true);
 			}
 		});