rewrite upgrade script so it doesnt error on alot of users

https://community.nodebb.org/post/95433

src/upgrades/3.3.0/chat_room_refactor.js

@@ -1,8 +1,6 @@
 'use strict';
 
 
-const _ = require('lodash');
-
 const db = require('../../database');
 const batch = require('../../batch');
 
@@ -18,46 +16,69 @@ module.exports = {
 		for (let i = 1; i <= nextChatRoomId; i++) {
 			allRoomIds.push(i);
 		}
-		progress.total = allRoomIds.length;
+		progress.total = 0;
+
+		// calculate user count and set progress.total
 		await batch.processArray(allRoomIds, async (roomIds) => {
-			progress.incr(roomIds.length);
+			await Promise.all(roomIds.map(async (roomId) => {
-			const [arrayOfUids, arrayOfRoomData] = await Promise.all([
+				const userCount = await db.sortedSetCard(`chat:room:${roomId}:uids`);
-				db.getSortedSetsMembers(roomIds.map(roomId => `chat:room:${roomId}:uids`)),
+				await db.setObjectField(`chat:room:${roomId}`, 'userCount', userCount);
-				db.getObjects(roomIds.map(roomId => `chat:room:${roomId}`)),
+				progress.total += userCount;
-			]);
+			}));
+		}, {
+			batch: 500,
+		});
+
+		await batch.processArray(allRoomIds, async (roomIds) => {
+			const arrayOfRoomData = await db.getObjects(roomIds.map(roomId => `chat:room:${roomId}`));
 
 			await Promise.all(roomIds.map(async (roomId, index) => {
-				const uids = arrayOfUids[index];
 				const roomData = arrayOfRoomData[index];
-				if (!uids.length && !roomData) {
+				if (!roomData) {
 					return;
 				}
-				if (roomData && roomData.owner && !uids.includes(String(roomData.owner))) {
+
-					uids.push(roomData.owner);
+				const midsSeen = Object.create(null);
-				}
+				await batch.processSortedSet(`chat:room:${roomId}:uids`, async (uids) => {
-				const userKeys = uids.map(uid => `uid:${uid}:chat:room:${roomId}:mids`);
+					for (const uid of uids) {
-				const mids = await db.getSortedSetsMembers(userKeys);
+						// eslint-disable-next-line no-await-in-loop
-				const uniqMids = _.uniq(_.flatten(mids));
+						await batch.processSortedSet(`uid:${uid}:chat:room:${roomId}:mids`, async (mids) => {
-				let messageData = await db.getObjects(uniqMids.map(mid => `message:${mid}`));
+							const uniqMids = mids.filter(mid => !midsSeen.hasOwnProperty(mid));
-				messageData.forEach((m, idx) => {
+							if (!uniqMids.length) {
-					if (m) {
+								return;
-						m.mid = parseInt(uniqMids[idx], 10);
+							}
+
+							let messageData = await db.getObjects(uniqMids.map(mid => `message:${mid}`));
+							messageData.forEach((m, idx) => {
+								if (m) {
+									m.mid = parseInt(uniqMids[idx], 10);
+								}
+							});
+							messageData = messageData.filter(Boolean);
+
+							const bulkSet = messageData.map(
+								msg => [`message:${msg.mid}`, { roomId: roomId }]
+							);
+
+							await db.setObjectBulk(bulkSet);
+							await db.sortedSetAdd(
+								`chat:room:${roomId}:mids`,
+								messageData.map(m => m.timestamp),
+								messageData.map(m => m.mid),
+							);
+							uniqMids.forEach((mid) => {
+								midsSeen[mid] = 1;
+							});
+						}, {
+							batch: 500,
+						});
+						// eslint-disable-next-line no-await-in-loop
+						await db.deleteAll(`uid:${uid}:chat:room:${roomId}:mids`);
 					}
+					progress.incr(uids.length);
+				}, {
+					batch: 500,
 				});
-				messageData = messageData.filter(Boolean);
-
-				const bulkSet = messageData.map(
-					msg => [`message:${msg.mid}`, { roomId: roomId }]
-				);
-
-				await db.setObjectBulk(bulkSet);
-				await db.setObjectField(`chat:room:${roomId}`, 'userCount', uids.length);
-				await db.sortedSetAdd(
-					`chat:room:${roomId}:mids`,
-					messageData.map(m => m.timestamp),
-					messageData.map(m => m.mid),
-				);
-				await db.deleteAll(userKeys);
 			}));
 		}, {
 			batch: 500,