hyperzlib
/
nodebb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: controllers/category.js

Browse Source
v1.18.x
Baris Usakli 6 years ago
parent 8c1ecdc13c
commit bd8736db38
1 changed files with 107 additions and 152 deletions
Show Stats Download Patch File Download Diff File

259
src/controllers/category.js
Unescape Escape View File

@ -1,178 +1,133 @@
'use strict'; 'use strict';
var async = require('async'); const nconf = require('nconf');
var nconf = require('nconf');
const db = require('../database');
var db = require('../database'); const privileges = require('../privileges');
var privileges = require('../privileges'); const user = require('../user');
var user = require('../user'); const categories = require('../categories');
var categories = require('../categories'); const meta = require('../meta');
var meta = require('../meta'); const pagination = require('../pagination');
var pagination = require('../pagination'); const helpers = require('./helpers');
var helpers = require('./helpers'); const utils = require('../utils');
var utils = require('../utils'); const translator = require('../translator');
var translator = require('../translator'); const analytics = require('../analytics');
var analytics = require('../analytics');
const categoryController = module.exports;
var categoryController = module.exports;
categoryController.get = async function (req, res, next) {
categoryController.get = function (req, res, callback) { const cid = req.params.category_id;
var cid = req.params.category_id;
var currentPage = parseInt(req.query.page, 10) || 1;
var pageCount = 1;
var userPrivileges;
var settings;
var rssToken;
if ((req.params.topic_index && !utils.isNumber(req.params.topic_index)) || !utils.isNumber(cid)) { if ((req.params.topic_index && !utils.isNumber(req.params.topic_index)) || !utils.isNumber(cid)) {
return callback(); return next();
} }
var topicIndex = utils.isNumber(req.params.topic_index) ? parseInt(req.params.topic_index, 10) - 1 : 0; const [categoryFields, userPrivileges, userSettings, rssToken] = await Promise.all([
categories.getCategoryFields(cid, ['slug', 'disabled', 'topic_count']),
async.waterfall([ privileges.categories.get(cid, req.uid),
function (next) { user.getSettings(req.uid),
async.parallel({ user.auth.getFeedToken(req.uid),
categoryData: function (next) { ]);
categories.getCategoryFields(cid, ['slug', 'disabled', 'topic_count'], next);
},
privileges: function (next) {
privileges.categories.get(cid, req.uid, next);
},
userSettings: function (next) {
user.getSettings(req.uid, next);
},
rssToken: function (next) {
user.auth.getFeedToken(req.uid, next);
},
}, next);
},
function (results, next) {
userPrivileges = results.privileges;
rssToken = results.rssToken;
if (!results.categoryData.slug || (results.categoryData && results.categoryData.disabled)) { if (!categoryFields.slug || (categoryFields && categoryFields.disabled)) {
return callback(); return next();
} }
if (!results.privileges.read) { if (!userPrivileges.read) {
return helpers.notAllowed(req, res); return helpers.notAllowed(req, res);
} }
if (!res.locals.isAPI && (!req.params.slug || results.categoryData.slug !== cid + '/' + req.params.slug) && (results.categoryData.slug && results.categoryData.slug !== cid + '/')) { if (!res.locals.isAPI && (!req.params.slug || categoryFields.slug !== cid + '/' + req.params.slug) && (categoryFields.slug && categoryFields.slug !== cid + '/')) {
return helpers.redirect(res, '/category/' + results.categoryData.slug); return helpers.redirect(res, '/category/' + categoryFields.slug);
} }
settings = results.userSettings; const topicCount = categoryFields.topic_count;
let topicIndex = utils.isNumber(req.params.topic_index) ? parseInt(req.params.topic_index, 10) - 1 : 0;
if (topicIndex < 0 || topicIndex > Math.max(topicCount - 1, 0)) {
return helpers.redirect(res, '/category/' + cid + '/' + req.params.slug + (topicIndex > topicCount ? '/' + topicCount : ''));
}
const pageCount = Math.max(1, Math.ceil(topicCount / userSettings.topicsPerPage));
let currentPage = parseInt(req.query.page, 10) || 1;
if (userSettings.usePagination && (currentPage < 1 || currentPage > pageCount)) {
return next();
}
var topicCount = results.categoryData.topic_count; if (!userSettings.usePagination) {
pageCount = Math.max(1, Math.ceil(topicCount / settings.topicsPerPage)); topicIndex = Math.max(0, topicIndex - (Math.ceil(userSettings.topicsPerPage / 2) - 1));
} else if (!req.query.page) {
const index = Math.max(parseInt((topicIndex || 0), 10), 0);
currentPage = Math.ceil((index + 1) / userSettings.topicsPerPage);
topicIndex = 0;
}
if (topicIndex < 0 || topicIndex > Math.max(topicCount - 1, 0)) { const targetUid = await user.getUidByUserslug(req.query.author);
return helpers.redirect(res, '/category/' + cid + '/' + req.params.slug + (topicIndex > topicCount ? '/' + topicCount : '')); const start = ((currentPage - 1) * userSettings.topicsPerPage) + topicIndex;
} const stop = start + userSettings.topicsPerPage - 1;
const categoryData = await categories.getCategoryById({
uid: req.uid,
cid: cid,
start: start,
stop: stop,
sort: req.query.sort || userSettings.categoryTopicSort,
settings: userSettings,
query: req.query,
tag: req.query.tag,
targetUid: targetUid,
});
if (!categoryData) {
return next();
}
categories.modifyTopicsByPrivilege(categoryData.topics, userPrivileges);
if (categoryData.link) {
await db.incrObjectField('category:' + categoryData.cid, 'timesClicked');
return helpers.redirect(res, categoryData.link);
}
await buildBreadcrumbs(req, categoryData);
if (categoryData.children.length) {
const allCategories = [];
categories.flattenCategories(allCategories, categoryData.children);
await categories.getRecentTopicReplies(allCategories, req.uid);
}
if (settings.usePagination && (currentPage < 1 || currentPage > pageCount)) { categoryData.title = translator.escape(categoryData.name);
return callback(); categoryData.description = translator.escape(categoryData.description);
} categoryData.privileges = userPrivileges;
categoryData.showSelect = userPrivileges.editable;
categoryData.rssFeedUrl = nconf.get('url') + '/category/' + categoryData.cid + '.rss';
if (parseInt(req.uid, 10)) {
categories.markAsRead([cid], req.uid);
categoryData.rssFeedUrl += '?uid=' + req.uid + '&token=' + rssToken;
}
if (!settings.usePagination) { addTags(categoryData, res);
topicIndex = Math.max(0, topicIndex - (Math.ceil(settings.topicsPerPage / 2) - 1));
} else if (!req.query.page) {
var index = Math.max(parseInt((topicIndex || 0), 10), 0);
currentPage = Math.ceil((index + 1) / settings.topicsPerPage);
topicIndex = 0;
}
user.getUidByUserslug(req.query.author, next); categoryData['feeds:disableRSS'] = meta.config['feeds:disableRSS'];
}, categoryData['reputation:disabled'] = meta.config['reputation:disabled'];
function (targetUid, next) {
var start = ((currentPage - 1) * settings.topicsPerPage) + topicIndex; categoryData.pagination = pagination.create(currentPage, pageCount, req.query);
var stop = start + settings.topicsPerPage - 1; categoryData.pagination.rel.forEach(function (rel) {
categories.getCategoryById({ rel.href = nconf.get('url') + '/category/' + categoryData.slug + rel.href;
uid: req.uid, res.locals.linkTags.push(rel);
cid: cid, });
start: start,
stop: stop, analytics.increment(['pageviews:byCid:' + categoryData.cid]);
sort: req.query.sort || settings.categoryTopicSort,
settings: settings, res.render('category', categoryData);
query: req.query,
tag: req.query.tag,
targetUid: targetUid,
}, next);
},
function (categoryData, next) {
if (!categoryData) {
return callback();
}
categories.modifyTopicsByPrivilege(categoryData.topics, userPrivileges);
if (categoryData.link) {
db.incrObjectField('category:' + categoryData.cid, 'timesClicked');
return helpers.redirect(res, categoryData.link);
}
buildBreadcrumbs(req, categoryData, next);
},
function (categoryData, next) {
if (!categoryData.children.length) {
return next(null, categoryData);
}
var allCategories = [];
categories.flattenCategories(allCategories, categoryData.children);
categories.getRecentTopicReplies(allCategories, req.uid, function (err) {
next(err, categoryData);
});
},
function (categoryData) {
categoryData.description = translator.escape(categoryData.description);
categoryData.privileges = userPrivileges;
categoryData.showSelect = categoryData.privileges.editable;
categoryData.rssFeedUrl = nconf.get('url') + '/category/' + categoryData.cid + '.rss';
if (parseInt(req.uid, 10)) {
categories.markAsRead([cid], req.uid);
categoryData.rssFeedUrl += '?uid=' + req.uid + '&token=' + rssToken;
}
addTags(categoryData, res);
categoryData['feeds:disableRSS'] = meta.config['feeds:disableRSS'];
categoryData['reputation:disabled'] = meta.config['reputation:disabled'];
categoryData.title = translator.escape(categoryData.name);
pageCount = Math.max(1, Math.ceil(categoryData.topic_count / settings.topicsPerPage));
categoryData.pagination = pagination.create(currentPage, pageCount, req.query);
categoryData.pagination.rel.forEach(function (rel) {
rel.href = nconf.get('url') + '/category/' + categoryData.slug + rel.href;
res.locals.linkTags.push(rel);
});
analytics.increment(['pageviews:byCid:' + categoryData.cid]);
res.render('category', categoryData);
},
], callback);
}; };
function buildBreadcrumbs(req, categoryData, callback) { async function buildBreadcrumbs(req, categoryData) {
var breadcrumbs = [ const breadcrumbs = [
{ {
text: categoryData.name, text: categoryData.name,
url: nconf.get('relative_path') + '/category/' + categoryData.slug, url: nconf.get('relative_path') + '/category/' + categoryData.slug,
}, },
]; ];
async.waterfall([ const crumbs = await helpers.buildCategoryBreadcrumbs(categoryData.parentCid);
function (next) { if (req.originalUrl.startsWith(nconf.get('relative_path') + '/api/category') || req.originalUrl.startsWith(nconf.get('relative_path') + '/category')) {
helpers.buildCategoryBreadcrumbs(categoryData.parentCid, next); categoryData.breadcrumbs = crumbs.concat(breadcrumbs);
}, }
function (crumbs, next) {
if (req.originalUrl.startsWith(nconf.get('relative_path') + '/api/category') || req.originalUrl.startsWith(nconf.get('relative_path') + '/category')) {
categoryData.breadcrumbs = crumbs.concat(breadcrumbs);
}
next(null, categoryData);
},
], callback);
} }
function addTags(categoryData, res) { function addTags(categoryData, res) {

Write Preview
Loading…
Cancel
Save