cleanup

public/src/forum/admin/general/dashboard.js

@@ -307,11 +307,11 @@ define('forum/admin/general/dashboard', ['semver'], function(semver) {
 	}
 
 	function updateTopicsGraph(topics) {
-		var tids = Object.keys(topics);
+		var tids = Object.keys(topics),
+			segments = graphs.topics.segments;
 
-		var segments = graphs.topics.segments;
+		function reassignExistingTopics() {
-
+			for (var i = 0, ii = segments.length; i < ii; i++ ) {
-		for (var i = 0, ii = segments.length; i < ii; i++ ){
 				var tid = segments[i].tid;
 
 				if ($.inArray(tid, tids) === -1) {
@@ -322,7 +322,9 @@ define('forum/admin/general/dashboard', ['semver'], function(semver) {
 					delete topics[tid];
 				}
 			}
+		}
 
+		function assignNewTopics() {
 			while (segments.length < 10 && tids.length > 0) {
 				var tid = tids.pop(),
 					value = topics[tid],
@@ -353,9 +355,17 @@ define('forum/admin/general/dashboard', ['semver'], function(semver) {
 
 				segments[segments.length - 1].tid = tid;
 			}
+		}
+
+		reassignExistingTopics();
+		assignNewTopics();
 
 		graphs.topics.update();
 	}
 
+	function buildTopicsLegend() {
+
+	}
+
 	return Admin;
 });