fix: #9827, fix reward duplication

public/src/admin/extend/rewards.js

@@ -167,11 +167,17 @@ define('admin/extend/rewards', [], function () {
 			activeRewards.push(data);
 		});
 
-		socket.emit('admin.rewards.save', activeRewards, function (err) {
+		socket.emit('admin.rewards.save', activeRewards, function (err, result) {
 			if (err) {
 				app.alertError(err.message);
 			} else {
 				app.alertSuccess('[[admin/extend/rewards:alert.save-success]]');
+				// newly added rewards are missing data-id, update to prevent rewards getting duplicated
+				$('#active li').each(function (index) {
+					if (!$(this).attr('data-id')) {
+						$(this).attr('data-id', result[index].id);
+					}
+				});
 			}
 		});
 	}

src/rewards/admin.js

@@ -24,6 +24,7 @@ rewards.save = async function (data) {
 
 	await Promise.all(data.map(data => save(data)));
 	await saveConditions(data);
+	return data;
 };
 
 rewards.delete = async function (data) {

src/socket.io/admin/rewards.js

@@ -5,7 +5,7 @@ const rewardsAdmin = require('../../rewards/admin');
 const SocketRewards = module.exports;
 
 SocketRewards.save = async function (socket, data) {
-	await rewardsAdmin.save(data);
+	return await rewardsAdmin.save(data);
 };
 
 SocketRewards.delete = async function (socket, data) {