closes #4273

public/src/client/register.js

@@ -1,6 +1,6 @@
 'use strict';
 
-/* globals define, app, utils, socket, config */
+/* globals define, app, utils, socket, config, ajaxify, bootbox */
 
 
 define('forum/register', ['csrf', 'translator'], function(csrf, translator) {
@@ -67,41 +67,44 @@ define('forum/register', ['csrf', 'translator'], function(csrf, translator) {
 
 		register.on('click', function(e) {
 			var registerBtn = $(this);
+			var errorEl = $('#register-error-notify');
+			errorEl.addClass('hidden');
 			e.preventDefault();
 			validateForm(function() {
-				if (!validationError) {
+				if (validationError) {
-					registerBtn.addClass('disabled');
+					return;
-
+				}
-					registerBtn.parents('form').ajaxSubmit({
+
-						headers: {
+				registerBtn.addClass('disabled');
-							'x-csrf-token': csrf.get()
+
-						},
+				registerBtn.parents('form').ajaxSubmit({
-						success: function(data, status) {
+					headers: {
-							registerBtn.removeClass('disabled');
+						'x-csrf-token': csrf.get()
-							if (!data) {
+					},
-								return;
+					success: function(data) {
-							}
+						registerBtn.removeClass('disabled');
-							if (data.referrer) {
+						if (!data) {
-								window.location.href = data.referrer;
+							return;
-							} else if (data.message) {
+						}
-								require(['translator'], function(translator) {
+						if (data.referrer) {
-									translator.translate(data.message, function(msg) {
+							window.location.href = data.referrer;
-										bootbox.alert(msg);
+						} else if (data.message) {
-										ajaxify.go('/');
+							require(['translator'], function(translator) {
-									});
+								translator.translate(data.message, function(msg) {
+									bootbox.alert(msg);
+									ajaxify.go('/');
 								});
-							}
-						},
-						error: function(data, status) {
-							var errorEl = $('#register-error-notify');
-							translator.translate(data.responseText, config.defaultLang, function(translated) {
-								errorEl.find('p').text(translated);
-								errorEl.show();
-								registerBtn.removeClass('disabled');
 							});
 						}
-					});
+					},
-				}
+					error: function(data) {
+						translator.translate(data.responseText, config.defaultLang, function(translated) {
+							errorEl.find('p').text(translated);
+							errorEl.removeClass('hidden');
+							registerBtn.removeClass('disabled');
+						});
+					}
+				});
 			});
 		});
 
@@ -181,6 +184,8 @@ define('forum/register', ['csrf', 'translator'], function(csrf, translator) {
 
 		if (password.length < ajaxify.data.minimumPasswordLength) {
 			showError(password_notify, '[[user:change_password_error_length]]');
+		} else if (password.length > 4096) {
+			showError(password_notify, '[[error:password-too-long]]');
 		} else if (!utils.isPasswordValid(password)) {
 			showError(password_notify, '[[user:change_password_error]]');
 		} else if (password === $('#username').val()) {