fix: #9800, don't send all welcome test emails to test@example.org @julianlam

src/socket.io/admin/email.js

@@ -14,7 +14,6 @@ Email.test = async function (socket, data) {
 		...(data.payload || {}),
 		subject: '[[email:test-email.subject]]',
 	};
-	let template;
 
 	switch (data.template) {
 		case 'digest':
@@ -34,15 +33,11 @@ Email.test = async function (socket, data) {
 			break;
 
 		case 'verify-email':
-			template = 'verify-email';
-			// falls through
-
 		case 'welcome':
 			await userEmail.sendValidationEmail(socket.uid, {
 				force: 1,
-				email: 'test@example.org',
+				template: data.template,
-				template: template || 'welcome',
+				subject: data.template === 'welcome' ? `[[email:welcome-to, ${meta.config.title || meta.config.browserTitle || 'NodeBB'}]]` : undefined,
-				subject: !template ? `[[email:welcome-to, ${meta.config.title || meta.config.browserTitle || 'NodeBB'}]]` : undefined,
 			});
 			break;