fix: guests dont always have sid

src/api/topics.js

@@ -75,8 +75,8 @@ topicsAPI.reply = async function (caller, data) {
 	user.updateOnlineUsers(caller.uid);
 	if (caller.uid) {
 		socketHelpers.emitToUids('event:new_post', result, [caller.uid]);
-	} else if (caller.uid === 0 && caller.sessionID) {
+	} else if (caller.uid === 0) {
-		websockets.in('sess_' + caller.sessionID).emit('event:new_post', result);
+		websockets.in('online_guests').emit('event:new_post', result);
 	}
 
 	socketHelpers.notifyNew(caller.uid, 'newPost', result);

src/socket.io/index.js

@@ -198,15 +198,13 @@ async function authorize(socket, callback) {
 	}
 
 	await cookieParserAsync(request);
-	const sid = request.signedCookies[nconf.get('sessionKey')];
+	const sessionData = await getSessionAsync(request.signedCookies[nconf.get('sessionKey')]);
-	const sessionData = await getSessionAsync(sid);
 	if (sessionData && sessionData.passport && sessionData.passport.user) {
 		request.session = sessionData;
 		socket.uid = parseInt(sessionData.passport.user, 10);
 	} else {
 		socket.uid = 0;
 	}
-	socket.sessionID = sid;
 	request.uid = socket.uid;
 	callback();
 }