error checks in middleware/admin

v1.18.x
barisusakli 10 years ago
parent eaf89dc316
commit 698d113857

@ -5,12 +5,12 @@ var app,
nconf = require('nconf'), nconf = require('nconf'),
async = require('async'), async = require('async'),
path = require('path'), path = require('path'),
user = require('./../user'), user = require('../user'),
meta = require('./../meta'), meta = require('../meta'),
plugins = require('./../plugins'), plugins = require('../plugins'),
controllers = { controllers = {
api: require('./../controllers/api') api: require('../controllers/api')
}; };
@ -45,21 +45,31 @@ middleware.buildHeader = function(req, res, next) {
}; };
user.getUserFields(uid, ['username', 'userslug', 'picture'], function(err, userData) { user.getUserFields(uid, ['username', 'userslug', 'picture'], function(err, userData) {
if (err) {
return next(err);
}
async.parallel({ async.parallel({
scripts: function(next) { scripts: function(next) {
plugins.fireHook('filter:admin.scripts.get', [], function(err, scripts) { plugins.fireHook('filter:admin.scripts.get', [], function(err, scripts) {
if (err) {
return next(err);
}
var arr = []; var arr = [];
scripts.forEach(function(script) { scripts.forEach(function(script) {
arr.push({src: nconf.get('url') + script}); arr.push({src: nconf.get('url') + script});
}); });
next(err, arr); next(null, arr);
}); });
}, },
custom_header: function(next) { custom_header: function(next) {
plugins.fireHook('filter:admin.header.build', custom_header, next); plugins.fireHook('filter:admin.header.build', custom_header, next);
} }
}, function(err, pluginData) { }, function(err, pluginData) {
if (err) {
return next(err);
}
var data = { var data = {
csrf: req.csrfToken ? req.csrfToken() : undefined, csrf: req.csrfToken ? req.csrfToken() : undefined,
relative_path: nconf.get('relative_path'), relative_path: nconf.get('relative_path'),
@ -74,8 +84,11 @@ middleware.buildHeader = function(req, res, next) {
}; };
app.render('admin/header', data, function(err, template) { app.render('admin/header', data, function(err, template) {
if (err) {
return next(err);
}
res.locals.adminHeader = template; res.locals.adminHeader = template;
next(err); next();
}); });
}); });
}); });
@ -92,9 +105,7 @@ middleware.buildHeader = function(req, res, next) {
next(err); next(err);
}); });
} }
], function(err) { ], next);
next();
});
}; };
module.exports = function(webserver) { module.exports = function(webserver) {

Loading…
Cancel
Save