some controller tests

src/controllers/accounts/blocks.js

@@ -8,7 +8,7 @@ var pagination = require('../../pagination');
 var user = require('../../user');
 var plugins = require('../../plugins');
 
-var blocksController = {};
+var blocksController = module.exports;
 
 blocksController.getBlocks = function (req, res, callback) {
 	var userData;
@@ -41,11 +41,7 @@ blocksController.getBlocks = function (req, res, callback) {
 		function (data, next) {
 			user.getUsers(data.uids, res.locals.uid, next);
 		},
-	], function (err, users) {
+		function (users) {
-		if (err) {
-			return callback(err);
-		}
-
 			userData.users = users;
 			userData.title = '[[pages:account/blocks, ' + userData.username + ']]';
 			var count = userData.blocksCount;
@@ -54,7 +50,6 @@ blocksController.getBlocks = function (req, res, callback) {
 			userData.breadcrumbs = helpers.buildBreadcrumbs([{ text: userData.username, url: '/user/' + userData.userslug }, { text: '[[user:blocks]]' }]);
 
 			res.render('account/blocks', userData);
-	});
+		},
+	], callback);
 };
-
-module.exports = blocksController;

src/controllers/accounts/consent.js

@@ -7,7 +7,7 @@ var meta = require('../../meta');
 var helpers = require('../helpers');
 var accountHelpers = require('./helpers');
 
-var consentController = {};
+var consentController = module.exports;
 
 consentController.get = function (req, res, next) {
 	var userData;
@@ -23,21 +23,10 @@ consentController.get = function (req, res, next) {
 			}
 
 			// Direct database call is used here because `gdpr_consent` is a protected user field and is automatically scrubbed from standard user data retrieval calls
-			db.getObjectField('user:' + userData.uid, 'gdpr_consent', function (err, consented) {
+			db.getObjectField('user:' + userData.uid, 'gdpr_consent', next);
-				if (err) {
-					return next(err);
-				}
-
-				userData.gdpr_consent = !!parseInt(consented, 10);
-
-				next(null, userData);
-			});
 		},
-	], function (err, userData) {
+		function (consented) {
-		if (err) {
+			userData.gdpr_consent = parseInt(consented, 10) === 1;
-			return next(err);
-		}
-
 			userData.digest = {
 				frequency: meta.config.dailyDigestFreq,
 				enabled: meta.config.dailyDigestFreq !== 'off',
@@ -47,7 +36,6 @@ consentController.get = function (req, res, next) {
 			userData.breadcrumbs = helpers.buildBreadcrumbs([{ text: userData.username, url: '/user/' + userData.userslug }, { text: '[[user:consent.title]]' }]);
 
 			res.render('account/consent', userData);
-	});
+		},
+	], next);
 };
-
-module.exports = consentController;

test/controllers-admin.js

@@ -101,6 +101,32 @@ describe('Admin Controllers', function () {
 		});
 	});
 
+	it('should load global privileges page', function (done) {
+		request(nconf.get('url') + '/admin/manage/privileges', { jar: jar }, function (err, res, body) {
+			assert.ifError(err);
+			assert.equal(res.statusCode, 200);
+			assert(body);
+			done();
+		});
+	});
+
+	it('should load privileges page for category 1', function (done) {
+		request(nconf.get('url') + '/admin/manage/privileges/1', { jar: jar }, function (err, res, body) {
+			assert.ifError(err);
+			assert.equal(res.statusCode, 200);
+			assert(body);
+			done();
+		});
+	});
+
+	it('should load manage uploads', function (done) {
+		request(nconf.get('url') + '/admin/manage/uploads', { jar: jar }, function (err, res, body) {
+			assert.ifError(err);
+			assert.equal(res.statusCode, 200);
+			assert(body);
+			done();
+		});
+	});
 
 	it('should load general settings page', function (done) {
 		request(nconf.get('url') + '/admin/settings', { jar: jar }, function (err, res, body) {

test/controllers.js

@@ -1133,6 +1133,33 @@ describe('Controllers', function () {
 			});
 		});
 
+		it('should load /user/foo/blocks', function (done) {
+			request(nconf.get('url') + '/api/user/foo/blocks', { jar: jar }, function (err, res, body) {
+				assert.ifError(err);
+				assert.equal(res.statusCode, 200);
+				assert(body);
+				done();
+			});
+		});
+
+		it('should load /user/foo/consent', function (done) {
+			request(nconf.get('url') + '/api/user/foo/consent', { jar: jar }, function (err, res, body) {
+				assert.ifError(err);
+				assert.equal(res.statusCode, 200);
+				assert(body);
+				done();
+			});
+		});
+
+		it('should load /user/foo/uploads', function (done) {
+			request(nconf.get('url') + '/api/user/foo/uploads', { jar: jar }, function (err, res, body) {
+				assert.ifError(err);
+				assert.equal(res.statusCode, 200);
+				assert(body);
+				done();
+			});
+		});
+
 		it('should load notifications page', function (done) {
 			var notifications = require('../src/notifications');
 			var notifData = {