fix: #9389, allow admins to add themselves to private groups

src/api/groups.js

@@ -98,7 +98,7 @@ groupsAPI.join = async function (caller, data) {
 		return;
 	}
 
-	if (isSelf && groupData.private && groupData.disableJoinRequests) {
+	if (!isCallerAdmin && isSelf && groupData.private && groupData.disableJoinRequests) {
 		throw new Error('[[error:group-join-disabled]]');
 	}
 

test/groups.js

@@ -723,6 +723,12 @@ describe('Groups', () => {
 			}
 			meta.config.allowPrivateGroups = oldValue;
 		});
+
+		it('should allow admins to join private groups', async () => {
+			const groupsAPI = require('../src/api/groups');
+			await groupsAPI.join({ uid: adminUid }, { uid: adminUid, slug: 'global-moderators' });
+			assert(await Groups.isMember(adminUid, 'Global Moderators'));
+		});
 	});
 
 	describe('.leave()', () => {