fix: response hook logic

After some more thought, a response hook should be checking for
whether headers are sent, and executing (or not executing) the
default logic in that case.

Before, we were relying on hooks to call data.next() to continue
execution, but it makes more sense to have the listener either
send a response or not, and handle the behaviour afterwards.

src/middleware/user.js

@@ -16,19 +16,18 @@ const controllers = {
 };
 
 module.exports = function (middleware) {
-	function authenticate(req, res, next, callback) {
+	async function authenticate(req, res, next, callback) {
 		if (req.loggedIn) {
 			return next();
 		}
-		if (plugins.hasListeners('response:middleware.authenticate')) {
+
-			return plugins.fireHook('response:middleware.authenticate', {
+		await plugins.fireHook('response:middleware.authenticate', {
 			req: req,
 			res: res,
-				next: function (err) {
+			next: function () {},	// no-op for backwards compatibility
-					if (err) {
+		});
-						return next(err);
-					}
 
+		if (!res.headersSent) {
 			auth.setAuthVars(req, res, function () {
 				if (req.loggedIn && req.user && req.user.uid) {
 					return next();
@@ -36,11 +35,7 @@ module.exports = function (middleware) {
 
 				callback();
 			});
-				},
-			});
 		}
-
-		callback();
 	}
 
 	middleware.authenticate = function middlewareAuthenticate(req, res, next) {