prevent crash on invalid data

v1.18.x
barisusakli 10 years ago
parent 6b20cf5cff
commit 5128f7d2f9

@ -70,23 +70,29 @@ SocketPosts.reply = function(socket, data, callback) {
}; };
SocketPosts.getVoters = function(socket, data, callback) { SocketPosts.getVoters = function(socket, data, callback) {
if (!data || !data.pid || !data.cid) {
return callback(new Error('[[error:invalid-data]]'));
}
var pid = data.pid, var pid = data.pid,
cid = data.cid, cid = data.cid;
uid = socket.uid;
async.parallel([ async.parallel({
function(next) { isAdmin: function(next) {
user.isAdministrator(uid, next); user.isAdministrator(socket.uid, next);
}, },
function(next) { isModerator: function(next) {
user.isModerator(uid, cid, next); user.isModerator(socket.uid, cid, next);
} }
], function(err, tests) { }, function(err, tests) {
if (tests[0] || tests[1]) { if (err) {
getVoters(pid, callback); return callback(err);
} }
})
if (tests.isAdmin || tests.isModerator) {
getVoters(pid, callback);
}
});
}; };
function getVoters(pid, callback) { function getVoters(pid, callback) {

Loading…
Cancel
Save