remove dupe code in minify_js

v1.18.x
Barış Soner Uşaklı
parent 647f1bb3ed
commit 50f4fd5345

@ -164,64 +164,59 @@ function concat(data, callback) {
actions.concat = concat; actions.concat = concat;
function minifyJS_batch(data, callback) { function minifyJS_batch(data, callback) {
async.each(data.files, function (ref, next) { async.each(data.files, function (fileObj, next) {
var srcPath = ref.srcPath; fs.readFile(fileObj.srcPath, 'utf8', function (err, source) {
var destPath = ref.destPath;
var filename = ref.filename;
fs.readFile(srcPath, 'utf8', function (err, file) {
if (err) { if (err) {
return next(err); return next(err);
} }
var scripts = {}; var filesToMinify = [
scripts[filename] = file; {
srcPath: fileObj.srcPath,
try { filename: fileObj.filename,
var minified = uglify.minify(scripts, { source: source,
sourceMap: {
filename: filename,
url: filename + '.map',
includeSources: true,
}, },
compress: false, ];
}); minifyAndSave({
files: filesToMinify,
async.parallel([ destPath: fileObj.destPath,
async.apply(fs.writeFile, destPath, minified.code), filename: fileObj.filename,
async.apply(fs.writeFile, destPath + '.map', minified.map), }, next);
], next);
} catch (e) {
next(e);
}
}); });
}, callback); }, callback);
} }
actions.minifyJS_batch = minifyJS_batch; actions.minifyJS_batch = minifyJS_batch;
function minifyJS(data, callback) { function minifyJS(data, callback) {
async.mapLimit(data.files, 1000, function (ref, next) { async.mapLimit(data.files, 1000, function (fileObj, next) {
var srcPath = ref.srcPath; fs.readFile(fileObj.srcPath, 'utf8', function (err, source) {
var filename = ref.filename;
fs.readFile(srcPath, 'utf8', function (err, file) {
if (err) { if (err) {
return next(err); return next(err);
} }
next(null, { next(null, {
srcPath: srcPath, srcPath: fileObj.srcPath,
filename: filename, filename: fileObj.filename,
source: file, source: source,
}); });
}); });
}, function (err, files) { }, function (err, filesToMinify) {
if (err) { if (err) {
return callback(err); return callback(err);
} }
minifyAndSave({
files: filesToMinify,
destPath: data.destPath,
filename: data.filename,
}, callback);
});
}
actions.minifyJS = minifyJS;
function minifyAndSave(data, callback) {
var scripts = {}; var scripts = {};
files.forEach(function (ref) { data.files.forEach(function (ref) {
if (!ref) { if (!ref) {
return; return;
} }
@ -246,9 +241,7 @@ function minifyJS(data, callback) {
async.apply(fs.writeFile, data.destPath, minified.code), async.apply(fs.writeFile, data.destPath, minified.code),
async.apply(fs.writeFile, data.destPath + '.map', minified.map), async.apply(fs.writeFile, data.destPath + '.map', minified.map),
], callback); ], callback);
});
} }
actions.minifyJS = minifyJS;
Minifier.js = {}; Minifier.js = {};
Minifier.js.bundle = function (data, minify, fork, callback) { Minifier.js.bundle = function (data, minify, fork, callback) {

Loading…
Cancel
Save