refactor: messaging

src/messaging/create.js

@@ -1,9 +1,9 @@
 'use strict';
 
-var meta = require('../meta');
+const meta = require('../meta');
-var plugins = require('../plugins');
+const plugins = require('../plugins');
-var db = require('../database');
+const db = require('../database');
-var user = require('../user');
+const user = require('../user');
 
 module.exports = function (Messaging) {
 	Messaging.sendMessage = async (data) => {
@@ -21,7 +21,7 @@ module.exports = function (Messaging) {
 			throw new Error('[[error:invalid-chat-message]]');
 		}
 
-		const maximumChatMessageLength = (meta.config.maximumChatMessageLength || 1000);
+		const maximumChatMessageLength = meta.config.maximumChatMessageLength || 1000;
 		const data = await plugins.fireHook('filter:messaging.checkContent', { content: content });
 		content = String(data.content).trim();
 		if (!content) {

src/messaging/data.js

@@ -2,10 +2,10 @@
 
 const validator = require('validator');
 
-var db = require('../database');
+const db = require('../database');
-var user = require('../user');
+const user = require('../user');
-var utils = require('../utils');
+const utils = require('../utils');
-var plugins = require('../plugins');
+const plugins = require('../plugins');
 
 const intFields = ['timestamp', 'edited', 'fromuid', 'roomId', 'deleted', 'system'];
 

src/messaging/delete.js

@@ -11,6 +11,6 @@ module.exports = function (Messaging) {
 			throw new Error('[[error:chat-' + field + '-already]]');
 		}
 
-		return await Messaging.setMessageField(mid, 'deleted', state);
+		await Messaging.setMessageField(mid, 'deleted', state);
 	}
 };

src/messaging/edit.js

@@ -1,9 +1,9 @@
 'use strict';
 
-var meta = require('../meta');
+const meta = require('../meta');
-var user = require('../user');
+const user = require('../user');
 
-var sockets = require('../socket.io');
+const sockets = require('../socket.io');
 
 
 module.exports = function (Messaging) {
@@ -63,7 +63,7 @@ module.exports = function (Messaging) {
 		if (isAdmin && !messageData.system) {
 			return;
 		}
-		var chatConfigDuration = meta.config[durationConfig];
+		const chatConfigDuration = meta.config[durationConfig];
 		if (chatConfigDuration && Date.now() - messageData.timestamp > chatConfigDuration * 1000) {
 			throw new Error('[[error:chat-' + type + '-duration-expired, ' + meta.config[durationConfig] + ']]');
 		}

src/messaging/index.js

@@ -139,14 +139,8 @@ Messaging.getRecentChats = async (callerUid, uid, start, stop) => {
 	});
 };
 
-Messaging.generateUsernames = (users, excludeUid) => {
+Messaging.generateUsernames = (users, excludeUid) => users.filter(user => user && parseInt(user.uid, 10) !== excludeUid)
-	users = users.filter(function (user) {
+	.map(user => user.username).join(', ');
-		return user && parseInt(user.uid, 10) !== excludeUid;
-	});
-	return users.map(function (user) {
-		return user.username;
-	}).join(', ');
-};
 
 Messaging.getTeaser = async (uid, roomId) => {
 	const mid = await Messaging.getLatestUndeletedMessage(uid, roomId);