fix: don't return promise

src/socket.io/groups.js

@@ -38,7 +38,8 @@ SocketGroups.join = function (socket, data, callback) {
 			}
 
 			if (!meta.config.allowPrivateGroups) {
-				return groups.join(data.groupName, socket.uid, callback);
+				groups.join(data.groupName, socket.uid, callback);
+				return;
 			}
 
 			async.parallel({

src/socket.io/topics/infinitescroll.js

@@ -93,7 +93,8 @@ module.exports = function (SocketTopics) {
 		};
 		if (data.sort === 'unread') {
 			params.cid = data.cid;
-			return topics.getUnreadTopics(params, callback);
+			topics.getUnreadTopics(params, callback);
+			return;
 		}
 		params.cids = data.cid;
 		params.sort = data.sort;

src/socket.io/user/ban.js

@@ -130,13 +130,12 @@ module.exports = function (SocketUser) {
 				db.setObjectField('uid:' + uid + ':ban:' + banData.timestamp, 'fromUid', callerUid, next);
 			},
 			function (next) {
-				if (!reason) {
+				if (reason) {
-					return translator.translate('[[user:info.banned-no-reason]]', function (translated) {
+					return next(null, reason);
-						next(null, translated);
-					});
 				}
-
+				translator.translate('[[user:info.banned-no-reason]]', function (translated) {
-				next(null, reason);
+					next(null, translated);
+				});
 			},
 			function (_reason, next) {
 				websockets.in('uid_' + uid).emit('event:banned', {

test/socket.io.js

@@ -127,7 +127,7 @@ describe('socket.io', function () {
 	it('should get more unread topics', function (done) {
 		io.emit('topics.loadMoreSortedTopics', { after: 0, count: 10, direction: 1, sort: 'unread' }, function (err, result) {
 			assert.ifError(err);
-			console.log(result);
+			assert(Array.isArray(result.topics));
 			done();
 		});
 	});