fix: bug where fallback window trigger was not firing if there were no hook listeners attached

... so in essence the backwards compatibility was not working at all.

closes nodebb/nodebb-plugin-composer-default#147
v1.18.x
Julian Lam 4 years ago
parent c8b78654d9
commit 1e579428e7

@ -63,12 +63,10 @@ define('hooks', [], () => {
}; };
const _fireActionHook = (hookName, data) => { const _fireActionHook = (hookName, data) => {
if (!Hooks.hasListeners(hookName)) { if (Hooks.hasListeners(hookName)) {
return; Hooks.loaded[hookName].forEach(listener => listener(data));
} }
Hooks.loaded[hookName].forEach(listener => listener(data));
// Backwards compatibility (remove this when we eventually remove jQuery from NodeBB core) // Backwards compatibility (remove this when we eventually remove jQuery from NodeBB core)
$(window).trigger(hookName, data); $(window).trigger(hookName, data);
}; };

Loading…
Cancel
Save