fixed bug in privilege settings where categories near the end of a list were not having their permissions read properly if earlier categories were disabled, #2887

v1.18.x
Julian Lam 10 years ago
parent b268927cf9
commit 06d547a6cb

@ -101,18 +101,19 @@ module.exports = function(privileges) {
return callback(err); return callback(err);
} }
cids = cids.filter(function(cid, index) { cids = cids.map(function(cid, index) {
return !results.categories[index].disabled; return !results.categories[index].disabled ? cid : null;
}); });
if (results.isAdmin) { if (results.isAdmin) {
return callback(null, cids); return callback(null, cids.filter(Boolean));
} }
cids = cids.filter(function(cid, index) { cids = cids.map(function(cid, index) {
return results.allowedTo[index] || results.isModerators[index]; return (results.allowedTo[index] || results.isModerators[index]) ? cid : null;
}); });
callback(null, cids);
callback(null, cids.filter(Boolean));
}); });
}; };

Loading…
Cancel
Save