You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
nodebb/test/messaging.js

866 lines
32 KiB
JavaScript

'use strict';
const assert = require('assert');
const async = require('async');
const request = require('request-promise-native');
const nconf = require('nconf');
const util = require('util');
const sleep = util.promisify(setTimeout);
const db = require('./mocks/databasemock');
const meta = require('../src/meta');
const User = require('../src/user');
const Groups = require('../src/groups');
const Messaging = require('../src/messaging');
const helpers = require('./helpers');
const socketModules = require('../src/socket.io/modules');
Webpack5 (#10311) * feat: webpack 5 part 1 * fix: gruntfile fixes * fix: fix taskbar warning add app.importScript copy public/src/modules to build folder * refactor: remove commented old code * feat: reenable admin * fix: acp settings pages, fix sortable on manage categories embedded require in html not allowed * fix: bundle serialize/deserizeli so plugins dont break * test: fixe util tests * test: fix require path * test: more test fixes * test: require correct utils module * test: require correct utils * test: log stack * test: fix db require blowing up tests * test: move and disable bundle test * refactor: add aliases * test: disable testing route * fix: move webpack modules necessary for build, into `dependencies` * test: fix one more test remove 500-embed.tpl * fix: restore use of assets/nodebb.min.js, at least for now * fix: remove unnecessary line break * fix: point to proper ACP bundle * test: maybe fix build test * test: composer * refactor: dont need dist * refactor: more cleanup use everything from build/public folder * get rid of conditional import in app.js * fix: ace * refactor: cropper alias * test: lint and test fixes * lint: fix * refactor: rename function to app.require * refactor: go back to using app.require * chore: use github branch * chore: use webpack branch * feat: webpack webinstaller * feat: add chunkFile name with contenthash * refactor: move hooks to top * refactor: get rid of template500Function * fix(deps): use webpack5 branch of 2factor plugin * chore: tagging v2.0.0-beta.0 pre-release version :boom: :shipit: :tada: :rocket: * refactor: disable cache on templates loadTemplate is called once by benchpress and the result is cache internally * refactor: add server side helpers.js * feat: deprecate /plugins shorthand route, closes #10343 * refactor: use build/public for webpack * test: fix filename * fix: more specific selector * lint: ignore * refactor: fix comments * test: add debug for random failing test * refactor: cleanup remove test page, remove dupe functions in utils.common * lint: use relative path for now * chore: bump prerelease version * feat: add translateKeys * fix: optional params * fix: get rid of extra timeago files * refactor: cleanup, require timeago locale earlier remove translator.prepareDOM, it is in header.tpl html tag * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378) * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels - Existing hooks are preserved (to be deprecated at a later date, possibly) - New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks * docs: fix typo in comment * test: spec changes * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378) * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels - Existing hooks are preserved (to be deprecated at a later date, possibly) - New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks * docs: fix typo in comment * test: spec changes * feat: allow app.require('bootbox'/'benchpressjs') * refactor: require server side utils * test: jquery ready * change istaller to use build/public * test: use document.addEventListener * refactor: closes #10301 * refactor: generateTopicClass * fix: column counts for other privileges * fix: #10443, regression where sorted-list items did not render into the DOM in the predicted order [breaking] * fix: typo in hook name * refactor: introduce a generic autocomplete.init() method that can be called to add nodebb-style autocompletion but using different data sources (e.g. not user/groups/tags) * fix: crash if `delay` not passed in (as it cannot be destructured) * refactor: replace substr * feat: set --panel-offset style in html element based on stored value in localStorage * refactor: addDropupHandler() logic to be less naive - Take into account height of the menu - Don't apply dropUp logic if there's nothing in the dropdown - Remove 'hidden' class (added by default in Persona for post tools) when menu items are added closes #10423 * refactor: simplify utils.params [breaking] Retrospective analysis of the usage of this method suggests that the options passed in are superfluous, and that only `url` is required. Using a browser built-in makes more sense to accomplish what this method sets out to do. * feat: add support for returning full URLSearchParams for utils.params * fix: utils.params() fallback handling * fix: default empty obj for params() * fix: remove \'loggedin\' and \'register\' qs parameters once they have been used, delay invocation of messages until ajaxify.end * fix: utils.params() not allowing relative paths to be passed in * refactor(DRY): new assertPasswordValidity utils method * fix: incorrect error message returned on insufficient privilege on flag edit * fix: read/update/delete access to flags API should be limited for moderators to only post flags in categories they moderate - added failing tests and patched up middleware.assert.flags to fix * refactor: flag api v3 tests to create new post and flags on every round * fix: missing error:no-flag language key * refactor: flags.canView to check flag existence, simplify middleware.assert.flag * feat: flag deletion API endpoint, #10426 * feat: UI for flag deletion, closes #10426 * chore: update plugin versions * chore: up emoji * chore: update markdown * chore: up emoji-android * fix: regression caused by utils.params() refactor, supports arrays and pipes all values through utils.toType, adjusts tests to type check Co-authored-by: Julian Lam <[email protected]>
3 years ago
const utils = require('../src/utils');
const translator = require('../src/translator');
8 years ago
describe('Messaging Library', () => {
const mocks = {
users: {
foo: {}, // the admin
bar: {},
baz: {}, // the user with chat restriction enabled
herp: {},
},
};
let roomId;
8 years ago
let chatMessageDelay;
const callv3API = async (method, path, body, user) => {
const options = {
method,
body,
json: true,
jar: mocks.users[user].jar,
resolveWithFullResponse: true,
simple: false,
};
if (method !== 'get') {
options.headers = {
'x-csrf-token': mocks.users[user].csrf,
};
}
return request(`${nconf.get('url')}/api/v3${path}`, options);
};
before(async () => {
// Create 3 users: 1 admin, 2 regular
({
foo: mocks.users.foo.uid,
bar: mocks.users.bar.uid,
baz: mocks.users.baz.uid,
herp: mocks.users.herp.uid,
} = await utils.promiseParallel({
foo: User.create({ username: 'foo', password: 'barbar' }), // admin
bar: User.create({ username: 'bar', password: 'bazbaz' }), // admin
baz: User.create({ username: 'baz', password: 'quuxquux' }), // restricted user
herp: User.create({ username: 'herp', password: 'derpderp' }), // a regular user
}));
await Groups.join('administrators', mocks.users.foo.uid);
await User.setSetting(mocks.users.baz.uid, 'restrictChat', '1');
({ jar: mocks.users.foo.jar, csrf_token: mocks.users.foo.csrf } = await util.promisify(helpers.loginUser)('foo', 'barbar'));
({ jar: mocks.users.bar.jar, csrf_token: mocks.users.bar.csrf } = await util.promisify(helpers.loginUser)('bar', 'bazbaz'));
({ jar: mocks.users.baz.jar, csrf_token: mocks.users.baz.csrf } = await util.promisify(helpers.loginUser)('baz', 'quuxquux'));
({ jar: mocks.users.herp.jar, csrf_token: mocks.users.herp.csrf } = await util.promisify(helpers.loginUser)('herp', 'derpderp'));
chatMessageDelay = meta.config.chatMessageDelay;
meta.config.chatMessageDelay = 0;
});
after(() => {
meta.configs.chatMessageDelay = chatMessageDelay;
});
describe('.canMessage()', () => {
it('should allow messages to be sent to an unrestricted user', (done) => {
Messaging.canMessageUser(mocks.users.baz.uid, mocks.users.herp.uid, (err) => {
9 years ago
assert.ifError(err);
done();
});
});
it('should NOT allow messages to be sent to a restricted user', async () => {
await User.setSetting(mocks.users.baz.uid, 'restrictChat', '1');
try {
await Messaging.canMessageUser(mocks.users.herp.uid, mocks.users.baz.uid);
} catch (err) {
assert.strictEqual(err.message, '[[error:chat-restricted]]');
}
});
it('should always allow admins through', (done) => {
Messaging.canMessageUser(mocks.users.foo.uid, mocks.users.baz.uid, (err) => {
9 years ago
assert.ifError(err);
done();
});
});
it('should allow messages to be sent to a restricted user if restricted user follows sender', (done) => {
User.follow(mocks.users.baz.uid, mocks.users.herp.uid, () => {
Messaging.canMessageUser(mocks.users.herp.uid, mocks.users.baz.uid, (err) => {
9 years ago
assert.ifError(err);
done();
});
});
});
});
describe('rooms', () => {
it('should fail to create a new chat room with invalid data', async () => {
const { body } = await callv3API('post', '/chats', {}, 'foo');
assert.equal(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));
8 years ago
});
it('should return rate limit error on second try', async () => {
const oldValue = meta.config.chatMessageDelay;
meta.config.chatMessageDelay = 1000;
await callv3API('post', '/chats', {
uids: [mocks.users.baz.uid],
}, 'foo');
const { statusCode, body } = await callv3API('post', `/chats`, {
uids: [mocks.users.baz.uid],
}, 'foo');
assert.equal(statusCode, 400);
assert.equal(body.status.code, 'bad-request');
assert.equal(body.status.message, await translator.translate('[[error:too-many-messages]]'));
meta.config.chatMessageDelay = oldValue;
8 years ago
});
it('should create a new chat room', async () => {
await User.setSetting(mocks.users.baz.uid, 'restrictChat', '0');
const { body } = await callv3API('post', `/chats`, {
uids: [mocks.users.baz.uid],
}, 'foo');
await User.setSetting(mocks.users.baz.uid, 'restrictChat', '1');
roomId = body.response.roomId;
assert(roomId);
await util.promisify(socketModules.chats.canMessage)({ uid: mocks.users.foo.uid }, roomId);
8 years ago
});
it('should send a user-join system message when a chat room is created', async () => {
const { body } = await callv3API('get', `/chats/${roomId}`, {}, 'foo');
const { messages } = body.response;
assert.equal(messages.length, 2);
assert.strictEqual(messages[0].system, true);
assert.strictEqual(messages[0].content, 'user-join');
const { statusCode, body: body2 } = await callv3API('put', `/chats/${roomId}/messages/${messages[0].messageId}`, {
message: 'test',
}, 'foo');
assert.strictEqual(statusCode, 400);
assert.equal(body2.status.message, await translator.translate('[[error:cant-edit-chat-message]]'));
});
it('should fail to add user to room with invalid data', async () => {
let { statusCode, body } = await callv3API('post', `/chats/${roomId}/users`, {}, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));
({ statusCode, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [null] }, 'foo'));
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
});
it('should add a user to room', async () => {
await callv3API('post', `/chats/${roomId}/users`, { uids: [mocks.users.herp.uid] }, 'foo');
const isInRoom = await Messaging.isUserInRoom(mocks.users.herp.uid, roomId);
assert(isInRoom);
8 years ago
});
it('should get users in room', async () => {
const { body } = await callv3API('get', `/chats/${roomId}/users`, {}, 'foo');
assert(Array.isArray(body.response.users));
assert.strictEqual(body.response.users.length, 3);
});
it('should throw error if user is not in room', async () => {
const { statusCode, body } = await callv3API('get', `/chats/${roomId}/users`, {}, 'bar');
assert.strictEqual(statusCode, 403);
assert.equal(body.status.message, await translator.translate('[[error:no-privileges]]'));
});
it('should fail to add users to room if max is reached', async () => {
8 years ago
meta.config.maximumUsersInChatRoom = 2;
const { statusCode, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [mocks.users.bar.uid] }, 'foo');
assert.strictEqual(statusCode, 400);
assert.equal(body.status.message, await translator.translate('[[error:cant-add-more-users-to-chat-room]]'));
meta.config.maximumUsersInChatRoom = 0;
8 years ago
});
it('should fail to add users to room if user does not exist', async () => {
const { statusCode, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [98237498234] }, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
8 years ago
});
it('should fail to add self to room', async () => {
const { statusCode, body } = await callv3API('post', `/chats/${roomId}/users`, { uids: [mocks.users.foo.uid] }, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:cant-chat-with-yourself]]'));
8 years ago
});
it('should fail to leave room with invalid data', async () => {
let { statusCode, body } = await callv3API('delete', `/chats/${roomId}/users`, {}, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));
({ statusCode, body } = await callv3API('delete', `/chats/${roomId}/users`, { uids: [98237423] }, 'foo'));
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
8 years ago
});
it('should leave the chat room', async () => {
await callv3API('delete', `/chats/${roomId}/users/${mocks.users.baz.uid}`, {}, 'baz');
const isUserInRoom = await Messaging.isUserInRoom(mocks.users.baz.uid, roomId);
assert.equal(isUserInRoom, false);
const data = await Messaging.getRoomData(roomId);
assert.equal(data.owner, mocks.users.foo.uid);
7 years ago
});
it('should send a user-leave system message when a user leaves the chat room', (done) => {
socketModules.chats.getMessages(
{ uid: mocks.users.foo.uid },
{ uid: mocks.users.foo.uid, roomId: roomId, start: 0 },
(err, messages) => {
assert.ifError(err);
assert.equal(messages.length, 4);
const message = messages.pop();
assert.strictEqual(message.system, true);
assert.strictEqual(message.content, 'user-leave');
done();
}
);
});
it('should not send a user-leave system message when a user tries to leave a room they are not in', async () => {
await callv3API('delete', `/chats/${roomId}/users/${mocks.users.baz.uid}`, {}, 'baz');
const messages = await socketModules.chats.getMessages(
{ uid: mocks.users.foo.uid },
{ uid: mocks.users.foo.uid, roomId: roomId, start: 0 }
);
assert.equal(messages.length, 4);
let message = messages.pop();
assert.strictEqual(message.system, true);
assert.strictEqual(message.content, 'user-leave');
// The message before should still be a user-join
message = messages.pop();
assert.strictEqual(message.system, true);
assert.strictEqual(message.content, 'user-join');
});
it('should change owner when owner leaves room', async () => {
const { body } = await callv3API('post', '/chats', {
uids: [mocks.users.foo.uid],
}, 'herp');
await callv3API('post', `/chats/${body.response.roomId}/users`, { uids: [mocks.users.baz.uid] }, 'herp');
await util.promisify(socketModules.chats.leave)({ uid: mocks.users.herp.uid }, body.response.roomId);
const data = await Messaging.getRoomData(body.response.roomId);
assert.equal(data.owner, mocks.users.foo.uid);
7 years ago
});
it('should change owner if owner is deleted', async () => {
const sender = await User.create({ username: 'deleted_chat_user', password: 'barbar' });
const { jar: senderJar, csrf_token: senderCsrf } = await util.promisify(helpers.loginUser)('deleted_chat_user', 'barbar');
const receiver = await User.create({ username: 'receiver' });
const { response } = await request(`${nconf.get('url')}/api/v3/chats`, {
method: 'post',
json: true,
jar: senderJar,
body: {
uids: [receiver],
},
headers: {
'x-csrf-token': senderCsrf,
},
});
await User.deleteAccount(sender);
const data = await Messaging.getRoomData(response.roomId);
assert.equal(data.owner, receiver);
});
it('should fail to remove user from room', async () => {
let { statusCode, body } = await callv3API('delete', `/chats/${roomId}/users`, {}, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, uids]]'));
({ statusCode, body } = await callv3API('delete', `/chats/${roomId}/users`, { uids: [null] }, 'foo'));
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
8 years ago
});
it('should fail to remove user from room if user does not exist', async () => {
const { statusCode, body } = await callv3API('delete', `/chats/${roomId}/users`, { uids: [99] }, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:no-user]]'));
8 years ago
});
it('should remove user from room', async () => {
const { statusCode, body } = await callv3API('post', `/chats`, {
uids: [mocks.users.herp.uid],
}, 'foo');
const { roomId } = body.response;
assert.strictEqual(statusCode, 200);
let isInRoom = await Messaging.isUserInRoom(mocks.users.herp.uid, roomId);
assert(isInRoom);
await callv3API('delete', `/chats/${roomId}/users`, { uids: [mocks.users.herp.uid] }, 'foo');
isInRoom = await Messaging.isUserInRoom(mocks.users.herp.uid, roomId);
assert(!isInRoom);
8 years ago
});
it('should fail to send a message to room with invalid data', async () => {
let { body } = await callv3API('post', `/chats/abc`, { message: 'test' }, 'foo');
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-data]]'));
({ body } = await callv3API('post', `/chats/1`, {}, 'foo'));
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, message]]'));
8 years ago
});
it('should fail to send chat if content is empty', async () => {
const { body } = await callv3API('post', `/chats/${roomId}`, {
message: ' ',
}, 'foo');
const { status, response } = body;
assert.deepStrictEqual(response, {});
assert.equal(status.message, await translator.translate('[[error:invalid-chat-message]]'));
6 years ago
});
it('should send a message to a room', async () => {
const { body } = await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'first chat message' }, 'foo');
const messageData = body.response;
assert(messageData);
assert.equal(messageData.content, 'first chat message');
assert(messageData.fromUser);
assert(messageData.roomId, roomId);
const raw =
await util.promisify(socketModules.chats.getRaw)({ uid: mocks.users.foo.uid }, { mid: messageData.mid });
assert.equal(raw, 'first chat message');
8 years ago
});
it('should fail to send second message due to rate limit', async () => {
const socketMock = { uid: mocks.users.foo.uid };
const oldValue = meta.config.chatMessageDelay;
meta.config.chatMessageDelay = 1000;
await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'first chat message' }, 'foo');
const { body } = await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'first chat message' }, 'foo');
const { status } = body;
assert.equal(status.message, await translator.translate('[[error:too-many-messages]]'));
meta.config.chatMessageDelay = oldValue;
8 years ago
});
it('should return invalid-data error', (done) => {
socketModules.chats.getRaw({ uid: mocks.users.foo.uid }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.getRaw({ uid: mocks.users.foo.uid }, {}, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
8 years ago
done();
});
});
});
it('should return not allowed error if mid is not in room', async () => {
const uids = await User.create({ username: 'dummy' });
let { body } = await callv3API('post', '/chats', { uids: [uids] }, 'baz');
const myRoomId = body.response.roomId;
assert(myRoomId);
try {
await util.promisify(socketModules.chats.getRaw)({ uid: mocks.users.baz.uid }, { mid: 200 });
} catch (err) {
assert(err);
assert.equal(err.message, '[[error:not-allowed]]');
}
({ body } = await callv3API('post', `/chats/${myRoomId}`, { roomId: myRoomId, message: 'admin will see this' }, 'baz'));
const message = body.response;
const raw = await util.promisify(socketModules.chats.getRaw)({ uid: mocks.users.foo.uid }, { mid: message.mid });
assert.equal(raw, 'admin will see this');
8 years ago
});
7 years ago
it('should notify offline users of message', async () => {
meta.config.notificationSendDelay = 0.1;
const { body } = await callv3API('post', '/chats', { uids: [mocks.users.baz.uid] }, 'foo');
const { roomId } = body.response;
assert(roomId);
await callv3API('post', `/chats/${roomId}/users`, { uids: [mocks.users.herp.uid] }, 'foo');
await db.sortedSetAdd('users:online', Date.now() - ((meta.config.onlineCutoff * 60000) + 50000), mocks.users.herp.uid);
await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'second chat message **bold** text' }, 'foo');
await sleep(3000);
const data = await User.notifications.get(mocks.users.herp.uid);
assert(data.unread[0]);
const notification = data.unread[0];
assert.strictEqual(notification.bodyShort, '[[notifications:new_message_from, foo]]');
assert.strictEqual(notification.nid, `chat_${mocks.users.foo.uid}_${roomId}`);
assert.strictEqual(notification.path, `${nconf.get('relative_path')}/chats/${roomId}`);
});
it('should fail to get messages from room with invalid data', (done) => {
socketModules.chats.getMessages({ uid: null }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.getMessages({ uid: mocks.users.foo.uid }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.getMessages({ uid: mocks.users.foo.uid }, { uid: null }, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.getMessages({ uid: mocks.users.foo.uid }, { uid: 1, roomId: null }, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
});
});
});
it('should get messages from room', (done) => {
socketModules.chats.getMessages({ uid: mocks.users.foo.uid }, {
uid: mocks.users.foo.uid,
roomId: roomId,
start: 0,
}, (err, messages) => {
assert.ifError(err);
assert(Array.isArray(messages));
// Filter out system messages
messages = messages.filter(message => !message.system);
assert.equal(messages[0].roomId, roomId);
assert.equal(messages[0].fromuid, mocks.users.foo.uid);
done();
});
});
8 years ago
it('should fail to mark read with invalid data', (done) => {
socketModules.chats.markRead({ uid: null }, roomId, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.markRead({ uid: mocks.users.foo.uid }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
});
it('should not error if user is not in room', (done) => {
socketModules.chats.markRead({ uid: mocks.users.herp.uid }, 10, (err) => {
8 years ago
assert.ifError(err);
done();
});
});
it('should mark room read', (done) => {
socketModules.chats.markRead({ uid: mocks.users.foo.uid }, roomId, (err) => {
8 years ago
assert.ifError(err);
done();
});
});
it('should mark all rooms read', (done) => {
socketModules.chats.markAllRead({ uid: mocks.users.foo.uid }, {}, (err) => {
8 years ago
assert.ifError(err);
done();
});
});
it('should fail to rename room with invalid data', async () => {
let { body } = await callv3API('put', `/chats/${roomId}`, { name: null }, 'foo');
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-data]]'));
({ body } = await callv3API('put', `/chats/${roomId}`, {}, 'foo'));
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, name]]'));
8 years ago
});
it('should rename room', async () => {
const { statusCode } = await callv3API('put', `/chats/${roomId}`, { name: 'new room name' }, 'foo');
assert.strictEqual(statusCode, 200);
8 years ago
});
it('should send a room-rename system message when a room is renamed', (done) => {
socketModules.chats.getMessages(
{ uid: mocks.users.foo.uid },
{ uid: mocks.users.foo.uid, roomId: roomId, start: 0 },
(err, messages) => {
assert.ifError(err);
const message = messages.pop();
assert.strictEqual(message.system, true);
assert.strictEqual(message.content, 'room-rename, new room name');
done();
}
);
});
it('should fail to load room with invalid-data', async () => {
const { body } = await callv3API('get', `/chats/abc`, {}, 'foo');
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-data]]'));
8 years ago
});
8 years ago
it('should fail to load room if user is not in', async () => {
const { body } = await callv3API('get', `/chats/${roomId}`, {}, 'baz');
assert.strictEqual(body.status.message, await translator.translate('[[error:no-privileges]]'));
8 years ago
});
it('should load chat room', async () => {
const { body } = await callv3API('get', `/chats/${roomId}`, {}, 'foo');
assert.strictEqual(body.response.roomName, 'new room name');
8 years ago
});
8 years ago
it('should return true if user is dnd', (done) => {
db.setObjectField(`user:${mocks.users.herp.uid}`, 'status', 'dnd', (err) => {
8 years ago
assert.ifError(err);
socketModules.chats.isDnD({ uid: mocks.users.foo.uid }, mocks.users.herp.uid, (err, isDnD) => {
8 years ago
assert.ifError(err);
assert(isDnD);
done();
});
});
});
8 years ago
it('should fail to load recent chats with invalid data', (done) => {
socketModules.chats.getRecentChats({ uid: mocks.users.foo.uid }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.getRecentChats({ uid: mocks.users.foo.uid }, { after: null }, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.getRecentChats({ uid: mocks.users.foo.uid }, { after: 0, uid: null }, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
});
});
it('should load recent chats of user', (done) => {
socketModules.chats.getRecentChats(
{ uid: mocks.users.foo.uid },
{ after: 0, uid: mocks.users.foo.uid },
(err, data) => {
assert.ifError(err);
assert(Array.isArray(data.rooms));
done();
}
);
});
it('should escape teaser', async () => {
await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: '<svg/onload=alert(document.location);' }, 'foo');
const data = await util.promisify(socketModules.chats.getRecentChats)(
{ uid: mocks.users.foo.uid },
{ after: 0, uid: mocks.users.foo.uid }
);
assert.equal(data.rooms[0].teaser.content, '&lt;svg&#x2F;onload=alert(document.location);');
});
it('should fail to check if user has private chat with invalid data', (done) => {
socketModules.chats.hasPrivateChat({ uid: null }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.hasPrivateChat({ uid: mocks.users.foo.uid }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
});
it('should check if user has private chat with another uid', (done) => {
socketModules.chats.hasPrivateChat({ uid: mocks.users.foo.uid }, mocks.users.herp.uid, (err, roomId) => {
8 years ago
assert.ifError(err);
assert(roomId);
done();
});
});
});
describe('edit/delete', () => {
const socketModules = require('../src/socket.io/modules');
let mid;
let mid2;
before(async () => {
await callv3API('post', `/chats/${roomId}/users`, { uids: [mocks.users.baz.uid] }, 'foo');
let { body } = await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'first chat message' }, 'foo');
mid = body.response.mid;
({ body } = await callv3API('post', `/chats/${roomId}`, { roomId: roomId, message: 'second chat message' }, 'baz'));
mid2 = body.response.mid;
});
after(async () => {
await callv3API('delete', `/chats/${roomId}/users/${mocks.users.baz.uid}`, {}, 'baz');
8 years ago
});
it('should fail to edit message with invalid data', async () => {
let { statusCode, body } = await callv3API('put', `/chats/1/messages/10000`, { message: 'foo' }, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-mid]]'));
({ statusCode, body } = await callv3API('put', `/chats/${roomId}/messages/${mid}`, {}, 'foo'));
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-chat-message]]'));
8 years ago
});
it('should fail to edit message if new content is empty string', async () => {
const { statusCode, body } = await callv3API('put', `/chats/${roomId}/messages/${mid}`, { message: ' ' }, 'foo');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-chat-message]]'));
6 years ago
});
it('should fail to edit message if not own message', async () => {
const { statusCode, body } = await callv3API('put', `/chats/${roomId}/messages/${mid}`, { message: 'message edited' }, 'herp');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:cant-edit-chat-message]]'));
8 years ago
});
it('should fail to edit message if message not in room', async () => {
const { statusCode, body } = await callv3API('put', `/chats/${roomId}/messages/1014`, { message: 'message edited' }, 'herp');
assert.strictEqual(statusCode, 400);
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-mid]]'));
});
it('should edit message', async () => {
let { statusCode, body } = await callv3API('put', `/chats/${roomId}/messages/${mid}`, { message: 'message edited' }, 'foo');
assert.strictEqual(statusCode, 200);
assert.strictEqual(body.response.content, 'message edited');
({ statusCode, body } = await callv3API('get', `/chats/${roomId}/messages/${mid}`, {}, 'foo'));
assert.strictEqual(statusCode, 200);
assert.strictEqual(body.response.content, 'message edited');
8 years ago
});
it('should fail to delete message with invalid data', (done) => {
socketModules.chats.delete({ uid: mocks.users.foo.uid }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.delete({ uid: mocks.users.foo.uid }, { roomId: null }, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.delete({ uid: mocks.users.foo.uid }, { roomId: 1, messageId: null }, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
});
});
it('should fail to delete message if not owner', (done) => {
socketModules.chats.delete({ uid: mocks.users.herp.uid }, { messageId: mid, roomId: roomId }, (err) => {
8 years ago
assert.equal(err.message, '[[error:cant-delete-chat-message]]');
done();
});
});
it('should mark the message as deleted', (done) => {
socketModules.chats.delete({ uid: mocks.users.foo.uid }, { messageId: mid, roomId: roomId }, (err) => {
assert.ifError(err);
db.getObjectField(`message:${mid}`, 'deleted', (err, value) => {
assert.ifError(err);
assert.strictEqual(1, parseInt(value, 10));
done();
});
});
});
it('should show deleted message to original users', (done) => {
socketModules.chats.getMessages(
{ uid: mocks.users.foo.uid },
{ uid: mocks.users.foo.uid, roomId: roomId, start: 0 },
(err, messages) => {
assert.ifError(err);
// Reduce messages to their mids
const mids = messages.reduce((mids, cur) => {
mids.push(cur.messageId);
return mids;
}, []);
assert(mids.includes(mid));
done();
}
);
});
it('should not show deleted message to other users', (done) => {
socketModules.chats.getMessages(
{ uid: mocks.users.herp.uid },
{ uid: mocks.users.herp.uid, roomId: roomId, start: 0 },
(err, messages) => {
assert.ifError(err);
messages.forEach((msg) => {
assert(!msg.deleted || msg.content === '[[modules:chat.message-deleted]]', msg.content);
assert(!msg.deleted || msg.cleanedContent, '[[modules:chat.message-deleted]]', msg.content);
});
done();
}
);
});
it('should error out if a message is deleted again', (done) => {
socketModules.chats.delete({ uid: mocks.users.foo.uid }, { messageId: mid, roomId: roomId }, (err) => {
assert.strictEqual('[[error:chat-deleted-already]]', err.message);
done();
});
});
it('should restore the message', (done) => {
socketModules.chats.restore({ uid: mocks.users.foo.uid }, { messageId: mid, roomId: roomId }, (err) => {
8 years ago
assert.ifError(err);
db.getObjectField(`message:${mid}`, 'deleted', (err, value) => {
8 years ago
assert.ifError(err);
assert.strictEqual(0, parseInt(value, 10));
done();
8 years ago
});
});
});
it('should error out if a message is restored again', (done) => {
socketModules.chats.restore({ uid: mocks.users.foo.uid }, { messageId: mid, roomId: roomId }, (err) => {
assert.strictEqual('[[error:chat-restored-already]]', err.message);
done();
});
});
describe('disabled via ACP', () => {
before(async () => {
meta.config.disableChatMessageEditing = true;
});
after(async () => {
meta.config.disableChatMessageEditing = false;
});
it('should error out for regular users', async () => {
try {
await socketModules.chats.delete({ uid: mocks.users.baz.uid }, { messageId: mid2, roomId: roomId });
} catch (err) {
assert.strictEqual('[[error:chat-message-editing-disabled]]', err.message);
}
});
it('should succeed for administrators', async () => {
await socketModules.chats.delete({ uid: mocks.users.foo.uid }, { messageId: mid2, roomId: roomId });
await socketModules.chats.restore({ uid: mocks.users.foo.uid }, { messageId: mid2, roomId: roomId });
});
it('should succeed for global moderators', async () => {
await Groups.join(['Global Moderators'], mocks.users.baz.uid);
await socketModules.chats.delete({ uid: mocks.users.foo.uid }, { messageId: mid2, roomId: roomId });
await socketModules.chats.restore({ uid: mocks.users.foo.uid }, { messageId: mid2, roomId: roomId });
await Groups.leave(['Global Moderators'], mocks.users.baz.uid);
});
});
8 years ago
});
describe('controller', () => {
it('should 404 if chat is disabled', async () => {
8 years ago
meta.config.disableChat = 1;
const response = await request(`${nconf.get('url')}/user/baz/chats`, {
resolveWithFullResponse: true,
simple: false,
8 years ago
});
assert.equal(response.statusCode, 404);
8 years ago
});
it('should 500 for guest with no privilege error', async () => {
8 years ago
meta.config.disableChat = 0;
const response = await request(`${nconf.get('url')}/api/user/baz/chats`, {
resolveWithFullResponse: true,
simple: false,
json: true,
});
const { body } = response;
assert.equal(response.statusCode, 500);
assert.equal(body.error, '[[error:no-privileges]]');
});
8 years ago
it('should 404 for non-existent user', async () => {
const response = await request(`${nconf.get('url')}/user/doesntexist/chats`, {
resolveWithFullResponse: true,
simple: false,
8 years ago
});
assert.equal(response.statusCode, 404);
8 years ago
});
});
describe('logged in chat controller', () => {
let jar;
before(async () => {
({ jar } = await helpers.loginUser('herp', 'derpderp'));
8 years ago
});
it('should return chats page data', async () => {
const response = await request(`${nconf.get('url')}/api/user/herp/chats`, {
resolveWithFullResponse: true,
simple: false,
json: true,
jar,
8 years ago
});
const { body } = response;
assert.equal(response.statusCode, 200);
assert(Array.isArray(body.rooms));
assert.equal(body.rooms.length, 2);
assert.equal(body.title, '[[pages:chats]]');
8 years ago
});
it('should return room data', async () => {
const response = await request(`${nconf.get('url')}/api/user/herp/chats/${roomId}`, {
resolveWithFullResponse: true,
simple: false,
json: true,
jar,
8 years ago
});
const { body } = response;
assert.equal(response.statusCode, 200);
assert.equal(body.roomId, roomId);
assert.equal(body.isOwner, false);
8 years ago
});
it('should redirect to chats page', async () => {
const res = await request(`${nconf.get('url')}/api/chats`, {
resolveWithFullResponse: true,
simple: false,
jar,
json: true,
8 years ago
});
const { body } = res;
assert.equal(res.statusCode, 200);
assert.equal(res.headers['x-redirect'], '/user/herp/chats');
assert.equal(body, '/user/herp/chats');
8 years ago
});
it('should return 404 if user is not in room', async () => {
const data = await util.promisify(helpers.loginUser)('baz', 'quuxquux');
const response = await request(`${nconf.get('url')}/api/user/baz/chats/${roomId}`, {
resolveWithFullResponse: true,
simple: false,
json: true,
jar: data.jar,
8 years ago
});
assert.equal(response.statusCode, 404);
8 years ago
});
});
});