This feature was copied from Vector where it was recently removed
in e5c837e3ebf8.
In a nut shell, HTML output from PHP generally either has no
tabindex, tabindex=0 or tabindex=-1, or sometimes numbers between
1-100 for custom tab ordering. In JavaScript we then used
lastTabIndex (returns highest+1) to get an input field to be at the
end of the tab order. Thus making it be the *first* thing that
gets focussed when pressing Tab on a page (I guess the browser
offset is at the end of the document by default?)
This JS-based approach wasn't very stable as it required only
other thing in JS to use it for other reasons (e.g. genuinely
minting normal-use tab indexes for something) to break it as
we can't use the same logic for both "the lowest next number"
and "the highest possible number".
If we want to preserve this feature, it should probably do
something like attr('tabindex', '99999') which, while ugly,
would be a more sustainable way to implement this this.
Per Jack Phoenix in code review on this patch, match Vector
behaviour for now, where it was removed per T226148 for
being contrary to accessibility best practies.
Bug: T234581
Change-Id: I24777bdb6655f21d2f4896d5f887a125b36ab584
* Remove Liberation Mono from font stack; comes out excessively light on
hidpi chrome, to the point of unreadability (and probably is not a local
config problem beyond merely having it installed at all, as chrome
overrides normal font rendering settings regardless)
* Kill double border on pre styles; doesn't match other such boxes (notice,
warning, whatever)
Change-Id: I7a95931bd6af4efc880c3ee8f37a91d61f3e6539
Only does this with wordmarks; desktop devices are a lot less likely to merit this, and
the larger desktop logos are probably a rather bad idea to make unnecessarily large
anyway. Whereas the wordmarks should still be pretty small in terms of filesize as
they're going to be pretty simple, and are all we normally show on mobile.
Bug: T232540
Change-Id: I1932a99d8784eadf02f2711d9557425de0db0100
And put the position:relative on that. Keeps the sticky header out of
it, regardless, and let folks do their weird non-content voodoo on
stuff like the siteSub more consistently, I guess...
Bug: T231400
Change-Id: I7ac35f741210a0c54976f43d2294af8f123967a1
Basically, move a bunch of the logic to ProofreadPage itself, and only
do some timeless-specific reordering/styling as due to its Special
nature. Because timeless is Special.
Bug: T231250
Depends-On: Ifd8be387cef671b2aaa2a482c145bccf2e6d1543
Change-Id: I6fd7b648e459fee60569a06ffa1f0a5eb179c9ba
Currently js-only due to the default (only) vector styles requiring js. Fixed in
Ifd8be387cef671b2aaa2a482c145bccf2e6d1543, with a followup to clean up a bit after
that assuming that doesn't mess up too much to be merged, but this works regardless.
Bug: T231250
Change-Id: I4cadcbc3e51672fb075c884b2d2cc1d799b1b1b0
Translation updater bot
Umherirrender
jenkins-bot
Timo Tijhof
James D. Forrester
Isarra